Details

    • Hadoop Flags:
      Reviewed

      Description

      Found a typo in Encrypted Shuffle documentation (STRICT_I6 --> STRICT_IE6).
      The typo also appears in core-default.xml

        Activity

        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Posted a trivial patch to fix the typo.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Posted a trivial patch to fix the typo.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 6m 48s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 20s Maven dependency ordering for branch
        +1 mvninstall 6m 59s trunk passed
        +1 compile 6m 14s trunk passed with JDK v1.8.0_74
        +1 compile 6m 48s trunk passed with JDK v1.7.0_95
        +1 mvnsite 1m 29s trunk passed
        +1 mvneclipse 0m 29s trunk passed
        +1 javadoc 1m 15s trunk passed with JDK v1.8.0_74
        +1 javadoc 1m 31s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 1m 12s the patch passed
        +1 compile 7m 21s the patch passed with JDK v1.8.0_74
        +1 javac 7m 21s the patch passed
        +1 compile 7m 30s the patch passed with JDK v1.7.0_95
        +1 javac 7m 30s the patch passed
        +1 mvnsite 1m 36s the patch passed
        +1 mvneclipse 0m 29s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 javadoc 1m 27s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 34s the patch passed with JDK v1.7.0_95
        -1 unit 8m 3s hadoop-common in the patch failed with JDK v1.8.0_74.
        +1 unit 2m 20s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_74.
        -1 unit 8m 8s hadoop-common in the patch failed with JDK v1.7.0_95.
        +1 unit 2m 33s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95.
        -1 asflicense 0m 26s Patch generated 2 ASF License warnings.
        75m 46s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
        JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker
        JDK v1.7.0_95 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
          hadoop.security.ssl.TestReloadingX509TrustManager
        JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794223/MAPREDUCE-6655.001.patch
        JIRA Issue MAPREDUCE-6655
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux 0e8b0c869342 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / fbe3e86
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6384/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6384/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6384/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6384/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6384/testReport/
        asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6384/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6384/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 6m 48s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 20s Maven dependency ordering for branch +1 mvninstall 6m 59s trunk passed +1 compile 6m 14s trunk passed with JDK v1.8.0_74 +1 compile 6m 48s trunk passed with JDK v1.7.0_95 +1 mvnsite 1m 29s trunk passed +1 mvneclipse 0m 29s trunk passed +1 javadoc 1m 15s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 31s trunk passed with JDK v1.7.0_95 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 12s the patch passed +1 compile 7m 21s the patch passed with JDK v1.8.0_74 +1 javac 7m 21s the patch passed +1 compile 7m 30s the patch passed with JDK v1.7.0_95 +1 javac 7m 30s the patch passed +1 mvnsite 1m 36s the patch passed +1 mvneclipse 0m 29s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 1m 27s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 34s the patch passed with JDK v1.7.0_95 -1 unit 8m 3s hadoop-common in the patch failed with JDK v1.8.0_74. +1 unit 2m 20s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_74. -1 unit 8m 8s hadoop-common in the patch failed with JDK v1.7.0_95. +1 unit 2m 33s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95. -1 asflicense 0m 26s Patch generated 2 ASF License warnings. 75m 46s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker JDK v1.7.0_95 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.security.ssl.TestReloadingX509TrustManager JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794223/MAPREDUCE-6655.001.patch JIRA Issue MAPREDUCE-6655 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 0e8b0c869342 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fbe3e86 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6384/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6384/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6384/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6384/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6384/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6384/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6384/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        The asf licensing warning and unit test error are unrelated to this patch, as this patch only modified documentation and the description of a core-default.xml property.

        Show
        jojochuang Wei-Chiu Chuang added a comment - The asf licensing warning and unit test error are unrelated to this patch, as this patch only modified documentation and the description of a core-default.xml property.
        Hide
        djp Junping Du added a comment -

        Patch LGTM. +1. Will commit it shortly.

        Show
        djp Junping Du added a comment - Patch LGTM. +1. Will commit it shortly.
        Hide
        djp Junping Du added a comment -

        I have commit the patch to trunk and branch-2. Thanks Wei-Chiu Chuang for the patch contribution!

        Show
        djp Junping Du added a comment - I have commit the patch to trunk and branch-2. Thanks Wei-Chiu Chuang for the patch contribution!
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Thanks Junping Du for reviewing and committing this!

        Show
        jojochuang Wei-Chiu Chuang added a comment - Thanks Junping Du for reviewing and committing this!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9511 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9511/)
        MAPREDUCE-6655. Fix a typo (STRICT_IE6) in Encrypted Shuffle. (junping_du: rev 90fcb16c0fc7cded2593948f1cc08f3d1ae88bda)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/EncryptedShuffle.md
        • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9511 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9511/ ) MAPREDUCE-6655 . Fix a typo (STRICT_IE6) in Encrypted Shuffle. (junping_du: rev 90fcb16c0fc7cded2593948f1cc08f3d1ae88bda) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/EncryptedShuffle.md hadoop-common-project/hadoop-common/src/main/resources/core-default.xml

          People

          • Assignee:
            jojochuang Wei-Chiu Chuang
            Reporter:
            jojochuang Wei-Chiu Chuang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development