Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6627

Add machine-readable output to mapred job -history command

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.9.0
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: client
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      It would be great if we could add a machine-readable output format, say JSON, to the mapred job -history [all] <jobHistoryFile> command so that it's easier for programs to consume that information and do further processing on it. At the same time, we should keep the existing API and formatting intact for backwards compatibility.

      1. json_all.txt
        37 kB
        Robert Kanter
      2. json.txt
        10 kB
        Robert Kanter
      3. MAPREDUCE-6627.001.patch
        63 kB
        Robert Kanter
      4. MAPREDUCE-6627.002.patch
        66 kB
        Robert Kanter
      5. MAPREDUCE-6627.003.patch
        112 kB
        Robert Kanter
      6. MAPREDUCE-6627.004.patch
        113 kB
        Robert Kanter
      7. MAPREDUCE-6627.005.patch
        122 kB
        Robert Kanter
      8. MAPREDUCE-6627.006.patch
        123 kB
        Robert Kanter

        Activity

        Hide
        rkanter Robert Kanter added a comment -

        json.txt and json_all.txt show what the JSON output currently looks like (after prettifying it for human-readability).

        Show
        rkanter Robert Kanter added a comment - json.txt and json_all.txt show what the JSON output currently looks like (after prettifying it for human-readability).
        Hide
        rkanter Robert Kanter added a comment -

        I moved most of the printing code from HistoryViewer into a new class, so I could create an interface to be able to implement other output formats. A lot of the patch is moving that existing code. Otherwise, the patch adds the new JobHistoryViewerJSONPrinter class, which prints mostly the same information as the JobHistoryViewerHumanPrinter. It omits the Analysis section, as that's not really necessary for this use case, and changes a few other things to be more machine-friendly (e.g. using counter names instead of counter display names and other misc formatting). I didn't change any of the formatting of the existing human readable output for backwards compatibility.

        I also added the ability to specify an output file for the results, which works for either format and cleaned up the CLI parsing for this subcommand.

        The command now looks like this:

        mapred job -history [all] <jobHistoryFile> [-outfile <file>] [-format <human|json>]]
        

        It defaults to the human format and stdout.

        Show
        rkanter Robert Kanter added a comment - I moved most of the printing code from HistoryViewer into a new class, so I could create an interface to be able to implement other output formats. A lot of the patch is moving that existing code. Otherwise, the patch adds the new JobHistoryViewerJSONPrinter class, which prints mostly the same information as the JobHistoryViewerHumanPrinter . It omits the Analysis section, as that's not really necessary for this use case, and changes a few other things to be more machine-friendly (e.g. using counter names instead of counter display names and other misc formatting). I didn't change any of the formatting of the existing human readable output for backwards compatibility. I also added the ability to specify an output file for the results, which works for either format and cleaned up the CLI parsing for this subcommand. The command now looks like this: mapred job -history [all] <jobHistoryFile> [-outfile <file>] [-format <human|json>]] It defaults to the human format and stdout.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 37s Maven dependency ordering for branch
        +1 mvninstall 7m 4s trunk passed
        +1 compile 1m 38s trunk passed with JDK v1.8.0_66
        +1 compile 1m 47s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 27s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 27s trunk passed
        +1 findbugs 1m 33s trunk passed
        +1 javadoc 0m 34s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 40s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 17s Maven dependency ordering for patch
        +1 mvninstall 0m 49s the patch passed
        +1 compile 1m 30s the patch passed with JDK v1.8.0_66
        +1 javac 1m 30s the patch passed
        +1 compile 1m 41s the patch passed with JDK v1.7.0_91
        -1 javac 4m 18s hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.7.0_91 with JDK v1.7.0_91 generated 5 new + 360 unchanged - 5 fixed = 365 total (was 365)
        +1 javac 1m 41s the patch passed
        -1 checkstyle 0m 24s hadoop-mapreduce-project/hadoop-mapreduce-client: patch generated 20 new + 198 unchanged - 60 fixed = 218 total (was 258)
        +1 mvnsite 0m 56s the patch passed
        +1 mvneclipse 0m 23s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        -1 findbugs 1m 16s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
        +1 javadoc 0m 31s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 35s the patch passed with JDK v1.7.0_91
        +1 unit 1m 52s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66.
        -1 unit 99m 17s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
        +1 unit 2m 18s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91.
        -1 unit 105m 29s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91.
        -1 asflicense 0m 26s Patch generated 15 ASF License warnings.
        235m 36s



        Reason Tests
        FindBugs module:hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
          Exception is caught when Exception is not thrown in new org.apache.hadoop.mapreduce.jobhistory.HistoryViewer(String, Configuration, boolean, String) At HistoryViewer.java:is not thrown in new org.apache.hadoop.mapreduce.jobhistory.HistoryViewer(String, Configuration, boolean, String) At HistoryViewer.java:[line 114]
          Found reliance on default encoding in org.apache.hadoop.mapreduce.jobhistory.JobHistoryViewerJSONPrinter.print(PrintStream):in org.apache.hadoop.mapreduce.jobhistory.JobHistoryViewerJSONPrinter.print(PrintStream): new java.io.PrintWriter(OutputStream) At JobHistoryViewerJSONPrinter.java:[line 59]
          org.apache.hadoop.mapreduce.jobhistory.JobHistoryViewerPrinter.dateFormat is a static field of type java.text.DateFormat, which isn't thread safe In JobHistoryViewerPrinter.java:of type java.text.DateFormat, which isn't thread safe In JobHistoryViewerPrinter.java
          Found reliance on default encoding in org.apache.hadoop.mapreduce.tools.CLI.viewHistory(String, boolean, String, String):in org.apache.hadoop.mapreduce.tools.CLI.viewHistory(String, boolean, String, String): new java.io.PrintStream(File) At CLI.java:[line 531]
        JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.TestMRJobsWithProfiler
          hadoop.mapred.TestNetworkedJob
        JDK v1.7.0_91 Failed junit tests hadoop.mapred.TestNetworkedJob



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786164/MAPREDUCE-6627.001.patch
        JIRA Issue MAPREDUCE-6627
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3493d8113192 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / c89a14a
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        javac hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/artifact/patchprocess/diff-compile-javac-hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.7.0_91.txt
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
        findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/artifact/patchprocess/new-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.html
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/testReport/
        asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Max memory used 77MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 37s Maven dependency ordering for branch +1 mvninstall 7m 4s trunk passed +1 compile 1m 38s trunk passed with JDK v1.8.0_66 +1 compile 1m 47s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 27s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 1m 33s trunk passed +1 javadoc 0m 34s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 40s trunk passed with JDK v1.7.0_91 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 0m 49s the patch passed +1 compile 1m 30s the patch passed with JDK v1.8.0_66 +1 javac 1m 30s the patch passed +1 compile 1m 41s the patch passed with JDK v1.7.0_91 -1 javac 4m 18s hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.7.0_91 with JDK v1.7.0_91 generated 5 new + 360 unchanged - 5 fixed = 365 total (was 365) +1 javac 1m 41s the patch passed -1 checkstyle 0m 24s hadoop-mapreduce-project/hadoop-mapreduce-client: patch generated 20 new + 198 unchanged - 60 fixed = 218 total (was 258) +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 1m 16s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) +1 javadoc 0m 31s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 35s the patch passed with JDK v1.7.0_91 +1 unit 1m 52s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66. -1 unit 99m 17s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 2m 18s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91. -1 unit 105m 29s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 26s Patch generated 15 ASF License warnings. 235m 36s Reason Tests FindBugs module:hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core   Exception is caught when Exception is not thrown in new org.apache.hadoop.mapreduce.jobhistory.HistoryViewer(String, Configuration, boolean, String) At HistoryViewer.java:is not thrown in new org.apache.hadoop.mapreduce.jobhistory.HistoryViewer(String, Configuration, boolean, String) At HistoryViewer.java: [line 114]   Found reliance on default encoding in org.apache.hadoop.mapreduce.jobhistory.JobHistoryViewerJSONPrinter.print(PrintStream):in org.apache.hadoop.mapreduce.jobhistory.JobHistoryViewerJSONPrinter.print(PrintStream): new java.io.PrintWriter(OutputStream) At JobHistoryViewerJSONPrinter.java: [line 59]   org.apache.hadoop.mapreduce.jobhistory.JobHistoryViewerPrinter.dateFormat is a static field of type java.text.DateFormat, which isn't thread safe In JobHistoryViewerPrinter.java:of type java.text.DateFormat, which isn't thread safe In JobHistoryViewerPrinter.java   Found reliance on default encoding in org.apache.hadoop.mapreduce.tools.CLI.viewHistory(String, boolean, String, String):in org.apache.hadoop.mapreduce.tools.CLI.viewHistory(String, boolean, String, String): new java.io.PrintStream(File) At CLI.java: [line 531] JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapred.TestNetworkedJob JDK v1.7.0_91 Failed junit tests hadoop.mapred.TestNetworkedJob Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786164/MAPREDUCE-6627.001.patch JIRA Issue MAPREDUCE-6627 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3493d8113192 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c89a14a Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 javac hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/artifact/patchprocess/diff-compile-javac-hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.7.0_91.txt checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/artifact/patchprocess/new-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.html unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/console This message was automatically generated.
        Hide
        rkanter Robert Kanter added a comment -

        Test failures are unrelated (See MAPREDUCE-6579 and MAPREDUCE-6580). The asflicense issues look like they're from some unrelated files that weren't cleaned up.

        The 002 patch fixes the findbugs and checkstyle warnings, other than some some protected class variables that it wanted me to make private. I'm not sure that's necessary.

        Show
        rkanter Robert Kanter added a comment - Test failures are unrelated (See MAPREDUCE-6579 and MAPREDUCE-6580 ). The asflicense issues look like they're from some unrelated files that weren't cleaned up. The 002 patch fixes the findbugs and checkstyle warnings, other than some some protected class variables that it wanted me to make private. I'm not sure that's necessary.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 18m 43s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 24s Maven dependency ordering for branch
        +1 mvninstall 6m 56s trunk passed
        +1 compile 1m 34s trunk passed with JDK v1.8.0_72
        +1 compile 1m 49s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 25s trunk passed
        +1 findbugs 1m 29s trunk passed
        +1 javadoc 0m 33s trunk passed with JDK v1.8.0_72
        +1 javadoc 0m 40s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 0m 50s the patch passed
        +1 compile 1m 26s the patch passed with JDK v1.8.0_72
        +1 javac 1m 26s the patch passed
        +1 compile 1m 37s the patch passed with JDK v1.7.0_95
        -1 javac 4m 10s hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.7.0_95 with JDK v1.7.0_95 generated 5 new + 360 unchanged - 5 fixed = 365 total (was 365)
        +1 javac 1m 37s the patch passed
        -1 checkstyle 0m 23s hadoop-mapreduce-project/hadoop-mapreduce-client: patch generated 6 new + 191 unchanged - 67 fixed = 197 total (was 258)
        +1 mvnsite 0m 54s the patch passed
        +1 mvneclipse 0m 23s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 47s the patch passed
        +1 javadoc 0m 28s the patch passed with JDK v1.8.0_72
        +1 javadoc 0m 35s the patch passed with JDK v1.7.0_95
        +1 unit 1m 51s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_72.
        -1 unit 99m 34s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_72.
        +1 unit 2m 16s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95.
        -1 unit 105m 36s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_95.
        -1 asflicense 0m 31s Patch generated 15 ASF License warnings.
        253m 41s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.mapreduce.v2.TestMRJobsWithProfiler
          hadoop.mapred.TestNetworkedJob
        JDK v1.7.0_95 Failed junit tests hadoop.mapred.TestNetworkedJob



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786359/MAPREDUCE-6627.002.patch
        JIRA Issue MAPREDUCE-6627
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux e2cce1b9a4cb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1bcfab8
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        javac hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6314/artifact/patchprocess/diff-compile-javac-hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.7.0_95.txt
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6314/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6314/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6314/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6314/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6314/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6314/testReport/
        asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6314/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Max memory used 77MB
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6314/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 18m 43s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 24s Maven dependency ordering for branch +1 mvninstall 6m 56s trunk passed +1 compile 1m 34s trunk passed with JDK v1.8.0_72 +1 compile 1m 49s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 26s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 1m 29s trunk passed +1 javadoc 0m 33s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 40s trunk passed with JDK v1.7.0_95 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 0m 50s the patch passed +1 compile 1m 26s the patch passed with JDK v1.8.0_72 +1 javac 1m 26s the patch passed +1 compile 1m 37s the patch passed with JDK v1.7.0_95 -1 javac 4m 10s hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.7.0_95 with JDK v1.7.0_95 generated 5 new + 360 unchanged - 5 fixed = 365 total (was 365) +1 javac 1m 37s the patch passed -1 checkstyle 0m 23s hadoop-mapreduce-project/hadoop-mapreduce-client: patch generated 6 new + 191 unchanged - 67 fixed = 197 total (was 258) +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 47s the patch passed +1 javadoc 0m 28s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 35s the patch passed with JDK v1.7.0_95 +1 unit 1m 51s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_72. -1 unit 99m 34s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_72. +1 unit 2m 16s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95. -1 unit 105m 36s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 31s Patch generated 15 ASF License warnings. 253m 41s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapred.TestNetworkedJob JDK v1.7.0_95 Failed junit tests hadoop.mapred.TestNetworkedJob Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786359/MAPREDUCE-6627.002.patch JIRA Issue MAPREDUCE-6627 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e2cce1b9a4cb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1bcfab8 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6314/artifact/patchprocess/diff-compile-javac-hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.7.0_95.txt checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6314/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6314/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6314/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6314/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6314/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6314/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6314/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6314/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        Thanks for the patch, Robert Kanter. A couple of first pass comments:

        • Since you're touching the javadocs, the param and return descriptions shouldn't start with capital letters. It would also be nice to have description fields for the throws tags.
        • In the new HistoryViewer constructor you have:
            } catch (RuntimeException e) {
              throw e;
            } ...
        
        • Please add javadoc headers for the JobHistoryViewerHumanPrinter and JobHistoryViewerJsonPrinter classes
        • On a philosophical note, I don't like the if x then return idiom. I'd rather have the code wrapped in an if !x.
        • I really don't love the nested ternary operators in the comparators in JobHistoryViewerHumanPrinter
        • In the JobHistoryViewerJsonPrinter.print() method, you have:
            } catch (JSONException je) {
              throw new IOException(je);
            } finally {
        

        I'd rather see the IOException have a message that sets some useful context, e.g. throw new IOException("Failure parsing JSON document: " + je, je)

        • In JobHistoryViewerJsonPrinter.print(), I'd rather that this:
            private String fixGroupNameForShuffleErrors(String name) {
              if (name.equals("Shuffle Errors")) {
                return "org.apache.hadoop.mapreduce.task.reduce.Fetcher.ShuffleErrors";
              }
              return name;
            }
          

          were this:

            private String fixGroupNameForShuffleErrors(String name) {
              String retName = name;
          
              if (name.equals("Shuffle Errors")) {
                retName = "org.apache.hadoop.mapreduce.task.reduce.Fetcher.ShuffleErrors";
              }
          
              return retName;
            }
          

          But maybe I'm just obsessive.

        • I'm not sure the utility you get from JobHistoryViewerPrinter being an abstract class is worth it. I would think hard about making it an interface.
        • In CLI, I'd rather have space around operators, so index + 1 instead of index+1.
        • The tests seem really light. I'd like to see the tests dig into the JSON object and confirm that the data is an expected. I'd also like to see some testing of failure scenarios, like -format biteMe.

        I haven't applied the patch or played with it yet, though, so there may be more to say later.

        Show
        templedf Daniel Templeton added a comment - Thanks for the patch, Robert Kanter . A couple of first pass comments: Since you're touching the javadocs, the param and return descriptions shouldn't start with capital letters. It would also be nice to have description fields for the throws tags. In the new HistoryViewer constructor you have: } catch (RuntimeException e) { throw e; } ... Please add javadoc headers for the JobHistoryViewerHumanPrinter and JobHistoryViewerJsonPrinter classes On a philosophical note, I don't like the if x then return idiom. I'd rather have the code wrapped in an if !x . I really don't love the nested ternary operators in the comparators in JobHistoryViewerHumanPrinter In the JobHistoryViewerJsonPrinter.print() method, you have: } catch (JSONException je) { throw new IOException(je); } finally { I'd rather see the IOException have a message that sets some useful context, e.g. throw new IOException("Failure parsing JSON document: " + je, je) In JobHistoryViewerJsonPrinter.print() , I'd rather that this: private String fixGroupNameForShuffleErrors( String name) { if (name.equals( "Shuffle Errors" )) { return "org.apache.hadoop.mapreduce.task.reduce.Fetcher.ShuffleErrors" ; } return name; } were this: private String fixGroupNameForShuffleErrors( String name) { String retName = name; if (name.equals( "Shuffle Errors" )) { retName = "org.apache.hadoop.mapreduce.task.reduce.Fetcher.ShuffleErrors" ; } return retName; } But maybe I'm just obsessive. I'm not sure the utility you get from JobHistoryViewerPrinter being an abstract class is worth it. I would think hard about making it an interface. In CLI , I'd rather have space around operators, so index + 1 instead of index+1 . The tests seem really light. I'd like to see the tests dig into the JSON object and confirm that the data is an expected. I'd also like to see some testing of failure scenarios, like -format biteMe . I haven't applied the patch or played with it yet, though, so there may be more to say later.
        Hide
        rkanter Robert Kanter added a comment -

        Thanks for the review. I'll start working on the more straightforward ones, but here's some that I either had questions on or wanted to clarify:

        • FindBugs actually suggested I catch the RuntimeException and rethrow it like that. The idea is to handle Exception without accidentally catching RuntimeExeption. See https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/artifact/patchprocess/new-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.html#REC_CATCH_EXCEPTION That said, we're just wrapping Exception and not really handling it anyway, so I'll revisit this.
        • Where are you referring to exactly on this?

          On a philosophical note, I don't like the if x then return idiom. I'd rather have the code wrapped in an if !x.

        • You're right that the comparators are a bit confusing. I didn't write them originally, but now that I'm moving them I'll take the opportunity to rewrite them for clarity.
        • I originally had JobHistoryViewerPrinter as an abstract class because it had some common methods in it that both Printer implementations used, but I had since refactored that a lot, so there's no more common code and never changed it. Good catch; I'll make this in an interface.
        Show
        rkanter Robert Kanter added a comment - Thanks for the review. I'll start working on the more straightforward ones, but here's some that I either had questions on or wanted to clarify: FindBugs actually suggested I catch the RuntimeException and rethrow it like that. The idea is to handle Exception without accidentally catching RuntimeExeption . See https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/artifact/patchprocess/new-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.html#REC_CATCH_EXCEPTION That said, we're just wrapping Exception and not really handling it anyway, so I'll revisit this. Where are you referring to exactly on this? On a philosophical note, I don't like the if x then return idiom. I'd rather have the code wrapped in an if !x. You're right that the comparators are a bit confusing. I didn't write them originally, but now that I'm moving them I'll take the opportunity to rewrite them for clarity. I originally had JobHistoryViewerPrinter as an abstract class because it had some common methods in it that both Printer implementations used, but I had since refactored that a lot, so there's no more common code and never changed it. Good catch; I'll make this in an interface.
        Hide
        rkanter Robert Kanter added a comment -

        I think I figured out the "if x then return idiom" stuff you were referring to. I'll change those.

        Show
        rkanter Robert Kanter added a comment - I think I figured out the "if x then return idiom" stuff you were referring to. I'll change those.
        Hide
        rkanter Robert Kanter added a comment -

        The 003 patch addresses Daniel Templeton's feedback, including adding more unit tests.

        Show
        rkanter Robert Kanter added a comment - The 003 patch addresses Daniel Templeton 's feedback, including adding more unit tests.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 27s Maven dependency ordering for branch
        +1 mvninstall 6m 35s trunk passed
        +1 compile 5m 40s trunk passed with JDK v1.8.0_72
        +1 compile 6m 33s trunk passed with JDK v1.7.0_95
        +1 checkstyle 1m 7s trunk passed
        +1 mvnsite 1m 12s trunk passed
        +1 mvneclipse 0m 38s trunk passed
        0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-project
        +1 findbugs 1m 28s trunk passed
        +1 javadoc 0m 42s trunk passed with JDK v1.8.0_72
        +1 javadoc 0m 50s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 17s Maven dependency ordering for patch
        +1 mvninstall 0m 54s the patch passed
        +1 compile 5m 37s the patch passed with JDK v1.8.0_72
        +1 javac 5m 37s the patch passed
        +1 compile 6m 36s the patch passed with JDK v1.7.0_95
        -1 javac 13m 24s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 3 new + 732 unchanged - 3 fixed = 735 total (was 735)
        +1 javac 6m 36s the patch passed
        -1 checkstyle 1m 4s root: patch generated 1 new + 190 unchanged - 68 fixed = 191 total (was 258)
        +1 mvnsite 1m 11s the patch passed
        +1 mvneclipse 0m 38s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-project
        +1 findbugs 1m 53s the patch passed
        +1 javadoc 0m 42s the patch passed with JDK v1.8.0_72
        +1 javadoc 0m 51s the patch passed with JDK v1.7.0_95
        +1 unit 0m 8s hadoop-project in the patch passed with JDK v1.8.0_72.
        -1 unit 1m 53s hadoop-mapreduce-client-core in the patch failed with JDK v1.8.0_72.
        -1 unit 102m 1s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_72.
        +1 unit 0m 17s hadoop-project in the patch passed with JDK v1.7.0_95.
        -1 unit 2m 25s hadoop-mapreduce-client-core in the patch failed with JDK v1.7.0_95.
        -1 unit 104m 57s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_95.
        -1 asflicense 0m 32s Patch generated 15 ASF License warnings.
        258m 49s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.mapreduce.jobhistory.TestJobHistoryViewerPrinter
          hadoop.mapreduce.v2.TestMRJobsWithProfiler
          hadoop.mapred.TestNetworkedJob
        JDK v1.7.0_95 Failed junit tests hadoop.mapreduce.jobhistory.TestJobHistoryViewerPrinter
          hadoop.mapred.TestNetworkedJob



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787988/MAPREDUCE-6627.003.patch
        JIRA Issue MAPREDUCE-6627
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
        uname Linux 48b11a743e8a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8ed07bd
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_95.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/testReport/
        asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: .
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 27s Maven dependency ordering for branch +1 mvninstall 6m 35s trunk passed +1 compile 5m 40s trunk passed with JDK v1.8.0_72 +1 compile 6m 33s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 7s trunk passed +1 mvnsite 1m 12s trunk passed +1 mvneclipse 0m 38s trunk passed 0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-project +1 findbugs 1m 28s trunk passed +1 javadoc 0m 42s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 50s trunk passed with JDK v1.7.0_95 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 0m 54s the patch passed +1 compile 5m 37s the patch passed with JDK v1.8.0_72 +1 javac 5m 37s the patch passed +1 compile 6m 36s the patch passed with JDK v1.7.0_95 -1 javac 13m 24s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 3 new + 732 unchanged - 3 fixed = 735 total (was 735) +1 javac 6m 36s the patch passed -1 checkstyle 1m 4s root: patch generated 1 new + 190 unchanged - 68 fixed = 191 total (was 258) +1 mvnsite 1m 11s the patch passed +1 mvneclipse 0m 38s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-project +1 findbugs 1m 53s the patch passed +1 javadoc 0m 42s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 51s the patch passed with JDK v1.7.0_95 +1 unit 0m 8s hadoop-project in the patch passed with JDK v1.8.0_72. -1 unit 1m 53s hadoop-mapreduce-client-core in the patch failed with JDK v1.8.0_72. -1 unit 102m 1s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_72. +1 unit 0m 17s hadoop-project in the patch passed with JDK v1.7.0_95. -1 unit 2m 25s hadoop-mapreduce-client-core in the patch failed with JDK v1.7.0_95. -1 unit 104m 57s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 32s Patch generated 15 ASF License warnings. 258m 49s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.mapreduce.jobhistory.TestJobHistoryViewerPrinter   hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapred.TestNetworkedJob JDK v1.7.0_95 Failed junit tests hadoop.mapreduce.jobhistory.TestJobHistoryViewerPrinter   hadoop.mapred.TestNetworkedJob Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787988/MAPREDUCE-6627.003.patch JIRA Issue MAPREDUCE-6627 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 48b11a743e8a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8ed07bd Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: . Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6323/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        rkanter Robert Kanter added a comment -

        The 004 patch fixes the related unit test failures (Timezone issues). The checkstyle warning is about a method being too long, but it was already like that and I don't think we need to split it up (CLI argument parsing).

        Show
        rkanter Robert Kanter added a comment - The 004 patch fixes the related unit test failures (Timezone issues). The checkstyle warning is about a method being too long, but it was already like that and I don't think we need to split it up (CLI argument parsing).
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 14s Maven dependency ordering for branch
        +1 mvninstall 6m 50s trunk passed
        +1 compile 6m 30s trunk passed with JDK v1.8.0_72
        +1 compile 6m 55s trunk passed with JDK v1.7.0_95
        +1 checkstyle 1m 8s trunk passed
        +1 mvnsite 1m 16s trunk passed
        +1 mvneclipse 0m 45s trunk passed
        0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-project
        +1 findbugs 1m 30s trunk passed
        +1 javadoc 0m 42s trunk passed with JDK v1.8.0_72
        +1 javadoc 0m 51s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 0m 55s the patch passed
        +1 compile 5m 34s the patch passed with JDK v1.8.0_72
        +1 javac 5m 34s the patch passed
        +1 compile 6m 33s the patch passed with JDK v1.7.0_95
        -1 javac 13m 18s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 3 new + 732 unchanged - 3 fixed = 735 total (was 735)
        +1 javac 6m 33s the patch passed
        -1 checkstyle 1m 5s root: patch generated 1 new + 190 unchanged - 68 fixed = 191 total (was 258)
        +1 mvnsite 1m 12s the patch passed
        +1 mvneclipse 0m 38s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-project
        +1 findbugs 1m 55s the patch passed
        +1 javadoc 0m 42s the patch passed with JDK v1.8.0_72
        +1 javadoc 0m 49s the patch passed with JDK v1.7.0_95
        +1 unit 0m 9s hadoop-project in the patch passed with JDK v1.8.0_72.
        -1 unit 1m 54s hadoop-mapreduce-client-core in the patch failed with JDK v1.8.0_72.
        -1 unit 102m 46s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_72.
        +1 unit 0m 17s hadoop-project in the patch passed with JDK v1.7.0_95.
        +1 unit 2m 51s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95.
        -1 unit 101m 40s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_95.
        -1 asflicense 0m 31s Patch generated 15 ASF License warnings.
        258m 6s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.mapreduce.jobhistory.TestJobHistoryViewerPrinter
          hadoop.mapreduce.v2.TestMRJobsWithProfiler
          hadoop.mapred.TestNetworkedJob
        JDK v1.7.0_95 Failed junit tests hadoop.mapred.TestNetworkedJob



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788119/MAPREDUCE-6627.004.patch
        JIRA Issue MAPREDUCE-6627
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
        uname Linux 2d5425f849ad 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4b0e59f
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/testReport/
        asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: .
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 50s trunk passed +1 compile 6m 30s trunk passed with JDK v1.8.0_72 +1 compile 6m 55s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 8s trunk passed +1 mvnsite 1m 16s trunk passed +1 mvneclipse 0m 45s trunk passed 0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-project +1 findbugs 1m 30s trunk passed +1 javadoc 0m 42s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 51s trunk passed with JDK v1.7.0_95 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 0m 55s the patch passed +1 compile 5m 34s the patch passed with JDK v1.8.0_72 +1 javac 5m 34s the patch passed +1 compile 6m 33s the patch passed with JDK v1.7.0_95 -1 javac 13m 18s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 3 new + 732 unchanged - 3 fixed = 735 total (was 735) +1 javac 6m 33s the patch passed -1 checkstyle 1m 5s root: patch generated 1 new + 190 unchanged - 68 fixed = 191 total (was 258) +1 mvnsite 1m 12s the patch passed +1 mvneclipse 0m 38s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-project +1 findbugs 1m 55s the patch passed +1 javadoc 0m 42s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 49s the patch passed with JDK v1.7.0_95 +1 unit 0m 9s hadoop-project in the patch passed with JDK v1.8.0_72. -1 unit 1m 54s hadoop-mapreduce-client-core in the patch failed with JDK v1.8.0_72. -1 unit 102m 46s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_72. +1 unit 0m 17s hadoop-project in the patch passed with JDK v1.7.0_95. +1 unit 2m 51s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95. -1 unit 101m 40s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 31s Patch generated 15 ASF License warnings. 258m 6s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.mapreduce.jobhistory.TestJobHistoryViewerPrinter   hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapred.TestNetworkedJob JDK v1.7.0_95 Failed junit tests hadoop.mapred.TestNetworkedJob Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788119/MAPREDUCE-6627.004.patch JIRA Issue MAPREDUCE-6627 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 2d5425f849ad 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4b0e59f Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: . Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6325/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        rkanter Robert Kanter added a comment -

        Test failures unrelated other than TestJobHistoryViewerPrinter, which was due to an ordering issue on JDK 8. The 005 patch fixes that.

        Show
        rkanter Robert Kanter added a comment - Test failures unrelated other than TestJobHistoryViewerPrinter , which was due to an ordering issue on JDK 8. The 005 patch fixes that.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 36s Maven dependency ordering for branch
        +1 mvninstall 6m 40s trunk passed
        +1 compile 6m 11s trunk passed with JDK v1.8.0_72
        +1 compile 6m 41s trunk passed with JDK v1.7.0_95
        +1 checkstyle 1m 7s trunk passed
        +1 mvnsite 1m 11s trunk passed
        +1 mvneclipse 0m 36s trunk passed
        0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-project
        +1 findbugs 1m 28s trunk passed
        +1 javadoc 0m 42s trunk passed with JDK v1.8.0_72
        +1 javadoc 0m 49s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 15s Maven dependency ordering for patch
        +1 mvninstall 0m 55s the patch passed
        +1 compile 5m 43s the patch passed with JDK v1.8.0_72
        +1 javac 5m 43s the patch passed
        +1 compile 6m 45s the patch passed with JDK v1.7.0_95
        -1 javac 13m 39s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 3 new + 732 unchanged - 3 fixed = 735 total (was 735)
        +1 javac 6m 45s the patch passed
        -1 checkstyle 1m 8s root: patch generated 1 new + 190 unchanged - 68 fixed = 191 total (was 258)
        +1 mvnsite 1m 13s the patch passed
        +1 mvneclipse 0m 37s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-project
        +1 findbugs 1m 53s the patch passed
        +1 javadoc 0m 41s the patch passed with JDK v1.8.0_72
        +1 javadoc 0m 50s the patch passed with JDK v1.7.0_95
        +1 unit 0m 8s hadoop-project in the patch passed with JDK v1.8.0_72.
        -1 unit 1m 57s hadoop-mapreduce-client-core in the patch failed with JDK v1.8.0_72.
        -1 unit 106m 22s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_72.
        +1 unit 0m 16s hadoop-project in the patch passed with JDK v1.7.0_95.
        -1 unit 2m 22s hadoop-mapreduce-client-core in the patch failed with JDK v1.7.0_95.
        -1 unit 102m 4s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_95.
        -1 asflicense 0m 30s Patch generated 15 ASF License warnings.
        261m 18s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.mapred.TestFileInputFormat
          hadoop.mapreduce.lib.input.TestFileInputFormat
          hadoop.mapreduce.tools.TestCLI
          hadoop.mapreduce.v2.TestMRJobsWithProfiler
          hadoop.mapred.TestNetworkedJob
        JDK v1.7.0_95 Failed junit tests hadoop.mapred.TestFileInputFormat
          hadoop.mapreduce.lib.input.TestFileInputFormat
          hadoop.mapred.TestNetworkedJob



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788284/MAPREDUCE-6627.005.patch
        JIRA Issue MAPREDUCE-6627
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
        uname Linux 52f0fec86693 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 77f7ca3
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_95.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/testReport/
        asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: .
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 36s Maven dependency ordering for branch +1 mvninstall 6m 40s trunk passed +1 compile 6m 11s trunk passed with JDK v1.8.0_72 +1 compile 6m 41s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 7s trunk passed +1 mvnsite 1m 11s trunk passed +1 mvneclipse 0m 36s trunk passed 0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-project +1 findbugs 1m 28s trunk passed +1 javadoc 0m 42s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 49s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 0m 55s the patch passed +1 compile 5m 43s the patch passed with JDK v1.8.0_72 +1 javac 5m 43s the patch passed +1 compile 6m 45s the patch passed with JDK v1.7.0_95 -1 javac 13m 39s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 3 new + 732 unchanged - 3 fixed = 735 total (was 735) +1 javac 6m 45s the patch passed -1 checkstyle 1m 8s root: patch generated 1 new + 190 unchanged - 68 fixed = 191 total (was 258) +1 mvnsite 1m 13s the patch passed +1 mvneclipse 0m 37s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-project +1 findbugs 1m 53s the patch passed +1 javadoc 0m 41s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 50s the patch passed with JDK v1.7.0_95 +1 unit 0m 8s hadoop-project in the patch passed with JDK v1.8.0_72. -1 unit 1m 57s hadoop-mapreduce-client-core in the patch failed with JDK v1.8.0_72. -1 unit 106m 22s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_72. +1 unit 0m 16s hadoop-project in the patch passed with JDK v1.7.0_95. -1 unit 2m 22s hadoop-mapreduce-client-core in the patch failed with JDK v1.7.0_95. -1 unit 102m 4s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 30s Patch generated 15 ASF License warnings. 261m 18s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.mapred.TestFileInputFormat   hadoop.mapreduce.lib.input.TestFileInputFormat   hadoop.mapreduce.tools.TestCLI   hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapred.TestNetworkedJob JDK v1.7.0_95 Failed junit tests hadoop.mapred.TestFileInputFormat   hadoop.mapreduce.lib.input.TestFileInputFormat   hadoop.mapred.TestNetworkedJob Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788284/MAPREDUCE-6627.005.patch JIRA Issue MAPREDUCE-6627 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 52f0fec86693 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 77f7ca3 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: . Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6329/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        kasha Karthik Kambatla added a comment -

        Thanks for working on this, Robert.

        The v5 patch looks generally good barring these nits:

        1. Rename the subclasses of JobHistoryViewerPrinter, may be to HumanReadableViewerPrinter and JsonViewerPrinter or something else? The current naming uses Human and JSON between Viewer and Printer and hence a little confusing.
        2. This is not introduced in this patch, but the command-line parsing in the CLI looks very complicated. May be there is value in revisiting this and use a CLI-parsing library for simplicity, probably in a follow up JIRA?
        3. For the CLI changes in this patch, I was wondering if it would make sense to add methods getOutputFile, getFormat etc. to see if those options are specified. For example, it appears the ordering of the options is to maintained. If one specifies "-format" before "-outfile", the latter wouldn't be parsed.
        Show
        kasha Karthik Kambatla added a comment - Thanks for working on this, Robert. The v5 patch looks generally good barring these nits: Rename the subclasses of JobHistoryViewerPrinter, may be to HumanReadableViewerPrinter and JsonViewerPrinter or something else? The current naming uses Human and JSON between Viewer and Printer and hence a little confusing. This is not introduced in this patch, but the command-line parsing in the CLI looks very complicated. May be there is value in revisiting this and use a CLI-parsing library for simplicity, probably in a follow up JIRA? For the CLI changes in this patch, I was wondering if it would make sense to add methods getOutputFile, getFormat etc. to see if those options are specified. For example, it appears the ordering of the options is to maintained. If one specifies "-format" before "-outfile", the latter wouldn't be parsed.
        Hide
        rkanter Robert Kanter added a comment -

        The 006 patch renames the new files.

        I spoke with Karthik offline and we agreed that for now, I'll just clarify the CLI parsing with comments, and a followup JIRA to clean up all of the parsing with a library will suffice. Trying to manually parse this one command for now, and allowing it to be in any order, will be error prone (e.g. mapred job -history foo.jhst -outfile all), and if we're going to redo it anyway with a library, we may as well wait.

        Show
        rkanter Robert Kanter added a comment - The 006 patch renames the new files. I spoke with Karthik offline and we agreed that for now, I'll just clarify the CLI parsing with comments, and a followup JIRA to clean up all of the parsing with a library will suffice. Trying to manually parse this one command for now, and allowing it to be in any order, will be error prone (e.g. mapred job -history foo.jhst -outfile all ), and if we're going to redo it anyway with a library, we may as well wait.
        Hide
        rkanter Robert Kanter added a comment -

        I created MAPREDUCE-6636 to cleanup the CLI parsing.

        Show
        rkanter Robert Kanter added a comment - I created MAPREDUCE-6636 to cleanup the CLI parsing.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 22s Maven dependency ordering for branch
        +1 mvninstall 6m 42s trunk passed
        +1 compile 5m 55s trunk passed with JDK v1.8.0_72
        +1 compile 6m 37s trunk passed with JDK v1.7.0_95
        +1 checkstyle 1m 6s trunk passed
        +1 mvnsite 1m 11s trunk passed
        +1 mvneclipse 0m 37s trunk passed
        0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-project
        +1 findbugs 1m 28s trunk passed
        +1 javadoc 0m 40s trunk passed with JDK v1.8.0_72
        +1 javadoc 0m 47s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 0m 55s the patch passed
        +1 compile 5m 51s the patch passed with JDK v1.8.0_72
        -1 javac 7m 2s root-jdk1.8.0_72 with JDK v1.8.0_72 generated 2 new + 737 unchanged - 2 fixed = 739 total (was 739)
        +1 javac 5m 51s the patch passed
        +1 compile 6m 45s the patch passed with JDK v1.7.0_95
        -1 javac 13m 47s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 3 new + 732 unchanged - 3 fixed = 735 total (was 735)
        +1 javac 6m 45s the patch passed
        -1 checkstyle 1m 8s root: patch generated 1 new + 190 unchanged - 68 fixed = 191 total (was 258)
        +1 mvnsite 1m 10s the patch passed
        +1 mvneclipse 0m 37s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-project
        +1 findbugs 1m 54s the patch passed
        +1 javadoc 0m 40s the patch passed with JDK v1.8.0_72
        +1 javadoc 0m 49s the patch passed with JDK v1.7.0_95
        +1 unit 0m 8s hadoop-project in the patch passed with JDK v1.8.0_72.
        -1 unit 1m 54s hadoop-mapreduce-client-core in the patch failed with JDK v1.8.0_72.
        -1 unit 97m 51s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_72.
        +1 unit 0m 15s hadoop-project in the patch passed with JDK v1.7.0_95.
        -1 unit 2m 22s hadoop-mapreduce-client-core in the patch failed with JDK v1.7.0_95.
        -1 unit 102m 30s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_95.
        -1 asflicense 0m 32s Patch generated 17 ASF License warnings.
        252m 35s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.mapreduce.lib.input.TestFileInputFormat
          hadoop.mapred.TestFileInputFormat
          hadoop.mapred.TestNetworkedJob
          hadoop.mapreduce.v2.TestMRJobsWithProfiler
        JDK v1.7.0_95 Failed junit tests hadoop.mapreduce.lib.input.TestFileInputFormat
          hadoop.mapred.TestFileInputFormat
          hadoop.mapred.TestNetworkedJob



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788346/MAPREDUCE-6627.006.patch
        JIRA Issue MAPREDUCE-6627
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
        uname Linux f8639faf7945 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0fb14aa
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        javac root-jdk1.8.0_72: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_72.txt
        javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_95.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/testReport/
        asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: .
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 22s Maven dependency ordering for branch +1 mvninstall 6m 42s trunk passed +1 compile 5m 55s trunk passed with JDK v1.8.0_72 +1 compile 6m 37s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 6s trunk passed +1 mvnsite 1m 11s trunk passed +1 mvneclipse 0m 37s trunk passed 0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-project +1 findbugs 1m 28s trunk passed +1 javadoc 0m 40s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 47s trunk passed with JDK v1.7.0_95 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 0m 55s the patch passed +1 compile 5m 51s the patch passed with JDK v1.8.0_72 -1 javac 7m 2s root-jdk1.8.0_72 with JDK v1.8.0_72 generated 2 new + 737 unchanged - 2 fixed = 739 total (was 739) +1 javac 5m 51s the patch passed +1 compile 6m 45s the patch passed with JDK v1.7.0_95 -1 javac 13m 47s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 3 new + 732 unchanged - 3 fixed = 735 total (was 735) +1 javac 6m 45s the patch passed -1 checkstyle 1m 8s root: patch generated 1 new + 190 unchanged - 68 fixed = 191 total (was 258) +1 mvnsite 1m 10s the patch passed +1 mvneclipse 0m 37s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-project +1 findbugs 1m 54s the patch passed +1 javadoc 0m 40s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 49s the patch passed with JDK v1.7.0_95 +1 unit 0m 8s hadoop-project in the patch passed with JDK v1.8.0_72. -1 unit 1m 54s hadoop-mapreduce-client-core in the patch failed with JDK v1.8.0_72. -1 unit 97m 51s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_72. +1 unit 0m 15s hadoop-project in the patch passed with JDK v1.7.0_95. -1 unit 2m 22s hadoop-mapreduce-client-core in the patch failed with JDK v1.7.0_95. -1 unit 102m 30s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 32s Patch generated 17 ASF License warnings. 252m 35s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.mapreduce.lib.input.TestFileInputFormat   hadoop.mapred.TestFileInputFormat   hadoop.mapred.TestNetworkedJob   hadoop.mapreduce.v2.TestMRJobsWithProfiler JDK v1.7.0_95 Failed junit tests hadoop.mapreduce.lib.input.TestFileInputFormat   hadoop.mapred.TestFileInputFormat   hadoop.mapred.TestNetworkedJob Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788346/MAPREDUCE-6627.006.patch JIRA Issue MAPREDUCE-6627 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux f8639faf7945 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0fb14aa Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac root-jdk1.8.0_72: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_72.txt javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: . Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6330/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        kasha Karthik Kambatla added a comment -

        LGTM. +1

        Show
        kasha Karthik Kambatla added a comment - LGTM. +1
        Hide
        rkanter Robert Kanter added a comment -

        Thanks for the reviews Karthik Kambatla and Daniel Templeton. Committed to trunk and branch-2!

        Show
        rkanter Robert Kanter added a comment - Thanks for the reviews Karthik Kambatla and Daniel Templeton . Committed to trunk and branch-2!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9327 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9327/)
        MAPREDUCE-6627. Add machine-readable output to mapred job -history (rkanter: rev 8eee59ce6b3044cb73bb41fed6b7ece959e7c2f8)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/pom.xml
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/TestMRJobClient.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/MapredCommands.md
        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HumanReadableHistoryViewerPrinter.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewerPrinter.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JSONHistoryViewerPrinter.java
        • hadoop-project/pom.xml
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/jobhistory/TestHistoryViewerPrinter.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9327 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9327/ ) MAPREDUCE-6627 . Add machine-readable output to mapred job -history (rkanter: rev 8eee59ce6b3044cb73bb41fed6b7ece959e7c2f8) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/pom.xml hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/TestMRJobClient.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/MapredCommands.md hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HumanReadableHistoryViewerPrinter.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewerPrinter.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JSONHistoryViewerPrinter.java hadoop-project/pom.xml hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/jobhistory/TestHistoryViewerPrinter.java

          People

          • Assignee:
            rkanter Robert Kanter
            Reporter:
            rkanter Robert Kanter
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development