Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6614

Remove unnecessary code in TestMapreduceConfigFields

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0
    • Component/s: test
    • Labels:
    • Target Version/s:

      Description

      In branch-2, the following code can be removed because these parameters are in both mapred-default.xml and MRJobConfig.java.

      TestMapreduceConfigFields.java
          xmlPropsToSkipCompare.add("mapreduce.reduce.skip.proc-count.auto-incr");
          xmlPropsToSkipCompare.add("mapreduce.map.skip.proc-count.auto-incr");
      

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9175 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9175/)
          Added MAPREDUCE-6614 to 2.8.0 in CHANGES.txt. (aajisaka: rev 2b833297ceb523d39e683fcd34ed8ab9b5651bcf)

          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9175 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9175/ ) Added MAPREDUCE-6614 to 2.8.0 in CHANGES.txt. (aajisaka: rev 2b833297ceb523d39e683fcd34ed8ab9b5651bcf) hadoop-mapreduce-project/CHANGES.txt
          Hide
          ajisakaa Akira Ajisaka added a comment -

          The test failure looks unrelated to the patch. I ran the test locally on branch-2, and the test passed.

          Show
          ajisakaa Akira Ajisaka added a comment - The test failure looks unrelated to the patch. I ran the test locally on branch-2, and the test passed.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to branch-2 and branch-2.8. Thanks Kai Sasaki for the contribution!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to branch-2 and branch-2.8. Thanks Kai Sasaki for the contribution!
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, committing this.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, committing this.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 9m 22s branch-2 passed
          +1 compile 0m 34s branch-2 passed with JDK v1.8.0_66
          +1 compile 0m 32s branch-2 passed with JDK v1.7.0_91
          +1 checkstyle 0m 14s branch-2 passed
          +1 mvnsite 0m 39s branch-2 passed
          +1 mvneclipse 0m 17s branch-2 passed
          +1 findbugs 1m 1s branch-2 passed
          +1 javadoc 0m 25s branch-2 passed with JDK v1.8.0_66
          +1 javadoc 0m 26s branch-2 passed with JDK v1.7.0_91
          +1 mvninstall 0m 32s the patch passed
          +1 compile 0m 30s the patch passed with JDK v1.8.0_66
          +1 javac 0m 30s the patch passed
          +1 compile 0m 29s the patch passed with JDK v1.7.0_91
          +1 javac 0m 29s the patch passed
          +1 checkstyle 0m 14s the patch passed
          +1 mvnsite 0m 34s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 12s the patch passed
          +1 javadoc 0m 22s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 21s the patch passed with JDK v1.7.0_91
          -1 unit 11m 41s hadoop-mapreduce-client-app in the patch failed with JDK v1.8.0_66.
          -1 unit 11m 16s hadoop-mapreduce-client-app in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          42m 52s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.app.job.impl.TestJobImpl
          JDK v1.7.0_91 Failed junit tests hadoop.mapreduce.v2.app.job.impl.TestTaskAttempt
            hadoop.mapreduce.v2.app.job.impl.TestJobImpl



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:babe025
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783976/MAPREDUCE-6614-branch-2.01.patch
          JIRA Issue MAPREDUCE-6614
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 5432ea632c97 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 280c9b8
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6276/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6276/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6276/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6276/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6276/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
          Max memory used 75MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6276/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 22s branch-2 passed +1 compile 0m 34s branch-2 passed with JDK v1.8.0_66 +1 compile 0m 32s branch-2 passed with JDK v1.7.0_91 +1 checkstyle 0m 14s branch-2 passed +1 mvnsite 0m 39s branch-2 passed +1 mvneclipse 0m 17s branch-2 passed +1 findbugs 1m 1s branch-2 passed +1 javadoc 0m 25s branch-2 passed with JDK v1.8.0_66 +1 javadoc 0m 26s branch-2 passed with JDK v1.7.0_91 +1 mvninstall 0m 32s the patch passed +1 compile 0m 30s the patch passed with JDK v1.8.0_66 +1 javac 0m 30s the patch passed +1 compile 0m 29s the patch passed with JDK v1.7.0_91 +1 javac 0m 29s the patch passed +1 checkstyle 0m 14s the patch passed +1 mvnsite 0m 34s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 12s the patch passed +1 javadoc 0m 22s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 21s the patch passed with JDK v1.7.0_91 -1 unit 11m 41s hadoop-mapreduce-client-app in the patch failed with JDK v1.8.0_66. -1 unit 11m 16s hadoop-mapreduce-client-app in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 42m 52s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.app.job.impl.TestJobImpl JDK v1.7.0_91 Failed junit tests hadoop.mapreduce.v2.app.job.impl.TestTaskAttempt   hadoop.mapreduce.v2.app.job.impl.TestJobImpl Subsystem Report/Notes Docker Image:yetus/hadoop:babe025 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783976/MAPREDUCE-6614-branch-2.01.patch JIRA Issue MAPREDUCE-6614 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5432ea632c97 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 280c9b8 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6276/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6276/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6276/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6276/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6276/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6276/console This message was automatically generated.
          Hide
          lewuathe Kai Sasaki added a comment -

          Akira Ajisaka Thank you for the followup review! I updated TestMapreduceConfigFields. Could you check it?

          Show
          lewuathe Kai Sasaki added a comment - Akira Ajisaka Thank you for the followup review! I updated TestMapreduceConfigFields . Could you check it?

            People

            • Assignee:
              lewuathe Kai Sasaki
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development