Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Ports KeyValueLineRecordReader and KeyValueTextInputFormat the new Map/Reduce API
    1. patch-655.txt
      20 kB
      Amareshwari Sriramadasu
    2. patch-655-1.txt
      22 kB
      Amareshwari Sriramadasu
    3. patch-655-2.txt
      21 kB
      Amareshwari Sriramadasu

      Activity

      Amareshwari Sriramadasu created issue -
      Amareshwari Sriramadasu made changes -
      Field Original Value New Value
      Link This issue blocks HADOOP-6090 [ HADOOP-6090 ]
      Hide
      Amareshwari Sriramadasu added a comment -

      Patch modifying KeyValueLineRecordReader and KeyValueTextInputFormat to use new api

      Show
      Amareshwari Sriramadasu added a comment - Patch modifying KeyValueLineRecordReader and KeyValueTextInputFormat to use new api
      Amareshwari Sriramadasu made changes -
      Attachment patch-655.txt [ 12412361 ]
      Hide
      Amareshwari Sriramadasu added a comment -

      test-patch result:

           [exec] -1 overall.
           [exec]
           [exec]     +1 @author.  The patch does not contain any @author tags.
           [exec]
           [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
           [exec]
           [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
           [exec]
           [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
           [exec]
           [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
           [exec]
           [exec]     -1 release audit.  The applied patch generated 305 release audit warnings (more than the trunk's current 303 warnings).
           [exec]
           [exec]
      

      -1 release audit. looks spurious. releaseAuditDiffWarnings.txt shows the difference for html files.

      Show
      Amareshwari Sriramadasu added a comment - test-patch result: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] -1 release audit. The applied patch generated 305 release audit warnings (more than the trunk's current 303 warnings). [exec] [exec] -1 release audit. looks spurious. releaseAuditDiffWarnings.txt shows the difference for html files.
      Amareshwari Sriramadasu made changes -
      Status Open [ 1 ] Patch Available [ 10002 ]
      Hide
      Amareshwari Sriramadasu added a comment -

      All tests passed on my machine except TestJobTrackerRestart and TestJobTrackerRestartWithLostTracker due to MAPREDUCE-683 and MAPREDUCE-171

      Show
      Amareshwari Sriramadasu added a comment - All tests passed on my machine except TestJobTrackerRestart and TestJobTrackerRestartWithLostTracker due to MAPREDUCE-683 and MAPREDUCE-171
      Hide
      Jothi Padmanabhan added a comment -

      Minor. Some methods can be shared by the old and new API.

      Show
      Jothi Padmanabhan added a comment - Minor. Some methods can be shared by the old and new API.
      Amareshwari Sriramadasu made changes -
      Link This issue blocks HADOOP-6090 [ HADOOP-6090 ]
      Hide
      Amareshwari Sriramadasu added a comment -

      Patch with comments incorporated

      Show
      Amareshwari Sriramadasu added a comment - Patch with comments incorporated
      Amareshwari Sriramadasu made changes -
      Attachment patch-655-1.txt [ 12412968 ]
      Amareshwari Sriramadasu made changes -
      Status Patch Available [ 10002 ] Open [ 1 ]
      Hide
      Amareshwari Sriramadasu added a comment -

      submitting for hudson

      Show
      Amareshwari Sriramadasu added a comment - submitting for hudson
      Amareshwari Sriramadasu made changes -
      Status Open [ 1 ] Patch Available [ 10002 ]
      Hide
      Amareshwari Sriramadasu added a comment -

      ant test and test-patch passed on my machine

      Show
      Amareshwari Sriramadasu added a comment - ant test and test-patch passed on my machine
      Hide
      Jothi Padmanabhan added a comment -

      +1. Patch looks good.

      Show
      Jothi Padmanabhan added a comment - +1. Patch looks good.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12412968/patch-655-1.txt
      against trunk revision 792704.

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 6 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs warnings.

      -1 release audit. The applied patch generated 315 release audit warnings (more than the trunk's current 313 warnings).

      +1 core tests. The patch passed core unit tests.

      -1 contrib tests. The patch failed contrib unit tests.

      Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/372/testReport/
      Release audit warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/372/artifact/trunk/current/releaseAuditDiffWarnings.txt
      Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/372/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
      Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/372/artifact/trunk/build/test/checkstyle-errors.html
      Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/372/console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12412968/patch-655-1.txt against trunk revision 792704. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 315 release audit warnings (more than the trunk's current 313 warnings). +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/372/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/372/artifact/trunk/current/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/372/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/372/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/372/console This message is automatically generated.
      Hide
      Amareshwari Sriramadasu added a comment -

      Patch changing the dummy reporter create a counters and do findCounter. This removes the change in LineRecordReader.
      Ran both TestMRKeyValueTextInputFormat and TestKeyValueTextInputFormat

      Show
      Amareshwari Sriramadasu added a comment - Patch changing the dummy reporter create a counters and do findCounter. This removes the change in LineRecordReader. Ran both TestMRKeyValueTextInputFormat and TestKeyValueTextInputFormat
      Amareshwari Sriramadasu made changes -
      Attachment patch-655-2.txt [ 12413094 ]
      Hide
      Sharad Agarwal added a comment -

      I just committed this. Thanks Amareshwari!

      Show
      Sharad Agarwal added a comment - I just committed this. Thanks Amareshwari!
      Sharad Agarwal made changes -
      Status Patch Available [ 10002 ] Resolved [ 5 ]
      Hadoop Flags [Reviewed]
      Fix Version/s 0.21.0 [ 12314045 ]
      Resolution Fixed [ 1 ]
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk #20 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/20/)

      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #20 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/20/ )
      Jothi Padmanabhan made changes -
      Release Note Ports KeyValueLineRecordReader and KeyValueTextInputFormat the new Map/Reduce API
      Tom White made changes -
      Status Resolved [ 5 ] Closed [ 6 ]

        People

        • Assignee:
          Amareshwari Sriramadasu
          Reporter:
          Amareshwari Sriramadasu
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development