Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6542

HistoryViewer uses SimpleDateFormat, but SimpleDateFormat is not threadsafe

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.0, 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: jobhistoryserver
    • Labels:
      None
    • Environment:

      CentOS6.5 Hadoop

      Description

      I use SimpleDateFormat to Parse the JobHistory File before

      private static final SimpleDateFormat dateFormat =
          new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
       public static String getJobDetail(JobInfo job) {
              StringBuffer jobDetails = new StringBuffer("");
              SummarizedJob ts = new SummarizedJob(job);
              jobDetails.append(job.getJobId().toString().trim()).append("\t");
              jobDetails.append(job.getUsername()).append("\t");
              jobDetails.append(job.getJobname().replaceAll("\\n", "")).append("\t");
              jobDetails.append(job.getJobQueueName()).append("\t");
              jobDetails.append(job.getPriority()).append("\t");
              jobDetails.append(job.getJobConfPath()).append("\t");
              jobDetails.append(job.getUberized()).append("\t");
              jobDetails.append(dateFormat.format(job.getSubmitTime())).append("\t");
              jobDetails.append(dateFormat.format(job.getLaunchTime())).append("\t");
              jobDetails.append(dateFormat.format(job.getFinishTime())).append("\t");
             return jobDetails.toString();
      }
      

      But I find I query the SubmitTime and LaunchTime in hive and compare JobHistory File time , I find that the submitTime and launchTime was wrong.

      Finally,I change to use the FastDateFormat to parse the time format and the time become right

      1. MAPREDUCE-6542.patch
        1 kB
        zhangyubiao
      2. MAPREDUCE-6542-branch-2.8.patch
        10 kB
        zhangyubiao
      3. MAPREDUCE-6542-branch-2.8-v1.patch
        8 kB
        zhangyubiao
      4. MAPREDUCE-6542-branch-2.8-v2.patch
        8 kB
        zhangyubiao
      5. MAPREDUCE-6542-v10.patch
        8 kB
        zhangyubiao
      6. MAPREDUCE-6542-v11.patch
        10 kB
        zhangyubiao
      7. MAPREDUCE-6542-v12.patch
        10 kB
        zhangyubiao
      8. MAPREDUCE-6542-v13.patch
        15 kB
        zhangyubiao
      9. MAPREDUCE-6542-v14.patch
        15 kB
        zhangyubiao
      10. MAPREDUCE-6542-v15.patch
        9 kB
        zhangyubiao
      11. MAPREDUCE-6542-v16.patch
        9 kB
        zhangyubiao
      12. MAPREDUCE-6542-v2.patch
        8 kB
        zhangyubiao
      13. MAPREDUCE-6542-v3.patch
        4 kB
        zhangyubiao
      14. MAPREDUCE-6542-v4.patch
        4 kB
        zhangyubiao
      15. MAPREDUCE-6542-v5.patch
        6 kB
        zhangyubiao
      16. MAPREDUCE-6542-v6.patch
        7 kB
        zhangyubiao
      17. MAPREDUCE-6542-v7.patch
        7 kB
        zhangyubiao
      18. MAPREDUCE-6542-v8.patch
        7 kB
        zhangyubiao
      19. MAPREDUCE-6542-v9.patch
        8 kB
        zhangyubiao

        Issue Links

          Activity

          Hide
          piaoyu zhang zhangyubiao added a comment -

          MAPREDUCE-6542.patch for review

          Show
          piaoyu zhang zhangyubiao added a comment - MAPREDUCE-6542 .patch for review
          Hide
          templedf Daniel Templeton added a comment -

          Looks fine to me. Please remove the import for SimpleDateFormat.

          Show
          templedf Daniel Templeton added a comment - Looks fine to me. Please remove the import for SimpleDateFormat.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Thanks Daniel Templeton to review.I remove the import for SimpleDateFormat.
          And I find some dateFormat method need to change.
          MAPREDUCE-6542-v2.patch is update for review

          Show
          piaoyu zhang zhangyubiao added a comment - Thanks Daniel Templeton to review.I remove the import for SimpleDateFormat. And I find some dateFormat method need to change. MAPREDUCE-6542 -v2.patch is update for review
          Hide
          templedf Daniel Templeton added a comment -

          zhangyubiao, looks better. What's the rationale behind removing all the time diffs? I don't think this patch should change the user-visible output.

          Show
          templedf Daniel Templeton added a comment - zhangyubiao , looks better. What's the rationale behind removing all the time diffs? I don't think this patch should change the user-visible output.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks for working on this issue zhangyubiao, I think this is applicable for 2.6 branch too if so can "target version" be appended for 2.6 and check whether same patch modification suffices ?

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks for working on this issue zhangyubiao , I think this is applicable for 2.6 branch too if so can "target version" be appended for 2.6 and check whether same patch modification suffices ?
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          zhangyubiao, FYI, Fix-version is set by committers at commit time, so please only use Target-Version to express your intended releases. Thanks.

          Also, 2.7.2 is ready for release, moving this to 2.7.3.

          Fixing this myself for now and also adding it to 2.6.3 per comment above.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - zhangyubiao , FYI, Fix-version is set by committers at commit time, so please only use Target-Version to express your intended releases. Thanks. Also, 2.7.2 is ready for release, moving this to 2.7.3. Fixing this myself for now and also adding it to 2.6.3 per comment above.
          Hide
          templedf Daniel Templeton added a comment -

          As it is currently written, this patch affects the output format of the CLI (-history). In order to go into branch-2, the patch needs to leave the output format unchanged, correct?

          Show
          templedf Daniel Templeton added a comment - As it is currently written, this patch affects the output format of the CLI (-history). In order to go into branch-2, the patch needs to leave the output format unchanged, correct?
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Daniel Templeton Should I add the method into StringUtils
          public static String getFastFormattedTimeWithDiff(FastDateFormat fastDateFormat,long finishTime, long startTime){
          StringBuffer buf = new StringBuffer();
          if (0 != finishTime) {
          buf.append(fastDateFormat.format(new Date(finishTime)));
          if (0 != startTime)

          { buf.append(" (" + formatTimeDiff(finishTime , startTime) + ")"); }

          }
          return buf.toString();
          }

          and Change the method formatTime(long timeDiff)'s StringBuilder to StringBuffer .

          Show
          piaoyu zhang zhangyubiao added a comment - Daniel Templeton Should I add the method into StringUtils public static String getFastFormattedTimeWithDiff(FastDateFormat fastDateFormat,long finishTime, long startTime){ StringBuffer buf = new StringBuffer(); if (0 != finishTime) { buf.append(fastDateFormat.format(new Date(finishTime))); if (0 != startTime) { buf.append(" (" + formatTimeDiff(finishTime , startTime) + ")"); } } return buf.toString(); } and Change the method formatTime(long timeDiff)'s StringBuilder to StringBuffer .
          Hide
          templedf Daniel Templeton added a comment -

          zhangyubiao, I'd rather keep the method name the same and let the parameter types distinguish it.

          I strongly suspect that HistoryViewer is the only code in Hadoop using the current (DateFormat version) of the method. You should check. There may be client code using it, though. If it really is otherwise unused within Hadoop, I would consider marking the DateFormat version of the method as deprecated when you add the FastDateFormat version. Vinod Kumar Vavilapalli, any thoughts on that?

          The alternative would be to keep both methods and refactor out the common parts into a third private method.

          Show
          templedf Daniel Templeton added a comment - zhangyubiao , I'd rather keep the method name the same and let the parameter types distinguish it. I strongly suspect that HistoryViewer is the only code in Hadoop using the current ( DateFormat version) of the method. You should check. There may be client code using it, though. If it really is otherwise unused within Hadoop, I would consider marking the DateFormat version of the method as deprecated when you add the FastDateFormat version. Vinod Kumar Vavilapalli , any thoughts on that? The alternative would be to keep both methods and refactor out the common parts into a third private method.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Daniel Templeton you are right. I search the getFormattedTimeWithDiff method and find it only use in HistoryViewer.

          Show
          piaoyu zhang zhangyubiao added a comment - Daniel Templeton you are right. I search the getFormattedTimeWithDiff method and find it only use in HistoryViewer.
          Hide
          djp Junping Du added a comment -

          Hi zhangyubiao, thanks for the patch! The "Reviewed" flag is only set after some committer give +1 on your patch.
          In addition, you should click "Submit Patch" when you upload a new patch so your JIRA status will become "Patch Available" and Jenkins can trigger test automatically on your patch. I will fix it for you at this time.

          Show
          djp Junping Du added a comment - Hi zhangyubiao , thanks for the patch! The "Reviewed" flag is only set after some committer give +1 on your patch. In addition, you should click "Submit Patch" when you upload a new patch so your JIRA status will become "Patch Available" and Jenkins can trigger test automatically on your patch. I will fix it for you at this time.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 6s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 16s trunk passed
          +1 compile 0m 19s trunk passed with JDK v1.8.0_66
          +1 compile 0m 21s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 12s trunk passed
          +1 mvnsite 0m 30s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 11s trunk passed
          +1 javadoc 0m 21s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 25s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 23s the patch passed
          +1 compile 0m 18s the patch passed with JDK v1.8.0_66
          +1 javac 0m 18s the patch passed
          +1 compile 0m 21s the patch passed with JDK v1.7.0_85
          +1 javac 0m 21s the patch passed
          -1 checkstyle 0m 12s Patch generated 5 new checkstyle issues in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core (total was 207, now 211).
          +1 mvnsite 0m 27s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 18s the patch passed
          +1 javadoc 0m 20s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 23s the patch passed with JDK v1.7.0_85
          +1 unit 1m 37s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 53s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_85.
          -1 asflicense 0m 21s Patch generated 1 ASF License warnings.
          15m 41s



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-12
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771359/MAPREDUCE-6542-v2.patch
          JIRA Issue MAPREDUCE-6542
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 81134e6cd941 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-fa12328/precommit/personality/hadoop.sh
          git revision trunk / 06a7031
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6155/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6155/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6155/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
          Max memory used 228MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6155/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 6s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 16s trunk passed +1 compile 0m 19s trunk passed with JDK v1.8.0_66 +1 compile 0m 21s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 30s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 11s trunk passed +1 javadoc 0m 21s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 25s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 23s the patch passed +1 compile 0m 18s the patch passed with JDK v1.8.0_66 +1 javac 0m 18s the patch passed +1 compile 0m 21s the patch passed with JDK v1.7.0_85 +1 javac 0m 21s the patch passed -1 checkstyle 0m 12s Patch generated 5 new checkstyle issues in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core (total was 207, now 211). +1 mvnsite 0m 27s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 18s the patch passed +1 javadoc 0m 20s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 23s the patch passed with JDK v1.7.0_85 +1 unit 1m 37s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66. +1 unit 1m 53s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_85. -1 asflicense 0m 21s Patch generated 1 ASF License warnings. 15m 41s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-12 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771359/MAPREDUCE-6542-v2.patch JIRA Issue MAPREDUCE-6542 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 81134e6cd941 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-fa12328/precommit/personality/hadoop.sh git revision trunk / 06a7031 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6155/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6155/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6155/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core Max memory used 228MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6155/console This message was automatically generated.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Junping Du Thank you for your help.
          MAPREDUCE-6542-v3.patch for review

          Show
          piaoyu zhang zhangyubiao added a comment - Junping Du Thank you for your help. MAPREDUCE-6542 -v3.patch for review
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 7s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 4s trunk passed
          +1 compile 4m 24s trunk passed with JDK v1.8.0_60
          +1 compile 4m 11s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 56s trunk passed
          +1 mvnsite 1m 27s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          +1 findbugs 2m 43s trunk passed
          +1 javadoc 1m 14s trunk passed with JDK v1.8.0_60
          +1 javadoc 1m 29s trunk passed with JDK v1.7.0_79
          +1 mvninstall 2m 6s the patch passed
          +1 compile 4m 29s the patch passed with JDK v1.8.0_60
          +1 javac 4m 29s the patch passed
          +1 compile 4m 12s the patch passed with JDK v1.7.0_79
          +1 javac 4m 12s the patch passed
          -1 checkstyle 0m 56s Patch generated 2 new checkstyle issues in root (total was 299, now 300).
          +1 mvnsite 1m 22s the patch passed
          +1 mvneclipse 0m 30s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 59s the patch passed
          +1 javadoc 1m 15s the patch passed with JDK v1.8.0_60
          +1 javadoc 1m 28s the patch passed with JDK v1.7.0_79
          +1 unit 6m 59s hadoop-common in the patch passed with JDK v1.8.0_60.
          +1 unit 1m 36s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_60.
          -1 unit 6m 49s hadoop-common in the patch failed with JDK v1.7.0_79.
          +1 unit 1m 53s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_79.
          -1 asflicense 0m 22s Patch generated 1 ASF License warnings.
          58m 15s



          Reason Tests
          JDK v1.7.0_79 Failed junit tests hadoop.ipc.TestDecayRpcScheduler



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-13
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772191/MAPREDUCE-6542-v3.patch
          JIRA Issue MAPREDUCE-6542
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b3e295baf393 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-fa12328/precommit/personality/hadoop.sh
          git revision trunk / cccf884
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6157/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6157/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6157/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6157/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6157/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
          Max memory used 227MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6157/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 7s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 4s trunk passed +1 compile 4m 24s trunk passed with JDK v1.8.0_60 +1 compile 4m 11s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 56s trunk passed +1 mvnsite 1m 27s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 2m 43s trunk passed +1 javadoc 1m 14s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 29s trunk passed with JDK v1.7.0_79 +1 mvninstall 2m 6s the patch passed +1 compile 4m 29s the patch passed with JDK v1.8.0_60 +1 javac 4m 29s the patch passed +1 compile 4m 12s the patch passed with JDK v1.7.0_79 +1 javac 4m 12s the patch passed -1 checkstyle 0m 56s Patch generated 2 new checkstyle issues in root (total was 299, now 300). +1 mvnsite 1m 22s the patch passed +1 mvneclipse 0m 30s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 59s the patch passed +1 javadoc 1m 15s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 28s the patch passed with JDK v1.7.0_79 +1 unit 6m 59s hadoop-common in the patch passed with JDK v1.8.0_60. +1 unit 1m 36s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_60. -1 unit 6m 49s hadoop-common in the patch failed with JDK v1.7.0_79. +1 unit 1m 53s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_79. -1 asflicense 0m 22s Patch generated 1 ASF License warnings. 58m 15s Reason Tests JDK v1.7.0_79 Failed junit tests hadoop.ipc.TestDecayRpcScheduler Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-13 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772191/MAPREDUCE-6542-v3.patch JIRA Issue MAPREDUCE-6542 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b3e295baf393 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-fa12328/precommit/personality/hadoop.sh git revision trunk / cccf884 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6157/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6157/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6157/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6157/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6157/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Max memory used 227MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6157/console This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          zhangyubiao, thanks for the new patch. We're getting closer. Three more things I'd like to see:

          1. Mark the old getFormattedTimeWithDiff() method as @Deprecated
          2. Refactor both the getFormattedTimeWithDiff() methods to call a new private method that contains all the replicated logic. Something like private static getFormattedTimeWithDiff(String formattedFinishTime, long startTime)
          3. Use StringBuilder instead of StringBuffer. StringBuffer is MT safe, but the places where it's used are locally scoped, so necessarily single-threaded. StringBuilder is faster because it's not MT-safe. (http://stackoverflow.com/questions/355089/stringbuilder-and-stringbuffer)

          If you're feeling ambitious, it would also be nice to add a unit test that tries to force concurrent access to the function.

          Show
          templedf Daniel Templeton added a comment - zhangyubiao , thanks for the new patch. We're getting closer. Three more things I'd like to see: Mark the old getFormattedTimeWithDiff() method as @Deprecated Refactor both the getFormattedTimeWithDiff() methods to call a new private method that contains all the replicated logic. Something like private static getFormattedTimeWithDiff(String formattedFinishTime, long startTime) Use StringBuilder instead of StringBuffer . StringBuffer is MT safe, but the places where it's used are locally scoped, so necessarily single-threaded. StringBuilder is faster because it's not MT-safe. ( http://stackoverflow.com/questions/355089/stringbuilder-and-stringbuffer ) If you're feeling ambitious, it would also be nice to add a unit test that tries to force concurrent access to the function.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Daniel Templeton,thanks for your help. Just Like you say,Replicated logic should be get into one method.
          And I find that the SimpleDateFormat and the FastDateFormat was all extends abstract class Format.
          Could we make it simple and change the getFormattedTimeWithDiff() into
          getFormattedTimeWithDiff(Format dateFormat,long finishTime, long startTime) ?

          Show
          piaoyu zhang zhangyubiao added a comment - Daniel Templeton ,thanks for your help. Just Like you say,Replicated logic should be get into one method. And I find that the SimpleDateFormat and the FastDateFormat was all extends abstract class Format. Could we make it simple and change the getFormattedTimeWithDiff() into getFormattedTimeWithDiff(Format dateFormat,long finishTime, long startTime) ?
          Hide
          templedf Daniel Templeton added a comment -

          zhangyubiao, the risk there is moving a compile-time issue to runtime. It would be better to keep both methods and refactor. Then someday in the distant future, we can remove the DateFormat variant.

          Show
          templedf Daniel Templeton added a comment - zhangyubiao , the risk there is moving a compile-time issue to runtime. It would be better to keep both methods and refactor. Then someday in the distant future, we can remove the DateFormat variant.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Thanks for Daniel Templeton's answer. I update MAPREDUCE-6542-v4.patch for review.

          Show
          piaoyu zhang zhangyubiao added a comment - Thanks for Daniel Templeton 's answer. I update MAPREDUCE-6542 -v4.patch for review.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 7s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 30s trunk passed
          +1 compile 9m 7s trunk passed with JDK v1.8.0_66
          +1 compile 9m 25s trunk passed with JDK v1.7.0_85
          +1 checkstyle 1m 3s trunk passed
          +1 mvnsite 1m 45s trunk passed
          +1 mvneclipse 0m 31s trunk passed
          -1 findbugs 1m 16s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 2 extant Findbugs warnings.
          +1 javadoc 1m 22s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 33s trunk passed with JDK v1.7.0_85
          +1 mvninstall 2m 12s the patch passed
          +1 compile 8m 42s the patch passed with JDK v1.8.0_66
          +1 javac 8m 42s the patch passed
          +1 compile 9m 55s the patch passed with JDK v1.7.0_85
          +1 javac 9m 55s the patch passed
          -1 checkstyle 1m 2s Patch generated 8 new checkstyle issues in root (total was 299, now 306).
          +1 mvnsite 1m 38s the patch passed
          +1 mvneclipse 0m 29s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 25s the patch passed
          +1 javadoc 1m 22s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 34s the patch passed with JDK v1.7.0_85
          -1 unit 18m 13s hadoop-common in the patch failed with JDK v1.8.0_66.
          +1 unit 2m 3s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66.
          -1 unit 9m 55s hadoop-common in the patch failed with JDK v1.7.0_85.
          +1 unit 2m 8s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_85.
          -1 asflicense 0m 22s Patch generated 1 ASF License warnings.
          100m 57s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestRPC
            hadoop.security.ssl.TestReloadingX509TrustManager
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle
          JDK v1.7.0_85 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.fs.shell.find.TestFind
            hadoop.ha.TestZKFailoverController
            hadoop.metrics2.impl.TestMetricsSystemImpl
            hadoop.security.TestShellBasedIdMapping



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:date2015-11-18
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772944/MAPREDUCE-6542-v4.patch
          JIRA Issue MAPREDUCE-6542
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1c428f694a8a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh
          git revision trunk / 4a3b8f1
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6170/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6170/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6170/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6170/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6170/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6170/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6170/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6170/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
          Max memory used 77MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6170/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 7s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 30s trunk passed +1 compile 9m 7s trunk passed with JDK v1.8.0_66 +1 compile 9m 25s trunk passed with JDK v1.7.0_85 +1 checkstyle 1m 3s trunk passed +1 mvnsite 1m 45s trunk passed +1 mvneclipse 0m 31s trunk passed -1 findbugs 1m 16s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 2 extant Findbugs warnings. +1 javadoc 1m 22s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 33s trunk passed with JDK v1.7.0_85 +1 mvninstall 2m 12s the patch passed +1 compile 8m 42s the patch passed with JDK v1.8.0_66 +1 javac 8m 42s the patch passed +1 compile 9m 55s the patch passed with JDK v1.7.0_85 +1 javac 9m 55s the patch passed -1 checkstyle 1m 2s Patch generated 8 new checkstyle issues in root (total was 299, now 306). +1 mvnsite 1m 38s the patch passed +1 mvneclipse 0m 29s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 25s the patch passed +1 javadoc 1m 22s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 34s the patch passed with JDK v1.7.0_85 -1 unit 18m 13s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 2m 3s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66. -1 unit 9m 55s hadoop-common in the patch failed with JDK v1.7.0_85. +1 unit 2m 8s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_85. -1 asflicense 0m 22s Patch generated 1 ASF License warnings. 100m 57s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestRPC   hadoop.security.ssl.TestReloadingX509TrustManager JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle JDK v1.7.0_85 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.fs.shell.find.TestFind   hadoop.ha.TestZKFailoverController   hadoop.metrics2.impl.TestMetricsSystemImpl   hadoop.security.TestShellBasedIdMapping Subsystem Report/Notes Docker Image:yetus/hadoop:date2015-11-18 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772944/MAPREDUCE-6542-v4.patch JIRA Issue MAPREDUCE-6542 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1c428f694a8a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh git revision trunk / 4a3b8f1 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6170/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6170/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6170/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6170/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6170/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6170/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6170/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6170/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Max memory used 77MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6170/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 9m 46s trunk passed
          +1 compile 11m 48s trunk passed with JDK v1.8.0_66
          +1 compile 11m 4s trunk passed with JDK v1.7.0_85
          +1 checkstyle 1m 13s trunk passed
          +1 mvnsite 2m 0s trunk passed
          +1 mvneclipse 0m 35s trunk passed
          -1 findbugs 1m 29s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 2 extant Findbugs warnings.
          +1 javadoc 1m 46s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 52s trunk passed with JDK v1.7.0_85
          +1 mvninstall 2m 38s the patch passed
          +1 compile 11m 40s the patch passed with JDK v1.8.0_66
          +1 javac 11m 40s the patch passed
          +1 compile 11m 6s the patch passed with JDK v1.7.0_85
          +1 javac 11m 6s the patch passed
          -1 checkstyle 1m 12s Patch generated 7 new checkstyle issues in root (total was 299, now 305).
          +1 mvnsite 1m 57s the patch passed
          +1 mvneclipse 0m 36s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 6s the patch passed
          +1 javadoc 1m 43s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 53s the patch passed with JDK v1.7.0_85
          -1 unit 8m 55s hadoop-common in the patch failed with JDK v1.8.0_66.
          +1 unit 2m 20s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66.
          +1 unit 8m 53s hadoop-common in the patch passed with JDK v1.7.0_85.
          +1 unit 2m 24s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_85.
          -1 asflicense 0m 26s Patch generated 1 ASF License warnings.
          105m 34s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.ipc.TestIPC
            hadoop.security.ssl.TestReloadingX509TrustManager
            hadoop.test.TestTimedOutTestsListener



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:date2015-11-18
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772947/MAPREDUCE-6542-v4.patch
          JIRA Issue MAPREDUCE-6542
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux c9d68720d80e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh
          git revision trunk / 4a3b8f1
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6171/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6171/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6171/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6171/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6171/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6171/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
          Max memory used 78MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6171/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 9m 46s trunk passed +1 compile 11m 48s trunk passed with JDK v1.8.0_66 +1 compile 11m 4s trunk passed with JDK v1.7.0_85 +1 checkstyle 1m 13s trunk passed +1 mvnsite 2m 0s trunk passed +1 mvneclipse 0m 35s trunk passed -1 findbugs 1m 29s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 2 extant Findbugs warnings. +1 javadoc 1m 46s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 52s trunk passed with JDK v1.7.0_85 +1 mvninstall 2m 38s the patch passed +1 compile 11m 40s the patch passed with JDK v1.8.0_66 +1 javac 11m 40s the patch passed +1 compile 11m 6s the patch passed with JDK v1.7.0_85 +1 javac 11m 6s the patch passed -1 checkstyle 1m 12s Patch generated 7 new checkstyle issues in root (total was 299, now 305). +1 mvnsite 1m 57s the patch passed +1 mvneclipse 0m 36s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 6s the patch passed +1 javadoc 1m 43s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 53s the patch passed with JDK v1.7.0_85 -1 unit 8m 55s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 2m 20s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66. +1 unit 8m 53s hadoop-common in the patch passed with JDK v1.7.0_85. +1 unit 2m 24s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_85. -1 asflicense 0m 26s Patch generated 1 ASF License warnings. 105m 34s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.ipc.TestIPC   hadoop.security.ssl.TestReloadingX509TrustManager   hadoop.test.TestTimedOutTestsListener Subsystem Report/Notes Docker Image:yetus/hadoop:date2015-11-18 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772947/MAPREDUCE-6542-v4.patch JIRA Issue MAPREDUCE-6542 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c9d68720d80e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh git revision trunk / 4a3b8f1 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6171/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6171/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6171/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6171/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6171/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6171/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Max memory used 78MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6171/console This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          Thanks, zhangyubiao. Looks good to me. What testing did you do for the patch?

          Show
          templedf Daniel Templeton added a comment - Thanks, zhangyubiao . Looks good to me. What testing did you do for the patch?
          Hide
          templedf Daniel Templeton added a comment -

          BTW, you should look at the checkstyle comments from the last Jenkins run and clean those up.

          Show
          templedf Daniel Templeton added a comment - BTW, you should look at the checkstyle comments from the last Jenkins run and clean those up.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Hi,Daniel Templeton. Last patch I don't give a unit test.
          Beacause I confuse how to test the force concurrent access to the function GetFormattedTimeWithDiff()
          I get the idea this days. Under the Code ,You will find first time1 was not the same in the Multithread and
          the second time1 was the same. Is it OK for the test ? Give me some advise,Thanks.

            @Test
            //Multithreaded Test GetFormattedTimeWithDiff()
            public void testGetFormattedTimeWithDiff() throws InterruptedException {
              ExecutorService exec1 = Executors.newFixedThreadPool(16);
              final long currentTime = System.currentTimeMillis();
              final long currentTime2 = currentTime - 30000;
              for (int i = 0; i < 20; i++)
                exec1.execute(new Runnable() {
                  @Override public void run() {
                    String time1 = StringUtils.getFormattedTimeWithDiff(dateFormat, currentTime, 0);
                    System.out.println("time1 : " + time1);
                    String time2 = StringUtils.getFormattedTimeWithDiff(dateFormat, currentTime2, 0);
                    System.out.println("time2 : " + time2);
                  }
                });
              exec1.shutdown();
              exec1.awaitTermination(50, TimeUnit.SECONDS);
          
              System.out.println("---------------------------------------------------------");
              ExecutorService exec = Executors.newFixedThreadPool(16);
              for (int i = 0; i < 20; i++)
                exec.execute(new Runnable() {
                  @Override public void run() {
                    String time1 = StringUtils.getFormattedTimeWithDiff(fastDateFormat, currentTime, 0);
                    System.out.println("time1 : " + time1);
                    String time2 = StringUtils.getFormattedTimeWithDiff(fastDateFormat, currentTime2, 0);
                    System.out.println("time2 : " + time2);
                  }
                });
              exec.shutdown();
              exec.awaitTermination(50, TimeUnit.SECONDS);
            }
          
          Show
          piaoyu zhang zhangyubiao added a comment - Hi, Daniel Templeton . Last patch I don't give a unit test. Beacause I confuse how to test the force concurrent access to the function GetFormattedTimeWithDiff() I get the idea this days. Under the Code ,You will find first time1 was not the same in the Multithread and the second time1 was the same. Is it OK for the test ? Give me some advise,Thanks. @Test //Multithreaded Test GetFormattedTimeWithDiff() public void testGetFormattedTimeWithDiff() throws InterruptedException { ExecutorService exec1 = Executors.newFixedThreadPool(16); final long currentTime = System .currentTimeMillis(); final long currentTime2 = currentTime - 30000; for ( int i = 0; i < 20; i++) exec1.execute( new Runnable () { @Override public void run() { String time1 = StringUtils.getFormattedTimeWithDiff(dateFormat, currentTime, 0); System .out.println( "time1 : " + time1); String time2 = StringUtils.getFormattedTimeWithDiff(dateFormat, currentTime2, 0); System .out.println( "time2 : " + time2); } }); exec1.shutdown(); exec1.awaitTermination(50, TimeUnit.SECONDS); System .out.println( "---------------------------------------------------------" ); ExecutorService exec = Executors.newFixedThreadPool(16); for ( int i = 0; i < 20; i++) exec.execute( new Runnable () { @Override public void run() { String time1 = StringUtils.getFormattedTimeWithDiff(fastDateFormat, currentTime, 0); System .out.println( "time1 : " + time1); String time2 = StringUtils.getFormattedTimeWithDiff(fastDateFormat, currentTime2, 0); System .out.println( "time2 : " + time2); } }); exec.shutdown(); exec.awaitTermination(50, TimeUnit.SECONDS); }
          Hide
          templedf Daniel Templeton added a comment -

          zhangyubiao, that looks like a reasonable way to test. I wouldn't test that the old method breaks – we don't really care. What we want to prove is that the new method doesn't break.

          I would add two things to the test. First, instead of printing the times, assert that they're equal:

          Assert.assertTrue("Method returned inconsistent results indicative of a race condition", time1.equals(time2))
          

          I'd use the assertTrue() method instead of the assertEquals() method because assertEquals() implies that the first argument is the canonically correct value, but that's up to you.

          Second, I'd start the run() method with a barrier so that you don't end up with a case where the threads happen to all run serially as they're spawned. It's probably pretty darned unlikely, but since the point of the test is to make the threads try to stomp on each other, it may be worth it.

          Show
          templedf Daniel Templeton added a comment - zhangyubiao , that looks like a reasonable way to test. I wouldn't test that the old method breaks – we don't really care. What we want to prove is that the new method doesn't break. I would add two things to the test. First, instead of printing the times, assert that they're equal: Assert.assertTrue( "Method returned inconsistent results indicative of a race condition" , time1.equals(time2)) I'd use the assertTrue() method instead of the assertEquals() method because assertEquals() implies that the first argument is the canonically correct value, but that's up to you. Second, I'd start the run() method with a barrier so that you don't end up with a case where the threads happen to all run serially as they're spawned. It's probably pretty darned unlikely, but since the point of the test is to make the threads try to stomp on each other, it may be worth it.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Thanks for Daniel Templeton's answer. I update MAPREDUCE-6542-v5.patch for review.

          Show
          piaoyu zhang zhangyubiao added a comment - Thanks for Daniel Templeton's answer. I update MAPREDUCE-6542 -v5.patch for review.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 42s trunk passed
          +1 compile 7m 37s trunk passed with JDK v1.8.0_66
          +1 compile 8m 24s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 58s trunk passed
          +1 mvnsite 1m 36s trunk passed
          +1 mvneclipse 0m 29s trunk passed
          -1 findbugs 1m 46s hadoop-common-project/hadoop-common in trunk has 1 extant Findbugs warnings.
          -1 findbugs 1m 8s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 2 extant Findbugs warnings.
          +1 javadoc 1m 15s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 28s trunk passed with JDK v1.7.0_85
          +1 mvninstall 2m 14s the patch passed
          +1 compile 7m 30s the patch passed with JDK v1.8.0_66
          +1 javac 7m 30s the patch passed
          +1 compile 8m 24s the patch passed with JDK v1.7.0_85
          +1 javac 8m 24s the patch passed
          -1 checkstyle 0m 56s Patch generated 1 new checkstyle issues in root (total was 299, now 299).
          +1 mvnsite 1m 32s the patch passed
          +1 mvneclipse 0m 28s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 13s the patch passed
          +1 javadoc 1m 13s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 28s the patch passed with JDK v1.7.0_85
          -1 unit 7m 18s hadoop-common in the patch failed with JDK v1.8.0_66.
          +1 unit 1m 33s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66.
          -1 unit 7m 38s hadoop-common in the patch failed with JDK v1.7.0_85.
          +1 unit 1m 53s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_85.
          -1 asflicense 0m 20s Patch generated 1 ASF License warnings.
          79m 29s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.fs.permission.TestFsPermission
            hadoop.io.compress.TestCompressorDecompressor
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor
          JDK v1.7.0_85 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.fs.permission.TestFsPermission
            hadoop.io.compress.TestCompressorDecompressor
          JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773801/MAPREDUCE-6542-v5.patch
          JIRA Issue MAPREDUCE-6542
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6a639e15a004 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 001ecf9
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6180/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6180/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6180/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6180/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6180/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6180/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6180/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6180/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6180/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
          Max memory used 75MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6180/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 42s trunk passed +1 compile 7m 37s trunk passed with JDK v1.8.0_66 +1 compile 8m 24s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 58s trunk passed +1 mvnsite 1m 36s trunk passed +1 mvneclipse 0m 29s trunk passed -1 findbugs 1m 46s hadoop-common-project/hadoop-common in trunk has 1 extant Findbugs warnings. -1 findbugs 1m 8s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 2 extant Findbugs warnings. +1 javadoc 1m 15s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 28s trunk passed with JDK v1.7.0_85 +1 mvninstall 2m 14s the patch passed +1 compile 7m 30s the patch passed with JDK v1.8.0_66 +1 javac 7m 30s the patch passed +1 compile 8m 24s the patch passed with JDK v1.7.0_85 +1 javac 8m 24s the patch passed -1 checkstyle 0m 56s Patch generated 1 new checkstyle issues in root (total was 299, now 299). +1 mvnsite 1m 32s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 13s the patch passed +1 javadoc 1m 13s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 28s the patch passed with JDK v1.7.0_85 -1 unit 7m 18s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 1m 33s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66. -1 unit 7m 38s hadoop-common in the patch failed with JDK v1.7.0_85. +1 unit 1m 53s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_85. -1 asflicense 0m 20s Patch generated 1 ASF License warnings. 79m 29s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.fs.permission.TestFsPermission   hadoop.io.compress.TestCompressorDecompressor JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor JDK v1.7.0_85 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.fs.permission.TestFsPermission   hadoop.io.compress.TestCompressorDecompressor JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773801/MAPREDUCE-6542-v5.patch JIRA Issue MAPREDUCE-6542 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6a639e15a004 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 001ecf9 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6180/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6180/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6180/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6180/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6180/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6180/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6180/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6180/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6180/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6180/console This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          zhangyubiao, thanks! Looks like you have all the rights pieces now. We just have some details to iron out in the test code.

            static final FastDateFormat fastDateFormat = FastDateFormat.getInstance("d-MMM-yyyy HH:mm:ss");
          

          Let's make this private and move it up to the top of the class. I find member variables declared in the middle of a class to be confusing.

            @Test
            //Multithreaded Test GetFormattedTimeWithDiff()
            public void testGetFormattedTimeWithDiff() {
              class Worker implements Runnable{
          

          Please add a space before the open brace.

                private CyclicBarrier cyclicBarrier;
          

          Insert a newline here.

                public Worker(CyclicBarrier cyclicBarrier){
          

          Please add a space before the open brace.

                  this.cyclicBarrier = cyclicBarrier;
                }
          

          Insert a newline here.

                @Override public void run() {
          

          Please put the @Override on a line by itself for clarity and consistency.

                  final long currentTime = System.currentTimeMillis() - 30000 ;
                  final long currentTime2 = currentTime ;
          

          I think what you meant to do was set currentTime2 = System.currentTimeMillis() and then set currentTime = currentTime2 - 30000. Also, please take out the spaces before the semicolons.

                  String time1 = StringUtils.getFormattedTimeWithDiff(fastDateFormat, currentTime, 0);
                  String time2 = StringUtils.getFormattedTimeWithDiff(fastDateFormat, currentTime2, 0);
          

          I think you can just call getFormattedTimeWithDiff(fastDateFormat, currentTime2, currentTime) twice and then compare the results.

                  assertTrue("Method returned consistent results indicative of a race condition",
                      time1.equals(time2));
          

          Should be *in*consistent, not consistent.

                  try {
                    this.cyclicBarrier.await();
                  } catch (Exception e) {
                    e.printStackTrace();
                  }
          

          The barrier should go at the beginning of the method instead of at the end. With it at the end, it's making sure all threads terminate at the same time, but does nothing to synchronize the time formatting.

                }
              }
          
              CyclicBarrier cyclicBarrier = new CyclicBarrier(1000);
              for (int i = 0; i < 1000; i++) {
                new Thread(new Worker(cyclicBarrier)).start();
              }
            }
          

          Instead of creating Thread objects directly, I liked your previous approach of using an ExecutorService better.

          1000 is a lot of threads. It's highly unlikely that this code will run on a system with that level of concurrency. Instead, I think you'd be better served by dropping the thread count to something more like 10 and having each thread loop to make up the difference.

          If you want to find the number of loops to use empirically, run the code with a DateFormat instead to see how many loops it takes to make it break, and then multiply that number by 10 to be safe.

          Almost there!

          Show
          templedf Daniel Templeton added a comment - zhangyubiao , thanks! Looks like you have all the rights pieces now. We just have some details to iron out in the test code. static final FastDateFormat fastDateFormat = FastDateFormat.getInstance( "d-MMM-yyyy HH:mm:ss" ); Let's make this private and move it up to the top of the class. I find member variables declared in the middle of a class to be confusing. @Test //Multithreaded Test GetFormattedTimeWithDiff() public void testGetFormattedTimeWithDiff() { class Worker implements Runnable { Please add a space before the open brace. private CyclicBarrier cyclicBarrier; Insert a newline here. public Worker(CyclicBarrier cyclicBarrier){ Please add a space before the open brace. this .cyclicBarrier = cyclicBarrier; } Insert a newline here. @Override public void run() { Please put the @Override on a line by itself for clarity and consistency. final long currentTime = System .currentTimeMillis() - 30000 ; final long currentTime2 = currentTime ; I think what you meant to do was set currentTime2 = System.currentTimeMillis() and then set currentTime = currentTime2 - 30000 . Also, please take out the spaces before the semicolons. String time1 = StringUtils.getFormattedTimeWithDiff(fastDateFormat, currentTime, 0); String time2 = StringUtils.getFormattedTimeWithDiff(fastDateFormat, currentTime2, 0); I think you can just call getFormattedTimeWithDiff(fastDateFormat, currentTime2, currentTime) twice and then compare the results. assertTrue( "Method returned consistent results indicative of a race condition" , time1.equals(time2)); Should be *in*consistent, not consistent. try { this .cyclicBarrier.await(); } catch (Exception e) { e.printStackTrace(); } The barrier should go at the beginning of the method instead of at the end. With it at the end, it's making sure all threads terminate at the same time, but does nothing to synchronize the time formatting. } } CyclicBarrier cyclicBarrier = new CyclicBarrier(1000); for ( int i = 0; i < 1000; i++) { new Thread ( new Worker(cyclicBarrier)).start(); } } Instead of creating Thread objects directly, I liked your previous approach of using an ExecutorService better. 1000 is a lot of threads. It's highly unlikely that this code will run on a system with that level of concurrency. Instead, I think you'd be better served by dropping the thread count to something more like 10 and having each thread loop to make up the difference. If you want to find the number of loops to use empirically, run the code with a DateFormat instead to see how many loops it takes to make it break, and then multiply that number by 10 to be safe. Almost there!
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Daniel Templeton,Thanks a lot for review. I learn so much this days .
          I update MAPREDUCE-6542-v6.patch

          Show
          piaoyu zhang zhangyubiao added a comment - Daniel Templeton ,Thanks a lot for review. I learn so much this days . I update MAPREDUCE-6542 -v6.patch
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 23s trunk passed
          +1 compile 7m 33s trunk passed with JDK v1.8.0_66
          +1 compile 8m 42s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 58s trunk passed
          +1 mvnsite 1m 33s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          -1 findbugs 1m 48s hadoop-common-project/hadoop-common in trunk has 1 extant Findbugs warnings.
          -1 findbugs 1m 10s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 2 extant Findbugs warnings.
          +1 javadoc 1m 13s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 27s trunk passed with JDK v1.7.0_85
          +1 mvninstall 2m 14s the patch passed
          +1 compile 7m 32s the patch passed with JDK v1.8.0_66
          +1 javac 7m 32s the patch passed
          +1 compile 8m 25s the patch passed with JDK v1.7.0_85
          +1 javac 8m 25s the patch passed
          -1 checkstyle 0m 58s Patch generated 1 new checkstyle issues in root (total was 299, now 299).
          +1 mvnsite 1m 32s the patch passed
          +1 mvneclipse 0m 28s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 13s the patch passed
          +1 javadoc 1m 10s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 26s the patch passed with JDK v1.7.0_85
          -1 unit 6m 58s hadoop-common in the patch failed with JDK v1.8.0_66.
          +1 unit 1m 33s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66.
          -1 unit 7m 6s hadoop-common in the patch failed with JDK v1.7.0_85.
          +1 unit 1m 57s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_85.
          -1 asflicense 0m 21s Patch generated 1 ASF License warnings.
          78m 31s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.fs.permission.TestFsPermission
          JDK v1.7.0_85 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.fs.permission.TestFsPermission



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774349/MAPREDUCE-6542-v6.patch
          JIRA Issue MAPREDUCE-6542
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 70fbec7e8ee0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 177975e
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6196/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6196/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6196/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6196/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6196/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6196/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6196/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6196/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6196/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
          Max memory used 75MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6196/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 23s trunk passed +1 compile 7m 33s trunk passed with JDK v1.8.0_66 +1 compile 8m 42s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 58s trunk passed +1 mvnsite 1m 33s trunk passed +1 mvneclipse 0m 28s trunk passed -1 findbugs 1m 48s hadoop-common-project/hadoop-common in trunk has 1 extant Findbugs warnings. -1 findbugs 1m 10s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 2 extant Findbugs warnings. +1 javadoc 1m 13s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 27s trunk passed with JDK v1.7.0_85 +1 mvninstall 2m 14s the patch passed +1 compile 7m 32s the patch passed with JDK v1.8.0_66 +1 javac 7m 32s the patch passed +1 compile 8m 25s the patch passed with JDK v1.7.0_85 +1 javac 8m 25s the patch passed -1 checkstyle 0m 58s Patch generated 1 new checkstyle issues in root (total was 299, now 299). +1 mvnsite 1m 32s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 13s the patch passed +1 javadoc 1m 10s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 26s the patch passed with JDK v1.7.0_85 -1 unit 6m 58s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 1m 33s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66. -1 unit 7m 6s hadoop-common in the patch failed with JDK v1.7.0_85. +1 unit 1m 57s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_85. -1 asflicense 0m 21s Patch generated 1 ASF License warnings. 78m 31s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.fs.permission.TestFsPermission JDK v1.7.0_85 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.fs.permission.TestFsPermission Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774349/MAPREDUCE-6542-v6.patch JIRA Issue MAPREDUCE-6542 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 70fbec7e8ee0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 177975e findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6196/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6196/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6196/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6196/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6196/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6196/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6196/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6196/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6196/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6196/console This message was automatically generated.
          Hide
          djp Junping Du added a comment -

          Hi, can we move this out of 2.6.3? Thanks!

          Show
          djp Junping Du added a comment - Hi, can we move this out of 2.6.3? Thanks!
          Hide
          templedf Daniel Templeton added a comment -

          zhangyubiao, making good progress! Now we just need to tune.

          1. Please don't import *. Add an import line for every class.
          2. Your try-catch in the Worker.run() method should catch only InterruptedException and BrokenBarrierException. Feel free to use a multi-catch. Also, the catch in the Worker.run() method should not print the stack trace. Instead you can add a comment that explains that you're ignoring the exceptions. In production code, that would be a bad thing, but in this simple test case I think it's OK.
          3. If it were me, I think I'd restructure the test a little. First I'd make the barrier final. Then I'd replace the Worker inner class with an anonymous inner class that does the same thing, except that it references the barrier directly. I'd only instantiate one of those anonymous Runnable objects and use it repeatedly in the loop. If that's unclear, let me know.
          4. I don't think there's a need to make currentTime and currentTime2 final. It is technically correct, but it's not helpful in this context, and it's a little distracting. (And inconsistent. If currentTime is final, why isn't time1?)
          5. If you have time1 and time2, you should have currentTime1 and currentTime2. Actually, I'd rather they were called something more like start, end, formattedTime1, and formattedTime2.
          6. Mind your whitespace. I generally like to have blank lines separating code blocks (loops, methods, etc) from other code.
          Show
          templedf Daniel Templeton added a comment - zhangyubiao , making good progress! Now we just need to tune. Please don't import *. Add an import line for every class. Your try-catch in the Worker.run() method should catch only InterruptedException and BrokenBarrierException . Feel free to use a multi-catch. Also, the catch in the Worker.run() method should not print the stack trace. Instead you can add a comment that explains that you're ignoring the exceptions. In production code, that would be a bad thing, but in this simple test case I think it's OK. If it were me, I think I'd restructure the test a little. First I'd make the barrier final. Then I'd replace the Worker inner class with an anonymous inner class that does the same thing, except that it references the barrier directly. I'd only instantiate one of those anonymous Runnable objects and use it repeatedly in the loop. If that's unclear, let me know. I don't think there's a need to make currentTime and currentTime2 final. It is technically correct, but it's not helpful in this context, and it's a little distracting. (And inconsistent. If currentTime is final, why isn't time1 ?) If you have time1 and time2 , you should have currentTime1 and currentTime2 . Actually, I'd rather they were called something more like start , end , formattedTime1 , and formattedTime2 . Mind your whitespace. I generally like to have blank lines separating code blocks (loops, methods, etc) from other code.
          Hide
          djp Junping Du added a comment -

          Moving target releases to 2.6.4.

          Show
          djp Junping Du added a comment - Moving target releases to 2.6.4.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Thanks a lot for Daniel Templeton's guide.

            @Test
            //Multithreaded Test GetFormattedTimeWithDiff()
            public void testGetFormattedTimeWithDiff() throws InterruptedException {
              ExecutorService executorService = Executors.newFixedThreadPool(16);
              final CyclicBarrier cyclicBarrier = new CyclicBarrier(10);
          
              for (int i = 0; i < 10; i++) {
          
                executorService.execute(new Runnable() {
                  @Override
                  public void run() {
                    try {
                      cyclicBarrier.await();
                    } catch (InterruptedException e) {
                      assertEquals("cyclicBarrier InterruptedException", e.getMessage());
                    } catch (BrokenBarrierException e) {
                      assertEquals("cyclicBarrier BrokenBarrierException", e.getMessage());
                    }
                    final long end = System.currentTimeMillis();
                    final long start = end - 30000;
                    String formattedTime1 = StringUtils.getFormattedTimeWithDiff(fastDateFormat,
                            start, end);
                    String formattedTime2 = StringUtils.getFormattedTimeWithDiff(fastDateFormat,
                            start, end);
                    assertTrue("Method returned inconsistent results indicative of a race condition",
                            formattedTime1.equals(formattedTime2));
                  }
                });
          
              }
          
              executorService.shutdown();
            }
          

          Is it OK for the test unit ?

          And I find StringUtils.java:413: Line is longer than 80 characters (found 82).
          Should I fix this ?

          Show
          piaoyu zhang zhangyubiao added a comment - Thanks a lot for Daniel Templeton 's guide. @Test //Multithreaded Test GetFormattedTimeWithDiff() public void testGetFormattedTimeWithDiff() throws InterruptedException { ExecutorService executorService = Executors.newFixedThreadPool(16); final CyclicBarrier cyclicBarrier = new CyclicBarrier(10); for ( int i = 0; i < 10; i++) { executorService.execute( new Runnable () { @Override public void run() { try { cyclicBarrier.await(); } catch (InterruptedException e) { assertEquals( "cyclicBarrier InterruptedException" , e.getMessage()); } catch (BrokenBarrierException e) { assertEquals( "cyclicBarrier BrokenBarrierException" , e.getMessage()); } final long end = System .currentTimeMillis(); final long start = end - 30000; String formattedTime1 = StringUtils.getFormattedTimeWithDiff(fastDateFormat, start, end); String formattedTime2 = StringUtils.getFormattedTimeWithDiff(fastDateFormat, start, end); assertTrue( "Method returned inconsistent results indicative of a race condition" , formattedTime1.equals(formattedTime2)); } }); } executorService.shutdown(); } Is it OK for the test unit ? And I find StringUtils.java:413: Line is longer than 80 characters (found 82). Should I fix this ?
          Hide
          templedf Daniel Templeton added a comment -

          zhangyubiao, looks great. I'm not sure that you need the asserts in the catch clauses, but I suppose they don't hurt.

          Don't worry about fixing line 413 in StringUtils. There's no sensible way to break that line up, and it's not worth making the code ugly to shave 2 characters off the length.

          Note that you have a stray file in the last patch, debugout.

          Show
          templedf Daniel Templeton added a comment - zhangyubiao , looks great. I'm not sure that you need the asserts in the catch clauses, but I suppose they don't hurt. Don't worry about fixing line 413 in StringUtils . There's no sensible way to break that line up, and it's not worth making the code ugly to shave 2 characters off the length. Note that you have a stray file in the last patch, debugout.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Thanks Daniel Templeton, I summit MAPREDUCE-6542-v7.patch for review.

          Show
          piaoyu zhang zhangyubiao added a comment - Thanks Daniel Templeton , I summit MAPREDUCE-6542 -v7.patch for review.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 9m 58s trunk passed
          +1 compile 11m 56s trunk passed with JDK v1.8.0_66
          +1 compile 11m 20s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 13s trunk passed
          +1 mvnsite 2m 2s trunk passed
          +1 mvneclipse 0m 36s trunk passed
          -1 findbugs 1m 31s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 2 extant Findbugs warnings.
          +1 javadoc 1m 48s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 57s trunk passed with JDK v1.7.0_91
          +1 mvninstall 2m 38s the patch passed
          +1 compile 11m 46s the patch passed with JDK v1.8.0_66
          +1 javac 11m 46s the patch passed
          +1 compile 11m 22s the patch passed with JDK v1.7.0_91
          +1 javac 11m 22s the patch passed
          +1 checkstyle 1m 14s the patch passed
          +1 mvnsite 2m 3s the patch passed
          +1 mvneclipse 0m 35s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 15s the patch passed
          +1 javadoc 1m 46s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 52s the patch passed with JDK v1.7.0_91
          -1 unit 9m 40s hadoop-common in the patch failed with JDK v1.8.0_66.
          +1 unit 2m 43s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66.
          +1 unit 9m 47s hadoop-common in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 47s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91.
          -1 asflicense 0m 27s Patch generated 1 ASF License warnings.
          109m 26s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager
            hadoop.fs.shell.find.TestFind



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775976/MAPREDUCE-6542-v7.patch
          JIRA Issue MAPREDUCE-6542
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a4bc4bc20c8f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 742632e
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6202/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6202/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6202/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6202/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6202/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6202/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 58s trunk passed +1 compile 11m 56s trunk passed with JDK v1.8.0_66 +1 compile 11m 20s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 13s trunk passed +1 mvnsite 2m 2s trunk passed +1 mvneclipse 0m 36s trunk passed -1 findbugs 1m 31s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 2 extant Findbugs warnings. +1 javadoc 1m 48s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 57s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 38s the patch passed +1 compile 11m 46s the patch passed with JDK v1.8.0_66 +1 javac 11m 46s the patch passed +1 compile 11m 22s the patch passed with JDK v1.7.0_91 +1 javac 11m 22s the patch passed +1 checkstyle 1m 14s the patch passed +1 mvnsite 2m 3s the patch passed +1 mvneclipse 0m 35s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 15s the patch passed +1 javadoc 1m 46s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 52s the patch passed with JDK v1.7.0_91 -1 unit 9m 40s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 2m 43s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66. +1 unit 9m 47s hadoop-common in the patch passed with JDK v1.7.0_91. +1 unit 2m 47s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91. -1 asflicense 0m 27s Patch generated 1 ASF License warnings. 109m 26s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager   hadoop.fs.shell.find.TestFind Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775976/MAPREDUCE-6542-v7.patch JIRA Issue MAPREDUCE-6542 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a4bc4bc20c8f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 742632e findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6202/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6202/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6202/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6202/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6202/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6202/console This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          Nicely done, zhangyubiao. The last four things I see are:

          • The private getFormattedTimeWithDiff() method needs javadocs
          • You may as well make the two catches in the test method into one multi-catch (http://docs.oracle.com/javase/8/docs/technotes/guides/language/catch-multiple.html).
          • The comments inside the catch blocks in the tests say "expected." The exceptions aren't really expected; we just don't mind if they happen. "Ignored," might be a better comment. I said it earlier, but it bears repeating: this would be very bad coding style in production code. It's only acceptable here because it's test code where we can legitimately not care about those exceptions. Maybe a better comment would be to explain that since you're doing the operation many times, you can ignore the exception this time and hope it succeeds next time.
          • You need to awaitTermination() after shutting down the ExecutorService.

          Almost there.

          Show
          templedf Daniel Templeton added a comment - Nicely done, zhangyubiao . The last four things I see are: The private getFormattedTimeWithDiff() method needs javadocs You may as well make the two catches in the test method into one multi-catch ( http://docs.oracle.com/javase/8/docs/technotes/guides/language/catch-multiple.html ). The comments inside the catch blocks in the tests say "expected." The exceptions aren't really expected; we just don't mind if they happen. "Ignored," might be a better comment. I said it earlier, but it bears repeating: this would be very bad coding style in production code. It's only acceptable here because it's test code where we can legitimately not care about those exceptions. Maybe a better comment would be to explain that since you're doing the operation many times, you can ignore the exception this time and hope it succeeds next time. You need to awaitTermination() after shutting down the ExecutorService . Almost there.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Thanks a lot for Daniel Templeton for patient guidance.

          Show
          piaoyu zhang zhangyubiao added a comment - Thanks a lot for Daniel Templeton for patient guidance.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          MAPREDUCE-6542-v8.patch for review

          Show
          piaoyu zhang zhangyubiao added a comment - MAPREDUCE-6542 -v8.patch for review
          Hide
          templedf Daniel Templeton added a comment -

          zhangyubiao, that patch looks pretty good to me. I'll take closer look later, but nice work!

          Show
          templedf Daniel Templeton added a comment - zhangyubiao , that patch looks pretty good to me. I'll take closer look later, but nice work!
          Hide
          templedf Daniel Templeton added a comment -

          zhangyubiao, one last change:

          • Please replace the import java.util.concurrent.* with the individual imports.

          +1 pending that change.

          Show
          templedf Daniel Templeton added a comment - zhangyubiao , one last change: Please replace the import java.util.concurrent.* with the individual imports. +1 pending that change.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 28s trunk passed
          +1 compile 7m 56s trunk passed with JDK v1.8.0_66
          +1 compile 8m 47s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 58s trunk passed
          +1 mvnsite 1m 34s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          -1 findbugs 1m 10s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 2 extant Findbugs warnings.
          +1 javadoc 1m 14s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 28s trunk passed with JDK v1.7.0_91
          +1 mvninstall 2m 6s the patch passed
          +1 compile 8m 28s the patch passed with JDK v1.8.0_66
          +1 javac 8m 28s the patch passed
          +1 compile 10m 27s the patch passed with JDK v1.7.0_91
          +1 javac 10m 27s the patch passed
          +1 checkstyle 1m 7s the patch passed
          +1 mvnsite 1m 43s the patch passed
          +1 mvneclipse 0m 30s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 24s the patch passed
          +1 javadoc 1m 22s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 35s the patch passed with JDK v1.7.0_91
          -1 unit 7m 18s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 2m 13s hadoop-mapreduce-client-core in the patch failed with JDK v1.8.0_66.
          +1 unit 7m 48s hadoop-common in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 34s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91.
          -1 asflicense 0m 25s Patch generated 1 ASF License warnings.
          86m 16s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.test.TestTimedOutTestsListener
            hadoop.security.ssl.TestReloadingX509TrustManager
            hadoop.mapreduce.tools.TestCLI



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776948/MAPREDUCE-6542-v8.patch
          JIRA Issue MAPREDUCE-6542
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6aeb192160a3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2f623fb
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6214/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6214/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6214/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_66.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6214/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6214/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6214/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6214/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6214/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 28s trunk passed +1 compile 7m 56s trunk passed with JDK v1.8.0_66 +1 compile 8m 47s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 58s trunk passed +1 mvnsite 1m 34s trunk passed +1 mvneclipse 0m 28s trunk passed -1 findbugs 1m 10s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 2 extant Findbugs warnings. +1 javadoc 1m 14s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 28s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 6s the patch passed +1 compile 8m 28s the patch passed with JDK v1.8.0_66 +1 javac 8m 28s the patch passed +1 compile 10m 27s the patch passed with JDK v1.7.0_91 +1 javac 10m 27s the patch passed +1 checkstyle 1m 7s the patch passed +1 mvnsite 1m 43s the patch passed +1 mvneclipse 0m 30s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 24s the patch passed +1 javadoc 1m 22s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 35s the patch passed with JDK v1.7.0_91 -1 unit 7m 18s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 2m 13s hadoop-mapreduce-client-core in the patch failed with JDK v1.8.0_66. +1 unit 7m 48s hadoop-common in the patch passed with JDK v1.7.0_91. +1 unit 2m 34s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91. -1 asflicense 0m 25s Patch generated 1 ASF License warnings. 86m 16s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.test.TestTimedOutTestsListener   hadoop.security.ssl.TestReloadingX509TrustManager   hadoop.mapreduce.tools.TestCLI Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776948/MAPREDUCE-6542-v8.patch JIRA Issue MAPREDUCE-6542 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6aeb192160a3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2f623fb findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6214/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6214/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6214/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6214/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6214/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6214/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6214/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6214/console This message was automatically generated.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Daniel Templeton, It's my mistake. Thanks for remind

          Show
          piaoyu zhang zhangyubiao added a comment - Daniel Templeton , It's my mistake. Thanks for remind
          Hide
          piaoyu zhang zhangyubiao added a comment -

          MAPREDUCE-6542-v9.patch for review.

          Show
          piaoyu zhang zhangyubiao added a comment - MAPREDUCE-6542 -v9.patch for review.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 9m 16s trunk passed
          +1 compile 12m 4s trunk passed with JDK v1.8.0_66
          +1 compile 10m 49s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 10s trunk passed
          +1 mvnsite 1m 58s trunk passed
          +1 mvneclipse 0m 32s trunk passed
          -1 findbugs 1m 28s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 2 extant Findbugs warnings.
          +1 javadoc 1m 40s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 45s trunk passed with JDK v1.7.0_91
          +1 mvninstall 2m 24s the patch passed
          +1 compile 9m 19s the patch passed with JDK v1.8.0_66
          +1 javac 9m 19s the patch passed
          +1 compile 9m 52s the patch passed with JDK v1.7.0_91
          +1 javac 9m 52s the patch passed
          +1 checkstyle 1m 2s the patch passed
          +1 mvnsite 1m 41s the patch passed
          +1 mvneclipse 0m 29s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 29s the patch passed
          +1 javadoc 1m 23s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 36s the patch passed with JDK v1.7.0_91
          -1 unit 8m 6s hadoop-common in the patch failed with JDK v1.8.0_66.
          +1 unit 2m 5s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66.
          +1 unit 8m 28s hadoop-common in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 24s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91.
          -1 asflicense 0m 23s Patch generated 1 ASF License warnings.
          97m 3s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778416/MAPREDUCE-6542-v9.patch
          JIRA Issue MAPREDUCE-6542
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 06ff7fd68561 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 061c05c
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6215/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6215/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6215/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6215/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6215/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6215/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 16s trunk passed +1 compile 12m 4s trunk passed with JDK v1.8.0_66 +1 compile 10m 49s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 10s trunk passed +1 mvnsite 1m 58s trunk passed +1 mvneclipse 0m 32s trunk passed -1 findbugs 1m 28s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 2 extant Findbugs warnings. +1 javadoc 1m 40s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 45s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 24s the patch passed +1 compile 9m 19s the patch passed with JDK v1.8.0_66 +1 javac 9m 19s the patch passed +1 compile 9m 52s the patch passed with JDK v1.7.0_91 +1 javac 9m 52s the patch passed +1 checkstyle 1m 2s the patch passed +1 mvnsite 1m 41s the patch passed +1 mvneclipse 0m 29s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 29s the patch passed +1 javadoc 1m 23s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 36s the patch passed with JDK v1.7.0_91 -1 unit 8m 6s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 2m 5s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66. +1 unit 8m 28s hadoop-common in the patch passed with JDK v1.7.0_91. +1 unit 2m 24s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91. -1 asflicense 0m 23s Patch generated 1 ASF License warnings. 97m 3s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778416/MAPREDUCE-6542-v9.patch JIRA Issue MAPREDUCE-6542 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 06ff7fd68561 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 061c05c findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6215/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6215/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6215/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6215/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6215/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6215/console This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          +1 (non-binding) Nicely done, zhangyubiao.

          Show
          templedf Daniel Templeton added a comment - +1 (non-binding) Nicely done, zhangyubiao .
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Vinod Kumar Vavilapalli,Is it OK for commit?

          Show
          piaoyu zhang zhangyubiao added a comment - Vinod Kumar Vavilapalli ,Is it OK for commit?
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Junping Du ,Is it OK for commit?

          Show
          piaoyu zhang zhangyubiao added a comment - Junping Du ,Is it OK for commit?
          Hide
          piaoyu zhang zhangyubiao added a comment -

          git revision

          Show
          piaoyu zhang zhangyubiao added a comment - git revision
          Hide
          piaoyu zhang zhangyubiao added a comment -

          MAPREDUCE-6542-v10.patch for review. git revision

          Show
          piaoyu zhang zhangyubiao added a comment - MAPREDUCE-6542 -v10.patch for review. git revision
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 29s Maven dependency ordering for branch
          +1 mvninstall 7m 47s trunk passed
          +1 compile 6m 1s trunk passed with JDK v1.8.0_66
          +1 compile 6m 55s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 2s trunk passed
          +1 mvnsite 1m 36s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          -1 findbugs 1m 11s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 2 extant Findbugs warnings.
          +1 javadoc 1m 14s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 29s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 2m 5s the patch passed
          +1 compile 5m 57s the patch passed with JDK v1.8.0_66
          +1 javac 5m 57s the patch passed
          +1 compile 6m 52s the patch passed with JDK v1.7.0_91
          +1 javac 6m 52s the patch passed
          -1 checkstyle 1m 1s root: patch generated 1 new + 290 unchanged - 3 fixed = 291 total (was 293)
          +1 mvnsite 1m 34s the patch passed
          +1 mvneclipse 0m 28s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 25s the patch passed
          +1 javadoc 1m 18s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 25s the patch passed with JDK v1.7.0_91
          -1 unit 6m 16s hadoop-common in the patch failed with JDK v1.8.0_66.
          +1 unit 1m 50s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66.
          +1 unit 6m 48s hadoop-common in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 10s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          73m 19s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.ha.TestZKFailoverController



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784137/MAPREDUCE-6542-v10.patch
          JIRA Issue MAPREDUCE-6542
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d430104bdf87 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6eacdea
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6280/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6280/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6280/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6280/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6280/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6280/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 29s Maven dependency ordering for branch +1 mvninstall 7m 47s trunk passed +1 compile 6m 1s trunk passed with JDK v1.8.0_66 +1 compile 6m 55s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 2s trunk passed +1 mvnsite 1m 36s trunk passed +1 mvneclipse 0m 28s trunk passed -1 findbugs 1m 11s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 2 extant Findbugs warnings. +1 javadoc 1m 14s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 29s trunk passed with JDK v1.7.0_91 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 2m 5s the patch passed +1 compile 5m 57s the patch passed with JDK v1.8.0_66 +1 javac 5m 57s the patch passed +1 compile 6m 52s the patch passed with JDK v1.7.0_91 +1 javac 6m 52s the patch passed -1 checkstyle 1m 1s root: patch generated 1 new + 290 unchanged - 3 fixed = 291 total (was 293) +1 mvnsite 1m 34s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 25s the patch passed +1 javadoc 1m 18s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 25s the patch passed with JDK v1.7.0_91 -1 unit 6m 16s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 1m 50s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66. +1 unit 6m 48s hadoop-common in the patch passed with JDK v1.7.0_91. +1 unit 2m 10s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 73m 19s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.ha.TestZKFailoverController Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784137/MAPREDUCE-6542-v10.patch JIRA Issue MAPREDUCE-6542 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d430104bdf87 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6eacdea Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6280/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6280/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6280/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6280/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6280/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6280/console This message was automatically generated.
          Hide
          djp Junping Du added a comment -

          Sorry for late response, zhangyubiao. I haven't get chance to take a look at the patch here. Hopefully I can review it soon after 2.6.4 release work if no one review it before.
          BTW, 2.6.4 should be out soon, so move all non-critical pending issues out of 2.6.4 into 2.6.5.

          Show
          djp Junping Du added a comment - Sorry for late response, zhangyubiao . I haven't get chance to take a look at the patch here. Hopefully I can review it soon after 2.6.4 release work if no one review it before. BTW, 2.6.4 should be out soon, so move all non-critical pending issues out of 2.6.4 into 2.6.5.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Junping Du,Thanks for response. Hopefully you can review it soon.

          Show
          piaoyu zhang zhangyubiao added a comment - Junping Du ,Thanks for response. Hopefully you can review it soon.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          git revision

          Show
          piaoyu zhang zhangyubiao added a comment - git revision
          Hide
          piaoyu zhang zhangyubiao added a comment -

          MAPREDUCE-6542-v11.patch for review

          Show
          piaoyu zhang zhangyubiao added a comment - MAPREDUCE-6542 -v11.patch for review
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 6m 33s trunk passed
          +1 compile 5m 34s trunk passed with JDK v1.8.0_74
          +1 compile 6m 31s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 3s trunk passed
          +1 mvnsite 1m 26s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          +1 findbugs 2m 36s trunk passed
          +1 javadoc 1m 10s trunk passed with JDK v1.8.0_74
          +1 javadoc 1m 28s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 5s the patch passed
          +1 compile 5m 52s the patch passed with JDK v1.8.0_74
          +1 javac 5m 52s the patch passed
          +1 compile 6m 44s the patch passed with JDK v1.7.0_95
          +1 javac 6m 44s the patch passed
          +1 checkstyle 1m 5s root: patch generated 0 new + 85 unchanged - 1 fixed = 85 total (was 86)
          +1 mvnsite 1m 26s the patch passed
          +1 mvneclipse 0m 27s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 5s the patch passed
          +1 javadoc 1m 15s the patch passed with JDK v1.8.0_74
          +1 javadoc 1m 28s the patch passed with JDK v1.7.0_95
          +1 unit 6m 56s hadoop-common in the patch passed with JDK v1.8.0_74.
          +1 unit 1m 56s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_74.
          +1 unit 7m 15s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 2m 16s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          69m 59s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791476/MAPREDUCE-6542-v11.patch
          JIRA Issue MAPREDUCE-6542
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 31ab3b185702 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / cbd3132
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6362/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6362/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 33s trunk passed +1 compile 5m 34s trunk passed with JDK v1.8.0_74 +1 compile 6m 31s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 3s trunk passed +1 mvnsite 1m 26s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 2m 36s trunk passed +1 javadoc 1m 10s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 28s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 5s the patch passed +1 compile 5m 52s the patch passed with JDK v1.8.0_74 +1 javac 5m 52s the patch passed +1 compile 6m 44s the patch passed with JDK v1.7.0_95 +1 javac 6m 44s the patch passed +1 checkstyle 1m 5s root: patch generated 0 new + 85 unchanged - 1 fixed = 85 total (was 86) +1 mvnsite 1m 26s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 5s the patch passed +1 javadoc 1m 15s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 28s the patch passed with JDK v1.7.0_95 +1 unit 6m 56s hadoop-common in the patch passed with JDK v1.8.0_74. +1 unit 1m 56s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_74. +1 unit 7m 15s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 2m 16s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 69m 59s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791476/MAPREDUCE-6542-v11.patch JIRA Issue MAPREDUCE-6542 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 31ab3b185702 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cbd3132 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6362/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6362/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Junping Du, Could you please review the code ?

          Show
          piaoyu zhang zhangyubiao added a comment - Junping Du , Could you please review the code ?
          Hide
          piaoyu zhang zhangyubiao added a comment -

          git revision. MAPREDUCE-6542-v12.patch for review

          Show
          piaoyu zhang zhangyubiao added a comment - git revision. MAPREDUCE-6542 -v12.patch for review
          Hide
          piaoyu zhang zhangyubiao added a comment -

          MAPREDUCE-6542-v12.patch for review

          Show
          piaoyu zhang zhangyubiao added a comment - MAPREDUCE-6542 -v12.patch for review
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 1m 8s Maven dependency ordering for branch
          +1 mvninstall 6m 46s trunk passed
          +1 compile 5m 52s trunk passed with JDK v1.8.0_77
          +1 compile 6m 52s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 5s trunk passed
          +1 mvnsite 1m 31s trunk passed
          +1 mvneclipse 0m 29s trunk passed
          +1 findbugs 2m 45s trunk passed
          +1 javadoc 1m 16s trunk passed with JDK v1.8.0_77
          +1 javadoc 1m 31s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 6s the patch passed
          +1 compile 5m 44s the patch passed with JDK v1.8.0_77
          +1 javac 5m 44s the patch passed
          +1 compile 6m 50s the patch passed with JDK v1.7.0_95
          +1 javac 6m 50s the patch passed
          +1 checkstyle 1m 4s root: patch generated 0 new + 85 unchanged - 1 fixed = 85 total (was 86)
          +1 mvnsite 1m 32s the patch passed
          +1 mvneclipse 0m 28s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 8s the patch passed
          +1 javadoc 1m 19s the patch passed with JDK v1.8.0_77
          +1 javadoc 1m 31s the patch passed with JDK v1.7.0_95
          +1 unit 7m 18s hadoop-common in the patch passed with JDK v1.8.0_77.
          +1 unit 1m 58s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_77.
          +1 unit 7m 39s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 2m 17s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          73m 30s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797988/MAPREDUCE-6542-v12.patch
          JIRA Issue MAPREDUCE-6542
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 8d8d1d5b1e28 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / fdc46bf
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6439/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6439/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 1m 8s Maven dependency ordering for branch +1 mvninstall 6m 46s trunk passed +1 compile 5m 52s trunk passed with JDK v1.8.0_77 +1 compile 6m 52s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 5s trunk passed +1 mvnsite 1m 31s trunk passed +1 mvneclipse 0m 29s trunk passed +1 findbugs 2m 45s trunk passed +1 javadoc 1m 16s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 31s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 6s the patch passed +1 compile 5m 44s the patch passed with JDK v1.8.0_77 +1 javac 5m 44s the patch passed +1 compile 6m 50s the patch passed with JDK v1.7.0_95 +1 javac 6m 50s the patch passed +1 checkstyle 1m 4s root: patch generated 0 new + 85 unchanged - 1 fixed = 85 total (was 86) +1 mvnsite 1m 32s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 8s the patch passed +1 javadoc 1m 19s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 31s the patch passed with JDK v1.7.0_95 +1 unit 7m 18s hadoop-common in the patch passed with JDK v1.8.0_77. +1 unit 1m 58s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_77. +1 unit 7m 39s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 2m 17s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 73m 30s Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797988/MAPREDUCE-6542-v12.patch JIRA Issue MAPREDUCE-6542 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8d8d1d5b1e28 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fdc46bf Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6439/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6439/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          Thanks for the updated patch, zhangyubiao. I see two little things to consider correcting. First:

                    String formattedTime1 = StringUtils.getFormattedTimeWithDiff(fastDateFormat, +start, end);
                    String formattedTime2 = StringUtils.getFormattedTimeWithDiff(fastDateFormat, +start, end);
          

          The unary plus operator is superfluous here. (Is it ever not superfluous?) Since start is a long, the + has no effect.

          Also:

            final private static FastDateFormat fastDateFormat =
                FastDateFormat.getInstance("d-MMM-yyyy HH:mm:ss");
          

          should probably be:

            final private static FastDateFormat FAST_DATE_FORMAT =
                FastDateFormat.getInstance("d-MMM-yyyy HH:mm:ss");
          

          Similar for:

            private final FastDateFormat dateFormat;
          
          Show
          templedf Daniel Templeton added a comment - Thanks for the updated patch, zhangyubiao . I see two little things to consider correcting. First: String formattedTime1 = StringUtils.getFormattedTimeWithDiff(fastDateFormat, +start, end); String formattedTime2 = StringUtils.getFormattedTimeWithDiff(fastDateFormat, +start, end); The unary plus operator is superfluous here. (Is it ever not superfluous?) Since start is a long, the + has no effect. Also: final private static FastDateFormat fastDateFormat = FastDateFormat.getInstance( "d-MMM-yyyy HH:mm:ss" ); should probably be: final private static FastDateFormat FAST_DATE_FORMAT = FastDateFormat.getInstance( "d-MMM-yyyy HH:mm:ss" ); Similar for: private final FastDateFormat dateFormat;
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Daniel Templeton,thanks. it's my mistake. base the v10 that's not the unary plus operator.
          thanks for remind and guide . I will update the patch soon.

          Show
          piaoyu zhang zhangyubiao added a comment - Daniel Templeton ,thanks. it's my mistake. base the v10 that's not the unary plus operator. thanks for remind and guide . I will update the patch soon.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          MAPREDUCE-6542-v13.patch for review

          Show
          piaoyu zhang zhangyubiao added a comment - MAPREDUCE-6542 -v13.patch for review
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 11m 46s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 37s Maven dependency ordering for branch
          +1 mvninstall 6m 8s trunk passed
          +1 compile 6m 8s trunk passed
          +1 checkstyle 1m 21s trunk passed
          +1 mvnsite 1m 17s trunk passed
          +1 mvneclipse 0m 23s trunk passed
          +1 findbugs 2m 2s trunk passed
          +1 javadoc 1m 15s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 0m 58s the patch passed
          +1 compile 6m 4s the patch passed
          +1 javac 6m 4s the patch passed
          +1 checkstyle 1m 19s root: The patch generated 0 new + 122 unchanged - 3 fixed = 122 total (was 125)
          +1 mvnsite 1m 17s the patch passed
          +1 mvneclipse 0m 23s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 16s the patch passed
          +1 javadoc 1m 15s the patch passed
          +1 unit 7m 52s hadoop-common in the patch passed.
          -1 unit 1m 55s hadoop-mapreduce-client-core in the patch failed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          55m 37s



          Reason Tests
          Failed junit tests hadoop.mapreduce.tools.TestCLI



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808886/MAPREDUCE-6542-v13.patch
          JIRA Issue MAPREDUCE-6542
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 78674aa23dba 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 723432b
          Default Java 1.8.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6541/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6541/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6541/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6541/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 11m 46s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 37s Maven dependency ordering for branch +1 mvninstall 6m 8s trunk passed +1 compile 6m 8s trunk passed +1 checkstyle 1m 21s trunk passed +1 mvnsite 1m 17s trunk passed +1 mvneclipse 0m 23s trunk passed +1 findbugs 2m 2s trunk passed +1 javadoc 1m 15s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 58s the patch passed +1 compile 6m 4s the patch passed +1 javac 6m 4s the patch passed +1 checkstyle 1m 19s root: The patch generated 0 new + 122 unchanged - 3 fixed = 122 total (was 125) +1 mvnsite 1m 17s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 16s the patch passed +1 javadoc 1m 15s the patch passed +1 unit 7m 52s hadoop-common in the patch passed. -1 unit 1m 55s hadoop-mapreduce-client-core in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 55m 37s Reason Tests Failed junit tests hadoop.mapreduce.tools.TestCLI Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808886/MAPREDUCE-6542-v13.patch JIRA Issue MAPREDUCE-6542 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 78674aa23dba 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 723432b Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6541/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6541/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6541/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6541/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          Thanks for the updated patch, zhangyubiao! Looks like I wasn't clear in my comment about dateFormat, and I apologize for yet. I meant to consider making it DATE_FORMAT, not fastDateFormat. Looking at it again, I'm OK with either dateFormat or DATE_FORMAT. My issue with fastDateFormat is this line:

              this.fastDateFormat = FastDateFormat.
                  getInstance("d-MMM-yyyy HH:mm:ss", tz);
          

          which would be better formatted as:

              this.fastDateFormat =
                  FastDateFormat.getInstance("d-MMM-yyyy HH:mm:ss", tz);
          

          If you're going to cut a new patch to fix that formatting, it's probably better instead to go back to dateFormat or switch to DATE_FORMAT. Sorry for the confusion.

          Show
          templedf Daniel Templeton added a comment - Thanks for the updated patch, zhangyubiao ! Looks like I wasn't clear in my comment about dateFormat , and I apologize for yet. I meant to consider making it DATE_FORMAT , not fastDateFormat . Looking at it again, I'm OK with either dateFormat or DATE_FORMAT . My issue with fastDateFormat is this line: this .fastDateFormat = FastDateFormat. getInstance( "d-MMM-yyyy HH:mm:ss" , tz); which would be better formatted as: this .fastDateFormat = FastDateFormat.getInstance( "d-MMM-yyyy HH:mm:ss" , tz); If you're going to cut a new patch to fix that formatting, it's probably better instead to go back to dateFormat or switch to DATE_FORMAT . Sorry for the confusion.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 47s Maven dependency ordering for branch
          +1 mvninstall 6m 33s trunk passed
          +1 compile 6m 16s trunk passed
          +1 checkstyle 1m 20s trunk passed
          +1 mvnsite 1m 18s trunk passed
          +1 mvneclipse 0m 24s trunk passed
          +1 findbugs 2m 4s trunk passed
          +1 javadoc 1m 12s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 0m 58s the patch passed
          +1 compile 6m 5s the patch passed
          +1 javac 6m 5s the patch passed
          -1 checkstyle 1m 18s root: The patch generated 1 new + 122 unchanged - 3 fixed = 123 total (was 125)
          +1 mvnsite 1m 17s the patch passed
          +1 mvneclipse 0m 23s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 17s the patch passed
          +1 javadoc 1m 15s the patch passed
          +1 unit 7m 51s hadoop-common in the patch passed.
          +1 unit 1m 56s hadoop-mapreduce-client-core in the patch passed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          44m 43s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809181/MAPREDUCE-6542-v14.patch
          JIRA Issue MAPREDUCE-6542
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d90b02562574 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8ea9bbc
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6545/artifact/patchprocess/diff-checkstyle-root.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6545/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6545/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 47s Maven dependency ordering for branch +1 mvninstall 6m 33s trunk passed +1 compile 6m 16s trunk passed +1 checkstyle 1m 20s trunk passed +1 mvnsite 1m 18s trunk passed +1 mvneclipse 0m 24s trunk passed +1 findbugs 2m 4s trunk passed +1 javadoc 1m 12s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 58s the patch passed +1 compile 6m 5s the patch passed +1 javac 6m 5s the patch passed -1 checkstyle 1m 18s root: The patch generated 1 new + 122 unchanged - 3 fixed = 123 total (was 125) +1 mvnsite 1m 17s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 17s the patch passed +1 javadoc 1m 15s the patch passed +1 unit 7m 51s hadoop-common in the patch passed. +1 unit 1m 56s hadoop-mapreduce-client-core in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 44m 43s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809181/MAPREDUCE-6542-v14.patch JIRA Issue MAPREDUCE-6542 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d90b02562574 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8ea9bbc Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6545/artifact/patchprocess/diff-checkstyle-root.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6545/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6545/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          FAST_DATE_FORMAT is fine. I was also OK with dateFormat or DATE_FORMAT. Either way, LTGM. +1 (again).

          Show
          templedf Daniel Templeton added a comment - FAST_DATE_FORMAT is fine. I was also OK with dateFormat or DATE_FORMAT . Either way, LTGM. +1 (again).
          Hide
          templedf Daniel Templeton added a comment -

          Akira Ajisaka, wanna spread a little review love? zhangyubiao has been trying to get this one in for a looooong time. It started as just a quick fix...

          Show
          templedf Daniel Templeton added a comment - Akira Ajisaka , wanna spread a little review love? zhangyubiao has been trying to get this one in for a looooong time. It started as just a quick fix...
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks zhangyubiao for the long work and thanks Daniel Templeton for the reviews!
          Would you deprecate getFormattedTimeWithDiff(DateFormat, long, long) for developers to avoid using this method? I'm +1 if that is addressed. If we deprecated this, we can remove it in the next minor version (2.8.0 or 2.9.0) because StringUtils is not @Public.

          By the way, I prefer to use Date and Time API (JSR-310), which is newly introduced in JDK8. However, we cannot use this API in branch-2 because branch-2 supports both JDK7 and JDK8

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks zhangyubiao for the long work and thanks Daniel Templeton for the reviews! Would you deprecate getFormattedTimeWithDiff(DateFormat, long, long) for developers to avoid using this method? I'm +1 if that is addressed. If we deprecated this, we can remove it in the next minor version (2.8.0 or 2.9.0) because StringUtils is not @Public . By the way, I prefer to use Date and Time API (JSR-310), which is newly introduced in JDK8. However, we cannot use this API in branch-2 because branch-2 supports both JDK7 and JDK8
          Hide
          ajisakaa Akira Ajisaka added a comment -

          In addition, would you fix the checkstyle warning? dateFormat seems good.

          Show
          ajisakaa Akira Ajisaka added a comment - In addition, would you fix the checkstyle warning? dateFormat seems good.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Thanks Akira Ajisaka. I update the patch

          Show
          piaoyu zhang zhangyubiao added a comment - Thanks Akira Ajisaka . I update the patch
          Hide
          piaoyu zhang zhangyubiao added a comment -

          MAPREDUCE-6542-v15.patch for review

          Show
          piaoyu zhang zhangyubiao added a comment - MAPREDUCE-6542 -v15.patch for review
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 12s Maven dependency ordering for branch
          +1 mvninstall 6m 26s trunk passed
          +1 compile 6m 32s trunk passed
          +1 checkstyle 1m 20s trunk passed
          +1 mvnsite 1m 24s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 2m 10s trunk passed
          +1 javadoc 1m 9s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 2s the patch passed
          +1 compile 6m 32s the patch passed
          +1 javac 6m 32s the patch passed
          +1 checkstyle 1m 22s root: The patch generated 0 new + 122 unchanged - 3 fixed = 122 total (was 125)
          +1 mvnsite 1m 21s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 32s the patch passed
          +1 javadoc 1m 8s the patch passed
          +1 unit 7m 34s hadoop-common in the patch passed.
          +1 unit 1m 58s hadoop-mapreduce-client-core in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          45m 13s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e2f6409
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811061/MAPREDUCE-6542-v15.patch
          JIRA Issue MAPREDUCE-6542
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux bb8be7b3cf5a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2ca7344
          Default Java 1.8.0_91
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6559/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6559/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 12s Maven dependency ordering for branch +1 mvninstall 6m 26s trunk passed +1 compile 6m 32s trunk passed +1 checkstyle 1m 20s trunk passed +1 mvnsite 1m 24s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 2m 10s trunk passed +1 javadoc 1m 9s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 2s the patch passed +1 compile 6m 32s the patch passed +1 javac 6m 32s the patch passed +1 checkstyle 1m 22s root: The patch generated 0 new + 122 unchanged - 3 fixed = 122 total (was 125) +1 mvnsite 1m 21s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 32s the patch passed +1 javadoc 1m 8s the patch passed +1 unit 7m 34s hadoop-common in the patch passed. +1 unit 1m 58s hadoop-mapreduce-client-core in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 45m 13s Subsystem Report/Notes Docker Image:yetus/hadoop:e2f6409 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811061/MAPREDUCE-6542-v15.patch JIRA Issue MAPREDUCE-6542 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bb8be7b3cf5a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2ca7344 Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6559/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6559/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thank you for the update. Would you add

             * @deprecated Use
             * {@link StringUtils#getFormattedTimeWithDiff(FastDateFormat, long, long)} or
             * {@link StringUtils#getFormattedTimeWithDiff(String, long, long)} instead.
          

          to the javadoc of getFormattedTimeWithDiff(DateFormat, long, long)? I'm +1 if that is addressed.

          Show
          ajisakaa Akira Ajisaka added a comment - Thank you for the update. Would you add * @deprecated Use * {@link StringUtils#getFormattedTimeWithDiff(FastDateFormat, long, long)} or * {@link StringUtils#getFormattedTimeWithDiff(String, long, long)} instead. to the javadoc of getFormattedTimeWithDiff(DateFormat, long, long) ? I'm +1 if that is addressed.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Thanks Akira Ajisaka remind. I update the patch. MAPREDUCE-6542-v16.patch for review

          Show
          piaoyu zhang zhangyubiao added a comment - Thanks Akira Ajisaka remind. I update the patch. MAPREDUCE-6542 -v16.patch for review
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 11s Maven dependency ordering for branch
          +1 mvninstall 6m 38s trunk passed
          +1 compile 7m 40s trunk passed
          +1 checkstyle 1m 27s trunk passed
          +1 mvnsite 1m 33s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 2m 28s trunk passed
          +1 javadoc 1m 13s trunk passed
          0 mvndep 0m 12s Maven dependency ordering for patch
          +1 mvninstall 1m 6s the patch passed
          +1 compile 7m 34s the patch passed
          +1 javac 7m 34s the patch passed
          +1 checkstyle 1m 25s root: The patch generated 0 new + 122 unchanged - 3 fixed = 122 total (was 125)
          +1 mvnsite 1m 30s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 44s the patch passed
          +1 javadoc 1m 12s the patch passed
          +1 unit 8m 27s hadoop-common in the patch passed.
          -1 unit 2m 8s hadoop-mapreduce-client-core in the patch failed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          49m 51s



          Reason Tests
          Failed junit tests hadoop.mapreduce.tools.TestCLI



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e2f6409
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811111/MAPREDUCE-6542-v16.patch
          JIRA Issue MAPREDUCE-6542
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux acc5ed018330 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / cc6c265
          Default Java 1.8.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6560/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6560/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6560/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6560/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 6m 38s trunk passed +1 compile 7m 40s trunk passed +1 checkstyle 1m 27s trunk passed +1 mvnsite 1m 33s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 2m 28s trunk passed +1 javadoc 1m 13s trunk passed 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 1m 6s the patch passed +1 compile 7m 34s the patch passed +1 javac 7m 34s the patch passed +1 checkstyle 1m 25s root: The patch generated 0 new + 122 unchanged - 3 fixed = 122 total (was 125) +1 mvnsite 1m 30s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 44s the patch passed +1 javadoc 1m 12s the patch passed +1 unit 8m 27s hadoop-common in the patch passed. -1 unit 2m 8s hadoop-mapreduce-client-core in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 49m 51s Reason Tests Failed junit tests hadoop.mapreduce.tools.TestCLI Subsystem Report/Notes Docker Image:yetus/hadoop:e2f6409 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811111/MAPREDUCE-6542-v16.patch JIRA Issue MAPREDUCE-6542 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux acc5ed018330 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cc6c265 Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6560/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6560/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6560/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6560/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, committing this.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, committing this.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          The patch cannot be applied to branch-2.8. Hi zhangyubiao, would you rebase the patch for branch-2.8?

          Show
          ajisakaa Akira Ajisaka added a comment - The patch cannot be applied to branch-2.8. Hi zhangyubiao , would you rebase the patch for branch-2.8?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk and branch-2.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9975 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9975/)
          MAPREDUCE-6542. HistoryViewer uses SimpleDateFormat, but (aajisaka: rev 51d497fa93d35dec7503eb30b8e3a1e8f2d39b45)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HumanReadableHistoryViewerPrinter.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9975 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9975/ ) MAPREDUCE-6542 . HistoryViewer uses SimpleDateFormat, but (aajisaka: rev 51d497fa93d35dec7503eb30b8e3a1e8f2d39b45) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HumanReadableHistoryViewerPrinter.java
          Hide
          templedf Daniel Templeton added a comment -

          Yay!

          Show
          templedf Daniel Templeton added a comment - Yay!
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Filed MAPREDUCE-6717 for follow-up.

          Show
          ajisakaa Akira Ajisaka added a comment - Filed MAPREDUCE-6717 for follow-up.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Thanks Daniel Templeton and Akira Ajisaka review. Akira Ajisaka Should I summit a patch for rebase branch-2.8?

          Show
          piaoyu zhang zhangyubiao added a comment - Thanks Daniel Templeton and Akira Ajisaka review. Akira Ajisaka Should I summit a patch for rebase branch-2.8?
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Akira Ajisaka,branch-2.8 do not have HumanReadableHistoryViewerPrinter class and use HistoryViewer.
          I update patch for branch-2.8

          Show
          piaoyu zhang zhangyubiao added a comment - Akira Ajisaka ,branch-2.8 do not have HumanReadableHistoryViewerPrinter class and use HistoryViewer. I update patch for branch-2.8
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 22s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 2m 9s Maven dependency ordering for branch
          +1 mvninstall 7m 5s branch-2.8 passed
          +1 compile 6m 25s branch-2.8 passed with JDK v1.8.0_91
          +1 compile 6m 56s branch-2.8 passed with JDK v1.7.0_101
          +1 checkstyle 1m 10s branch-2.8 passed
          +1 mvnsite 1m 29s branch-2.8 passed
          +1 mvneclipse 0m 34s branch-2.8 passed
          +1 findbugs 2m 46s branch-2.8 passed
          +1 javadoc 1m 9s branch-2.8 passed with JDK v1.8.0_91
          +1 javadoc 1m 20s branch-2.8 passed with JDK v1.7.0_101
          0 mvndep 0m 13s Maven dependency ordering for patch
          +1 mvninstall 1m 5s the patch passed
          +1 compile 6m 18s the patch passed with JDK v1.8.0_91
          +1 javac 6m 18s the patch passed
          +1 compile 6m 54s the patch passed with JDK v1.7.0_101
          +1 javac 6m 54s the patch passed
          +1 checkstyle 1m 7s root: The patch generated 0 new + 294 unchanged - 3 fixed = 294 total (was 297)
          +1 mvnsite 1m 30s the patch passed
          +1 mvneclipse 0m 30s the patch passed
          -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 3m 11s the patch passed
          +1 javadoc 1m 6s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 21s the patch passed with JDK v1.7.0_101
          -1 unit 7m 0s hadoop-common in the patch failed with JDK v1.8.0_91.
          +1 unit 1m 49s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_91.
          +1 unit 7m 34s hadoop-common in the patch passed with JDK v1.7.0_101.
          -1 unit 2m 11s hadoop-mapreduce-client-core in the patch failed with JDK v1.7.0_101.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          75m 8s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
          JDK v1.7.0_101 Failed junit tests hadoop.mapreduce.tools.TestCLI



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b35c7cd
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12812177/MAPREDUCE-6542-branch-2.8.patch
          JIRA Issue MAPREDUCE-6542
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 348d4bf56d9f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / 6fefb8f
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6568/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6568/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6568/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_101.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6568/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6568/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6568/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6568/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 2m 9s Maven dependency ordering for branch +1 mvninstall 7m 5s branch-2.8 passed +1 compile 6m 25s branch-2.8 passed with JDK v1.8.0_91 +1 compile 6m 56s branch-2.8 passed with JDK v1.7.0_101 +1 checkstyle 1m 10s branch-2.8 passed +1 mvnsite 1m 29s branch-2.8 passed +1 mvneclipse 0m 34s branch-2.8 passed +1 findbugs 2m 46s branch-2.8 passed +1 javadoc 1m 9s branch-2.8 passed with JDK v1.8.0_91 +1 javadoc 1m 20s branch-2.8 passed with JDK v1.7.0_101 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 1m 5s the patch passed +1 compile 6m 18s the patch passed with JDK v1.8.0_91 +1 javac 6m 18s the patch passed +1 compile 6m 54s the patch passed with JDK v1.7.0_101 +1 javac 6m 54s the patch passed +1 checkstyle 1m 7s root: The patch generated 0 new + 294 unchanged - 3 fixed = 294 total (was 297) +1 mvnsite 1m 30s the patch passed +1 mvneclipse 0m 30s the patch passed -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 3m 11s the patch passed +1 javadoc 1m 6s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 21s the patch passed with JDK v1.7.0_101 -1 unit 7m 0s hadoop-common in the patch failed with JDK v1.8.0_91. +1 unit 1m 49s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_91. +1 unit 7m 34s hadoop-common in the patch passed with JDK v1.7.0_101. -1 unit 2m 11s hadoop-mapreduce-client-core in the patch failed with JDK v1.7.0_101. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 75m 8s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics JDK v1.7.0_101 Failed junit tests hadoop.mapreduce.tools.TestCLI Subsystem Report/Notes Docker Image:yetus/hadoop:b35c7cd JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12812177/MAPREDUCE-6542-branch-2.8.patch JIRA Issue MAPREDUCE-6542 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 348d4bf56d9f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / 6fefb8f Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6568/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6568/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6568/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6568/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6568/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6568/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6568/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thank zhangyubiao for rebasing the patch. Please don't make unnecessary changes in the patch? For example, we don't need to make the following change.

          @@ -133,7 +133,7 @@ public static String format(final String format, final Object... objects) {
              * @return a string representation of the percentage
              */
             public static String formatPercent(double fraction, int decimalPlaces) {
          -    return format("%." + decimalPlaces + "f%%", fraction*100);
          +    return format("%." + decimalPlaces + "f%%", fraction * 100);
             }
          

          In addition, please don't use glob pattern in import statements.

           import java.util.Map;
          +import java.util.concurrent.*;
           import java.util.regex.Pattern;
          
          Show
          ajisakaa Akira Ajisaka added a comment - Thank zhangyubiao for rebasing the patch. Please don't make unnecessary changes in the patch? For example, we don't need to make the following change. @@ -133,7 +133,7 @@ public static String format(final String format, final Object... objects) { * @return a string representation of the percentage */ public static String formatPercent(double fraction, int decimalPlaces) { - return format("%." + decimalPlaces + "f%%", fraction*100); + return format("%." + decimalPlaces + "f%%", fraction * 100); } In addition, please don't use glob pattern in import statements. import java.util.Map; +import java.util.concurrent.*; import java.util.regex.Pattern;
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Thanks Akira AjisakaMAPREDUCE-6542-branch-2.8-v1.patch for review

          Show
          piaoyu zhang zhangyubiao added a comment - Thanks Akira Ajisaka , MAPREDUCE-6542 -branch-2.8-v1.patch for review
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 28s Maven dependency ordering for branch
          +1 mvninstall 6m 30s branch-2.8 passed
          +1 compile 5m 47s branch-2.8 passed with JDK v1.8.0_91
          +1 compile 6m 44s branch-2.8 passed with JDK v1.7.0_101
          +1 checkstyle 1m 7s branch-2.8 passed
          +1 mvnsite 1m 30s branch-2.8 passed
          +1 mvneclipse 0m 31s branch-2.8 passed
          +1 findbugs 2m 39s branch-2.8 passed
          +1 javadoc 1m 5s branch-2.8 passed with JDK v1.8.0_91
          +1 javadoc 1m 20s branch-2.8 passed with JDK v1.7.0_101
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 4s the patch passed
          +1 compile 7m 0s the patch passed with JDK v1.8.0_91
          +1 javac 7m 0s the patch passed
          +1 compile 7m 22s the patch passed with JDK v1.7.0_101
          +1 javac 7m 22s the patch passed
          +1 checkstyle 1m 6s root: The patch generated 0 new + 294 unchanged - 3 fixed = 294 total (was 297)
          +1 mvnsite 1m 30s the patch passed
          +1 mvneclipse 0m 29s the patch passed
          -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 3m 10s the patch passed
          +1 javadoc 1m 8s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 19s the patch passed with JDK v1.7.0_101
          -1 unit 7m 23s hadoop-common in the patch failed with JDK v1.8.0_91.
          +1 unit 1m 49s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_91.
          -1 unit 8m 3s hadoop-common in the patch failed with JDK v1.7.0_101.
          +1 unit 2m 15s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          73m 45s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
          JDK v1.7.0_101 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b35c7cd
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12812709/MAPREDUCE-6542-branch-2.8-v1.patch
          JIRA Issue MAPREDUCE-6542
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b7d8a274001e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / d17265f
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6576/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6576/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6576/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6576/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6576/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6576/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6576/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 28s Maven dependency ordering for branch +1 mvninstall 6m 30s branch-2.8 passed +1 compile 5m 47s branch-2.8 passed with JDK v1.8.0_91 +1 compile 6m 44s branch-2.8 passed with JDK v1.7.0_101 +1 checkstyle 1m 7s branch-2.8 passed +1 mvnsite 1m 30s branch-2.8 passed +1 mvneclipse 0m 31s branch-2.8 passed +1 findbugs 2m 39s branch-2.8 passed +1 javadoc 1m 5s branch-2.8 passed with JDK v1.8.0_91 +1 javadoc 1m 20s branch-2.8 passed with JDK v1.7.0_101 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 4s the patch passed +1 compile 7m 0s the patch passed with JDK v1.8.0_91 +1 javac 7m 0s the patch passed +1 compile 7m 22s the patch passed with JDK v1.7.0_101 +1 javac 7m 22s the patch passed +1 checkstyle 1m 6s root: The patch generated 0 new + 294 unchanged - 3 fixed = 294 total (was 297) +1 mvnsite 1m 30s the patch passed +1 mvneclipse 0m 29s the patch passed -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 3m 10s the patch passed +1 javadoc 1m 8s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 19s the patch passed with JDK v1.7.0_101 -1 unit 7m 23s hadoop-common in the patch failed with JDK v1.8.0_91. +1 unit 1m 49s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_91. -1 unit 8m 3s hadoop-common in the patch failed with JDK v1.7.0_101. +1 unit 2m 15s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 73m 45s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics JDK v1.7.0_101 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:b35c7cd JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12812709/MAPREDUCE-6542-branch-2.8-v1.patch JIRA Issue MAPREDUCE-6542 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b7d8a274001e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / d17265f Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6576/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6576/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6576/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6576/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6576/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6576/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6576/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thank you for updating the patch.

          $ dev-support/bin/smart-apply-patch MAPREDUCE-6542
          $ git diff origin/trunk hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java | cat
          diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java
          index 1f474f8..32c10d0 100644
          --- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java
          +++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java
          @@ -58,7 +58,7 @@
               "\\,A\\\\\\,\\,B\\\\\\\\\\,";
           
             final private static FastDateFormat FAST_DATE_FORMAT =
          -      FastDateFormat.getInstance("d-MMM-yyyy HH:mm:ss");
          +    FastDateFormat.getInstance("d-MMM-yyyy HH:mm:ss");
             
             @Test (timeout = 30000)
             public void testEscapeString() throws Exception {
          @@ -462,11 +462,11 @@ public void run() {
                     final long end = System.currentTimeMillis();
                     final long start = end - 30000;
                     String formattedTime1 = StringUtils.getFormattedTimeWithDiff(
          -              FAST_DATE_FORMAT, start, end);
          +            FAST_DATE_FORMAT, start, end);
                     String formattedTime2 = StringUtils.getFormattedTimeWithDiff(
          -              FAST_DATE_FORMAT, start, end);
          +            FAST_DATE_FORMAT, start, end);
                     assertTrue("Method returned inconsistent results indicative of"
          -              + " a race condition", formattedTime1.equals(formattedTime2));
          +            + " a race condition", formattedTime1.equals(formattedTime2));
           
                   }
                 });
          @@ -476,6 +476,7 @@ public void run() {
               executorService.awaitTermination(50, TimeUnit.SECONDS);
             }
           
          +
             // Benchmark for StringUtils split
             public static void main(String []args) {
               final String TO_SPLIT = "foo,bar,baz,blah,blah";
          

          Would you clean up the diff between branch-2.8 and trunk/branch-2? I want to make the diff as small as possible for easier backport after this issue.

          Show
          ajisakaa Akira Ajisaka added a comment - Thank you for updating the patch. $ dev-support/bin/smart-apply-patch MAPREDUCE-6542 $ git diff origin/trunk hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java | cat diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java index 1f474f8..32c10d0 100644 --- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java +++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java @@ -58,7 +58,7 @@ "\\,A\\\\\\,\\,B\\\\\\\\\\,"; final private static FastDateFormat FAST_DATE_FORMAT = - FastDateFormat.getInstance("d-MMM-yyyy HH:mm:ss"); + FastDateFormat.getInstance("d-MMM-yyyy HH:mm:ss"); @Test (timeout = 30000) public void testEscapeString() throws Exception { @@ -462,11 +462,11 @@ public void run() { final long end = System.currentTimeMillis(); final long start = end - 30000; String formattedTime1 = StringUtils.getFormattedTimeWithDiff( - FAST_DATE_FORMAT, start, end); + FAST_DATE_FORMAT, start, end); String formattedTime2 = StringUtils.getFormattedTimeWithDiff( - FAST_DATE_FORMAT, start, end); + FAST_DATE_FORMAT, start, end); assertTrue("Method returned inconsistent results indicative of" - + " a race condition", formattedTime1.equals(formattedTime2)); + + " a race condition", formattedTime1.equals(formattedTime2)); } }); @@ -476,6 +476,7 @@ public void run() { executorService.awaitTermination(50, TimeUnit.SECONDS); } + // Benchmark for StringUtils split public static void main(String []args) { final String TO_SPLIT = "foo,bar,baz,blah,blah"; Would you clean up the diff between branch-2.8 and trunk/branch-2? I want to make the diff as small as possible for easier backport after this issue.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          MAPREDUCE-6542-branch-2.8-v2.patch for review

          Show
          piaoyu zhang zhangyubiao added a comment - MAPREDUCE-6542 -branch-2.8-v2.patch for review
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 docker 14m 2s Docker failed to build yetus/hadoop:5c07aee.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12812776/MAPREDUCE-6542-branch-2.8-v2.patch
          JIRA Issue MAPREDUCE-6542
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6579/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 14m 2s Docker failed to build yetus/hadoop:5c07aee. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12812776/MAPREDUCE-6542-branch-2.8-v2.patch JIRA Issue MAPREDUCE-6542 Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6579/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          piaoyu zhang zhangyubiao added a comment -

          MAPREDUCE-6542-branch-2.8-v2.patch for review

          Show
          piaoyu zhang zhangyubiao added a comment - MAPREDUCE-6542 -branch-2.8-v2.patch for review
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 docker 0m 3s Docker failed to build yetus/hadoop:5c07aee.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12812987/MAPREDUCE-6542-branch-2.8-v2.patch
          JIRA Issue MAPREDUCE-6542
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6584/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 0m 3s Docker failed to build yetus/hadoop:5c07aee. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12812987/MAPREDUCE-6542-branch-2.8-v2.patch JIRA Issue MAPREDUCE-6542 Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6584/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Sorry the docker build is failing by backporting HADOOP-13245, we need to backport HADOOP-13067 as well to fix the build.

          Show
          ajisakaa Akira Ajisaka added a comment - Sorry the docker build is failing by backporting HADOOP-13245 , we need to backport HADOOP-13067 as well to fix the build.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 12m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 2m 4s Maven dependency ordering for branch
          +1 mvninstall 6m 53s branch-2.8 passed
          +1 compile 5m 50s branch-2.8 passed with JDK v1.8.0_91
          +1 compile 6m 43s branch-2.8 passed with JDK v1.7.0_101
          +1 checkstyle 1m 10s branch-2.8 passed
          +1 mvnsite 1m 31s branch-2.8 passed
          +1 mvneclipse 0m 35s branch-2.8 passed
          +1 findbugs 2m 46s branch-2.8 passed
          +1 javadoc 1m 7s branch-2.8 passed with JDK v1.8.0_91
          +1 javadoc 1m 21s branch-2.8 passed with JDK v1.7.0_101
          0 mvndep 0m 13s Maven dependency ordering for patch
          +1 mvninstall 1m 7s the patch passed
          +1 compile 5m 46s the patch passed with JDK v1.8.0_91
          +1 javac 5m 46s the patch passed
          +1 compile 6m 45s the patch passed with JDK v1.7.0_101
          +1 javac 6m 45s the patch passed
          +1 checkstyle 1m 6s root: The patch generated 0 new + 294 unchanged - 3 fixed = 294 total (was 297)
          +1 mvnsite 1m 29s the patch passed
          +1 mvneclipse 0m 31s the patch passed
          -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 3m 8s the patch passed
          +1 javadoc 1m 5s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 20s the patch passed with JDK v1.7.0_101
          -1 unit 7m 25s hadoop-common in the patch failed with JDK v1.8.0_91.
          +1 unit 1m 52s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_91.
          -1 unit 8m 5s hadoop-common in the patch failed with JDK v1.7.0_101.
          +1 unit 2m 14s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          86m 12s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
          JDK v1.7.0_101 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.ipc.TestRPCWaitForProxy



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12812987/MAPREDUCE-6542-branch-2.8-v2.patch
          JIRA Issue MAPREDUCE-6542
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux bf9877c7b2b7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / ce788c2
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6588/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6588/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6588/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6588/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6588/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6588/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6588/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 12m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 2m 4s Maven dependency ordering for branch +1 mvninstall 6m 53s branch-2.8 passed +1 compile 5m 50s branch-2.8 passed with JDK v1.8.0_91 +1 compile 6m 43s branch-2.8 passed with JDK v1.7.0_101 +1 checkstyle 1m 10s branch-2.8 passed +1 mvnsite 1m 31s branch-2.8 passed +1 mvneclipse 0m 35s branch-2.8 passed +1 findbugs 2m 46s branch-2.8 passed +1 javadoc 1m 7s branch-2.8 passed with JDK v1.8.0_91 +1 javadoc 1m 21s branch-2.8 passed with JDK v1.7.0_101 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 1m 7s the patch passed +1 compile 5m 46s the patch passed with JDK v1.8.0_91 +1 javac 5m 46s the patch passed +1 compile 6m 45s the patch passed with JDK v1.7.0_101 +1 javac 6m 45s the patch passed +1 checkstyle 1m 6s root: The patch generated 0 new + 294 unchanged - 3 fixed = 294 total (was 297) +1 mvnsite 1m 29s the patch passed +1 mvneclipse 0m 31s the patch passed -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 3m 8s the patch passed +1 javadoc 1m 5s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 20s the patch passed with JDK v1.7.0_101 -1 unit 7m 25s hadoop-common in the patch failed with JDK v1.8.0_91. +1 unit 1m 52s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_91. -1 unit 8m 5s hadoop-common in the patch failed with JDK v1.7.0_101. +1 unit 2m 14s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 86m 12s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics JDK v1.7.0_101 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.ipc.TestRPCWaitForProxy Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12812987/MAPREDUCE-6542-branch-2.8-v2.patch JIRA Issue MAPREDUCE-6542 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bf9877c7b2b7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / ce788c2 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6588/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6588/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6588/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6588/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6588/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6588/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6588/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, the test failures seem to be unrelated to the patch. Committing this.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, the test failures seem to be unrelated to the patch. Committing this.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to branch-2.8. Thanks zhangyubiao for the contribution!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to branch-2.8. Thanks zhangyubiao for the contribution!
          Hide
          piaoyu zhang zhangyubiao added a comment -

          Thanks Akira Ajisaka.

          Show
          piaoyu zhang zhangyubiao added a comment - Thanks Akira Ajisaka .

            People

            • Assignee:
              piaoyu zhang zhangyubiao
              Reporter:
              piaoyu zhang zhangyubiao
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development