Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6503

archive-logs tool should use HADOOP_PREFIX instead of HADOOP_HOME

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The archive-logs tool currently uses HADOOP_HOME in the distributed shell job. It should instead use HADOOP_PREFIX due to HADOOP-12451/HADOOP-12456.

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2402 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2402/)
          MAPREDUCE-6503. archive-logs tool should use HADOOP_PREFIX instead of (rkanter: rev 1bca1bb5175b5976a5a0e45b6e1c4486bdf87a0e)

          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2402 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2402/ ) MAPREDUCE-6503 . archive-logs tool should use HADOOP_PREFIX instead of (rkanter: rev 1bca1bb5175b5976a5a0e45b6e1c4486bdf87a0e) hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2433 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2433/)
          MAPREDUCE-6503. archive-logs tool should use HADOOP_PREFIX instead of (rkanter: rev 1bca1bb5175b5976a5a0e45b6e1c4486bdf87a0e)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2433 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2433/ ) MAPREDUCE-6503 . archive-logs tool should use HADOOP_PREFIX instead of (rkanter: rev 1bca1bb5175b5976a5a0e45b6e1c4486bdf87a0e) hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #489 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/489/)
          MAPREDUCE-6503. archive-logs tool should use HADOOP_PREFIX instead of (rkanter: rev 1bca1bb5175b5976a5a0e45b6e1c4486bdf87a0e)

          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #489 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/489/ ) MAPREDUCE-6503 . archive-logs tool should use HADOOP_PREFIX instead of (rkanter: rev 1bca1bb5175b5976a5a0e45b6e1c4486bdf87a0e) hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #463 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/463/)
          MAPREDUCE-6503. archive-logs tool should use HADOOP_PREFIX instead of (rkanter: rev 1bca1bb5175b5976a5a0e45b6e1c4486bdf87a0e)

          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #463 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/463/ ) MAPREDUCE-6503 . archive-logs tool should use HADOOP_PREFIX instead of (rkanter: rev 1bca1bb5175b5976a5a0e45b6e1c4486bdf87a0e) hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #497 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/497/)
          MAPREDUCE-6503. archive-logs tool should use HADOOP_PREFIX instead of (rkanter: rev 1bca1bb5175b5976a5a0e45b6e1c4486bdf87a0e)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #497 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/497/ ) MAPREDUCE-6503 . archive-logs tool should use HADOOP_PREFIX instead of (rkanter: rev 1bca1bb5175b5976a5a0e45b6e1c4486bdf87a0e) hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1227 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1227/)
          MAPREDUCE-6503. archive-logs tool should use HADOOP_PREFIX instead of (rkanter: rev 1bca1bb5175b5976a5a0e45b6e1c4486bdf87a0e)

          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1227 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1227/ ) MAPREDUCE-6503 . archive-logs tool should use HADOOP_PREFIX instead of (rkanter: rev 1bca1bb5175b5976a5a0e45b6e1c4486bdf87a0e) hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #8580 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8580/)
          MAPREDUCE-6503. archive-logs tool should use HADOOP_PREFIX instead of (rkanter: rev 1bca1bb5175b5976a5a0e45b6e1c4486bdf87a0e)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #8580 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8580/ ) MAPREDUCE-6503 . archive-logs tool should use HADOOP_PREFIX instead of (rkanter: rev 1bca1bb5175b5976a5a0e45b6e1c4486bdf87a0e) hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
          Hide
          rkanter Robert Kanter added a comment -

          Thanks for the review Karthik. Committed to trunk and branch-2!

          Show
          rkanter Robert Kanter added a comment - Thanks for the review Karthik. Committed to trunk and branch-2!
          Hide
          kasha Karthik Kambatla added a comment -

          Yep, I have seen the release audit warning on other JIRAs as well.

          +1

          Show
          kasha Karthik Kambatla added a comment - Yep, I have seen the release audit warning on other JIRAs as well. +1
          Hide
          rkanter Robert Kanter added a comment -

          checkstyle warning is a line that's too long. It's the comment of the example of the script, so that's fine. The release audit warning is a missing Apache header in an unrelated file.

          Show
          rkanter Robert Kanter added a comment - checkstyle warning is a line that's too long. It's the comment of the example of the script, so that's fine. The release audit warning is a missing Apache header in an unrelated file.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 3s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 2s There were no new javac warning messages.
          +1 javadoc 10m 30s There were no new javadoc warning messages.
          -1 release audit 0m 16s The applied patch generated 1 release audit warnings.
          -1 checkstyle 0m 21s The applied patch generated 1 new checkstyle issues (total was 5, now 5).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 0m 41s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 tools/hadoop tests 0m 34s Tests passed in hadoop-archive-logs.
              39m 36s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12765245/MAPREDUCE-6503.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 6d5713a
          Release Audit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6058/artifact/patchprocess/patchReleaseAuditProblems.txt
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6058/artifact/patchprocess/diffcheckstylehadoop-archive-logs.txt
          hadoop-archive-logs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6058/artifact/patchprocess/testrun_hadoop-archive-logs.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6058/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6058/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 3s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 2s There were no new javac warning messages. +1 javadoc 10m 30s There were no new javadoc warning messages. -1 release audit 0m 16s The applied patch generated 1 release audit warnings. -1 checkstyle 0m 21s The applied patch generated 1 new checkstyle issues (total was 5, now 5). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 41s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 tools/hadoop tests 0m 34s Tests passed in hadoop-archive-logs.     39m 36s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12765245/MAPREDUCE-6503.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6d5713a Release Audit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6058/artifact/patchprocess/patchReleaseAuditProblems.txt checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6058/artifact/patchprocess/diffcheckstylehadoop-archive-logs.txt hadoop-archive-logs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6058/artifact/patchprocess/testrun_hadoop-archive-logs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6058/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6058/console This message was automatically generated.
          Hide
          rkanter Robert Kanter added a comment -

          Sorry; I forgot to mention that. I verified that $HADOOP_PREFIX is in the distributed shell's shell and also ran the archive-logs command against some logs.

          Show
          rkanter Robert Kanter added a comment - Sorry; I forgot to mention that. I verified that $HADOOP_PREFIX is in the distributed shell's shell and also ran the archive-logs command against some logs.
          Hide
          kasha Karthik Kambatla added a comment -

          Robert Kanter - thanks for filing and working on this.

          Any comments on the testing done? May be, combine logs?

          Show
          kasha Karthik Kambatla added a comment - Robert Kanter - thanks for filing and working on this. Any comments on the testing done? May be, combine logs?

            People

            • Assignee:
              rkanter Robert Kanter
              Reporter:
              rkanter Robert Kanter
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development