Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6499

Add elapsed time for retired job in JobHistoryServer WebUI

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: webapps
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Now in JobHistory Main Page show too little information about finished jobs,even don't have the job's running total time,only startTime,finishedTime.So,in jobHistory main page,we can add more informations about jobs, that we can better analyze jobs.

      1. HADOOP-MAPREDUCE-6499.2.patch
        9 kB
        Yiqun Lin
      2. HADOOP-MAPREDUCE-6499.3.patch
        9 kB
        Yiqun Lin
      3. HADOOP-MAPREDUCE-6499.4.patch
        10 kB
        Yiqun Lin
      4. HADOOP-MAPREDUCE-6499.5.patch
        10 kB
        Yiqun Lin
      5. HADOOP-MAPREDUCE-6499.6.patch
        5 kB
        Yiqun Lin
      6. HADOOP-MAPREDUCE-6499.7.patch
        5 kB
        Yiqun Lin
      7. HADOOP-MAPREDUCE-6499.8.patch
        7 kB
        Yiqun Lin
      8. HADOOP-MAPREDUCE-6499.9.patch
        7 kB
        Yiqun Lin
      9. HADOOP-MAPREDUCE-6499.patch
        8 kB
        Yiqun Lin
      10. Screen Shot 2015-11-13 at 23.47.10.png
        141 kB
        Akira Ajisaka

        Activity

        Hide
        linyiqun Yiqun Lin added a comment -

        Totally add the follow informations:
        1.UberTask-where the job is uberTask type.
        2.Avg MapTime
        3.Avg MergeTime
        4.Avg ShuffleTime
        5.Avg ReduceTime
        6.Failed MapAttempts
        7.Failed ReduceAttempts
        8.Successed MapAttempts
        9.Successed ReduceAttempts
        and then change the jobPage showing's code.And we can sort Jobs in page with more different conditions.

        Show
        linyiqun Yiqun Lin added a comment - Totally add the follow informations: 1.UberTask-where the job is uberTask type. 2.Avg MapTime 3.Avg MergeTime 4.Avg ShuffleTime 5.Avg ReduceTime 6.Failed MapAttempts 7.Failed ReduceAttempts 8.Successed MapAttempts 9.Successed ReduceAttempts and then change the jobPage showing's code.And we can sort Jobs in page with more different conditions.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        things are only tagged as "fixed" when checked in; fix version = version of hadoop with patch in.

        Instead, hit 'submit patch' and specify the hadoop version you are targeting (which must be unreleased) in the "target version" field.

        Show
        stevel@apache.org Steve Loughran added a comment - things are only tagged as "fixed" when checked in; fix version = version of hadoop with patch in. Instead, hit 'submit patch' and specify the hadoop version you are targeting (which must be unreleased) in the "target version" field.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 42s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 9m 1s There were no new javac warning messages.
        +1 javadoc 11m 19s There were no new javadoc warning messages.
        -1 release audit 0m 15s The applied patch generated 1 release audit warnings.
        -1 checkstyle 0m 31s The applied patch generated 56 new checkstyle issues (total was 19, now 68).
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 43s mvn install still works.
        +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse.
        +1 findbugs 0m 58s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 mapreduce tests 6m 10s Tests failed in hadoop-mapreduce-client-hs.
            49m 20s  



        Reason Tests
        Failed unit tests hadoop.mapreduce.v2.hs.webapp.TestBlocks



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12764404/HADOOP-MAPREDUCE-6499.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 5db371f
        Release Audit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6046/artifact/patchprocess/patchReleaseAuditProblems.txt
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6046/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-hs.txt
        whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6046/artifact/patchprocess/whitespace.txt
        hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6046/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6046/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6046/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 42s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 9m 1s There were no new javac warning messages. +1 javadoc 11m 19s There were no new javadoc warning messages. -1 release audit 0m 15s The applied patch generated 1 release audit warnings. -1 checkstyle 0m 31s The applied patch generated 56 new checkstyle issues (total was 19, now 68). -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 43s mvn install still works. +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse. +1 findbugs 0m 58s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 mapreduce tests 6m 10s Tests failed in hadoop-mapreduce-client-hs.     49m 20s   Reason Tests Failed unit tests hadoop.mapreduce.v2.hs.webapp.TestBlocks Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764404/HADOOP-MAPREDUCE-6499.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 5db371f Release Audit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6046/artifact/patchprocess/patchReleaseAuditProblems.txt checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6046/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-hs.txt whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6046/artifact/patchprocess/whitespace.txt hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6046/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6046/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6046/console This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        modify TestHsJobsBlock testcase and modify wrong name hint in search input on bottom of jobHistory app page table.

        Show
        linyiqun Yiqun Lin added a comment - modify TestHsJobsBlock testcase and modify wrong name hint in search input on bottom of jobHistory app page table.
        Hide
        linyiqun Yiqun Lin added a comment -

        add the latest new patch.

        Show
        linyiqun Yiqun Lin added a comment - add the latest new patch.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 43s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 8m 0s There were no new javac warning messages.
        +1 javadoc 10m 34s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 29s The applied patch generated 56 new checkstyle issues (total was 19, now 68).
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
        +1 findbugs 0m 53s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 mapreduce tests 5m 58s Tests failed in hadoop-mapreduce-client-hs.
            45m 18s  



        Reason Tests
        Failed unit tests hadoop.mapreduce.v2.hs.webapp.TestBlocks



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12764404/HADOOP-MAPREDUCE-6499.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 9cb5d35
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6071/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-hs.txt
        whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6071/artifact/patchprocess/whitespace.txt
        hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6071/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6071/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6071/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 43s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 0s There were no new javac warning messages. +1 javadoc 10m 34s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 29s The applied patch generated 56 new checkstyle issues (total was 19, now 68). -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 0m 53s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 mapreduce tests 5m 58s Tests failed in hadoop-mapreduce-client-hs.     45m 18s   Reason Tests Failed unit tests hadoop.mapreduce.v2.hs.webapp.TestBlocks Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764404/HADOOP-MAPREDUCE-6499.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 9cb5d35 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6071/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-hs.txt whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6071/artifact/patchprocess/whitespace.txt hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6071/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6071/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6071/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 37s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 58s There were no new javac warning messages.
        +1 javadoc 10m 20s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 28s The applied patch generated 26 new checkstyle issues (total was 19, now 38).
        -1 whitespace 0m 1s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 30s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 0m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 mapreduce tests 5m 52s Tests failed in hadoop-mapreduce-client-hs.
            44m 43s  



        Reason Tests
        Failed unit tests hadoop.mapreduce.v2.hs.TestJobHistoryEntities
          hadoop.mapreduce.v2.hs.TestJobHistoryParsing
          hadoop.mapreduce.v2.hs.webapp.dao.TestJobInfo



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12767602/HADOOP-MAPREDUCE-6499.2.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 9cb5d35
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6072/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-hs.txt
        whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6072/artifact/patchprocess/whitespace.txt
        hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6072/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6072/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6072/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 37s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 58s There were no new javac warning messages. +1 javadoc 10m 20s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 28s The applied patch generated 26 new checkstyle issues (total was 19, now 38). -1 whitespace 0m 1s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 0m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 mapreduce tests 5m 52s Tests failed in hadoop-mapreduce-client-hs.     44m 43s   Reason Tests Failed unit tests hadoop.mapreduce.v2.hs.TestJobHistoryEntities   hadoop.mapreduce.v2.hs.TestJobHistoryParsing   hadoop.mapreduce.v2.hs.webapp.dao.TestJobInfo Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767602/HADOOP-MAPREDUCE-6499.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 9cb5d35 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6072/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-hs.txt whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6072/artifact/patchprocess/whitespace.txt hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6072/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6072/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6072/console This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        modify some whitespace error other some warn.

        Show
        linyiqun Yiqun Lin added a comment - modify some whitespace error other some warn.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 20s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 51s There were no new javac warning messages.
        +1 javadoc 10m 56s There were no new javadoc warning messages.
        +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 28s The applied patch generated 15 new checkstyle issues (total was 19, now 25).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 39s mvn install still works.
        +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse.
        +1 findbugs 0m 56s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 mapreduce tests 6m 14s Tests passed in hadoop-mapreduce-client-hs.
            45m 31s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12767736/HADOOP-MAPREDUCE-6499.3.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 0c4af0f
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6075/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-hs.txt
        hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6075/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6075/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6075/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 20s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 51s There were no new javac warning messages. +1 javadoc 10m 56s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 28s The applied patch generated 15 new checkstyle issues (total was 19, now 25). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 39s mvn install still works. +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse. +1 findbugs 0m 56s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 6m 14s Tests passed in hadoop-mapreduce-client-hs.     45m 31s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767736/HADOOP-MAPREDUCE-6499.3.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0c4af0f checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6075/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-hs.txt hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6075/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6075/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6075/console This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        modify some checkstyle issues.

        Show
        linyiqun Yiqun Lin added a comment - modify some checkstyle issues.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 44s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 34s There were no new javac warning messages.
        +1 javadoc 11m 2s There were no new javadoc warning messages.
        +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 30s There were no new checkstyle issues.
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse.
        +1 findbugs 0m 58s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 mapreduce tests 6m 8s Tests passed in hadoop-mapreduce-client-hs.
            47m 38s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12767764/HADOOP-MAPREDUCE-6499.4.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 0c4af0f
        whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6076/artifact/patchprocess/whitespace.txt
        hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6076/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6076/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6076/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 44s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 34s There were no new javac warning messages. +1 javadoc 11m 2s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 30s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse. +1 findbugs 0m 58s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 6m 8s Tests passed in hadoop-mapreduce-client-hs.     47m 38s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767764/HADOOP-MAPREDUCE-6499.4.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0c4af0f whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6076/artifact/patchprocess/whitespace.txt hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6076/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6076/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6076/console This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        modify remain checkstyle issues.

        Show
        linyiqun Yiqun Lin added a comment - modify remain checkstyle issues.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 52s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 17s There were no new javac warning messages.
        +1 javadoc 10m 23s There were no new javadoc warning messages.
        +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 27s There were no new checkstyle issues.
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 28s mvn install still works.
        +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
        +1 findbugs 0m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 mapreduce tests 5m 58s Tests passed in hadoop-mapreduce-client-hs.
            46m 21s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12767768/HADOOP-MAPREDUCE-6499.4.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 0c4af0f
        hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6077/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6077/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6077/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 52s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 17s There were no new javac warning messages. +1 javadoc 10m 23s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 27s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 0m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 5m 58s Tests passed in hadoop-mapreduce-client-hs.     46m 21s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767768/HADOOP-MAPREDUCE-6499.4.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0c4af0f hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6077/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6077/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6077/console This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        please review my patch, thank you.

        Show
        linyiqun Yiqun Lin added a comment - please review my patch, thank you.
        Hide
        linyiqun Yiqun Lin added a comment -

        Steve Loughran,can you have time review my patch, test is all passed,thanks

        Show
        linyiqun Yiqun Lin added a comment - Steve Loughran,can you have time review my patch, test is all passed,thanks
        Hide
        linyiqun Yiqun Lin added a comment -
        Show
        linyiqun Yiqun Lin added a comment - Steve Loughran
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Yiqun Lin for creating the patch. Tried your patch and got the following error:

        DataTables warning (table id = 'jobs'): Requested unknown parameter '21' from the data source for row 0
        

        Probably this is because elapsed time is missing between reduces completed and uber job. Would you fix it?

        HsJobsBlock.java
        +      .append(String.valueOf(job.getReducesCompleted())).append("\",\"")
        +      .append(job.isUber()).append("\",\"")
        
        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Yiqun Lin for creating the patch. Tried your patch and got the following error: DataTables warning (table id = 'jobs'): Requested unknown parameter '21' from the data source for row 0 Probably this is because elapsed time is missing between reduces completed and uber job. Would you fix it? HsJobsBlock.java + .append( String .valueOf(job.getReducesCompleted())).append( "\" ,\"") + .append(job.isUber()).append( "\" ,\"")
        Hide
        linyiqun Yiqun Lin added a comment -

        add missed the elapsed time value.

        Show
        linyiqun Yiqun Lin added a comment - add missed the elapsed time value.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 8s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 6s There were no new javac warning messages.
        +1 javadoc 10m 38s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 28s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 43s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 0m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 mapreduce tests 5m 59s Tests passed in hadoop-mapreduce-client-hs.
            45m 55s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12769012/HADOOP-MAPREDUCE-6499.5.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / aa09880
        hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6091/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6091/testReport/
        Java 1.7.0_55
        uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6091/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 8s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 6s There were no new javac warning messages. +1 javadoc 10m 38s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 28s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 43s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 0m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 5m 59s Tests passed in hadoop-mapreduce-client-hs.     45m 55s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12769012/HADOOP-MAPREDUCE-6499.5.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / aa09880 hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6091/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6091/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6091/console This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Akira Ajisaka review. I update the patch.But there is a problem when the history job is larger enough, it will be load much more job infos and so slowly to open jobhistory pages.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka review. I update the patch.But there is a problem when the history job is larger enough, it will be load much more job infos and so slowly to open jobhistory pages.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thank you for updating the patch, Yiqun Lin.

        But there is a problem when the history job is larger enough, it will be load much more job infos and so slowly to open jobhistory pages.

        Good point. If you really need to sort by average map time and other information, we need to add them into index not to load full job information (See JobIndexInfo.java). In addition, we need to choose what information to add very carefully considering performance.
        IMO, adding elapsed time to the main page is a good idea because

        • Elapsed time can be calculated without loading full job info or editing index file.
        • Users can easily detect long-running-jobs by sorting by elapsed time
        -        th().input("search_init").$type(InputType.text).$name("start_time").$value("Job ID")._()._().
        -        th().input("search_init").$type(InputType.text).$name("start_time").$value("Name")._()._().
        -        th().input("search_init").$type(InputType.text).$name("start_time").$value("User")._()._().
        -        th().input("search_init").$type(InputType.text).$name("start_time").$value("Queue")._()._().
        -        th().input("search_init").$type(InputType.text).$name("start_time").$value("State")._()._().
        -        th().input("search_init").$type(InputType.text).$name("start_time").$value("Maps Total")._()._().
        -        th().input("search_init").$type(InputType.text).$name("start_time").$value("Maps Completed")._()._().
        -        th().input("search_init").$type(InputType.text).$name("start_time").$value("Reduces Total")._()._().
        -        th().input("search_init").$type(InputType.text).$name("start_time").$value("Reduces Completed")._()._()
        (snip)
        +        th().input("search_init").$type(InputType.text)
        +          .$name("job_id").$value("Job ID")._()._().
        +        th().input("search_init").$type(InputType.text)
        +          .$name("name").$value("Name")._()._().
        +        th().input("search_init").$type(InputType.text)
        +          .$name("user").$value("User")._()._().
        +        th().input("search_init").$type(InputType.text)
        +          .$name("queue").$value("Queue")._()._().
        +        th().input("search_init").$type(InputType.text)
        +          .$name("state").$value("State")._()._().
        +        th().input("search_init").$type(InputType.text)
        +          .$name("maps_total").$value("Maps Total")._()._().
        +        th().input("search_init").$type(InputType.text).
        +          $name("maps_completed").$value("Maps Completed")._()._().
        +        th().input("search_init").$type(InputType.text).
        +          $name("reduces_total").$value("Reduces Total")._()._().
        +        th().input("search_init").$type(InputType.text).
        +          $name("reduces_completed").$value("Reduces Completed")._()._().
        

        Good catch. We need to fix it.

        Show
        ajisakaa Akira Ajisaka added a comment - Thank you for updating the patch, Yiqun Lin . But there is a problem when the history job is larger enough, it will be load much more job infos and so slowly to open jobhistory pages. Good point. If you really need to sort by average map time and other information, we need to add them into index not to load full job information (See JobIndexInfo.java). In addition, we need to choose what information to add very carefully considering performance. IMO, adding elapsed time to the main page is a good idea because Elapsed time can be calculated without loading full job info or editing index file. Users can easily detect long-running-jobs by sorting by elapsed time - th().input( "search_init" ).$type(InputType.text).$name( "start_time" ).$value( "Job ID" )._()._(). - th().input( "search_init" ).$type(InputType.text).$name( "start_time" ).$value( "Name" )._()._(). - th().input( "search_init" ).$type(InputType.text).$name( "start_time" ).$value( "User" )._()._(). - th().input( "search_init" ).$type(InputType.text).$name( "start_time" ).$value( "Queue" )._()._(). - th().input( "search_init" ).$type(InputType.text).$name( "start_time" ).$value( "State" )._()._(). - th().input( "search_init" ).$type(InputType.text).$name( "start_time" ).$value( "Maps Total" )._()._(). - th().input( "search_init" ).$type(InputType.text).$name( "start_time" ).$value( "Maps Completed" )._()._(). - th().input( "search_init" ).$type(InputType.text).$name( "start_time" ).$value( "Reduces Total" )._()._(). - th().input( "search_init" ).$type(InputType.text).$name( "start_time" ).$value( "Reduces Completed" )._()._() (snip) + th().input( "search_init" ).$type(InputType.text) + .$name( "job_id" ).$value( "Job ID" )._()._(). + th().input( "search_init" ).$type(InputType.text) + .$name( "name" ).$value( "Name" )._()._(). + th().input( "search_init" ).$type(InputType.text) + .$name( "user" ).$value( "User" )._()._(). + th().input( "search_init" ).$type(InputType.text) + .$name( "queue" ).$value( "Queue" )._()._(). + th().input( "search_init" ).$type(InputType.text) + .$name( "state" ).$value( "State" )._()._(). + th().input( "search_init" ).$type(InputType.text) + .$name( "maps_total" ).$value( "Maps Total" )._()._(). + th().input( "search_init" ).$type(InputType.text). + $name( "maps_completed" ).$value( "Maps Completed" )._()._(). + th().input( "search_init" ).$type(InputType.text). + $name( "reduces_total" ).$value( "Reduces Total" )._()._(). + th().input( "search_init" ).$type(InputType.text). + $name( "reduces_completed" ).$value( "Reduces Completed" )._()._(). Good catch. We need to fix it.
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Akira Ajisaka advices. So should I update my patch and only leave the things as you said ?

        Show
        linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka advices. So should I update my patch and only leave the things as you said ?
        Hide
        linyiqun Yiqun Lin added a comment -

        Simplified the patch, only leave the elapsed time and modfiy some wrong hint text in search input.

        Show
        linyiqun Yiqun Lin added a comment - Simplified the patch, only leave the elapsed time and modfiy some wrong hint text in search input.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Mostly looks good to me. Two comments.

                      String.valueOf(secToTime((job.getFinishTime() - job
                          .getStartTime()) / 1000))).append("\"],\n");
        

        1. Can we reuse the implementation of StringUtils.formatTime? The implementation is simpler.

          private String unitFormat(long i)
        

        2. The method can be replaced by String.format("%02d", i).

        Now I'm +1 for "hh:mm:ss" format for elapsed time because it's sortable by datatable.js and the time unit is clear.

        Show
        ajisakaa Akira Ajisaka added a comment - Mostly looks good to me. Two comments. String .valueOf(secToTime((job.getFinishTime() - job .getStartTime()) / 1000))).append( "\" ],\n"); 1. Can we reuse the implementation of StringUtils.formatTime ? The implementation is simpler. private String unitFormat( long i) 2. The method can be replaced by String.format("%02d", i) . Now I'm +1 for "hh:mm:ss" format for elapsed time because it's sortable by datatable.js and the time unit is clear.
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Akira Ajisaka advices.I accept your first comment.It's simple to use StringUtils.formatTime method to show times, and can be consistent with other pages that also has show elapsed time.The hh:mm:ss is also good format ,but when the elapsed time is more than 99:99:99, maybe it can'be show the real value,and still be 99:99:99.And finally I update the patch.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka advices.I accept your first comment.It's simple to use StringUtils.formatTime method to show times, and can be consistent with other pages that also has show elapsed time.The hh:mm:ss is also good format ,but when the elapsed time is more than 99:99:99, maybe it can'be show the real value,and still be 99:99:99.And finally I update the patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 3m 2s trunk passed
        +1 compile 0m 14s trunk passed with JDK v1.8.0_60
        +1 compile 0m 14s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 8s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 36s trunk passed
        +1 javadoc 0m 13s trunk passed with JDK v1.8.0_60
        +1 javadoc 0m 15s trunk passed with JDK v1.7.0_79
        +1 mvninstall 0m 19s the patch passed
        +1 compile 0m 13s the patch passed with JDK v1.8.0_60
        +1 javac 0m 13s the patch passed
        +1 compile 0m 14s the patch passed with JDK v1.7.0_79
        +1 javac 0m 14s the patch passed
        +1 checkstyle 0m 9s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 45s the patch passed
        +1 javadoc 0m 13s the patch passed with JDK v1.8.0_60
        +1 javadoc 0m 16s the patch passed with JDK v1.7.0_79
        +1 unit 5m 33s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_60.
        +1 unit 6m 1s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_79.
        -1 asflicense 0m 21s Patch generated 14 ASF License warnings.
        20m 24s



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-03
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12770213/HADOOP-MAPREDUCE-6499.7.patch
        JIRA Issue MAPREDUCE-6499
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux 5f698a2bf651 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-1a9afee/precommit/personality/hadoop.sh
        git revision trunk / 5ba2b98
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6112/testReport/
        asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6112/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs
        Max memory used 226MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6112/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 2s trunk passed +1 compile 0m 14s trunk passed with JDK v1.8.0_60 +1 compile 0m 14s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 8s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 36s trunk passed +1 javadoc 0m 13s trunk passed with JDK v1.8.0_60 +1 javadoc 0m 15s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 19s the patch passed +1 compile 0m 13s the patch passed with JDK v1.8.0_60 +1 javac 0m 13s the patch passed +1 compile 0m 14s the patch passed with JDK v1.7.0_79 +1 javac 0m 14s the patch passed +1 checkstyle 0m 9s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 45s the patch passed +1 javadoc 0m 13s the patch passed with JDK v1.8.0_60 +1 javadoc 0m 16s the patch passed with JDK v1.7.0_79 +1 unit 5m 33s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_60. +1 unit 6m 1s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_79. -1 asflicense 0m 21s Patch generated 14 ASF License warnings. 20m 24s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-03 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12770213/HADOOP-MAPREDUCE-6499.7.patch JIRA Issue MAPREDUCE-6499 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 5f698a2bf651 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-1a9afee/precommit/personality/hadoop.sh git revision trunk / 5ba2b98 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6112/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6112/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs Max memory used 226MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6112/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Yiqun Lin for updating the patch. Now elapsed time is not sorted correctly. (ex. "44sec" is larger than "1mins, 10sec") Would you fix it?

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Yiqun Lin for updating the patch. Now elapsed time is not sorted correctly. (ex. "44sec" is larger than "1mins, 10sec") Would you fix it?
        Hide
        ajisakaa Akira Ajisaka added a comment -

        I'm thinking sortability is more important than consistency because

        • "44sec is larger than 1mins, 10sec" is a bug.
        • Finding long-running jobs is difficult if sorting is broken.
        Show
        ajisakaa Akira Ajisaka added a comment - I'm thinking sortability is more important than consistency because "44sec is larger than 1mins, 10sec" is a bug. Finding long-running jobs is difficult if sorting is broken.
        Hide
        linyiqun Yiqun Lin added a comment -

        That's a good point.Thanks Akira Ajisaka.I update with a sortable time format.It's similar to hrs,mins,seconds.The methond StringUtils.formatTime will be sorted not correctlly because some the format has not a complete same format,and the elapsed time is a string comparation,it will compare from left to right.So it will appear "44sec is larger than 1mins",I update a new format method StringUtils.formatTimeSortable,The format is like "00hrs,00mins,00sec", but this format will not satisfied with all times.When the hours is more than 99hours,it will be show a max value "99hrs,59mins,59sec".But I think this is enough for we to find the long-time-running jobs.And this methods can be reuse in other cases When I define it in hadoop-common-project.I attch the updated patch.

        Show
        linyiqun Yiqun Lin added a comment - That's a good point.Thanks Akira Ajisaka .I update with a sortable time format.It's similar to hrs,mins,seconds.The methond StringUtils.formatTime will be sorted not correctlly because some the format has not a complete same format,and the elapsed time is a string comparation,it will compare from left to right.So it will appear "44sec is larger than 1mins",I update a new format method StringUtils.formatTimeSortable ,The format is like "00hrs,00mins,00sec", but this format will not satisfied with all times.When the hours is more than 99hours,it will be show a max value "99hrs,59mins,59sec".But I think this is enough for we to find the long-time-running jobs.And this methods can be reuse in other cases When I define it in hadoop-common-project.I attch the updated patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 6s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 3m 5s trunk passed
        +1 compile 4m 24s trunk passed with JDK v1.8.0_60
        +1 compile 4m 12s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 56s trunk passed
        +1 mvneclipse 0m 27s trunk passed
        +1 findbugs 2m 13s trunk passed
        +1 javadoc 1m 4s trunk passed with JDK v1.8.0_60
        +1 javadoc 1m 19s trunk passed with JDK v1.7.0_79
        +1 mvninstall 1m 57s the patch passed
        +1 compile 4m 13s the patch passed with JDK v1.8.0_60
        +1 javac 4m 13s the patch passed
        +1 compile 4m 4s the patch passed with JDK v1.7.0_79
        +1 javac 4m 4s the patch passed
        +1 checkstyle 0m 54s the patch passed
        +1 mvneclipse 0m 27s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 27s the patch passed
        +1 javadoc 1m 3s the patch passed with JDK v1.8.0_60
        +1 javadoc 1m 18s the patch passed with JDK v1.7.0_79
        -1 unit 6m 50s hadoop-common in the patch failed with JDK v1.8.0_60.
        +1 unit 5m 25s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_60.
        -1 unit 7m 28s hadoop-common in the patch failed with JDK v1.7.0_79.
        +1 unit 5m 49s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_79.
        -1 asflicense 0m 22s Patch generated 14 ASF License warnings.
        61m 19s



        Reason Tests
        JDK v1.8.0_60 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
        JDK v1.7.0_79 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-09
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771337/HADOOP-MAPREDUCE-6499.8.patch
        JIRA Issue MAPREDUCE-6499
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux 6122cbf5d511 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh
        git revision trunk / 668e897
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6131/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6131/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
        unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6131/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6131/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6131/testReport/
        asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6131/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
        Max memory used 228MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6131/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 6s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 5s trunk passed +1 compile 4m 24s trunk passed with JDK v1.8.0_60 +1 compile 4m 12s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 56s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 2m 13s trunk passed +1 javadoc 1m 4s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 19s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 57s the patch passed +1 compile 4m 13s the patch passed with JDK v1.8.0_60 +1 javac 4m 13s the patch passed +1 compile 4m 4s the patch passed with JDK v1.7.0_79 +1 javac 4m 4s the patch passed +1 checkstyle 0m 54s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 27s the patch passed +1 javadoc 1m 3s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 18s the patch passed with JDK v1.7.0_79 -1 unit 6m 50s hadoop-common in the patch failed with JDK v1.8.0_60. +1 unit 5m 25s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_60. -1 unit 7m 28s hadoop-common in the patch failed with JDK v1.7.0_79. +1 unit 5m 49s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_79. -1 asflicense 0m 22s Patch generated 14 ASF License warnings. 61m 19s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics JDK v1.7.0_79 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-09 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771337/HADOOP-MAPREDUCE-6499.8.patch JIRA Issue MAPREDUCE-6499 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 6122cbf5d511 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh git revision trunk / 668e897 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6131/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6131/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6131/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6131/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6131/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6131/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Max memory used 228MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6131/console This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        The faild test is likely not related.

        Show
        linyiqun Yiqun Lin added a comment - The faild test is likely not related.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Mostly looks good to me. Minor nits:

        +   * Given the time in long milliseconds, returns a String in the format Xhrs,
        +   * Ymins, Z sec with a sortable format, if hour is 0,it will be add 00, and if
        +   * the time is more than 99 hours ,it will be show 99hrs, 59mins, 59seconds.
        

        returns a String in the format Xhrs, Ymins, Z sec with a sortable format,

        "format" and "sortable format" is redundant. It can be simplified as "returns a String in the sortable format Xhrs, Ymins, Zsec."

        if hour is 0, it will be add 00,

        Zero padding is applied not only to hour but also to min and sec, so "if hour is 0,it will be add 00" can be rewrittened as "X, Y, and Z are always two-digit."

        if the time is more than 99 hours, it will be show 99hrs, 59mins, 59seconds.

        • 99 should be 100 because 99 hours and 40 mins is more than 99 hours but it is displayed as "99hrs, 40mins, 00sec."
        • "it will be show 99hrs, 59mins, 59seconds." -> "it is displayed as 99hrs, 59mins, 59sec."
        Show
        ajisakaa Akira Ajisaka added a comment - Mostly looks good to me. Minor nits: + * Given the time in long milliseconds, returns a String in the format Xhrs, + * Ymins, Z sec with a sortable format, if hour is 0,it will be add 00, and if + * the time is more than 99 hours ,it will be show 99hrs, 59mins, 59seconds. returns a String in the format Xhrs, Ymins, Z sec with a sortable format, "format" and "sortable format" is redundant. It can be simplified as "returns a String in the sortable format Xhrs, Ymins, Zsec." if hour is 0, it will be add 00, Zero padding is applied not only to hour but also to min and sec, so "if hour is 0,it will be add 00" can be rewrittened as "X, Y, and Z are always two-digit." if the time is more than 99 hours, it will be show 99hrs, 59mins, 59seconds. 99 should be 100 because 99 hours and 40 mins is more than 99 hours but it is displayed as "99hrs, 40mins, 00sec." "it will be show 99hrs, 59mins, 59seconds." -> "it is displayed as 99hrs, 59mins, 59sec."
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Akira Ajisaka comment.I updated the method annotaion and attach the patch.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka comment.I updated the method annotaion and attach the patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 7s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 3m 13s trunk passed
        +1 compile 4m 30s trunk passed with JDK v1.8.0_60
        +1 compile 4m 20s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 59s trunk passed
        +1 mvnsite 1m 14s trunk passed
        +1 mvneclipse 0m 28s trunk passed
        +1 findbugs 2m 13s trunk passed
        +1 javadoc 1m 6s trunk passed with JDK v1.8.0_60
        +1 javadoc 1m 20s trunk passed with JDK v1.7.0_79
        +1 mvninstall 2m 1s the patch passed
        +1 compile 4m 18s the patch passed with JDK v1.8.0_60
        +1 javac 4m 18s the patch passed
        +1 compile 4m 8s the patch passed with JDK v1.7.0_79
        +1 javac 4m 8s the patch passed
        +1 checkstyle 0m 55s the patch passed
        +1 mvnsite 1m 14s the patch passed
        +1 mvneclipse 0m 29s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 29s the patch passed
        +1 javadoc 1m 8s the patch passed with JDK v1.8.0_60
        +1 javadoc 1m 19s the patch passed with JDK v1.7.0_79
        -1 unit 6m 44s hadoop-common in the patch failed with JDK v1.8.0_60.
        +1 unit 5m 37s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_60.
        +1 unit 7m 14s hadoop-common in the patch passed with JDK v1.7.0_79.
        +1 unit 5m 59s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_79.
        -1 asflicense 0m 22s Patch generated 14 ASF License warnings.
        64m 37s



        Reason Tests
        JDK v1.8.0_60 Failed junit tests hadoop.fs.TestLocalFsFCStatistics



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-13
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771737/HADOOP-MAPREDUCE-6499.9.patch
        JIRA Issue MAPREDUCE-6499
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8098796436fe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build@2/patchprocess/apache-yetus-fa12328/precommit/personality/hadoop.sh
        git revision trunk / f94d892
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6158/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
        unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6158/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6158/testReport/
        asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6158/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
        Max memory used 228MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6158/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 7s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 13s trunk passed +1 compile 4m 30s trunk passed with JDK v1.8.0_60 +1 compile 4m 20s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 59s trunk passed +1 mvnsite 1m 14s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 2m 13s trunk passed +1 javadoc 1m 6s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 20s trunk passed with JDK v1.7.0_79 +1 mvninstall 2m 1s the patch passed +1 compile 4m 18s the patch passed with JDK v1.8.0_60 +1 javac 4m 18s the patch passed +1 compile 4m 8s the patch passed with JDK v1.7.0_79 +1 javac 4m 8s the patch passed +1 checkstyle 0m 55s the patch passed +1 mvnsite 1m 14s the patch passed +1 mvneclipse 0m 29s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 29s the patch passed +1 javadoc 1m 8s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 19s the patch passed with JDK v1.7.0_79 -1 unit 6m 44s hadoop-common in the patch failed with JDK v1.8.0_60. +1 unit 5m 37s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_60. +1 unit 7m 14s hadoop-common in the patch passed with JDK v1.7.0_79. +1 unit 5m 59s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_79. -1 asflicense 0m 22s Patch generated 14 ASF License warnings. 64m 37s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.fs.TestLocalFsFCStatistics Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-13 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771737/HADOOP-MAPREDUCE-6499.9.patch JIRA Issue MAPREDUCE-6499 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8098796436fe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build@2/patchprocess/apache-yetus-fa12328/precommit/personality/hadoop.sh git revision trunk / f94d892 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6158/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6158/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6158/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6158/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Max memory used 228MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6158/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Tried your patch and it looks good to me, +1. Attaching a screen shot.

        Show
        ajisakaa Akira Ajisaka added a comment - Tried your patch and it looks good to me, +1. Attaching a screen shot.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        I'll commit this the day after tomorrow if there are no comments.

        Show
        ajisakaa Akira Ajisaka added a comment - I'll commit this the day after tomorrow if there are no comments.
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Akira Ajisaka reviews.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka reviews.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk and branch-2. Thanks Yiqun Lin for the contribution!

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Yiqun Lin for the contribution!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8813 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8813/)
        MAPREDUCE-6499. Add elapsed time for retired job in JobHistoryServer (aajisaka: rev a7f776ffdfc9f96d3091d99a2a87157b290cbfe0)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobsBlock.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8813 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8813/ ) MAPREDUCE-6499 . Add elapsed time for retired job in JobHistoryServer (aajisaka: rev a7f776ffdfc9f96d3091d99a2a87157b290cbfe0) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobsBlock.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2615 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2615/)
        MAPREDUCE-6499. Add elapsed time for retired job in JobHistoryServer (aajisaka: rev a7f776ffdfc9f96d3091d99a2a87157b290cbfe0)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobsBlock.java
        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2615 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2615/ ) MAPREDUCE-6499 . Add elapsed time for retired job in JobHistoryServer (aajisaka: rev a7f776ffdfc9f96d3091d99a2a87157b290cbfe0) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobsBlock.java hadoop-mapreduce-project/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #673 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/673/)
        MAPREDUCE-6499. Add elapsed time for retired job in JobHistoryServer (aajisaka: rev a7f776ffdfc9f96d3091d99a2a87157b290cbfe0)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobsBlock.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #673 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/673/ ) MAPREDUCE-6499 . Add elapsed time for retired job in JobHistoryServer (aajisaka: rev a7f776ffdfc9f96d3091d99a2a87157b290cbfe0) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobsBlock.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1410 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1410/)
        MAPREDUCE-6499. Add elapsed time for retired job in JobHistoryServer (aajisaka: rev a7f776ffdfc9f96d3091d99a2a87157b290cbfe0)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobsBlock.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1410 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1410/ ) MAPREDUCE-6499 . Add elapsed time for retired job in JobHistoryServer (aajisaka: rev a7f776ffdfc9f96d3091d99a2a87157b290cbfe0) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobsBlock.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #686 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/686/)
        MAPREDUCE-6499. Add elapsed time for retired job in JobHistoryServer (aajisaka: rev a7f776ffdfc9f96d3091d99a2a87157b290cbfe0)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobsBlock.java
        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #686 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/686/ ) MAPREDUCE-6499 . Add elapsed time for retired job in JobHistoryServer (aajisaka: rev a7f776ffdfc9f96d3091d99a2a87157b290cbfe0) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobsBlock.java hadoop-mapreduce-project/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Akira Ajisaka for commit !

        Show
        linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka for commit !
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2549 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2549/)
        MAPREDUCE-6499. Add elapsed time for retired job in JobHistoryServer (aajisaka: rev a7f776ffdfc9f96d3091d99a2a87157b290cbfe0)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobsBlock.java
        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2549 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2549/ ) MAPREDUCE-6499 . Add elapsed time for retired job in JobHistoryServer (aajisaka: rev a7f776ffdfc9f96d3091d99a2a87157b290cbfe0) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobsBlock.java hadoop-mapreduce-project/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #611 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/611/)
        MAPREDUCE-6499. Add elapsed time for retired job in JobHistoryServer (aajisaka: rev a7f776ffdfc9f96d3091d99a2a87157b290cbfe0)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobsBlock.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #611 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/611/ ) MAPREDUCE-6499 . Add elapsed time for retired job in JobHistoryServer (aajisaka: rev a7f776ffdfc9f96d3091d99a2a87157b290cbfe0) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobsBlock.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java hadoop-mapreduce-project/CHANGES.txt

          People

          • Assignee:
            linyiqun Yiqun Lin
            Reporter:
            linyiqun Yiqun Lin
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development