Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6497

Fix wrong value of JOB_FINISHED event in JobHistoryEventHandler

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 2.7.2, 2.6.2, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It seems that "MAP_COUNTER_GROUPS" values use total_counter value.
      We should fix to use map_counter value.

      1. MAPREDUCE-6497.001.patch
        1 kB
        Shinichi Yamashita

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 22m 51s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 10m 51s There were no new javac warning messages.
        +1 javadoc 10m 14s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 43s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 29s mvn install still works.
        +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
        +1 findbugs 1m 7s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 mapreduce tests 9m 31s Tests failed in hadoop-mapreduce-client-app.
            57m 51s  



        Reason Tests
        Failed unit tests hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12764241/MAPREDUCE-6497.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / d6fa34e
        hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6033/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6033/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6033/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 22m 51s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 10m 51s There were no new javac warning messages. +1 javadoc 10m 14s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 43s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 29s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 1m 7s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 mapreduce tests 9m 31s Tests failed in hadoop-mapreduce-client-app.     57m 51s   Reason Tests Failed unit tests hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764241/MAPREDUCE-6497.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d6fa34e hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6033/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6033/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6033/console This message was automatically generated.
        Hide
        sinchii Shinichi Yamashita added a comment -

        Test of hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler was success in my environment.

        Show
        sinchii Shinichi Yamashita added a comment - Test of hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler was success in my environment.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Looks good to me, +1.

        Show
        ajisakaa Akira Ajisaka added a comment - Looks good to me, +1.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        I've committed this to trunk, branch-2, branch-2.7, and branch-2.6. Thanks Shinichi Yamashita for finding this bug and creating the patch.

        Show
        ajisakaa Akira Ajisaka added a comment - I've committed this to trunk, branch-2, branch-2.7, and branch-2.6. Thanks Shinichi Yamashita for finding this bug and creating the patch.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8551 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8551/)
        MAPREDUCE-6497. Fix wrong value of JOB_FINISHED event in (aajisaka: rev 195793c6f3e53a5c0527020477fe9c9158576f77)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8551 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8551/ ) MAPREDUCE-6497 . Fix wrong value of JOB_FINISHED event in (aajisaka: rev 195793c6f3e53a5c0527020477fe9c9158576f77) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #476 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/476/)
        MAPREDUCE-6497. Fix wrong value of JOB_FINISHED event in (aajisaka: rev 195793c6f3e53a5c0527020477fe9c9158576f77)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #476 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/476/ ) MAPREDUCE-6497 . Fix wrong value of JOB_FINISHED event in (aajisaka: rev 195793c6f3e53a5c0527020477fe9c9158576f77) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1206 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1206/)
        MAPREDUCE-6497. Fix wrong value of JOB_FINISHED event in (aajisaka: rev 195793c6f3e53a5c0527020477fe9c9158576f77)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1206 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1206/ ) MAPREDUCE-6497 . Fix wrong value of JOB_FINISHED event in (aajisaka: rev 195793c6f3e53a5c0527020477fe9c9158576f77) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2411 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2411/)
        MAPREDUCE-6497. Fix wrong value of JOB_FINISHED event in (aajisaka: rev 195793c6f3e53a5c0527020477fe9c9158576f77)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2411 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2411/ ) MAPREDUCE-6497 . Fix wrong value of JOB_FINISHED event in (aajisaka: rev 195793c6f3e53a5c0527020477fe9c9158576f77) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #442 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/442/)
        MAPREDUCE-6497. Fix wrong value of JOB_FINISHED event in (aajisaka: rev 195793c6f3e53a5c0527020477fe9c9158576f77)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #442 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/442/ ) MAPREDUCE-6497 . Fix wrong value of JOB_FINISHED event in (aajisaka: rev 195793c6f3e53a5c0527020477fe9c9158576f77) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #468 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/468/)
        MAPREDUCE-6497. Fix wrong value of JOB_FINISHED event in (aajisaka: rev 195793c6f3e53a5c0527020477fe9c9158576f77)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #468 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/468/ ) MAPREDUCE-6497 . Fix wrong value of JOB_FINISHED event in (aajisaka: rev 195793c6f3e53a5c0527020477fe9c9158576f77) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2382 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2382/)
        MAPREDUCE-6497. Fix wrong value of JOB_FINISHED event in (aajisaka: rev 195793c6f3e53a5c0527020477fe9c9158576f77)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2382 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2382/ ) MAPREDUCE-6497 . Fix wrong value of JOB_FINISHED event in (aajisaka: rev 195793c6f3e53a5c0527020477fe9c9158576f77) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java

          People

          • Assignee:
            sinchii Shinichi Yamashita
            Reporter:
            sinchii Shinichi Yamashita
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development