Details
-
Type:
Bug
-
Status: Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.8.0
-
Fix Version/s: 2.8.0, 3.0.0-alpha1
-
Component/s: None
-
Labels:None
-
Target Version/s:
-
Hadoop Flags:Reviewed
Description
If the tool is run as user A, it creates /tmp/logs/archive-logs-work for temp work, but doesn't delete it. When it's run again as user B, you can run into permissions problems on /tmp/logs/archive-logs-work because user B doesn't have permission to do anything to that dir (it's 700). We should have the tool delete /tmp/logs/archive-logs-work when exiting.
Issue Links
- is related to
-
MAPREDUCE-6415
Create a tool to combine aggregated logs into HAR files
-
- Resolved
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Why is this using /tmp and not the user's working directory as provided by YARN?
It uses
Path remoteRootLogDir = new Path(conf.get( YarnConfiguration.NM_REMOTE_APP_LOG_DIR, YarnConfiguration.DEFAULT_NM_REMOTE_APP_LOG_DIR)); Path workingDir = new Path(remoteRootLogDir, "archive-logs-work");
and YarnConfiguration.DEFAULT_NM_REMOTE_APP_LOG_DIR is /tmp/logs, so the working dir becomes /tmp/logs/archive-logs-work (by default).
 -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | pre-patch | 16m 33s | Pre-patch trunk compilation is healthy. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| +1 | javac | 7m 59s | There were no new javac warning messages. |
| +1 | javadoc | 10m 15s | There were no new javadoc warning messages. |
| +1 | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. |
| +1 | checkstyle | 0m 21s | There were no new checkstyle issues. |
| +1 | whitespace | 0m 0s | The patch has no lines that end in whitespace. |
| +1 | install | 1m 31s | mvn install still works. |
| +1 | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. |
| +1 | findbugs | 0m 41s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| +1 | tools/hadoop tests | 0m 32s | Tests passed in hadoop-archive-logs. |
| 38m 52s |
| Subsystem | Report/Notes |
|---|---|
| Patch URL | http://issues.apache.org/jira/secure/attachment/12764100/MAPREDUCE-6494.001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / ab11085 |
| hadoop-archive-logs test log | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6029/artifact/patchprocess/testrun_hadoop-archive-logs.txt |
| Test Results | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6029/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6029/console |
This message was automatically generated.
What would happen if we run two instances of this concurrently? Should we also make it easy for the user to realize that its happening to avoid issues? Maybe we could we use the existence of the directory as a sign that someone else is running it.
That's a good idea. The tool is designed to only run one instance at a time, and we put off enforcing that to figure out later. This sounds like a good way to do that. If the working directory already exists, then the tool can print out a message explaining that. I'll also add a -force option that will delete the directory in case it's incorrectly there somehow.
The 002 patch uses the working dir to prevent multiple calls to the tool and the -force option as described in my previous comment.
 +1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | pre-patch | 16m 21s | Pre-patch trunk compilation is healthy. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 | tests included | 0m 0s | The patch appears to include 1 new or modified test files. |
| +1 | javac | 8m 10s | There were no new javac warning messages. |
| +1 | javadoc | 10m 30s | There were no new javadoc warning messages. |
| +1 | release audit | 0m 24s | The applied patch does not increase the total number of release audit warnings. |
| +1 | checkstyle | 0m 20s | There were no new checkstyle issues. |
| +1 | whitespace | 0m 0s | The patch has no lines that end in whitespace. |
| +1 | install | 1m 35s | mvn install still works. |
| +1 | eclipse:eclipse | 0m 37s | The patch built with eclipse:eclipse. |
| +1 | findbugs | 0m 43s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| +1 | tools/hadoop tests | 0m 34s | Tests passed in hadoop-archive-logs. |
| 39m 19s |
| Subsystem | Report/Notes |
|---|---|
| Patch URL | http://issues.apache.org/jira/secure/attachment/12764152/MAPREDUCE-6494.002.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 5c3b663 |
| hadoop-archive-logs test log | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6031/artifact/patchprocess/testrun_hadoop-archive-logs.txt |
| Test Results | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6031/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6031/console |
This message was automatically generated.
+1. Nice test case.
We actually found one last permissions issue. If using the DefaultContainerExecutor, the shells are run as the Yarn user who won't have permission to operate on the temp dir when it's permissions are using 700. The 003 patch changes it to use 770 permissions to fix this.
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | pre-patch | 17m 57s | Pre-patch trunk compilation is healthy. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 | tests included | 0m 0s | The patch appears to include 1 new or modified test files. |
| +1 | javac | 8m 21s | There were no new javac warning messages. |
| +1 | javadoc | 11m 18s | There were no new javadoc warning messages. |
| -1 | release audit | 0m 19s | The applied patch generated 1 release audit warnings. |
| +1 | checkstyle | 0m 24s | There were no new checkstyle issues. |
| +1 | whitespace | 0m 0s | The patch has no lines that end in whitespace. |
| +1 | install | 1m 54s | mvn install still works. |
| +1 | eclipse:eclipse | 0m 38s | The patch built with eclipse:eclipse. |
| +1 | findbugs | 0m 48s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| +1 | tools/hadoop tests | 0m 43s | Tests passed in hadoop-archive-logs. |
| 42m 27s |
| Subsystem | Report/Notes |
|---|---|
| Patch URL | http://issues.apache.org/jira/secure/attachment/12764476/MAPREDUCE-6494.003.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 6c17d31 |
| Release Audit | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6045/artifact/patchprocess/patchReleaseAuditProblems.txt |
| hadoop-archive-logs test log | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6045/artifact/patchprocess/testrun_hadoop-archive-logs.txt |
| Test Results | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6045/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6045/console |
This message was automatically generated.
These are same as the normal log directory permissions used by LogAggregationService. So looks good.
+1
Thanks for the review Anubhav. Committed to trunk and branch-2!
FAILURE: Integrated in Hadoop-trunk-Commit #8550 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8550/)
MAPREDUCE-6494. Permission issue when running archive-logs tool as (rkanter: rev 5db371f52f5c6e894a7e6a5d523084f4b316a7ab)
- hadoop-mapreduce-project/CHANGES.txt
- hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
- hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #475 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/475/)
MAPREDUCE-6494. Permission issue when running archive-logs tool as (rkanter: rev 5db371f52f5c6e894a7e6a5d523084f4b316a7ab)
- hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
- hadoop-mapreduce-project/CHANGES.txt
- hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
FAILURE: Integrated in Hadoop-Yarn-trunk #1205 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1205/)
MAPREDUCE-6494. Permission issue when running archive-logs tool as (rkanter: rev 5db371f52f5c6e894a7e6a5d523084f4b316a7ab)
- hadoop-mapreduce-project/CHANGES.txt
- hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
- hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #467 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/467/)
MAPREDUCE-6494. Permission issue when running archive-logs tool as (rkanter: rev 5db371f52f5c6e894a7e6a5d523084f4b316a7ab)
- hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
- hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
- hadoop-mapreduce-project/CHANGES.txt
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2410 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2410/)
MAPREDUCE-6494. Permission issue when running archive-logs tool as (rkanter: rev 5db371f52f5c6e894a7e6a5d523084f4b316a7ab)
- hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
- hadoop-mapreduce-project/CHANGES.txt
- hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #441 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/441/)
MAPREDUCE-6494. Permission issue when running archive-logs tool as (rkanter: rev 5db371f52f5c6e894a7e6a5d523084f4b316a7ab)
- hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
- hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
- hadoop-mapreduce-project/CHANGES.txt
FAILURE: Integrated in Hadoop-Hdfs-trunk #2381 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2381/)
MAPREDUCE-6494. Permission issue when running archive-logs tool as (rkanter: rev 5db371f52f5c6e894a7e6a5d523084f4b316a7ab)
- hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
- hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
- hadoop-mapreduce-project/CHANGES.txt
The changes are mostly just from indenting and moving a few things around. Otherwise, the "real" change is only deleting the directory.