Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6418

MRApp should not shutdown LogManager during shutdown

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Tests in TestRecovery.java lost their logs after recovery due to the change of MAPREDUCE-5694. MRApp should overwrite those changes to allow log after am recover to be shown.

      1. MAPREDUCE-6418.1.patch
        2 kB
        Chang Li
      2. MAPREDUCE-6418.2.patch
        2 kB
        Chang Li
      3. MAPREDUCE-6418.3.patch
        3 kB
        Chang Li
      4. MAPREDUCE-6418.4.patch
        3 kB
        Chang Li

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2192 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2192/)
        MAPREDUCE-6418. MRApp should not shutdown LogManager during shutdown. Contributed by Chang Li (jlowe: rev eac1d1894354e90d314087af8e7fb168ddef9a3d)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2192 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2192/ ) MAPREDUCE-6418 . MRApp should not shutdown LogManager during shutdown. Contributed by Chang Li (jlowe: rev eac1d1894354e90d314087af8e7fb168ddef9a3d) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2173 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2173/)
        MAPREDUCE-6418. MRApp should not shutdown LogManager during shutdown. Contributed by Chang Li (jlowe: rev eac1d1894354e90d314087af8e7fb168ddef9a3d)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2173 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2173/ ) MAPREDUCE-6418 . MRApp should not shutdown LogManager during shutdown. Contributed by Chang Li (jlowe: rev eac1d1894354e90d314087af8e7fb168ddef9a3d) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #234 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/234/)
        MAPREDUCE-6418. MRApp should not shutdown LogManager during shutdown. Contributed by Chang Li (jlowe: rev eac1d1894354e90d314087af8e7fb168ddef9a3d)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #234 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/234/ ) MAPREDUCE-6418 . MRApp should not shutdown LogManager during shutdown. Contributed by Chang Li (jlowe: rev eac1d1894354e90d314087af8e7fb168ddef9a3d) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #244 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/244/)
        MAPREDUCE-6418. MRApp should not shutdown LogManager during shutdown. Contributed by Chang Li (jlowe: rev eac1d1894354e90d314087af8e7fb168ddef9a3d)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #244 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/244/ ) MAPREDUCE-6418 . MRApp should not shutdown LogManager during shutdown. Contributed by Chang Li (jlowe: rev eac1d1894354e90d314087af8e7fb168ddef9a3d) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #976 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/976/)
        MAPREDUCE-6418. MRApp should not shutdown LogManager during shutdown. Contributed by Chang Li (jlowe: rev eac1d1894354e90d314087af8e7fb168ddef9a3d)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #976 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/976/ ) MAPREDUCE-6418 . MRApp should not shutdown LogManager during shutdown. Contributed by Chang Li (jlowe: rev eac1d1894354e90d314087af8e7fb168ddef9a3d) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #246 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/246/)
        MAPREDUCE-6418. MRApp should not shutdown LogManager during shutdown. Contributed by Chang Li (jlowe: rev eac1d1894354e90d314087af8e7fb168ddef9a3d)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #246 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/246/ ) MAPREDUCE-6418 . MRApp should not shutdown LogManager during shutdown. Contributed by Chang Li (jlowe: rev eac1d1894354e90d314087af8e7fb168ddef9a3d) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8107 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8107/)
        MAPREDUCE-6418. MRApp should not shutdown LogManager during shutdown. Contributed by Chang Li (jlowe: rev eac1d1894354e90d314087af8e7fb168ddef9a3d)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8107 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8107/ ) MAPREDUCE-6418 . MRApp should not shutdown LogManager during shutdown. Contributed by Chang Li (jlowe: rev eac1d1894354e90d314087af8e7fb168ddef9a3d) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
        Hide
        jlowe Jason Lowe added a comment -

        Thanks Chang! I committed this to trunk and branch-2.

        Show
        jlowe Jason Lowe added a comment - Thanks Chang! I committed this to trunk and branch-2.
        Hide
        jlowe Jason Lowe added a comment -

        +1 lgtm. Committing this.

        Show
        jlowe Jason Lowe added a comment - +1 lgtm. Committing this.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 15m 35s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 33s There were no new javac warning messages.
        +1 javadoc 9m 36s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 34s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 6s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 mapreduce tests 9m 7s Tests passed in hadoop-mapreduce-client-app.
            46m 3s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12742596/MAPREDUCE-6418.4.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 460e98f
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5855/artifact/patchprocess/trunkFindbugsWarningshadoop-mapreduce-client-app.html
        hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5855/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5855/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5855/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 35s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 33s There were no new javac warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 34s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 6s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 7s Tests passed in hadoop-mapreduce-client-app.     46m 3s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12742596/MAPREDUCE-6418.4.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 460e98f Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5855/artifact/patchprocess/trunkFindbugsWarningshadoop-mapreduce-client-app.html hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5855/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5855/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5855/console This message was automatically generated.
        Hide
        lichangleo Chang Li added a comment -

        .4 patch fixed some whitespace issues I just noticed

        Show
        lichangleo Chang Li added a comment - .4 patch fixed some whitespace issues I just noticed
        Hide
        lichangleo Chang Li added a comment -

        Thanks Jason Lowe for review and provide valuable suggestions! I just updated my patch to improve the comments and move comment inside the function body.

        Show
        lichangleo Chang Li added a comment - Thanks Jason Lowe for review and provide valuable suggestions! I just updated my patch to improve the comments and move comment inside the function body.
        Hide
        jlowe Jason Lowe added a comment -

        Nit: The comment wording could be improved quite a bit. How about "Avoid closing the logging system during unit tests, otherwise subsequent MRApp instances in the same test will fail to log anything."?

        Nit: Could you place the comments inside the function body? Normally comments outside the function are for documenting why the interface exists, etc. This is more of an implementation detail for this particular override.

        Show
        jlowe Jason Lowe added a comment - Nit: The comment wording could be improved quite a bit. How about "Avoid closing the logging system during unit tests, otherwise subsequent MRApp instances in the same test will fail to log anything."? Nit: Could you place the comments inside the function body? Normally comments outside the function are for documenting why the interface exists, etc. This is more of an implementation detail for this particular override.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 15m 39s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 30s There were no new javac warning messages.
        +1 javadoc 9m 42s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 37s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 6s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 mapreduce tests 9m 7s Tests passed in hadoop-mapreduce-client-app.
            46m 17s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12742560/MAPREDUCE-6418.2.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / d3fed8e
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5854/artifact/patchprocess/trunkFindbugsWarningshadoop-mapreduce-client-app.html
        hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5854/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5854/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5854/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 39s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 42s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 37s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 6s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 7s Tests passed in hadoop-mapreduce-client-app.     46m 17s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12742560/MAPREDUCE-6418.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d3fed8e Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5854/artifact/patchprocess/trunkFindbugsWarningshadoop-mapreduce-client-app.html hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5854/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5854/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5854/console This message was automatically generated.
        Hide
        lichangleo Chang Li added a comment -

        Jason Lowe thanks for review! I just updated my patch according to your suggestions.

        Show
        lichangleo Chang Li added a comment - Jason Lowe thanks for review! I just updated my patch according to your suggestions.
        Hide
        jlowe Jason Lowe added a comment -

        Thanks for the patch, Chang!

        There's a mix of space and tabs in the patch, please only use spaces.

        shutdownLogManager should not declare it throws Exception. I don't see a reason it needs to throw at all.

        Please add a comment to the body of MRApp shutdownTaskLog and shutdownLogManager explaining why it is not doing anything so when someone comes along later it's obvious why that was done.

        Show
        jlowe Jason Lowe added a comment - Thanks for the patch, Chang! There's a mix of space and tabs in the patch, please only use spaces. shutdownLogManager should not declare it throws Exception. I don't see a reason it needs to throw at all. Please add a comment to the body of MRApp shutdownTaskLog and shutdownLogManager explaining why it is not doing anything so when someone comes along later it's obvious why that was done.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 15m 16s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 1s There were no new javac warning messages.
        +1 javadoc 10m 0s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 17s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 36s mvn install still works.
        +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
        -1 findbugs 1m 12s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
        +1 mapreduce tests 9m 13s Tests passed in hadoop-mapreduce-client-app.
            46m 36s  



        Reason Tests
        FindBugs module:hadoop-mapreduce-client-app



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12742244/MAPREDUCE-6418.1.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / aa07dea
        Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5846/artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
        hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5846/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5846/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5846/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 16s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 1s There were no new javac warning messages. +1 javadoc 10m 0s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 17s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. -1 findbugs 1m 12s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 13s Tests passed in hadoop-mapreduce-client-app.     46m 36s   Reason Tests FindBugs module:hadoop-mapreduce-client-app Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12742244/MAPREDUCE-6418.1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / aa07dea Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5846/artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5846/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5846/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5846/console This message was automatically generated.
        Hide
        lichangleo Chang Li added a comment -

        Jason Lowe please help review. Thanks!

        Show
        lichangleo Chang Li added a comment - Jason Lowe please help review. Thanks!

          People

          • Assignee:
            lichangleo Chang Li
            Reporter:
            lichangleo Chang Li
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development