Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6382

Don't escape HTML links in Diagnostics in JHS job overview

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      for some reason, links are working properly in 2.4, but they are escaped in 2.6

      1. MAPREDUCE-6382.v1.patch
        0.9 kB
        Siqi Li
      2. links are escaped.jpg
        128 kB
        Siqi Li

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2164 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2164/)
          MAPREDUCE-6382. Don't escape HTML links in Diagnostics in JHS job overview. (Siqi Li via gera) (gera: rev e8302071ff16247a3d0cfc2dcca02da1bbf4db18)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobBlock.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2164 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2164/ ) MAPREDUCE-6382 . Don't escape HTML links in Diagnostics in JHS job overview. (Siqi Li via gera) (gera: rev e8302071ff16247a3d0cfc2dcca02da1bbf4db18) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobBlock.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #216 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/216/)
          MAPREDUCE-6382. Don't escape HTML links in Diagnostics in JHS job overview. (Siqi Li via gera) (gera: rev e8302071ff16247a3d0cfc2dcca02da1bbf4db18)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobBlock.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #216 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/216/ ) MAPREDUCE-6382 . Don't escape HTML links in Diagnostics in JHS job overview. (Siqi Li via gera) (gera: rev e8302071ff16247a3d0cfc2dcca02da1bbf4db18) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobBlock.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #207 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/207/)
          MAPREDUCE-6382. Don't escape HTML links in Diagnostics in JHS job overview. (Siqi Li via gera) (gera: rev e8302071ff16247a3d0cfc2dcca02da1bbf4db18)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobBlock.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #207 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/207/ ) MAPREDUCE-6382 . Don't escape HTML links in Diagnostics in JHS job overview. (Siqi Li via gera) (gera: rev e8302071ff16247a3d0cfc2dcca02da1bbf4db18) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobBlock.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2146 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2146/)
          MAPREDUCE-6382. Don't escape HTML links in Diagnostics in JHS job overview. (Siqi Li via gera) (gera: rev e8302071ff16247a3d0cfc2dcca02da1bbf4db18)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobBlock.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2146 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2146/ ) MAPREDUCE-6382 . Don't escape HTML links in Diagnostics in JHS job overview. (Siqi Li via gera) (gera: rev e8302071ff16247a3d0cfc2dcca02da1bbf4db18) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobBlock.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #948 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/948/)
          MAPREDUCE-6382. Don't escape HTML links in Diagnostics in JHS job overview. (Siqi Li via gera) (gera: rev e8302071ff16247a3d0cfc2dcca02da1bbf4db18)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobBlock.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #948 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/948/ ) MAPREDUCE-6382 . Don't escape HTML links in Diagnostics in JHS job overview. (Siqi Li via gera) (gera: rev e8302071ff16247a3d0cfc2dcca02da1bbf4db18) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobBlock.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #218 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/218/)
          MAPREDUCE-6382. Don't escape HTML links in Diagnostics in JHS job overview. (Siqi Li via gera) (gera: rev e8302071ff16247a3d0cfc2dcca02da1bbf4db18)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobBlock.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #218 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/218/ ) MAPREDUCE-6382 . Don't escape HTML links in Diagnostics in JHS job overview. (Siqi Li via gera) (gera: rev e8302071ff16247a3d0cfc2dcca02da1bbf4db18) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobBlock.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7962 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7962/)
          MAPREDUCE-6382. Don't escape HTML links in Diagnostics in JHS job overview. (Siqi Li via gera) (gera: rev e8302071ff16247a3d0cfc2dcca02da1bbf4db18)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobBlock.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7962 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7962/ ) MAPREDUCE-6382 . Don't escape HTML links in Diagnostics in JHS job overview. (Siqi Li via gera) (gera: rev e8302071ff16247a3d0cfc2dcca02da1bbf4db18) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobBlock.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          jira.shegalov Gera Shegalov added a comment -

          Thanks Siqi Li for contribution! Committed to trunk and branch-2.

          Show
          jira.shegalov Gera Shegalov added a comment - Thanks Siqi Li for contribution! Committed to trunk and branch-2.
          Hide
          jira.shegalov Gera Shegalov added a comment -

          Good find, Siqi Li! Test failures are unrelated. +1 for v1, committing

          Show
          jira.shegalov Gera Shegalov added a comment - Good find, Siqi Li ! Test failures are unrelated. +1 for v1, committing
          Hide
          l201514 Siqi Li added a comment -

          Hi Gera Shegalov, can you take a look at this patch?

          Show
          l201514 Siqi Li added a comment - Hi Gera Shegalov , can you take a look at this patch?
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 54s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 49s There were no new javac warning messages.
          +1 javadoc 9m 55s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 23s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 36s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 0m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 mapreduce tests 4m 15s Tests failed in hadoop-mapreduce-client-hs.
              41m 39s  



          Reason Tests
          Failed unit tests hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobsQuery
            hadoop.mapreduce.v2.hs.TestHistoryServerLeveldbStateStoreService
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobs
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesAttempts
          Timed out tests org.apache.hadoop.mapreduce.v2.hs.TestJobHistoryParsing
            org.apache.hadoop.mapreduce.v2.hs.webapp.TestHSWebApp



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12737029/MAPREDUCE-6382.v1.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 03fb5c6
          hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5764/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5764/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5764/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 54s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 49s There were no new javac warning messages. +1 javadoc 9m 55s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 23s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 0m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 mapreduce tests 4m 15s Tests failed in hadoop-mapreduce-client-hs.     41m 39s   Reason Tests Failed unit tests hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobsQuery   hadoop.mapreduce.v2.hs.TestHistoryServerLeveldbStateStoreService   hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobs   hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesAttempts Timed out tests org.apache.hadoop.mapreduce.v2.hs.TestJobHistoryParsing   org.apache.hadoop.mapreduce.v2.hs.webapp.TestHSWebApp Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12737029/MAPREDUCE-6382.v1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 03fb5c6 hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5764/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5764/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5764/console This message was automatically generated.

            People

            • Assignee:
              l201514 Siqi Li
              Reporter:
              l201514 Siqi Li
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development