Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6366

mapreduce.terasort.final.sync configuration in TeraSort doesn't work

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: examples
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      A TeraOutputFormat's field, finalSync, is always set "true". Therefore TeraSort 's mapreduce.terasort.final.sync option doesn't work.

        Activity

        Hide
        tfukudom Takuya Fukudome added a comment -

        I attached a patch. Could someone review it? Thank you.

        Show
        tfukudom Takuya Fukudome added a comment - I attached a patch. Could someone review it? Thank you.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Sure, let me check.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Sure, let me check.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Takuya Fukudome thank you for reporting and taking this issue. +1, committing this shortly.

        This change looks incompatible at a glance, but it is a compatible change. This is a bug which TeraSort problem ignores mapreduce.terasort.final.sync configuration. It should be fixed. The change of the default value only affects TeraSort. The polity also describes that we can change the default value.

        http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/Compatibility.html#Hadoop_Configuration_Files

        Show
        ozawa Tsuyoshi Ozawa added a comment - Takuya Fukudome thank you for reporting and taking this issue. +1, committing this shortly. This change looks incompatible at a glance, but it is a compatible change. This is a bug which TeraSort problem ignores mapreduce.terasort.final.sync configuration. It should be fixed. The change of the default value only affects TeraSort. The polity also describes that we can change the default value. http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/Compatibility.html#Hadoop_Configuration_Files
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Forgot to run Jenkins. Submitting a patch and pending for Jenkins.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Forgot to run Jenkins. Submitting a patch and pending for Jenkins.
        Hide
        tfukudom Takuya Fukudome added a comment -

        Thank you for reviewing, Tsuyoshi Ozawa!

        Show
        tfukudom Takuya Fukudome added a comment - Thank you for reviewing, Tsuyoshi Ozawa !
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 2s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 47s There were no new javac warning messages.
        +1 javadoc 9m 48s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 26s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 36s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 0m 46s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 mapreduce tests 0m 37s Tests passed in hadoop-mapreduce-examples.
            37m 1s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12732482/MAPREDUCE-6366.1.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / fcd0702
        hadoop-mapreduce-examples test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5724/artifact/patchprocess/testrun_hadoop-mapreduce-examples.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5724/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5724/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 2s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 47s There were no new javac warning messages. +1 javadoc 9m 48s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 26s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 46s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 mapreduce tests 0m 37s Tests passed in hadoop-mapreduce-examples.     37m 1s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12732482/MAPREDUCE-6366.1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / fcd0702 hadoop-mapreduce-examples test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5724/artifact/patchprocess/testrun_hadoop-mapreduce-examples.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5724/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5724/console This message was automatically generated.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Committing this shortly.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Committing this shortly.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Committed this to trunk and branch-2. Thanks Takuya Fukudome for your reporintg and contribution!

        Show
        ozawa Tsuyoshi Ozawa added a comment - Committed this to trunk and branch-2. Thanks Takuya Fukudome for your reporintg and contribution!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7812 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7812/)
        MAPREDUCE-6366. mapreduce.terasort.final.sync configuration in TeraSort doesn't work. Contributed by Takuya Fukudome. (ozawa: rev e82067bfe680ce04acc0153693cce3cd385e5567)

        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSortConfigKeys.java
        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSort.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7812 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7812/ ) MAPREDUCE-6366 . mapreduce.terasort.final.sync configuration in TeraSort doesn't work. Contributed by Takuya Fukudome. (ozawa: rev e82067bfe680ce04acc0153693cce3cd385e5567) hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSortConfigKeys.java hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSort.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #195 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/195/)
        MAPREDUCE-6366. mapreduce.terasort.final.sync configuration in TeraSort doesn't work. Contributed by Takuya Fukudome. (ozawa: rev e82067bfe680ce04acc0153693cce3cd385e5567)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSortConfigKeys.java
        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSort.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #195 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/195/ ) MAPREDUCE-6366 . mapreduce.terasort.final.sync configuration in TeraSort doesn't work. Contributed by Takuya Fukudome. (ozawa: rev e82067bfe680ce04acc0153693cce3cd385e5567) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSortConfigKeys.java hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSort.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #926 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/926/)
        MAPREDUCE-6366. mapreduce.terasort.final.sync configuration in TeraSort doesn't work. Contributed by Takuya Fukudome. (ozawa: rev e82067bfe680ce04acc0153693cce3cd385e5567)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSortConfigKeys.java
        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSort.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #926 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/926/ ) MAPREDUCE-6366 . mapreduce.terasort.final.sync configuration in TeraSort doesn't work. Contributed by Takuya Fukudome. (ozawa: rev e82067bfe680ce04acc0153693cce3cd385e5567) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSortConfigKeys.java hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSort.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2124 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2124/)
        MAPREDUCE-6366. mapreduce.terasort.final.sync configuration in TeraSort doesn't work. Contributed by Takuya Fukudome. (ozawa: rev e82067bfe680ce04acc0153693cce3cd385e5567)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSortConfigKeys.java
        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSort.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2124 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2124/ ) MAPREDUCE-6366 . mapreduce.terasort.final.sync configuration in TeraSort doesn't work. Contributed by Takuya Fukudome. (ozawa: rev e82067bfe680ce04acc0153693cce3cd385e5567) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSortConfigKeys.java hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSort.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #184 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/184/)
        MAPREDUCE-6366. mapreduce.terasort.final.sync configuration in TeraSort doesn't work. Contributed by Takuya Fukudome. (ozawa: rev e82067bfe680ce04acc0153693cce3cd385e5567)

        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSortConfigKeys.java
        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSort.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #184 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/184/ ) MAPREDUCE-6366 . mapreduce.terasort.final.sync configuration in TeraSort doesn't work. Contributed by Takuya Fukudome. (ozawa: rev e82067bfe680ce04acc0153693cce3cd385e5567) hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSortConfigKeys.java hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSort.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #194 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/194/)
        MAPREDUCE-6366. mapreduce.terasort.final.sync configuration in TeraSort doesn't work. Contributed by Takuya Fukudome. (ozawa: rev e82067bfe680ce04acc0153693cce3cd385e5567)

        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSort.java
        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSortConfigKeys.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #194 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/194/ ) MAPREDUCE-6366 . mapreduce.terasort.final.sync configuration in TeraSort doesn't work. Contributed by Takuya Fukudome. (ozawa: rev e82067bfe680ce04acc0153693cce3cd385e5567) hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSort.java hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSortConfigKeys.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2142 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2142/)
        MAPREDUCE-6366. mapreduce.terasort.final.sync configuration in TeraSort doesn't work. Contributed by Takuya Fukudome. (ozawa: rev e82067bfe680ce04acc0153693cce3cd385e5567)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSort.java
        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSortConfigKeys.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2142 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2142/ ) MAPREDUCE-6366 . mapreduce.terasort.final.sync configuration in TeraSort doesn't work. Contributed by Takuya Fukudome. (ozawa: rev e82067bfe680ce04acc0153693cce3cd385e5567) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSort.java hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSortConfigKeys.java

          People

          • Assignee:
            tfukudom Takuya Fukudome
            Reporter:
            tfukudom Takuya Fukudome
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development