Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6349

Fix typo in property org.apache.hadoop.mapreduce.lib.chain.Chain.REDUCER_INPUT_VALUE_CLASS

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Ran across this typo in a property. It doesn't look like it's used anywhere externally.

        Issue Links

          Activity

          Hide
          rchiang Ray Chiang added a comment -

          Fixes typo

          Show
          rchiang Ray Chiang added a comment - Fixes typo
          Hide
          rchiang Ray Chiang added a comment -

          Submit for testing

          Show
          rchiang Ray Chiang added a comment - Submit for testing
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 9s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 8m 9s There were no new javac warning messages.
          +1 javadoc 9m 55s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 48s The applied patch generated 1 new checkstyle issues (total was 44, now 44).
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 36s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 15s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 mapreduce tests 1m 39s Tests passed in hadoop-mapreduce-client-core.
              39m 30s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12729818/MAPREDUCE-6349.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 3393461
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5484/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-core.txt
          whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5484/artifact/patchprocess/whitespace.txt
          hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5484/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5484/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5484/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 9s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 9s There were no new javac warning messages. +1 javadoc 9m 55s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 48s The applied patch generated 1 new checkstyle issues (total was 44, now 44). -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 15s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 mapreduce tests 1m 39s Tests passed in hadoop-mapreduce-client-core.     39m 30s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12729818/MAPREDUCE-6349.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 3393461 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5484/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-core.txt whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5484/artifact/patchprocess/whitespace.txt hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5484/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5484/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5484/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          RE: No new unit tests

          Fixing a typo in a property.

          RE: whitespace

          Patch contains whitespace because original code contains whitespace for the property.

          Show
          rchiang Ray Chiang added a comment - RE: No new unit tests Fixing a typo in a property. RE: whitespace Patch contains whitespace because original code contains whitespace for the property.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          +1, confirmed compatibility - it's OK to change REDUCER_INPUT_VALUE_CLASS since REDUCER_INPUT_VALUE_CLASS is protected value and only used in Chain.java. The value set as REDUCER_INPUT_VALUE_CLASS isn't used from anywhere.

          Show
          ozawa Tsuyoshi Ozawa added a comment - +1, confirmed compatibility - it's OK to change REDUCER_INPUT_VALUE_CLASS since REDUCER_INPUT_VALUE_CLASS is protected value and only used in Chain.java. The value set as REDUCER_INPUT_VALUE_CLASS isn't used from anywhere.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Committed this to trunk and branch-2. Thanks Ray Chiang for your contribution!

          Show
          ozawa Tsuyoshi Ozawa added a comment - Committed this to trunk and branch-2. Thanks Ray Chiang for your contribution!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7720 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7720/)
          MAPREDUCE-6349. Fix typo in property org.apache.hadoop.mapreduce.lib.chain.Chain.REDUCER_INPUT_VALUE_CLASS. Contributed by Ray Chiang. (ozawa: rev bb6ef2984d8f117711b806c4ebdc757bd182c06e)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/chain/Chain.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7720 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7720/ ) MAPREDUCE-6349 . Fix typo in property org.apache.hadoop.mapreduce.lib.chain.Chain.REDUCER_INPUT_VALUE_CLASS. Contributed by Ray Chiang. (ozawa: rev bb6ef2984d8f117711b806c4ebdc757bd182c06e) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/chain/Chain.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #183 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/183/)
          MAPREDUCE-6349. Fix typo in property org.apache.hadoop.mapreduce.lib.chain.Chain.REDUCER_INPUT_VALUE_CLASS. Contributed by Ray Chiang. (ozawa: rev bb6ef2984d8f117711b806c4ebdc757bd182c06e)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/chain/Chain.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #183 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/183/ ) MAPREDUCE-6349 . Fix typo in property org.apache.hadoop.mapreduce.lib.chain.Chain.REDUCER_INPUT_VALUE_CLASS. Contributed by Ray Chiang. (ozawa: rev bb6ef2984d8f117711b806c4ebdc757bd182c06e) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/chain/Chain.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #917 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/917/)
          MAPREDUCE-6349. Fix typo in property org.apache.hadoop.mapreduce.lib.chain.Chain.REDUCER_INPUT_VALUE_CLASS. Contributed by Ray Chiang. (ozawa: rev bb6ef2984d8f117711b806c4ebdc757bd182c06e)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/chain/Chain.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #917 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/917/ ) MAPREDUCE-6349 . Fix typo in property org.apache.hadoop.mapreduce.lib.chain.Chain.REDUCER_INPUT_VALUE_CLASS. Contributed by Ray Chiang. (ozawa: rev bb6ef2984d8f117711b806c4ebdc757bd182c06e) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/chain/Chain.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2115 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2115/)
          MAPREDUCE-6349. Fix typo in property org.apache.hadoop.mapreduce.lib.chain.Chain.REDUCER_INPUT_VALUE_CLASS. Contributed by Ray Chiang. (ozawa: rev bb6ef2984d8f117711b806c4ebdc757bd182c06e)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/chain/Chain.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2115 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2115/ ) MAPREDUCE-6349 . Fix typo in property org.apache.hadoop.mapreduce.lib.chain.Chain.REDUCER_INPUT_VALUE_CLASS. Contributed by Ray Chiang. (ozawa: rev bb6ef2984d8f117711b806c4ebdc757bd182c06e) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/chain/Chain.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #174 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/174/)
          MAPREDUCE-6349. Fix typo in property org.apache.hadoop.mapreduce.lib.chain.Chain.REDUCER_INPUT_VALUE_CLASS. Contributed by Ray Chiang. (ozawa: rev bb6ef2984d8f117711b806c4ebdc757bd182c06e)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/chain/Chain.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #174 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/174/ ) MAPREDUCE-6349 . Fix typo in property org.apache.hadoop.mapreduce.lib.chain.Chain.REDUCER_INPUT_VALUE_CLASS. Contributed by Ray Chiang. (ozawa: rev bb6ef2984d8f117711b806c4ebdc757bd182c06e) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/chain/Chain.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #184 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/184/)
          MAPREDUCE-6349. Fix typo in property org.apache.hadoop.mapreduce.lib.chain.Chain.REDUCER_INPUT_VALUE_CLASS. Contributed by Ray Chiang. (ozawa: rev bb6ef2984d8f117711b806c4ebdc757bd182c06e)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/chain/Chain.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #184 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/184/ ) MAPREDUCE-6349 . Fix typo in property org.apache.hadoop.mapreduce.lib.chain.Chain.REDUCER_INPUT_VALUE_CLASS. Contributed by Ray Chiang. (ozawa: rev bb6ef2984d8f117711b806c4ebdc757bd182c06e) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/chain/Chain.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2133 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2133/)
          MAPREDUCE-6349. Fix typo in property org.apache.hadoop.mapreduce.lib.chain.Chain.REDUCER_INPUT_VALUE_CLASS. Contributed by Ray Chiang. (ozawa: rev bb6ef2984d8f117711b806c4ebdc757bd182c06e)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/chain/Chain.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2133 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2133/ ) MAPREDUCE-6349 . Fix typo in property org.apache.hadoop.mapreduce.lib.chain.Chain.REDUCER_INPUT_VALUE_CLASS. Contributed by Ray Chiang. (ozawa: rev bb6ef2984d8f117711b806c4ebdc757bd182c06e) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/chain/Chain.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          rchiang Ray Chiang added a comment -

          Thanks for the review and the commit!

          Show
          rchiang Ray Chiang added a comment - Thanks for the review and the commit!

            People

            • Assignee:
              rchiang Ray Chiang
              Reporter:
              rchiang Ray Chiang
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development