[MAPREDUCE-6296] A better way to deal with InterruptedException on waitForCompletion

• Type: Improvement
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Labels: BB2015-05-TBR
• Assignee: Yang Hao
• Reporter: Yang Hao
• Created: 30/Mar/15 03:06
• Updated: 24/Oct/17 12:27

Description

Some code in method waitForCompletion of Job class is

Job.java

  public boolean waitForCompletion(boolean verbose
                                   ) throws IOException, InterruptedException,
                                            ClassNotFoundException {
    if (state == JobState.DEFINE) {
      submit();
    }
    if (verbose) {
      monitorAndPrintJob();
    } else {
      // get the completion poll interval from the client.
      int completionPollIntervalMillis = 
        Job.getCompletionPollInterval(cluster.getConf());
      while (!isComplete()) {
        try {
          Thread.sleep(completionPollIntervalMillis);
        } catch (InterruptedException ie) {
        }
      }
    }
    return isSuccessful();
  }

but a better way to deal with InterruptException is

Job.java

  public boolean waitForCompletion(boolean verbose
                                   ) throws IOException, InterruptedException,
                                            ClassNotFoundException {
    if (state == JobState.DEFINE) {
      submit();
    }
    if (verbose) {
      monitorAndPrintJob();
    } else {
      // get the completion poll interval from the client.
      int completionPollIntervalMillis = 
        Job.getCompletionPollInterval(cluster.getConf());
      while (!isComplete()) {
        try {
          Thread.sleep(completionPollIntervalMillis);
        } catch (InterruptedException ie) {
          Thread.currentThread().interrupt();
        }
      }
    }
    return isSuccessful();
  }