Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently it is like following..

      Usage: JobQueueClient <command> <args>

      It should be

      Usage: queue <command> <args>

      For more Details check following

      hdfs@host1:/hadoop/bin> ./mapred queue
      Usage: JobQueueClient <command> <args>
      	[-list]
      	[-info <job-queue-name> [-showJobs]]
      	[-showacls] 
      
      1. MAPRED-6291.patch
        0.9 kB
        Brahma Reddy Battula
      2. MAPRED-6291-001.patch
        4 kB
        Brahma Reddy Battula
      3. MAPREDUCE-6291-002.patch
        4 kB
        Brahma Reddy Battula

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12707121/MAPRED-6291.patch
          against trunk revision 53a28af.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5333//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5333//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707121/MAPRED-6291.patch against trunk revision 53a28af. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5333//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5333//console This message is automatically generated.
          Hide
          qwertymaniac Harsh J added a comment -

          While I'm in agreement, is this something limited to just the queue command output currently? If not, can we make such changes to all other commands (under MR) at the same time?

          Show
          qwertymaniac Harsh J added a comment - While I'm in agreement, is this something limited to just the queue command output currently? If not, can we make such changes to all other commands (under MR) at the same time?
          Hide
          qwertymaniac Harsh J added a comment -

          +1 on change. Will commit by tomorrow unless we have other commands to add such changes in.

          Show
          qwertymaniac Harsh J added a comment - +1 on change. Will commit by tomorrow unless we have other commands to add such changes in.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          There is another command need to change mapred job. Similarly, it wold be better to cross check for other commands.

          Show
          rohithsharma Rohith Sharma K S added a comment - There is another command need to change mapred job . Similarly, it wold be better to cross check for other commands.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          typo mistake : wold - -> would

          Show
          rohithsharma Rohith Sharma K S added a comment - typo mistake : wold - -> would
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Probably it is would be good if usage command are in consistent like below.
          Usage: mapred <command> <sub-command> <args>
          any thought?

          Show
          rohithsharma Rohith Sharma K S added a comment - Probably it is would be good if usage command are in consistent like below. Usage: mapred <command> <sub-command> <args> any thought?
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thanks a lot for taking a look into this issue....Yes, there are some.. like pipes/archives/job...

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thanks a lot for taking a look into this issue....Yes, there are some.. like pipes/archives/job...
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thanks for taking a look into this issue..Yes, may be we can uniform like this but not only mapred, there are for yarn also hence I feel,can file separate jira to handle..

          *Here as you mentioned *

          hdfs@host131:/hadoop/bin> ./yarn logs
          Retrieve logs for completed YARN applications.
          usage: yarn logs -applicationId <application ID> [OPTIONS]

          general options are:
          -appOwner <Application Owner> AppOwner (assumed to be current user if
          not specified)
          -containerId <Container ID> ContainerId (must be specified if node
          address is specified)
          -nodeAddress <Node Address> NodeAddress in the format nodename:port
          (must be specified if container id is
          specified)

          • Here Different Format*

          hdfs@host131:/opt/hadoop/bin> ./yarn queue
          15/03/26 00:13:06 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
          Invalid Command Usage :
          usage: queue
          -help Displays help for all commands.
          -status <Queue Name> List queue information about given queue.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thanks for taking a look into this issue..Yes, may be we can uniform like this but not only mapred, there are for yarn also hence I feel,can file separate jira to handle.. *Here as you mentioned * hdfs@host131:/hadoop/bin> ./yarn logs Retrieve logs for completed YARN applications. usage: yarn logs -applicationId <application ID> [OPTIONS] general options are: -appOwner <Application Owner> AppOwner (assumed to be current user if not specified) -containerId <Container ID> ContainerId (must be specified if node address is specified) -nodeAddress <Node Address> NodeAddress in the format nodename:port (must be specified if container id is specified) Here Different Format* hdfs@host131:/opt/hadoop/bin> ./yarn queue 15/03/26 00:13:06 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable Invalid Command Usage : usage: queue -help Displays help for all commands. -status <Queue Name> List queue information about given queue.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Kindly review the attached patch..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Kindly review the attached patch..
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12707198/MAPRED-6291-001.patch
          against trunk revision e556198.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          -1 eclipse:eclipse. The patch failed to build with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5336//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5336//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707198/MAPRED-6291-001.patch against trunk revision e556198. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. -1 eclipse:eclipse . The patch failed to build with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5336//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5336//console This message is automatically generated.
          Hide
          qwertymaniac Harsh J added a comment -

          Thanks again!

          -      System.out.println("bin/hadoop pipes");
          +      System.out.println("pipes");
          

          Just like was done for 'archives', can this carry "Usage: " prefix too? Other than this it looks good to me.

          Do we have identified YARN/etc. changes we want to also do? We could target them all in one go to reduce work, and move the JIRA to HADOOP?

          Show
          qwertymaniac Harsh J added a comment - Thanks again! - System .out.println( "bin/hadoop pipes" ); + System .out.println( "pipes" ); Just like was done for 'archives', can this carry "Usage: " prefix too? Other than this it looks good to me. Do we have identified YARN/etc. changes we want to also do? We could target them all in one go to reduce work, and move the JIRA to HADOOP?
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          I did not find for remaining commands and updated the patch for pipes usage..

          Show
          brahmareddy Brahma Reddy Battula added a comment - I did not find for remaining commands and updated the patch for pipes usage..
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12707524/MAPREDUCE-6291-002.patch
          against trunk revision 2228456.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-tools/hadoop-archives.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5339//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5339//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707524/MAPREDUCE-6291-002.patch against trunk revision 2228456. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-tools/hadoop-archives. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5339//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5339//console This message is automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          If no commands need to change then I think YARN-3398 can closed as 'Not a Problem' if you dont have any concern.

          Show
          rohithsharma Rohith Sharma K S added a comment - If no commands need to change then I think YARN-3398 can closed as 'Not a Problem' if you dont have any concern.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          YARN-3398 for unification of usage commands not for other commands correction...

          Show
          brahmareddy Brahma Reddy Battula added a comment - YARN-3398 for unification of usage commands not for other commands correction...
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          I think it is better to strict to Harsh J suggestion, all Hadoop script help message changes can go all together in one jira. I believe this will reduce work.

          Show
          rohithsharma Rohith Sharma K S added a comment - I think it is better to strict to Harsh J suggestion, all Hadoop script help message changes can go all together in one jira. I believe this will reduce work.
          Hide
          qwertymaniac Harsh J added a comment -

          Thanks Brahma! I've pushed this to branch-2 and trunk.

          Since you've already opened YARN-3398 for the yarn side of things, I'll await the changes there. In future though, feel free to combine relevant changes into a single JIRA to save us both some time for such focussed changes.

          Show
          qwertymaniac Harsh J added a comment - Thanks Brahma! I've pushed this to branch-2 and trunk. Since you've already opened YARN-3398 for the yarn side of things, I'll await the changes there. In future though, feel free to combine relevant changes into a single JIRA to save us both some time for such focussed changes.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7452 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7452/)
          MAPREDUCE-6291. Correct mapred queue usage command. Contributed by Brahma Reddy Battula. (harsh: rev 27d49e6714ad7fc6038bc001e70ff5be3755f1ef)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
          • hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobQueueClient.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/pipes/Submitter.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7452 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7452/ ) MAPREDUCE-6291 . Correct mapred queue usage command. Contributed by Brahma Reddy Battula. (harsh: rev 27d49e6714ad7fc6038bc001e70ff5be3755f1ef) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobQueueClient.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/pipes/Submitter.java
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thanks a lot for review and commit!!!!

          YARN-3398 for uniforming all the usage commands ( this defect to correct usage commands,i.e usage commands itself not present and if present also those are wrong)

          As I had seen usage commands for all not in sync...Hence filed yarn-3398

          Some are like following
          /yarn logs
          usage: yarn logs -applicationId <application ID> [OPTIONS]

          And some are like following..
          /yarn queue
          usage: queue

          Hence whether we should go with yarn <command> <args> or <command> <args>

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thanks a lot for review and commit!!!! YARN-3398 for uniforming all the usage commands ( this defect to correct usage commands,i.e usage commands itself not present and if present also those are wrong) As I had seen usage commands for all not in sync...Hence filed yarn-3398 Some are like following /yarn logs usage: yarn logs -applicationId <application ID> [OPTIONS] And some are like following.. /yarn queue usage: queue Hence whether we should go with yarn <command> <args> or <command> <args>
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #146 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/146/)
          MAPREDUCE-6291. Correct mapred queue usage command. Contributed by Brahma Reddy Battula. (harsh: rev 27d49e6714ad7fc6038bc001e70ff5be3755f1ef)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobQueueClient.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/pipes/Submitter.java
          • hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #146 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/146/ ) MAPREDUCE-6291 . Correct mapred queue usage command. Contributed by Brahma Reddy Battula. (harsh: rev 27d49e6714ad7fc6038bc001e70ff5be3755f1ef) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobQueueClient.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/pipes/Submitter.java hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #880 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/880/)
          MAPREDUCE-6291. Correct mapred queue usage command. Contributed by Brahma Reddy Battula. (harsh: rev 27d49e6714ad7fc6038bc001e70ff5be3755f1ef)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobQueueClient.java
          • hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/pipes/Submitter.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #880 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/880/ ) MAPREDUCE-6291 . Correct mapred queue usage command. Contributed by Brahma Reddy Battula. (harsh: rev 27d49e6714ad7fc6038bc001e70ff5be3755f1ef) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobQueueClient.java hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/pipes/Submitter.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #137 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/137/)
          MAPREDUCE-6291. Correct mapred queue usage command. Contributed by Brahma Reddy Battula. (harsh: rev 27d49e6714ad7fc6038bc001e70ff5be3755f1ef)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/pipes/Submitter.java
          • hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobQueueClient.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #137 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/137/ ) MAPREDUCE-6291 . Correct mapred queue usage command. Contributed by Brahma Reddy Battula. (harsh: rev 27d49e6714ad7fc6038bc001e70ff5be3755f1ef) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/pipes/Submitter.java hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobQueueClient.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #146 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/146/)
          MAPREDUCE-6291. Correct mapred queue usage command. Contributed by Brahma Reddy Battula. (harsh: rev 27d49e6714ad7fc6038bc001e70ff5be3755f1ef)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
          • hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/pipes/Submitter.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobQueueClient.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #146 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/146/ ) MAPREDUCE-6291 . Correct mapred queue usage command. Contributed by Brahma Reddy Battula. (harsh: rev 27d49e6714ad7fc6038bc001e70ff5be3755f1ef) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/pipes/Submitter.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobQueueClient.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2096 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2096/)
          MAPREDUCE-6291. Correct mapred queue usage command. Contributed by Brahma Reddy Battula. (harsh: rev 27d49e6714ad7fc6038bc001e70ff5be3755f1ef)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobQueueClient.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/pipes/Submitter.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2096 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2096/ ) MAPREDUCE-6291 . Correct mapred queue usage command. Contributed by Brahma Reddy Battula. (harsh: rev 27d49e6714ad7fc6038bc001e70ff5be3755f1ef) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobQueueClient.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/pipes/Submitter.java hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2078 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2078/)
          MAPREDUCE-6291. Correct mapred queue usage command. Contributed by Brahma Reddy Battula. (harsh: rev 27d49e6714ad7fc6038bc001e70ff5be3755f1ef)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/pipes/Submitter.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobQueueClient.java
          • hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2078 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2078/ ) MAPREDUCE-6291 . Correct mapred queue usage command. Contributed by Brahma Reddy Battula. (harsh: rev 27d49e6714ad7fc6038bc001e70ff5be3755f1ef) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/pipes/Submitter.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobQueueClient.java hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
          Hide
          vvasudev Varun Vasudev added a comment -

          The change -

          -      System.out.println("bin/hadoop pipes");
          +      System.out.println("Usage: pipes ");
          

          is leading to the TestPipeApplication#testSubmitter test failing.

          The test specifically looks for -

          assertTrue(out.toString(), out.toString().contains("bin/hadoop pipes"));
          

          Reopening issue; Brahma Reddy Battula, Harsh J - can you guys please fix?

          Show
          vvasudev Varun Vasudev added a comment - The change - - System.out.println("bin/hadoop pipes"); + System.out.println("Usage: pipes "); is leading to the TestPipeApplication#testSubmitter test failing. The test specifically looks for - assertTrue(out.toString(), out.toString().contains("bin/hadoop pipes")); Reopening issue; Brahma Reddy Battula , Harsh J - can you guys please fix?
          Hide
          vvasudev Varun Vasudev added a comment -

          Sorry - the test looks for

          assertTrue(out.toString().contains("bin/hadoop pipes"));
          

          .

          I added the message when trying to debug the issue.

          Show
          vvasudev Varun Vasudev added a comment - Sorry - the test looks for assertTrue(out.toString().contains("bin/hadoop pipes")); . I added the message when trying to debug the issue.
          Hide
          qwertymaniac Harsh J added a comment -

          Varun Vasudev - Thanks for reporting this. Unfortunate that the tests here couldn't capture that. Can you file a new JIRA with the test changed as a patch?

          Show
          qwertymaniac Harsh J added a comment - Varun Vasudev - Thanks for reporting this. Unfortunate that the tests here couldn't capture that. Can you file a new JIRA with the test changed as a patch?
          Hide
          vvasudev Varun Vasudev added a comment -
          Show
          vvasudev Varun Vasudev added a comment - Filed MAPREDUCE-6314
          Hide
          qwertymaniac Harsh J added a comment -

          Thanks, re-closing.

          Show
          qwertymaniac Harsh J added a comment - Thanks, re-closing.

            People

            • Assignee:
              brahmareddy Brahma Reddy Battula
              Reporter:
              brahmareddy Brahma Reddy Battula
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development