Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6286

A typo in HistoryViewer makes some code useless, which causes counter limits are not reset correctly.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.6.0
    • Fix Version/s: None
    • Component/s: client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      A typo in HistoryViewer makes some code useless and it causes counter limits are not reset correctly.
      The typo is
      Limits.reset(conf);
      We should use jobConf instead of conf.
      With the typo, the following code becomes useless:

            final Path jobConfPath = new Path(jobFile.getParent(),  jobDetails[0]
                + "_" + jobDetails[1] + "_" + jobDetails[2] + "_conf.xml");
            final Configuration jobConf = new Configuration(conf);
              jobConf.addResource(fs.open(jobConfPath), jobConfPath.toString());
      

      The code wants to load the configuration from the Job configuration file and reset the Limits based on the new configuration loaded from the Job configuration file. But with the typo, the Limits are reset with the old configuration.
      So this typo is apparent.

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12706131/MAPREDUCE-6286.000.patch
          against trunk revision e1feb4e.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5323//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5323//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12706131/MAPREDUCE-6286.000.patch against trunk revision e1feb4e. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5323//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5323//console This message is automatically generated.
          Hide
          qwertymaniac Harsh J added a comment -

          +1, nice catch. Committing shortly. Thanks Zhihai!

          Show
          qwertymaniac Harsh J added a comment - +1, nice catch. Committing shortly. Thanks Zhihai!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7395 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7395/)
          MAPREDUCE-6286. A typo in HistoryViewer makes some code useless, which causes counter limits are not reset correctly. Contributed by Zhihai Xu. (harsh: rev 433542904aba5ddebf9bd9d299378647351eb13a)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7395 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7395/ ) MAPREDUCE-6286 . A typo in HistoryViewer makes some code useless, which causes counter limits are not reset correctly. Contributed by Zhihai Xu. (harsh: rev 433542904aba5ddebf9bd9d299378647351eb13a) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          zxu zhihai xu added a comment -

          Harsh J, many thanks for reviewing and committing the patch!

          Show
          zxu zhihai xu added a comment - Harsh J , many thanks for reviewing and committing the patch!
          Hide
          jira.shegalov Gera Shegalov added a comment -

          +1, Thanks for spotting the bug, zhihai xu!

          Harsh J, do you mind committing to branch-2.7 as well? It looks like a safe change.

          Show
          jira.shegalov Gera Shegalov added a comment - +1, Thanks for spotting the bug, zhihai xu ! Harsh J , do you mind committing to branch-2.7 as well? It looks like a safe change.
          Hide
          qwertymaniac Harsh J added a comment -

          Sure. Pushed into 2.7.0 (amended CHANGES.txt in trunk and branch-2 too).

          Show
          qwertymaniac Harsh J added a comment - Sure. Pushed into 2.7.0 (amended CHANGES.txt in trunk and branch-2 too).
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7398 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7398/)
          MAPREDUCE-6286. Amend commit to CHANGES.txt for backport into 2.7.0. (harsh: rev 8770c82acc948bc5127afb1c59072718fd04630c)

          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7398 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7398/ ) MAPREDUCE-6286 . Amend commit to CHANGES.txt for backport into 2.7.0. (harsh: rev 8770c82acc948bc5127afb1c59072718fd04630c) hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #140 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/140/)
          MAPREDUCE-6286. A typo in HistoryViewer makes some code useless, which causes counter limits are not reset correctly. Contributed by Zhihai Xu. (harsh: rev 433542904aba5ddebf9bd9d299378647351eb13a)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java
            MAPREDUCE-6286. Amend commit to CHANGES.txt for backport into 2.7.0. (harsh: rev 8770c82acc948bc5127afb1c59072718fd04630c)
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #140 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/140/ ) MAPREDUCE-6286 . A typo in HistoryViewer makes some code useless, which causes counter limits are not reset correctly. Contributed by Zhihai Xu. (harsh: rev 433542904aba5ddebf9bd9d299378647351eb13a) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java MAPREDUCE-6286 . Amend commit to CHANGES.txt for backport into 2.7.0. (harsh: rev 8770c82acc948bc5127afb1c59072718fd04630c) hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #874 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/874/)
          MAPREDUCE-6286. A typo in HistoryViewer makes some code useless, which causes counter limits are not reset correctly. Contributed by Zhihai Xu. (harsh: rev 433542904aba5ddebf9bd9d299378647351eb13a)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java
          • hadoop-mapreduce-project/CHANGES.txt
            MAPREDUCE-6286. Amend commit to CHANGES.txt for backport into 2.7.0. (harsh: rev 8770c82acc948bc5127afb1c59072718fd04630c)
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #874 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/874/ ) MAPREDUCE-6286 . A typo in HistoryViewer makes some code useless, which causes counter limits are not reset correctly. Contributed by Zhihai Xu. (harsh: rev 433542904aba5ddebf9bd9d299378647351eb13a) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java hadoop-mapreduce-project/CHANGES.txt MAPREDUCE-6286 . Amend commit to CHANGES.txt for backport into 2.7.0. (harsh: rev 8770c82acc948bc5127afb1c59072718fd04630c) hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2072 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2072/)
          MAPREDUCE-6286. A typo in HistoryViewer makes some code useless, which causes counter limits are not reset correctly. Contributed by Zhihai Xu. (harsh: rev 433542904aba5ddebf9bd9d299378647351eb13a)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java
            MAPREDUCE-6286. Amend commit to CHANGES.txt for backport into 2.7.0. (harsh: rev 8770c82acc948bc5127afb1c59072718fd04630c)
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2072 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2072/ ) MAPREDUCE-6286 . A typo in HistoryViewer makes some code useless, which causes counter limits are not reset correctly. Contributed by Zhihai Xu. (harsh: rev 433542904aba5ddebf9bd9d299378647351eb13a) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java MAPREDUCE-6286 . Amend commit to CHANGES.txt for backport into 2.7.0. (harsh: rev 8770c82acc948bc5127afb1c59072718fd04630c) hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #131 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/131/)
          MAPREDUCE-6286. A typo in HistoryViewer makes some code useless, which causes counter limits are not reset correctly. Contributed by Zhihai Xu. (harsh: rev 433542904aba5ddebf9bd9d299378647351eb13a)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java
            MAPREDUCE-6286. Amend commit to CHANGES.txt for backport into 2.7.0. (harsh: rev 8770c82acc948bc5127afb1c59072718fd04630c)
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #131 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/131/ ) MAPREDUCE-6286 . A typo in HistoryViewer makes some code useless, which causes counter limits are not reset correctly. Contributed by Zhihai Xu. (harsh: rev 433542904aba5ddebf9bd9d299378647351eb13a) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java MAPREDUCE-6286 . Amend commit to CHANGES.txt for backport into 2.7.0. (harsh: rev 8770c82acc948bc5127afb1c59072718fd04630c) hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #140 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/140/)
          MAPREDUCE-6286. A typo in HistoryViewer makes some code useless, which causes counter limits are not reset correctly. Contributed by Zhihai Xu. (harsh: rev 433542904aba5ddebf9bd9d299378647351eb13a)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java
            MAPREDUCE-6286. Amend commit to CHANGES.txt for backport into 2.7.0. (harsh: rev 8770c82acc948bc5127afb1c59072718fd04630c)
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #140 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/140/ ) MAPREDUCE-6286 . A typo in HistoryViewer makes some code useless, which causes counter limits are not reset correctly. Contributed by Zhihai Xu. (harsh: rev 433542904aba5ddebf9bd9d299378647351eb13a) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java MAPREDUCE-6286 . Amend commit to CHANGES.txt for backport into 2.7.0. (harsh: rev 8770c82acc948bc5127afb1c59072718fd04630c) hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2090 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2090/)
          MAPREDUCE-6286. A typo in HistoryViewer makes some code useless, which causes counter limits are not reset correctly. Contributed by Zhihai Xu. (harsh: rev 433542904aba5ddebf9bd9d299378647351eb13a)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java
          • hadoop-mapreduce-project/CHANGES.txt
            MAPREDUCE-6286. Amend commit to CHANGES.txt for backport into 2.7.0. (harsh: rev 8770c82acc948bc5127afb1c59072718fd04630c)
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2090 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2090/ ) MAPREDUCE-6286 . A typo in HistoryViewer makes some code useless, which causes counter limits are not reset correctly. Contributed by Zhihai Xu. (harsh: rev 433542904aba5ddebf9bd9d299378647351eb13a) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java hadoop-mapreduce-project/CHANGES.txt MAPREDUCE-6286 . Amend commit to CHANGES.txt for backport into 2.7.0. (harsh: rev 8770c82acc948bc5127afb1c59072718fd04630c) hadoop-mapreduce-project/CHANGES.txt
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Removed this from 2.7.0. See the discussion on MAPREDUCE-6288.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Removed this from 2.7.0. See the discussion on MAPREDUCE-6288 .
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7478 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7478/)
          Reverted MAPREDUCE-6286, MAPREDUCE-6199, and MAPREDUCE-5875 from branch-2.7. Editing CHANGES.txt to reflect this. (vinodkv: rev e428fea73029ea0c3494c71a50c5f6c994888fd2)

          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7478 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7478/ ) Reverted MAPREDUCE-6286 , MAPREDUCE-6199 , and MAPREDUCE-5875 from branch-2.7. Editing CHANGES.txt to reflect this. (vinodkv: rev e428fea73029ea0c3494c71a50c5f6c994888fd2) hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #150 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/150/)
          Reverted MAPREDUCE-6286, MAPREDUCE-6199, and MAPREDUCE-5875 from branch-2.7. Editing CHANGES.txt to reflect this. (vinodkv: rev e428fea73029ea0c3494c71a50c5f6c994888fd2)

          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #150 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/150/ ) Reverted MAPREDUCE-6286 , MAPREDUCE-6199 , and MAPREDUCE-5875 from branch-2.7. Editing CHANGES.txt to reflect this. (vinodkv: rev e428fea73029ea0c3494c71a50c5f6c994888fd2) hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #884 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/884/)
          Reverted MAPREDUCE-6286, MAPREDUCE-6199, and MAPREDUCE-5875 from branch-2.7. Editing CHANGES.txt to reflect this. (vinodkv: rev e428fea73029ea0c3494c71a50c5f6c994888fd2)

          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #884 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/884/ ) Reverted MAPREDUCE-6286 , MAPREDUCE-6199 , and MAPREDUCE-5875 from branch-2.7. Editing CHANGES.txt to reflect this. (vinodkv: rev e428fea73029ea0c3494c71a50c5f6c994888fd2) hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2082 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2082/)
          Reverted MAPREDUCE-6286, MAPREDUCE-6199, and MAPREDUCE-5875 from branch-2.7. Editing CHANGES.txt to reflect this. (vinodkv: rev e428fea73029ea0c3494c71a50c5f6c994888fd2)

          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2082 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2082/ ) Reverted MAPREDUCE-6286 , MAPREDUCE-6199 , and MAPREDUCE-5875 from branch-2.7. Editing CHANGES.txt to reflect this. (vinodkv: rev e428fea73029ea0c3494c71a50c5f6c994888fd2) hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #150 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/150/)
          Reverted MAPREDUCE-6286, MAPREDUCE-6199, and MAPREDUCE-5875 from branch-2.7. Editing CHANGES.txt to reflect this. (vinodkv: rev e428fea73029ea0c3494c71a50c5f6c994888fd2)

          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #150 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/150/ ) Reverted MAPREDUCE-6286 , MAPREDUCE-6199 , and MAPREDUCE-5875 from branch-2.7. Editing CHANGES.txt to reflect this. (vinodkv: rev e428fea73029ea0c3494c71a50c5f6c994888fd2) hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #141 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/141/)
          Reverted MAPREDUCE-6286, MAPREDUCE-6199, and MAPREDUCE-5875 from branch-2.7. Editing CHANGES.txt to reflect this. (vinodkv: rev e428fea73029ea0c3494c71a50c5f6c994888fd2)

          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #141 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/141/ ) Reverted MAPREDUCE-6286 , MAPREDUCE-6199 , and MAPREDUCE-5875 from branch-2.7. Editing CHANGES.txt to reflect this. (vinodkv: rev e428fea73029ea0c3494c71a50c5f6c994888fd2) hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2100 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2100/)
          Reverted MAPREDUCE-6286, MAPREDUCE-6199, and MAPREDUCE-5875 from branch-2.7. Editing CHANGES.txt to reflect this. (vinodkv: rev e428fea73029ea0c3494c71a50c5f6c994888fd2)

          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2100 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2100/ ) Reverted MAPREDUCE-6286 , MAPREDUCE-6199 , and MAPREDUCE-5875 from branch-2.7. Editing CHANGES.txt to reflect this. (vinodkv: rev e428fea73029ea0c3494c71a50c5f6c994888fd2) hadoop-mapreduce-project/CHANGES.txt
          Hide
          qwertymaniac Harsh J added a comment -

          Reopening this to set the right resolution state. Since the fix was reverted and never added back (does not exist on trunk), the Fixed resolution is incorrect.

          Show
          qwertymaniac Harsh J added a comment - Reopening this to set the right resolution state. Since the fix was reverted and never added back (does not exist on trunk), the Fixed resolution is incorrect.
          Hide
          qwertymaniac Harsh J added a comment -

          Uh sorry, the commit message timeline is confusing on this. This is indeed present in the trunk and branch-2.8/branch-2, was only reverted in branch-2.7. My bad - sorry for the noise - the addendum vs. 2.7 notes confused me

          Resetting to earlier state.

          Show
          qwertymaniac Harsh J added a comment - Uh sorry, the commit message timeline is confusing on this. This is indeed present in the trunk and branch-2.8/branch-2, was only reverted in branch-2.7. My bad - sorry for the noise - the addendum vs. 2.7 notes confused me Resetting to earlier state.
          Hide
          djp Junping Du added a comment -

          Revert it from branch-2.8 given we revert MAPREDUCE-5875 per discussion in MAPREDUCE-6288.

          Show
          djp Junping Du added a comment - Revert it from branch-2.8 given we revert MAPREDUCE-5875 per discussion in MAPREDUCE-6288 .
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12071 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12071/)
          Revert "MAPREDUCE-6286. A typo in HistoryViewer makes some code useless, (junping_du: rev e15f92829558cc4a30b10f2fccfd17c2f8088003)

          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12071 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12071/ ) Revert " MAPREDUCE-6286 . A typo in HistoryViewer makes some code useless, (junping_du: rev e15f92829558cc4a30b10f2fccfd17c2f8088003) (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java
          Hide
          djp Junping Du added a comment -

          MAPREDUCE-5875 is revert, so patch here is not needed. reopen and resolve it as won't fix.

          Show
          djp Junping Du added a comment - MAPREDUCE-5875 is revert, so patch here is not needed. reopen and resolve it as won't fix.

            People

            • Assignee:
              zxu zhihai xu
              Reporter:
              zxu zhihai xu
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development