Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6286

A typo in HistoryViewer makes some code useless, which causes counter limits are not reset correctly.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.6.0
    • Fix Version/s: None
    • Component/s: client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      A typo in HistoryViewer makes some code useless and it causes counter limits are not reset correctly.
      The typo is
      Limits.reset(conf);
      We should use jobConf instead of conf.
      With the typo, the following code becomes useless:

            final Path jobConfPath = new Path(jobFile.getParent(),  jobDetails[0]
                + "_" + jobDetails[1] + "_" + jobDetails[2] + "_conf.xml");
            final Configuration jobConf = new Configuration(conf);
              jobConf.addResource(fs.open(jobConfPath), jobConfPath.toString());
      

      The code wants to load the configuration from the Job configuration file and reset the Limits based on the new configuration loaded from the Job configuration file. But with the typo, the Limits are reset with the old configuration.
      So this typo is apparent.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                zxu zhihai xu
                Reporter:
                zxu zhihai xu
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: