Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6279

AM should explicity exit JVM after all services have stopped

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Occasionally the MapReduce AM can "get stuck" trying to shut down. MAPREDUCE-6049 and MAPREDUCE-5888 were specific instances that have been fixed, but this can also occur with uber jobs if the task code inadvertently leaves non-daemon threads lingering.

      We should explicitly shutdown the JVM after the MapReduce AM has unregistered and all services have been stopped.

      1. MAPREDUCE-6279.v4.patch
        6 kB
        Eric Payne
      2. MAPREDUCE-6279.v3.patch
        6 kB
        Eric Payne
      3. MAPREDUCE-6279.v2.txt
        6 kB
        Eric Payne
      4. MAPREDUCE-6279.v1.txt
        1 kB
        Eric Payne

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #189 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/189/)
        MAPREDUCE-6279. AM should explicity exit JVM after all services have stopped. Contributed by Eric Payne (jlowe: rev f30065c8b6099372f57015b505434120fe83c2b0)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #189 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/189/ ) MAPREDUCE-6279 . AM should explicity exit JVM after all services have stopped. Contributed by Eric Payne (jlowe: rev f30065c8b6099372f57015b505434120fe83c2b0) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2137 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2137/)
        MAPREDUCE-6279. AM should explicity exit JVM after all services have stopped. Contributed by Eric Payne (jlowe: rev f30065c8b6099372f57015b505434120fe83c2b0)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2137 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2137/ ) MAPREDUCE-6279 . AM should explicity exit JVM after all services have stopped. Contributed by Eric Payne (jlowe: rev f30065c8b6099372f57015b505434120fe83c2b0) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #179 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/179/)
        MAPREDUCE-6279. AM should explicity exit JVM after all services have stopped. Contributed by Eric Payne (jlowe: rev f30065c8b6099372f57015b505434120fe83c2b0)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #179 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/179/ ) MAPREDUCE-6279 . AM should explicity exit JVM after all services have stopped. Contributed by Eric Payne (jlowe: rev f30065c8b6099372f57015b505434120fe83c2b0) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2119 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2119/)
        MAPREDUCE-6279. AM should explicity exit JVM after all services have stopped. Contributed by Eric Payne (jlowe: rev f30065c8b6099372f57015b505434120fe83c2b0)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2119 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2119/ ) MAPREDUCE-6279 . AM should explicity exit JVM after all services have stopped. Contributed by Eric Payne (jlowe: rev f30065c8b6099372f57015b505434120fe83c2b0) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/190/)
        MAPREDUCE-6279. AM should explicity exit JVM after all services have stopped. Contributed by Eric Payne (jlowe: rev f30065c8b6099372f57015b505434120fe83c2b0)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/190/ ) MAPREDUCE-6279 . AM should explicity exit JVM after all services have stopped. Contributed by Eric Payne (jlowe: rev f30065c8b6099372f57015b505434120fe83c2b0) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #921 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/921/)
        MAPREDUCE-6279. AM should explicity exit JVM after all services have stopped. Contributed by Eric Payne (jlowe: rev f30065c8b6099372f57015b505434120fe83c2b0)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #921 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/921/ ) MAPREDUCE-6279 . AM should explicity exit JVM after all services have stopped. Contributed by Eric Payne (jlowe: rev f30065c8b6099372f57015b505434120fe83c2b0) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #7763 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7763/)
        MAPREDUCE-6279. AM should explicity exit JVM after all services have stopped. Contributed by Eric Payne (jlowe: rev f30065c8b6099372f57015b505434120fe83c2b0)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #7763 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7763/ ) MAPREDUCE-6279 . AM should explicity exit JVM after all services have stopped. Contributed by Eric Payne (jlowe: rev f30065c8b6099372f57015b505434120fe83c2b0) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java
        Hide
        jlowe Jason Lowe added a comment -

        Thanks, Eric! I committed this to trunk and branch-2.

        Show
        jlowe Jason Lowe added a comment - Thanks, Eric! I committed this to trunk and branch-2.
        Hide
        jlowe Jason Lowe added a comment -

        +1 lgtm. Committing this.

        Show
        jlowe Jason Lowe added a comment - +1 lgtm. Committing this.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 33s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 37s There were no new javac warning messages.
        +1 javadoc 10m 0s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 39s There were no new checkstyle issues.
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 52s mvn install still works.
        +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse.
        +1 findbugs 1m 15s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 mapreduce tests 13m 8s Tests passed in hadoop-mapreduce-client-app.
            52m 12s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12730530/MAPREDUCE-6279.v4.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 05adc76
        hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5645/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5645/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5645/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 33s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 37s There were no new javac warning messages. +1 javadoc 10m 0s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 39s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 52s mvn install still works. +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse. +1 findbugs 1m 15s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 mapreduce tests 13m 8s Tests passed in hadoop-mapreduce-client-app.     52m 12s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12730530/MAPREDUCE-6279.v4.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 05adc76 hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5645/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5645/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5645/console This message was automatically generated.
        Hide
        eepayne Eric Payne added a comment -

        Fixing whitespace errors.

        Show
        eepayne Eric Payne added a comment - Fixing whitespace errors.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 35s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 30s There were no new javac warning messages.
        +1 javadoc 9m 36s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 34s There were no new checkstyle issues.
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 0m 58s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 mapreduce tests 9m 30s Tests passed in hadoop-mapreduce-client-app.
            45m 22s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12730255/MAPREDUCE-6279.v3.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 3fe79e1
        whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5637/artifact/patchprocess/whitespace.txt
        hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5637/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5637/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5637/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 35s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 34s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 58s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 mapreduce tests 9m 30s Tests passed in hadoop-mapreduce-client-app.     45m 22s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12730255/MAPREDUCE-6279.v3.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 3fe79e1 whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5637/artifact/patchprocess/whitespace.txt hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5637/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5637/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5637/console This message was automatically generated.
        Hide
        eepayne Eric Payne added a comment -

        Version 3 has the .patch extension.

        Show
        eepayne Eric Payne added a comment - Version 3 has the .patch extension.
        Hide
        eepayne Eric Payne added a comment -

        Re-uploading version 2 of the patch and re-submitting the patch in order to kick the build.

        Show
        eepayne Eric Payne added a comment - Re-uploading version 2 of the patch and re-submitting the patch in order to kick the build.
        Hide
        eepayne Eric Payne added a comment -

        Jason Lowe, thank you very much for your help on this patch.

        The way the first patch was written, it caused many of the tests in hadoop-mapreduce-client-app to fail because they are instantiating the MRAppMaster object and invoking shutDownJob (either directly or inderectly through JobFinishEventHandler) without actually starting the main thread of MRAppMaster.

        In order to alleviate the need to modify several tests, version 2 of the patch puts the ExitUtil object into "test" mode if the MRAppMaster main thread has not been started.

        Show
        eepayne Eric Payne added a comment - Jason Lowe , thank you very much for your help on this patch. The way the first patch was written, it caused many of the tests in hadoop-mapreduce-client-app to fail because they are instantiating the MRAppMaster object and invoking shutDownJob (either directly or inderectly through JobFinishEventHandler ) without actually starting the main thread of MRAppMaster . In order to alleviate the need to modify several tests, version 2 of the patch puts the ExitUtil object into "test" mode if the MRAppMaster main thread has not been started.
        Hide
        jlowe Jason Lowe added a comment -

        Thanks for picking this up, Eric! Sorry for the long delay.

        are unit tests necessary for this change?

        It would be nice to add a unit test to verify we try to exit during normal operations. It should be relatively straightforward to add one to TestMRAppMaster, as ExitUtil has convenience functions for determining if it was called and if so with what exception. If it ends up being too complicated then don't bother, but at a glance it appears it would be easy to add.

        Show
        jlowe Jason Lowe added a comment - Thanks for picking this up, Eric! Sorry for the long delay. are unit tests necessary for this change? It would be nice to add a unit test to verify we try to exit during normal operations. It should be relatively straightforward to add one to TestMRAppMaster, as ExitUtil has convenience functions for determining if it was called and if so with what exception. If it ends up being too complicated then don't bother, but at a glance it appears it would be easy to add.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12707896/MAPREDUCE-6279.v1.txt
        against trunk revision 3836ad6.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app:

        org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler

        The following test timeouts occurred in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app:

        org.apache.hadoop.mapreduce.v2.app.TestStagingCleanup
        org.apache.hadoop.mapreduce.v2.app.TestJobEndNotifier

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5345//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5345//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707896/MAPREDUCE-6279.v1.txt against trunk revision 3836ad6. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app: org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler The following test timeouts occurred in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app: org.apache.hadoop.mapreduce.v2.app.TestStagingCleanup org.apache.hadoop.mapreduce.v2.app.TestJobEndNotifier Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5345//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5345//console This message is automatically generated.
        Hide
        eepayne Eric Payne added a comment -

        Jason Lowe, are unit tests necessary for this change?

        Show
        eepayne Eric Payne added a comment - Jason Lowe , are unit tests necessary for this change?

          People

          • Assignee:
            eepayne Eric Payne
            Reporter:
            jlowe Jason Lowe
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development