Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: scripts
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Functionality has been moved to bin/mapred.

      1. MAPREDUCE-6250-00.patch
        0.6 kB
        Allen Wittenauer

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #97 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/97/)
          MAPREDUCE-6250. deprecate sbin/mr-jobhistory-daemon.sh (aw) (aw: rev 6f5290b0309c0d06a7e05f64354ca0c1fb5a4676)

          • hadoop-mapreduce-project/bin/mr-jobhistory-daemon.sh
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #97 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/97/ ) MAPREDUCE-6250 . deprecate sbin/mr-jobhistory-daemon.sh (aw) (aw: rev 6f5290b0309c0d06a7e05f64354ca0c1fb5a4676) hadoop-mapreduce-project/bin/mr-jobhistory-daemon.sh hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2054 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2054/)
          MAPREDUCE-6250. deprecate sbin/mr-jobhistory-daemon.sh (aw) (aw: rev 6f5290b0309c0d06a7e05f64354ca0c1fb5a4676)

          • hadoop-mapreduce-project/bin/mr-jobhistory-daemon.sh
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2054 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2054/ ) MAPREDUCE-6250 . deprecate sbin/mr-jobhistory-daemon.sh (aw) (aw: rev 6f5290b0309c0d06a7e05f64354ca0c1fb5a4676) hadoop-mapreduce-project/bin/mr-jobhistory-daemon.sh hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #104 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/104/)
          MAPREDUCE-6250. deprecate sbin/mr-jobhistory-daemon.sh (aw) (aw: rev 6f5290b0309c0d06a7e05f64354ca0c1fb5a4676)

          • hadoop-mapreduce-project/bin/mr-jobhistory-daemon.sh
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #104 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/104/ ) MAPREDUCE-6250 . deprecate sbin/mr-jobhistory-daemon.sh (aw) (aw: rev 6f5290b0309c0d06a7e05f64354ca0c1fb5a4676) hadoop-mapreduce-project/bin/mr-jobhistory-daemon.sh hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2035 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2035/)
          MAPREDUCE-6250. deprecate sbin/mr-jobhistory-daemon.sh (aw) (aw: rev 6f5290b0309c0d06a7e05f64354ca0c1fb5a4676)

          • hadoop-mapreduce-project/bin/mr-jobhistory-daemon.sh
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2035 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2035/ ) MAPREDUCE-6250 . deprecate sbin/mr-jobhistory-daemon.sh (aw) (aw: rev 6f5290b0309c0d06a7e05f64354ca0c1fb5a4676) hadoop-mapreduce-project/bin/mr-jobhistory-daemon.sh hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #837 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/837/)
          MAPREDUCE-6250. deprecate sbin/mr-jobhistory-daemon.sh (aw) (aw: rev 6f5290b0309c0d06a7e05f64354ca0c1fb5a4676)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/bin/mr-jobhistory-daemon.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #837 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/837/ ) MAPREDUCE-6250 . deprecate sbin/mr-jobhistory-daemon.sh (aw) (aw: rev 6f5290b0309c0d06a7e05f64354ca0c1fb5a4676) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/bin/mr-jobhistory-daemon.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #103 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/103/)
          MAPREDUCE-6250. deprecate sbin/mr-jobhistory-daemon.sh (aw) (aw: rev 6f5290b0309c0d06a7e05f64354ca0c1fb5a4676)

          • hadoop-mapreduce-project/bin/mr-jobhistory-daemon.sh
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #103 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/103/ ) MAPREDUCE-6250 . deprecate sbin/mr-jobhistory-daemon.sh (aw) (aw: rev 6f5290b0309c0d06a7e05f64354ca0c1fb5a4676) hadoop-mapreduce-project/bin/mr-jobhistory-daemon.sh hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #7094 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7094/)
          MAPREDUCE-6250. deprecate sbin/mr-jobhistory-daemon.sh (aw) (aw: rev 6f5290b0309c0d06a7e05f64354ca0c1fb5a4676)

          • hadoop-mapreduce-project/bin/mr-jobhistory-daemon.sh
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #7094 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7094/ ) MAPREDUCE-6250 . deprecate sbin/mr-jobhistory-daemon.sh (aw) (aw: rev 6f5290b0309c0d06a7e05f64354ca0c1fb5a4676) hadoop-mapreduce-project/bin/mr-jobhistory-daemon.sh hadoop-mapreduce-project/CHANGES.txt
          Hide
          aw Allen Wittenauer added a comment -

          Thanks for the review!

          Committed to trunk.

          Show
          aw Allen Wittenauer added a comment - Thanks for the review! Committed to trunk.
          Hide
          cnauroth Chris Nauroth added a comment -

          +1 for the patch. Thank you, Allen.

          The test warning from Jenkins isn't relevant, because Jenkins doesn't run tests on the shell code.

          Show
          cnauroth Chris Nauroth added a comment - +1 for the patch. Thank you, Allen. The test warning from Jenkins isn't relevant, because Jenkins doesn't run tests on the shell code.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12697863/MAPREDUCE-6250-00.patch
          against trunk revision e9d26fe.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5181//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5181//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12697863/MAPREDUCE-6250-00.patch against trunk revision e9d26fe. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5181//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5181//console This message is automatically generated.
          Hide
          aw Allen Wittenauer added a comment - - edited

          It isn't hard-coded today for backwards compatibility. In other words, branch-2 is invoked like this:

          sbin/mr-jobhistory-daemon.sh start historyserver 
          

          (See http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/ClusterSetup.html . It's worth noting that putting --config at the end of line doesn't actually work though in branch-2. Love that doc bug. It doesn't work in trunk either, but the docs have been fixed...)

          I can certainly strip out historyserver from the command line options if you want.

          Show
          aw Allen Wittenauer added a comment - - edited It isn't hard-coded today for backwards compatibility. In other words, branch-2 is invoked like this: sbin/mr-jobhistory-daemon.sh start historyserver (See http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/ClusterSetup.html . It's worth noting that putting --config at the end of line doesn't actually work though in branch-2. Love that doc bug. It doesn't work in trunk either, but the docs have been fixed...) I can certainly strip out historyserver from the command line options if you want.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Okay, that helps. Will go look at that JIRA.

          Not sure which patch does this, but given your pattern above, for mapred it should be something like "mapred --daemon start jobhistoryserver". I'd like to make it explicit.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Okay, that helps. Will go look at that JIRA. Not sure which patch does this, but given your pattern above, for mapred it should be something like "mapred --daemon start jobhistoryserver". I'd like to make it explicit.
          Hide
          aw Allen Wittenauer added a comment - - edited

          Yup, that's the pattern.

          For example, after committing HADOOP-11565, my startup looks like this:

          $ hadoop --slaves version | grep repo
          $ hdfs namenode -format
          $ hdfs --daemon start namenode
          $ hdfs --slaves --daemon start datanode
          $ yarn --daemon start resourcemanager
          $ yarn --daemon start proxyserver
          $ yarn --slaves --daemon start nodemanager
          

          Of course, you can do fancier things now that all of the – options are supported on slaves.... (i.e., yarn --slaves --hosts="proxyhost" --daemon start --config /my/customfig --debug proxyserver will start the proxyserver on the host proxyhost with the custom config in debug mode.)

          I need to fix sbin/(start|stop) yet, but they'll turn into wrappers around these commands, eliminating about 4 levels of shell indirection vs. branch-2...

          Show
          aw Allen Wittenauer added a comment - - edited Yup, that's the pattern. For example, after committing HADOOP-11565 , my startup looks like this: $ hadoop --slaves version | grep repo $ hdfs namenode -format $ hdfs --daemon start namenode $ hdfs --slaves --daemon start datanode $ yarn --daemon start resourcemanager $ yarn --daemon start proxyserver $ yarn --slaves --daemon start nodemanager Of course, you can do fancier things now that all of the – options are supported on slaves.... (i.e., yarn --slaves --hosts="proxyhost" --daemon start --config /my/customfig --debug proxyserver will start the proxyserver on the host proxyhost with the custom config in debug mode.) I need to fix sbin/(start|stop) yet, but they'll turn into wrappers around these commands, eliminating about 4 levels of shell indirection vs. branch-2...
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Is "<script-name> --daemon $

          {daemonmode}

          " the suggest approach for all sub-project/module? What is the pattern for modules with multiple daemons?

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Is "<script-name> --daemon $ {daemonmode} " the suggest approach for all sub-project/module? What is the pattern for modules with multiple daemons?
          Hide
          aw Allen Wittenauer added a comment -

          -00:

          • Initial version
          Show
          aw Allen Wittenauer added a comment - -00: Initial version

            People

            • Assignee:
              aw Allen Wittenauer
              Reporter:
              aw Allen Wittenauer
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development