Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6239

Consolidate TestJobConf classes in hadoop-mapreduce-client-jobclient and hadoop-mapreduce-client-core

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. MAPREDUCE-6239.01.patch
      16 kB
      Varun Saxena
    2. MAPREDUCE-6239.branch-2.patch
      16 kB
      Varun Saxena

      Activity

      Hide
      hadoopqa Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12706036/MAPREDUCE-6239.01.patch
      against trunk revision 586348e.

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 1 new or modified test files.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. There were no new javadoc warning messages.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

      org.apache.hadoop.mapreduce.TestMapReduceLazyOutput

      Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5320//testReport/
      Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5320//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12706036/MAPREDUCE-6239.01.patch against trunk revision 586348e. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.mapreduce.TestMapReduceLazyOutput Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5320//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5320//console This message is automatically generated.
      Hide
      qwertymaniac Harsh J added a comment -

      Thanks Varun, +1 for trunk.

      Does not apply for branch-2, however. Could you provide a separate patch that applies to branch-2 too, as its jobclient TestJobConf varies from the trunk one? We may wanna commit to branch-2 too to avoid merge troubles in future.

      Show
      qwertymaniac Harsh J added a comment - Thanks Varun, +1 for trunk. Does not apply for branch-2, however. Could you provide a separate patch that applies to branch-2 too, as its jobclient TestJobConf varies from the trunk one? We may wanna commit to branch-2 too to avoid merge troubles in future.
      Hide
      qwertymaniac Harsh J added a comment -

      Failed test is unrelated, passes locally (for trunk).

      Show
      qwertymaniac Harsh J added a comment - Failed test is unrelated, passes locally (for trunk).
      Hide
      varun_saxena Varun Saxena added a comment -

      Harsh J, uploaded branch-2 patch

      Show
      varun_saxena Varun Saxena added a comment - Harsh J , uploaded branch-2 patch
      Hide
      hadoopqa Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12706181/MAPREDUCE-6239.branch-2.patch
      against trunk revision e1feb4e.

      -1 patch. The patch command could not apply the patch.

      Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5324//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12706181/MAPREDUCE-6239.branch-2.patch against trunk revision e1feb4e. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5324//console This message is automatically generated.
      Hide
      qwertymaniac Harsh J added a comment -

      Thanks again Varun! +1.

      Committed to branch-2 and trunk.

      Show
      qwertymaniac Harsh J added a comment - Thanks again Varun! +1. Committed to branch-2 and trunk.
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-trunk-Commit #7393 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7393/)
      MAPREDUCE-6239. Consolidate TestJobConf classes in hadoop-mapreduce-client-jobclient and hadoop-mapreduce-client-core. Contributed by Varun Saxena. (harsh: rev 7a678db3accf9480f3799dcf6fd7ffef09a311cc)

      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestJobConf.java
      • hadoop-mapreduce-project/CHANGES.txt
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/conf/TestJobConf.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7393 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7393/ ) MAPREDUCE-6239 . Consolidate TestJobConf classes in hadoop-mapreduce-client-jobclient and hadoop-mapreduce-client-core. Contributed by Varun Saxena. (harsh: rev 7a678db3accf9480f3799dcf6fd7ffef09a311cc) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestJobConf.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/conf/TestJobConf.java
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #140 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/140/)
      MAPREDUCE-6239. Consolidate TestJobConf classes in hadoop-mapreduce-client-jobclient and hadoop-mapreduce-client-core. Contributed by Varun Saxena. (harsh: rev 7a678db3accf9480f3799dcf6fd7ffef09a311cc)

      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestJobConf.java
      • hadoop-mapreduce-project/CHANGES.txt
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/conf/TestJobConf.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #140 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/140/ ) MAPREDUCE-6239 . Consolidate TestJobConf classes in hadoop-mapreduce-client-jobclient and hadoop-mapreduce-client-core. Contributed by Varun Saxena. (harsh: rev 7a678db3accf9480f3799dcf6fd7ffef09a311cc) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestJobConf.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/conf/TestJobConf.java
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Yarn-trunk #874 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/874/)
      MAPREDUCE-6239. Consolidate TestJobConf classes in hadoop-mapreduce-client-jobclient and hadoop-mapreduce-client-core. Contributed by Varun Saxena. (harsh: rev 7a678db3accf9480f3799dcf6fd7ffef09a311cc)

      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestJobConf.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/conf/TestJobConf.java
      • hadoop-mapreduce-project/CHANGES.txt
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #874 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/874/ ) MAPREDUCE-6239 . Consolidate TestJobConf classes in hadoop-mapreduce-client-jobclient and hadoop-mapreduce-client-core. Contributed by Varun Saxena. (harsh: rev 7a678db3accf9480f3799dcf6fd7ffef09a311cc) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestJobConf.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/conf/TestJobConf.java hadoop-mapreduce-project/CHANGES.txt
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Hdfs-trunk #2072 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2072/)
      MAPREDUCE-6239. Consolidate TestJobConf classes in hadoop-mapreduce-client-jobclient and hadoop-mapreduce-client-core. Contributed by Varun Saxena. (harsh: rev 7a678db3accf9480f3799dcf6fd7ffef09a311cc)

      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/conf/TestJobConf.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestJobConf.java
      • hadoop-mapreduce-project/CHANGES.txt
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2072 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2072/ ) MAPREDUCE-6239 . Consolidate TestJobConf classes in hadoop-mapreduce-client-jobclient and hadoop-mapreduce-client-core. Contributed by Varun Saxena. (harsh: rev 7a678db3accf9480f3799dcf6fd7ffef09a311cc) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/conf/TestJobConf.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestJobConf.java hadoop-mapreduce-project/CHANGES.txt
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #131 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/131/)
      MAPREDUCE-6239. Consolidate TestJobConf classes in hadoop-mapreduce-client-jobclient and hadoop-mapreduce-client-core. Contributed by Varun Saxena. (harsh: rev 7a678db3accf9480f3799dcf6fd7ffef09a311cc)

      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/conf/TestJobConf.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestJobConf.java
      • hadoop-mapreduce-project/CHANGES.txt
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #131 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/131/ ) MAPREDUCE-6239 . Consolidate TestJobConf classes in hadoop-mapreduce-client-jobclient and hadoop-mapreduce-client-core. Contributed by Varun Saxena. (harsh: rev 7a678db3accf9480f3799dcf6fd7ffef09a311cc) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/conf/TestJobConf.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestJobConf.java hadoop-mapreduce-project/CHANGES.txt
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #140 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/140/)
      MAPREDUCE-6239. Consolidate TestJobConf classes in hadoop-mapreduce-client-jobclient and hadoop-mapreduce-client-core. Contributed by Varun Saxena. (harsh: rev 7a678db3accf9480f3799dcf6fd7ffef09a311cc)

      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestJobConf.java
      • hadoop-mapreduce-project/CHANGES.txt
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/conf/TestJobConf.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #140 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/140/ ) MAPREDUCE-6239 . Consolidate TestJobConf classes in hadoop-mapreduce-client-jobclient and hadoop-mapreduce-client-core. Contributed by Varun Saxena. (harsh: rev 7a678db3accf9480f3799dcf6fd7ffef09a311cc) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestJobConf.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/conf/TestJobConf.java
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2090 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2090/)
      MAPREDUCE-6239. Consolidate TestJobConf classes in hadoop-mapreduce-client-jobclient and hadoop-mapreduce-client-core. Contributed by Varun Saxena. (harsh: rev 7a678db3accf9480f3799dcf6fd7ffef09a311cc)

      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestJobConf.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/conf/TestJobConf.java
      • hadoop-mapreduce-project/CHANGES.txt
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2090 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2090/ ) MAPREDUCE-6239 . Consolidate TestJobConf classes in hadoop-mapreduce-client-jobclient and hadoop-mapreduce-client-core. Contributed by Varun Saxena. (harsh: rev 7a678db3accf9480f3799dcf6fd7ffef09a311cc) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestJobConf.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/conf/TestJobConf.java hadoop-mapreduce-project/CHANGES.txt

        People

        • Assignee:
          varun_saxena Varun Saxena
          Reporter:
          varun_saxena Varun Saxena
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development