Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-5982

Task attempts that fail from the ASSIGNED state can disappear

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.10, 2.2.1, 2.7.1
    • Fix Version/s: 2.8.0, 2.7.2, 2.6.4, 3.0.0-alpha1
    • Component/s: mr-am
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      If a task attempt fails in the ASSIGNED state, e.g.: container launch fails, then it can disappear from the job history. The task overview page will show subsequent attempts but the attempt in question is simply missing. For example attempt ID 1 appears but the attempt ID 0 is missing. Similarly in the job overview page the task attempt doesn't appear in any of the failed/killed/succeeded counts or pages. It's as if the task attempt never existed, but the AM logs show otherwise.

      1. MAPREDUCE-5982.branch.2.7.patch
        15 kB
        Chang Li
      2. MAPREDUCE-5982.6.patch
        15 kB
        Chang Li
      3. MAPREDUCE-5982.5.patch
        15 kB
        Chang Li
      4. MAPREDUCE-5982.4.patch
        13 kB
        Chang Li
      5. MAPREDUCE-5982.3.patch
        13 kB
        Chang Li
      6. MAPREDUCE-5982.2.patch
        13 kB
        Chang Li
      7. MAPREDUCE-5982.patch
        13 kB
        Chang Li

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 15m 7s Findbugs (version ) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 41s There were no new javac warning messages.
          +1 javadoc 9m 40s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 18s There were no new checkstyle issues.
          -1 whitespace 0m 1s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 20s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 6s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 mapreduce tests 9m 9s Tests passed in hadoop-mapreduce-client-app.
              45m 22s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12748015/MAPREDUCE-5982.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / ddc867ce
          whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5916/artifact/patchprocess/whitespace.txt
          hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5916/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5916/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5916/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 7s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 41s There were no new javac warning messages. +1 javadoc 9m 40s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 18s There were no new checkstyle issues. -1 whitespace 0m 1s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 20s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 6s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 9s Tests passed in hadoop-mapreduce-client-app.     45m 22s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12748015/MAPREDUCE-5982.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ddc867ce whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5916/artifact/patchprocess/whitespace.txt hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5916/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5916/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5916/console This message was automatically generated.
          Hide
          lichangleo Chang Li added a comment -

          whitespace fix

          Show
          lichangleo Chang Li added a comment - whitespace fix
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 16s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 44s There were no new javac warning messages.
          +1 javadoc 9m 48s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 34s The applied patch generated 14 new checkstyle issues (total was 248, now 261).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 20s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 7s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 mapreduce tests 9m 10s Tests passed in hadoop-mapreduce-client-app.
              46m 59s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12748044/MAPREDUCE-5982.2.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 91b42e7
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5917/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt
          hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5917/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5917/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5917/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 16s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 44s There were no new javac warning messages. +1 javadoc 9m 48s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 34s The applied patch generated 14 new checkstyle issues (total was 248, now 261). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 20s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 7s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 10s Tests passed in hadoop-mapreduce-client-app.     46m 59s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12748044/MAPREDUCE-5982.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 91b42e7 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5917/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5917/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5917/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5917/console This message was automatically generated.
          Hide
          lichangleo Chang Li added a comment -

          checkstyle fix

          Show
          lichangleo Chang Li added a comment - checkstyle fix
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 31s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 58s There were no new javac warning messages.
          +1 javadoc 10m 14s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 37s The applied patch generated 2 new checkstyle issues (total was 248, now 249).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 25s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 1m 10s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 mapreduce tests 9m 29s Tests passed in hadoop-mapreduce-client-app.
              48m 24s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12748186/MAPREDUCE-5982.3.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 93d50b7
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5922/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt
          hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5922/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5922/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5922/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 31s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 58s There were no new javac warning messages. +1 javadoc 10m 14s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 37s The applied patch generated 2 new checkstyle issues (total was 248, now 249). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 25s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 10s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 29s Tests passed in hadoop-mapreduce-client-app.     48m 24s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12748186/MAPREDUCE-5982.3.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 93d50b7 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5922/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5922/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5922/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5922/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 15m 49s Findbugs (version ) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 55s There were no new javac warning messages.
          +1 javadoc 9m 43s There were no new javadoc warning messages.
          +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 22s There were no new checkstyle issues.
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 26s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 1m 7s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 mapreduce tests 9m 25s Tests passed in hadoop-mapreduce-client-app.
              46m 52s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12748216/MAPREDUCE-5982.4.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / d0e0ba8
          hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5924/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5924/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5924/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 49s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 55s There were no new javac warning messages. +1 javadoc 9m 43s There were no new javadoc warning messages. +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 22s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 26s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 7s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 25s Tests passed in hadoop-mapreduce-client-app.     46m 52s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12748216/MAPREDUCE-5982.4.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d0e0ba8 hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5924/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5924/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5924/console This message was automatically generated.
          Hide
          lichangleo Chang Li added a comment -

          Jason Lowe please help review.

          Show
          lichangleo Chang Li added a comment - Jason Lowe please help review.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for the patch, Chang!

          Note that the point of this change is to be able to have users locate any potential logs for applications that failed in the ASSIGNED state. By having a canned fake started event there's no way to determine which nodemanager tried to run the container and therefore we can't provide a good logs link. We need to preserve as much information as we can about the task, and that includes the host, http port, etc.

          The good news is that we have most of this information from the container that was assigned to the task attempt. See the code for LaunchedContainerTransition for details. It would be nice to see some of the code in that transition factored out so it can be reused when we are creating the start event for an attempt that failed in the ASSIGNED state. Also I would hesitate to call it a fake event. It's still a task started event, but we are missing just a few key components like the shuffle port and the start time. If we factor out the code from LaunchedContainerTransition then we can drop the "fake" part.

          Is forceFinishTime really necessary? We can go ahead and set the launch time as we are processing the task started event and then just call setFinishTime.

          In general I think we should worry about making sure we generate a proper task start event and then let the normal task unsuccessful completion event code handle things after that. For example, in DeallocateContainerTransition I think we should be generating the job counter update events for this scenario, but we don't since we go down a different task unsuccessful completion event handling path when launchTime is zero. Seems like we should just generate the missing start event when launchTime is zero then fall through to the normal unsucessful completion event handling code in all cases after that.

          Nit: missing whitespace before new method in MRApp.

          Show
          jlowe Jason Lowe added a comment - Thanks for the patch, Chang! Note that the point of this change is to be able to have users locate any potential logs for applications that failed in the ASSIGNED state. By having a canned fake started event there's no way to determine which nodemanager tried to run the container and therefore we can't provide a good logs link. We need to preserve as much information as we can about the task, and that includes the host, http port, etc. The good news is that we have most of this information from the container that was assigned to the task attempt. See the code for LaunchedContainerTransition for details. It would be nice to see some of the code in that transition factored out so it can be reused when we are creating the start event for an attempt that failed in the ASSIGNED state. Also I would hesitate to call it a fake event. It's still a task started event, but we are missing just a few key components like the shuffle port and the start time. If we factor out the code from LaunchedContainerTransition then we can drop the "fake" part. Is forceFinishTime really necessary? We can go ahead and set the launch time as we are processing the task started event and then just call setFinishTime. In general I think we should worry about making sure we generate a proper task start event and then let the normal task unsuccessful completion event code handle things after that. For example, in DeallocateContainerTransition I think we should be generating the job counter update events for this scenario, but we don't since we go down a different task unsuccessful completion event handling path when launchTime is zero. Seems like we should just generate the missing start event when launchTime is zero then fall through to the normal unsucessful completion event handling code in all cases after that. Nit: missing whitespace before new method in MRApp.
          Hide
          lichangleo Chang Li added a comment -

          Thanks Jason Lowe for review! I have updated my patch according to your suggestion.

          Show
          lichangleo Chang Li added a comment - Thanks Jason Lowe for review! I have updated my patch according to your suggestion.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 2s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 8m 10s There were no new javac warning messages.
          +1 javadoc 10m 14s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 35s The applied patch generated 11 new checkstyle issues (total was 248, now 257).
          -1 whitespace 0m 1s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 35s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 1m 7s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 mapreduce tests 9m 20s Tests failed in hadoop-mapreduce-client-app.
              49m 6s  



          Reason Tests
          Failed unit tests hadoop.mapreduce.v2.app.TestRecovery
          Timed out tests org.apache.hadoop.mapreduce.v2.app.TestMRAppMaster



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12755429/MAPREDUCE-5982.5.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / ca0827a
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5982/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt
          whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5982/artifact/patchprocess/whitespace.txt
          hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5982/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5982/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5982/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 2s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 8m 10s There were no new javac warning messages. +1 javadoc 10m 14s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 35s The applied patch generated 11 new checkstyle issues (total was 248, now 257). -1 whitespace 0m 1s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 7s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 mapreduce tests 9m 20s Tests failed in hadoop-mapreduce-client-app.     49m 6s   Reason Tests Failed unit tests hadoop.mapreduce.v2.app.TestRecovery Timed out tests org.apache.hadoop.mapreduce.v2.app.TestMRAppMaster Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12755429/MAPREDUCE-5982.5.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ca0827a checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5982/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5982/artifact/patchprocess/whitespace.txt hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5982/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5982/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5982/console This message was automatically generated.
          Hide
          lichangleo Chang Li added a comment -

          fixed broken tests and checkstyles

          Show
          lichangleo Chang Li added a comment - fixed broken tests and checkstyles
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 15s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 48s There were no new javac warning messages.
          +1 javadoc 9m 55s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 33s The applied patch generated 1 new checkstyle issues (total was 248, now 246).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 28s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 7s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 mapreduce tests 9m 23s Tests passed in hadoop-mapreduce-client-app.
              47m 31s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12755479/MAPREDUCE-5982.6.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / ea4bb27
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5983/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt
          hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5983/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5983/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5983/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 15s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 48s There were no new javac warning messages. +1 javadoc 9m 55s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 33s The applied patch generated 1 new checkstyle issues (total was 248, now 246). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 7s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 23s Tests passed in hadoop-mapreduce-client-app.     47m 31s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12755479/MAPREDUCE-5982.6.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ea4bb27 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5983/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5983/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5983/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5983/console This message was automatically generated.
          Hide
          lichangleo Chang Li added a comment -

          Jason Lowe please help review the latest patch. Thanks!

          Show
          lichangleo Chang Li added a comment - Jason Lowe please help review the latest patch. Thanks!
          Hide
          jlowe Jason Lowe added a comment -

          +1 latest patch lgtm. Committing this.

          Show
          jlowe Jason Lowe added a comment - +1 latest patch lgtm. Committing this.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks, Chang! I committed this to trunk and branch-2.

          It would be nice if this were fixed in 2.7.2 as well. Would you mind creating a patch for branch-2.7?

          Show
          jlowe Jason Lowe added a comment - Thanks, Chang! I committed this to trunk and branch-2. It would be nice if this were fixed in 2.7.2 as well. Would you mind creating a patch for branch-2.7?
          Hide
          lichangleo Chang Li added a comment -

          Thanks Jason Lowe for review and commit! I will work on a patch for branch-2.7.

          Show
          lichangleo Chang Li added a comment - Thanks Jason Lowe for review and commit! I will work on a patch for branch-2.7.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8473 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8473/)
          MAPREDUCE-5982. Task attempts that fail from the ASSIGNED state can disappear. Contributed by Chang Li (jlowe: rev ee4ee6af6a5a6299d27462adb6944206039bbbae)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskAttempt.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8473 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8473/ ) MAPREDUCE-5982 . Task attempts that fail from the ASSIGNED state can disappear. Contributed by Chang Li (jlowe: rev ee4ee6af6a5a6299d27462adb6944206039bbbae) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskAttempt.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2350 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2350/)
          MAPREDUCE-5982. Task attempts that fail from the ASSIGNED state can disappear. Contributed by Chang Li (jlowe: rev ee4ee6af6a5a6299d27462adb6944206039bbbae)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskAttempt.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2350 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2350/ ) MAPREDUCE-5982 . Task attempts that fail from the ASSIGNED state can disappear. Contributed by Chang Li (jlowe: rev ee4ee6af6a5a6299d27462adb6944206039bbbae) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskAttempt.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #403 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/403/)
          MAPREDUCE-5982. Task attempts that fail from the ASSIGNED state can disappear. Contributed by Chang Li (jlowe: rev ee4ee6af6a5a6299d27462adb6944206039bbbae)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskAttempt.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #403 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/403/ ) MAPREDUCE-5982 . Task attempts that fail from the ASSIGNED state can disappear. Contributed by Chang Li (jlowe: rev ee4ee6af6a5a6299d27462adb6944206039bbbae) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskAttempt.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #410 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/410/)
          MAPREDUCE-5982. Task attempts that fail from the ASSIGNED state can disappear. Contributed by Chang Li (jlowe: rev ee4ee6af6a5a6299d27462adb6944206039bbbae)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskAttempt.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #410 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/410/ ) MAPREDUCE-5982 . Task attempts that fail from the ASSIGNED state can disappear. Contributed by Chang Li (jlowe: rev ee4ee6af6a5a6299d27462adb6944206039bbbae) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskAttempt.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #1144 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1144/)
          MAPREDUCE-5982. Task attempts that fail from the ASSIGNED state can disappear. Contributed by Chang Li (jlowe: rev ee4ee6af6a5a6299d27462adb6944206039bbbae)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskAttempt.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1144 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1144/ ) MAPREDUCE-5982 . Task attempts that fail from the ASSIGNED state can disappear. Contributed by Chang Li (jlowe: rev ee4ee6af6a5a6299d27462adb6944206039bbbae) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskAttempt.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2325 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2325/)
          MAPREDUCE-5982. Task attempts that fail from the ASSIGNED state can disappear. Contributed by Chang Li (jlowe: rev ee4ee6af6a5a6299d27462adb6944206039bbbae)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskAttempt.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2325 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2325/ ) MAPREDUCE-5982 . Task attempts that fail from the ASSIGNED state can disappear. Contributed by Chang Li (jlowe: rev ee4ee6af6a5a6299d27462adb6944206039bbbae) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskAttempt.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #386 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/386/)
          MAPREDUCE-5982. Task attempts that fail from the ASSIGNED state can disappear. Contributed by Chang Li (jlowe: rev ee4ee6af6a5a6299d27462adb6944206039bbbae)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskAttempt.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #386 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/386/ ) MAPREDUCE-5982 . Task attempts that fail from the ASSIGNED state can disappear. Contributed by Chang Li (jlowe: rev ee4ee6af6a5a6299d27462adb6944206039bbbae) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskAttempt.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java
          Hide
          lichangleo Chang Li added a comment -

          Jason Lowe I uploaded 2.7 patch.

          Show
          lichangleo Chang Li added a comment - Jason Lowe I uploaded 2.7 patch.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks Chang! +1 for the branch-2.7 patch. I committed it to branch-2.7.

          Show
          jlowe Jason Lowe added a comment - Thanks Chang! +1 for the branch-2.7 patch. I committed it to branch-2.7.
          Hide
          djp Junping Du added a comment -

          Hi Jason Lowe, do you think we should backport the fix to branch-2.6 (as well as MAPREDUCE-6492)?

          Show
          djp Junping Du added a comment - Hi Jason Lowe , do you think we should backport the fix to branch-2.6 (as well as MAPREDUCE-6492 )?
          Hide
          jlowe Jason Lowe added a comment -

          Apologies for the delay in responding. I committed this to branch-2.6 as well, along with MAPREDUCE-6492.

          Show
          jlowe Jason Lowe added a comment - Apologies for the delay in responding. I committed this to branch-2.6 as well, along with MAPREDUCE-6492 .
          Hide
          djp Junping Du added a comment -

          Thanks Jason Lowe!

          Show
          djp Junping Du added a comment - Thanks Jason Lowe !

            People

            • Assignee:
              lichangleo Chang Li
              Reporter:
              jlowe Jason Lowe
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development