Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: task
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently, building the native task code on gcc 4.8 has a fair number of warnings. We should fix or suppress them so that new warnings are easier to see.

      1. gcc_compile.log
        452 kB
        Manu Zhang
      2. mapreduce-5977.txt
        32 kB
        Manu Zhang
      3. mapreduce-5977-v2.txt
        1.60 MB
        Manu Zhang
      4. mapreduce-5977-v3.txt
        1.60 MB
        Manu Zhang
      5. mapreduce-6056-v3.txt
        67 kB
        Manu Zhang

        Activity

        Hide
        Manu Zhang added a comment -

        Hi Todd, I'd like to have a try with this jira.
        Please note that the attached patch doesn't handle all the issues. I post it here for your opinion over those I'm not sure or feel uncomfortable.

        Here are they:
        1. I used static_cast when it's safe to cast a int to unsigned int. (should we use c-style cast instead ?)
        2. I included <inttypes.h> and replaced "llu" with the macro PRIu64 which could resolve to long long unsigned int or long unsigned int dependant on platforms . Same for "lld" and PRId64. The only exception is

        Unable to find source-code formatter for language: c++. Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml
        string StringUtil::ToString(int64_t v, char pad, int64_t len) {
          char tmp[32];
          snprintf(tmp, 32, "%%%c%lldlld", pad, static_cast<long long int>(len));
          return Format(tmp, static_cast<long long int>(v));
        }
        

        where it looks impossible to do so.
        3. I've left out warnings like

          
        warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
           [exec]    return *(float*)&ret;
        

        where I have not found a safe way to cast.
        4. I've left out unused-result warnings.
        5. I've left out warnings generated by gtest.

        Show
        Manu Zhang added a comment - Hi Todd, I'd like to have a try with this jira. Please note that the attached patch doesn't handle all the issues . I post it here for your opinion over those I'm not sure or feel uncomfortable. Here are they: 1. I used static_cast when it's safe to cast a int to unsigned int. (should we use c-style cast instead ?) 2. I included <inttypes.h> and replaced "llu" with the macro PRIu64 which could resolve to long long unsigned int or long unsigned int dependant on platforms . Same for "lld" and PRId64. The only exception is Unable to find source-code formatter for language: c++. Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml string StringUtil::ToString(int64_t v, char pad, int64_t len) { char tmp[32]; snprintf(tmp, 32, "%%%c%lldlld" , pad, static_cast< long long int >(len)); return Format(tmp, static_cast< long long int >(v)); } where it looks impossible to do so. 3. I've left out warnings like warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] [exec] return *( float *)&ret; where I have not found a safe way to cast. 4. I've left out unused-result warnings. 5. I've left out warnings generated by gtest.
        Hide
        Sean Zhong added a comment -

        Assign this to Manu

        Show
        Sean Zhong added a comment - Assign this to Manu
        Hide
        Sean Zhong added a comment -

        HI, Manu,

        Can you attach a file of GCC compie logs?

        IMHO, static_cast from int to uint32_t change doesn't sound necessary and clean, maybe we should supress this kind of warnings.
        +1 for PRIu64 and PRId64, we need to test tihs in multiple platforms to make sure it is safe.

        For gtest warnings, we can suppress the warning mesage like this http://stackoverflow.com/questions/1867065/how-to-suppress-gcc-warnings-from-library-headers

        Show
        Sean Zhong added a comment - HI, Manu, Can you attach a file of GCC compie logs? IMHO, static_cast from int to uint32_t change doesn't sound necessary and clean, maybe we should supress this kind of warnings. +1 for PRIu64 and PRId64, we need to test tihs in multiple platforms to make sure it is safe. For gtest warnings, we can suppress the warning mesage like this http://stackoverflow.com/questions/1867065/how-to-suppress-gcc-warnings-from-library-headers
        Hide
        Manu Zhang added a comment -

        the gcc compile log (before applying the patch) is attached

        Show
        Manu Zhang added a comment - the gcc compile log (before applying the patch) is attached
        Hide
        Manu Zhang added a comment -

        Hi Sean, I've updated the patch with the following changes.

        1. add compile flags "-fno-strict-aliasing" and "-Wno-sign-compare" to suppress strict-aliasing and sign-compare warnings. all "static_cast"s have been removed;
        2. "%%%c%lldlld" could be replaced with "%%%c%"PRId64""PRId64 so that PRId64 and PRIu64 work for all now;
        3. as you suggest, gtest is compiled before nttest and loaded as system library, to suppress gtest warnings. (Note that "gtest/gtest.h" is moved to "gtest/include/gtest/gtest.h" and "gtest/include" is included as system directory. )

        Show
        Manu Zhang added a comment - Hi Sean, I've updated the patch with the following changes. 1. add compile flags "-fno-strict-aliasing" and "-Wno-sign-compare" to suppress strict-aliasing and sign-compare warnings. all "static_cast"s have been removed; 2. "%%%c%lldlld" could be replaced with "%%%c%"PRId64""PRId64 so that PRId64 and PRIu64 work for all now; 3. as you suggest, gtest is compiled before nttest and loaded as system library, to suppress gtest warnings. (Note that "gtest/gtest.h" is moved to "gtest/include/gtest/gtest.h" and "gtest/include" is included as system directory. )
        Hide
        Manu Zhang added a comment -

        forget to mention I'm also using gcc 4.8 and all warnings disappear after the current patch is applied.

        Show
        Manu Zhang added a comment - forget to mention I'm also using gcc 4.8 and all warnings disappear after the current patch is applied.
        Hide
        Todd Lipcon added a comment -

        Have you done any simple before/after performance check of the impact of -fno-strict-aliasing? I generally support the flag, but would be good to have some assurance that it's not hurting any hot path. If it is we can manually add 'restrict' keywords where necessary. Another option is to fix the warnings where they show up by changing type punning to memcpy (which generally gets optimized to simple loads/stores if it has a fixed length)

             }
        @@ -196,7 +194,6 @@ void MeasureSingleFileLz4(const string & path, CompressResult & total, size_t bl
             startTime = t.now();
             for (int i = 0; i < times; i++) {
         //      memset(dest, 0, currentblocksize+8);
        -      int osize = LZ4_uncompress(outputBuffer, dest, currentblocksize);
         //      printf("%016llx blocksize: %lu\n", bswap64(*(uint64_t*)(dest+currentblocksize)), currentblocksize);
             }
        

        Removing this call seems problematic, given this is purporting to benchmark LZO decompression and you just removed the call to decompress

        Maybe you want to either cast the call to void (to get rid of the warning), or perform some kind of assertion on 'osize' so it's not unused?


           while (ir->nextPartition()) {
        -    const char * key, *value;
        +    const char * key;
             uint32_t keyLen, valueLen;
             while (NULL != (key = ir->nextKey(keyLen))) {
        -      value = ir->value(valueLen);
        +      ir->value(valueLen);
             }
           }
        

        Again, for a benchmark, this seem suspicious. The compiler might well elide the ir->value() call if it figures out there is no side effect. One trick I usually use here is to do something like:

           int sum = 0;
           while (ir->nextPartition()) {
             const char * key, *value;
             uint32_t keyLen, valueLen;
             while (NULL != (key = ir->nextKey(keyLen))) {
               value = ir->value(valueLen);
               sum += value[0];
             }
           }
           // Use the result so that the value() calls don't get optimized out.
           ASSERT_NE(0xdeadbeef, sum);
        

        (or if you don't like assert, another option is to log the result – anything so that gcc knows that it can't elide the actual memory accesses in the loop)

        Show
        Todd Lipcon added a comment - Have you done any simple before/after performance check of the impact of -fno-strict-aliasing? I generally support the flag, but would be good to have some assurance that it's not hurting any hot path. If it is we can manually add 'restrict' keywords where necessary. Another option is to fix the warnings where they show up by changing type punning to memcpy (which generally gets optimized to simple loads/stores if it has a fixed length) } @@ -196,7 +194,6 @@ void MeasureSingleFileLz4( const string & path, CompressResult & total, size_t bl startTime = t.now(); for ( int i = 0; i < times; i++) { // memset(dest, 0, currentblocksize+8); - int osize = LZ4_uncompress(outputBuffer, dest, currentblocksize); // printf( "%016llx blocksize: %lu\n" , bswap64(*(uint64_t*)(dest+currentblocksize)), currentblocksize); } Removing this call seems problematic, given this is purporting to benchmark LZO decompression and you just removed the call to decompress Maybe you want to either cast the call to void (to get rid of the warning), or perform some kind of assertion on 'osize' so it's not unused? while (ir->nextPartition()) { - const char * key, *value; + const char * key; uint32_t keyLen, valueLen; while (NULL != (key = ir->nextKey(keyLen))) { - value = ir->value(valueLen); + ir->value(valueLen); } } Again, for a benchmark, this seem suspicious. The compiler might well elide the ir->value() call if it figures out there is no side effect. One trick I usually use here is to do something like: int sum = 0; while (ir->nextPartition()) { const char * key, *value; uint32_t keyLen, valueLen; while (NULL != (key = ir->nextKey(keyLen))) { value = ir->value(valueLen); sum += value[0]; } } // Use the result so that the value() calls don't get optimized out. ASSERT_NE(0xdeadbeef, sum); (or if you don't like assert, another option is to log the result – anything so that gcc knows that it can't elide the actual memory accesses in the loop)
        Hide
        Manu Zhang added a comment -

        Thanks for the comment.

        1. Just wrote a performance test on WritableUtils:writeFloat, where I wrote out a float for 10M times. I didn't find any difference w/ and w/o strict-aliasing flag. Also checked about other native perf tests and no impact of -fno-strict-aliasing was found.
        2. oh, I was too happy removing unused codes. I will use assertion.
        3. your trick looks fine.

        will upload a new patch soon

        Show
        Manu Zhang added a comment - Thanks for the comment. 1. Just wrote a performance test on WritableUtils:writeFloat, where I wrote out a float for 10M times. I didn't find any difference w/ and w/o strict-aliasing flag. Also checked about other native perf tests and no impact of -fno-strict-aliasing was found. 2. oh, I was too happy removing unused codes. I will use assertion. 3. your trick looks fine. will upload a new patch soon
        Hide
        Manu Zhang added a comment -

        Hi Todd, patch updated as per your comments.

        Show
        Manu Zhang added a comment - Hi Todd, patch updated as per your comments.
        Hide
        Sean Zhong added a comment -

        gtest.h is moved to folder gtest/include/gtest/, is this because that it is more easy to treat it as system header, and removing compilation warnings?

        New patch looks good

        Show
        Sean Zhong added a comment - gtest.h is moved to folder gtest/include/gtest/, is this because that it is more easy to treat it as system header, and removing compilation warnings? New patch looks good
        Hide
        Manu Zhang added a comment -

        is this because that it is more easy to treat it as system header, and removing compilation warnings?

        Yes, the directory structure also conforms to that of the original google test project.

        Show
        Manu Zhang added a comment - is this because that it is more easy to treat it as system header, and removing compilation warnings? Yes, the directory structure also conforms to that of the original google test project.
        Hide
        Todd Lipcon added a comment -

        Patch looks good to me. +1. Sean, you want to commit this?

        Show
        Todd Lipcon added a comment - Patch looks good to me. +1. Sean, you want to commit this?
        Hide
        Sean Zhong added a comment -

        Hi Todd,

        I encounter errors when trying to commit, can you try this in your side?

        Commit failed (details follow):
        Changing file
        'C:\myData\MR-28412\hadoop-mapreduce-project\hadoop-mapreduce-client\hadoop-mapreduce-client-nativetask\src\main\native\gtest\gtest.h'
        is forbidden by the server
        Access to
        '/repos/asf/!svn/txr/1620252-ziae/hadoop/common/branches/MR-2841/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest.h'
        forbidden
        Additional errors:
        DELETE of
        '/repos/asf/!svn/txr/1620252-ziae/hadoop/common/branches/MR-2841/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest.h':
        403 Forbidden

        Show
        Sean Zhong added a comment - Hi Todd, I encounter errors when trying to commit, can you try this in your side? Commit failed (details follow): Changing file 'C:\myData\MR-28412\hadoop-mapreduce-project\hadoop-mapreduce-client\hadoop-mapreduce-client-nativetask\src\main\native\gtest\gtest.h' is forbidden by the server Access to '/repos/asf/!svn/txr/1620252-ziae/hadoop/common/branches/MR-2841/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest.h' forbidden Additional errors: DELETE of '/repos/asf/!svn/txr/1620252-ziae/hadoop/common/branches/MR-2841/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest.h': 403 Forbidden
        Hide
        Allen Wittenauer added a comment -

        svn is read-only as we are switching to git. See related posts in *-dev.

        Show
        Allen Wittenauer added a comment - svn is read-only as we are switching to git. See related posts in *-dev.
        Hide
        Todd Lipcon added a comment -

        Committed to branch (via git). Thanks, Manu.

        Show
        Todd Lipcon added a comment - Committed to branch (via git). Thanks, Manu.
        Hide
        Manu Zhang added a comment -

        Hi Todd. Haven't seen this committed in. Anything wrong with git ?

        Show
        Manu Zhang added a comment - Hi Todd. Haven't seen this committed in. Anything wrong with git ?
        Hide
        Binglin Chang added a comment -
        Show
        Binglin Chang added a comment - Haodop has moved to git, see https://wiki.apache.org/hadoop/HowToCommitWithGit
        Hide
        Binglin Chang added a comment -

        decster:~/projects/hadoop-trunk> git la
        2014-08-27 bfd1d75 (Todd Lipcon): MAPREDUCE-6054. native-task: Speed up tests. Contributed by Todd Lipcon.
        2014-08-27 fad4524 (Todd Lipcon): MAPREDUCE-5977. Fix or suppress native-task gcc warnings. Contributed by Manu Zhang.

        Show
        Binglin Chang added a comment - decster:~/projects/hadoop-trunk> git la 2014-08-27 bfd1d75 (Todd Lipcon): MAPREDUCE-6054 . native-task: Speed up tests. Contributed by Todd Lipcon. 2014-08-27 fad4524 (Todd Lipcon): MAPREDUCE-5977 . Fix or suppress native-task gcc warnings. Contributed by Manu Zhang.
        Hide
        Manu Zhang added a comment -

        If you checkout the github page (https://github.com/apache/hadoop-common/tree/MR-2841) , the last commit is MAPREDUCE-6025 and I can't pull in the changed made in above two jiras.

        Show
        Manu Zhang added a comment - If you checkout the github page ( https://github.com/apache/hadoop-common/tree/MR-2841 ) , the last commit is MAPREDUCE-6025 and I can't pull in the changed made in above two jiras.
        Hide
        Manu Zhang added a comment -

        thanks for the comment. The patch is updated.

        Show
        Manu Zhang added a comment - thanks for the comment. The patch is updated.
        Hide
        Manu Zhang added a comment -

        sorry, submitted patch at wrong place. Just ignore it

        Show
        Manu Zhang added a comment - sorry, submitted patch at wrong place. Just ignore it
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #679 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/679/)
        MAPREDUCE-5977. Fix or suppress native-task gcc warnings. Contributed by Manu Zhang. (todd: rev fad4524c85848b8efe27dcf4a3e3a9ac1725bd2a)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/util/TestHash.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestMemoryBlock.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/MapOutputCollector.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Buffers.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestMemBlockIterator.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestIterator.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/handler/BatchHandler.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/CMakeLists.txt
        • hadoop-mapreduce-project/CHANGES.MAPREDUCE-2841.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/handler/CombineHandler.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/TestIFile.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util/StringUtil.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/codec/BlockCodec.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/MapOutputCollector.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/commons.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Merge.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestFixSizeContainer.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestByteBuffer.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/PartitionBucket.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/IFile.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/TestCompressions.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/include/gtest/gtest.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/NativeTask.h
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #679 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/679/ ) MAPREDUCE-5977 . Fix or suppress native-task gcc warnings. Contributed by Manu Zhang. (todd: rev fad4524c85848b8efe27dcf4a3e3a9ac1725bd2a) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/util/TestHash.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestMemoryBlock.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/MapOutputCollector.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Buffers.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestMemBlockIterator.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestIterator.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/handler/BatchHandler.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/CMakeLists.txt hadoop-mapreduce-project/CHANGES. MAPREDUCE-2841 .txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/handler/CombineHandler.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/TestIFile.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util/StringUtil.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/codec/BlockCodec.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/MapOutputCollector.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/commons.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Merge.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestFixSizeContainer.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestByteBuffer.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/PartitionBucket.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/IFile.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/TestCompressions.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/include/gtest/gtest.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/NativeTask.h
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1895 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1895/)
        MAPREDUCE-5977. Fix or suppress native-task gcc warnings. Contributed by Manu Zhang. (todd: rev fad4524c85848b8efe27dcf4a3e3a9ac1725bd2a)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestMemBlockIterator.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestIterator.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/handler/CombineHandler.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/CMakeLists.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/handler/BatchHandler.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestByteBuffer.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/commons.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestFixSizeContainer.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/include/gtest/gtest.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Buffers.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/util/TestHash.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/TestIFile.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/PartitionBucket.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestMemoryBlock.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/IFile.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/TestCompressions.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/MapOutputCollector.h
        • hadoop-mapreduce-project/CHANGES.MAPREDUCE-2841.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/MapOutputCollector.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/codec/BlockCodec.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util/StringUtil.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/NativeTask.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Merge.cc
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1895 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1895/ ) MAPREDUCE-5977 . Fix or suppress native-task gcc warnings. Contributed by Manu Zhang. (todd: rev fad4524c85848b8efe27dcf4a3e3a9ac1725bd2a) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestMemBlockIterator.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestIterator.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/handler/CombineHandler.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/CMakeLists.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/handler/BatchHandler.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestByteBuffer.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/commons.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestFixSizeContainer.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/include/gtest/gtest.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Buffers.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/util/TestHash.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/TestIFile.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/PartitionBucket.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestMemoryBlock.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/IFile.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/TestCompressions.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/MapOutputCollector.h hadoop-mapreduce-project/CHANGES. MAPREDUCE-2841 .txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/MapOutputCollector.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/codec/BlockCodec.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util/StringUtil.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/NativeTask.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Merge.cc
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #1870 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1870/)
        MAPREDUCE-5977. Fix or suppress native-task gcc warnings. Contributed by Manu Zhang. (todd: rev fad4524c85848b8efe27dcf4a3e3a9ac1725bd2a)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestIterator.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/PartitionBucket.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/handler/BatchHandler.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/MapOutputCollector.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/commons.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestByteBuffer.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/IFile.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/CMakeLists.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Buffers.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/util/TestHash.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/MapOutputCollector.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/codec/BlockCodec.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestMemoryBlock.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestMemBlockIterator.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/NativeTask.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Merge.cc
        • hadoop-mapreduce-project/CHANGES.MAPREDUCE-2841.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/handler/CombineHandler.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/include/gtest/gtest.h
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestFixSizeContainer.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/TestIFile.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/TestCompressions.cc
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util/StringUtil.cc
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1870 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1870/ ) MAPREDUCE-5977 . Fix or suppress native-task gcc warnings. Contributed by Manu Zhang. (todd: rev fad4524c85848b8efe27dcf4a3e3a9ac1725bd2a) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestIterator.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/PartitionBucket.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/handler/BatchHandler.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/MapOutputCollector.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/commons.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestByteBuffer.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/IFile.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/CMakeLists.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Buffers.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/util/TestHash.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/MapOutputCollector.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/codec/BlockCodec.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestMemoryBlock.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestMemBlockIterator.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/NativeTask.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Merge.cc hadoop-mapreduce-project/CHANGES. MAPREDUCE-2841 .txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/handler/CombineHandler.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/include/gtest/gtest.h hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/lib/TestFixSizeContainer.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/TestIFile.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test/TestCompressions.cc hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util/StringUtil.cc

          People

          • Assignee:
            Manu Zhang
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development