[MAPREDUCE-5895] FileAlreadyExistsException was thrown : Temporary Index File can not be cleaned up because OutputStream doesn't close properly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha1
• Fix Version/s: 2.5.0
• Component/s: client
• Hadoop Flags: Reviewed
• Assignee: Kousuke Saruta
• Reporter: Kousuke Saruta
• Created: 20/May/14 08:34
• Updated: 12/May/16 18:24
• Resolved: 29/May/14 07:08

Description

In TaskLog.java, Temporary Index File is created by following code.

BufferedOutputStream bos =
  new BufferedOutputStream(
    SecureIOUtils.createForWrite(tmpIndexFile, 0644));
DataOutputStream dos = new DataOutputStream(bos);

The code is surrounded by try-finally so if some Exception/ERROR is thrown between constructing bos and dos, temporary file is not cleaned up.
I met the situation that when a thread ran, OOM was thrown after bos created and temporary file is not cleaned up. At different time, another thread executed same logic and fail because of FileAlreadyExistsException.