Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-5819

Binary token merge should be done once in TokenCache#obtainTokensForNamenodesInternal()

        Details

        • Type: Improvement
        • Status: Patch Available
        • Priority: Minor
        • Resolution: Unresolved
        • Affects Version/s: None
        • Fix Version/s: None
        • Component/s: security
        • Labels:

          Description

          Currently mergeBinaryTokens() is called by every invocation of obtainTokensForNamenodesInternal(FileSystem, Credentials, Configuration) in the loop of obtainTokensForNamenodesInternal(Credentials, Path[], Configuration).

          This can be simplified such that mergeBinaryTokens() is called only once in obtainTokensForNamenodesInternal(Credentials, Path[], Configuration).

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            yuzhihong@gmail.com Ted Yu added a comment -

            TestTokenCache and TestBinaryTokenFile pass based on patch.

            Show
            yuzhihong@gmail.com Ted Yu added a comment - TestTokenCache and TestBinaryTokenFile pass based on patch.
            Hide
            Permalink
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12638362/mapreduce-5819-v1.txt
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 javadoc. There were no new javadoc warning messages.

            +1 eclipse:eclipse. The patch built with eclipse:eclipse.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

            +1 contrib tests. The patch passed contrib unit tests.

            Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4483//testReport/
            Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4483//console

            This message is automatically generated.

            Show
            hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12638362/mapreduce-5819-v1.txt against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4483//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4483//console This message is automatically generated.
            Hide
            Permalink
            hadoopqa Hadoop QA added a comment -



            -1 overall



            Vote Subsystem Runtime Comment
            0 patch 0m 1s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
            -1 patch 0m 0s The patch command could not apply the patch during dryrun.



            Subsystem Report/Notes
            Patch URL http://issues.apache.org/jira/secure/attachment/12638362/mapreduce-5819-v1.txt
            Optional Tests javadoc javac unit findbugs checkstyle
            git revision trunk / edcaae4
            Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5888/console

            This message was automatically generated.

            Show
            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 patch 0m 1s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12638362/mapreduce-5819-v1.txt Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / edcaae4 Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5888/console This message was automatically generated.

              People

              • Assignee:
                yuzhihong@gmail.com Ted Yu
                Reporter:
                yuzhihong@gmail.com Ted Yu
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Development