Details

    • Type: Bug Bug
    • Status: Patch Available
    • Priority: Trivial Trivial
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: examples
    • Labels:
      None

      Description

      For new to hadoop, try for getting help mesage for examples jobs provided in mapreduce. These Usage helps them in providing arguements.

      terasort job execution does not print Usage message instead throw exception.

      ./yarn jar ../share/hadoop/mapreduce/hadoop-mapreduce-examples-*.jar terasort
      14/03/24 15:34:55 INFO terasort.TeraSort: starting
      java.lang.ArrayIndexOutOfBoundsException: 0
      at org.apache.hadoop.examples.terasort.TeraSort.run(TeraSort.java:283)
      at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
      at org.apache.hadoop.examples.terasort.TeraSort.main(TeraSort.java:325)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      at java.lang.reflect.Method.invoke(Method.java:597)
      at org.apache.hadoop.util.ProgramDriver$ProgramDescription.invoke(ProgramDriver.java:72)
      at org.apache.hadoop.util.ProgramDriver.run(ProgramDriver.java:144)
      at org.apache.hadoop.examples.ExampleDriver.main(ExampleDriver.java:74)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      at java.lang.reflect.Method.invoke(Method.java:597)
      at org.apache.hadoop.util.RunJar.main(RunJar.java:212)

        Activity

        Hide
        Rohith added a comment -

        Attached patch for printing usage.Pls review.

        Show
        Rohith added a comment - Attached patch for printing usage.Pls review.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12636320/MAPREDUCE-5807.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-examples.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4458//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4458//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12636320/MAPREDUCE-5807.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-examples. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4458//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4458//console This message is automatically generated.
        Hide
        Gera Shegalov added a comment -

        Rohith, that's a good idea. Do you mind adding help for terasort-specific configuration keys mapreduce.terasort.*. They are spread out across multiple classes.

        Show
        Gera Shegalov added a comment - Rohith , that's a good idea. Do you mind adding help for terasort-specific configuration keys mapreduce.terasort.* . They are spread out across multiple classes.
        Hide
        Rohith added a comment -

        Gera Shegalov, It is good to document terasort configurations separately. I feel that command help containes only usage of command. Basically , user should get at least what are the args to be provided!!
        I see 7 configurations are spread across multiple classes. Adding all configurations in command line help, is it good?

        Show
        Rohith added a comment - Gera Shegalov , It is good to document terasort configurations separately. I feel that command help containes only usage of command. Basically , user should get at least what are the args to be provided!! I see 7 configurations are spread across multiple classes. Adding all configurations in command line help, is it good?
        Hide
        Gera Shegalov added a comment -

        Hi Rohith, documenting separately is an option. It just usually goes stale very quickly. If we could consolidate all conf keys into a single enum along with descriptions, and dump it on some "-help config", that would be very useful. That's my experience with TeraSort versions.

        Show
        Gera Shegalov added a comment - Hi Rohith , documenting separately is an option. It just usually goes stale very quickly. If we could consolidate all conf keys into a single enum along with descriptions, and dump it on some "-help config", that would be very useful. That's my experience with TeraSort versions.

          People

          • Assignee:
            Rohith
            Reporter:
            Rohith
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:

              Development