Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: contrib/streaming
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The documentation for the Streaming module do not include any mention of the "slowmatch" parameter, which checks for CDATA sections while looking for XML records.

      An important point is that "slowmatch=true" violates the principle of least surprise: the "begin" and "end" parameters become regular expressions instead of exact strings. This is probably a useful feature, but should definitely be noted since users will be tempted to use the XML record reader on not-strictly-xml files, which may require escaping the "begin" and "end" patterns.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2093 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2093/)
        MAPREDUCE-579. Streaming slowmatch documentation. (harsh: rev b6dea9776b92c46d2ca593f7ada0a3b5dfdc2e04)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-tools/hadoop-streaming/src/site/markdown/HadoopStreaming.md.vm
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2093 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2093/ ) MAPREDUCE-579 . Streaming slowmatch documentation. (harsh: rev b6dea9776b92c46d2ca593f7ada0a3b5dfdc2e04) hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-streaming/src/site/markdown/HadoopStreaming.md.vm
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #143 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/143/)
        MAPREDUCE-579. Streaming slowmatch documentation. (harsh: rev b6dea9776b92c46d2ca593f7ada0a3b5dfdc2e04)

        • hadoop-tools/hadoop-streaming/src/site/markdown/HadoopStreaming.md.vm
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #143 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/143/ ) MAPREDUCE-579 . Streaming slowmatch documentation. (harsh: rev b6dea9776b92c46d2ca593f7ada0a3b5dfdc2e04) hadoop-tools/hadoop-streaming/src/site/markdown/HadoopStreaming.md.vm hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #134 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/134/)
        MAPREDUCE-579. Streaming slowmatch documentation. (harsh: rev b6dea9776b92c46d2ca593f7ada0a3b5dfdc2e04)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-tools/hadoop-streaming/src/site/markdown/HadoopStreaming.md.vm
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #134 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/134/ ) MAPREDUCE-579 . Streaming slowmatch documentation. (harsh: rev b6dea9776b92c46d2ca593f7ada0a3b5dfdc2e04) hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-streaming/src/site/markdown/HadoopStreaming.md.vm
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2075 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2075/)
        MAPREDUCE-579. Streaming slowmatch documentation. (harsh: rev b6dea9776b92c46d2ca593f7ada0a3b5dfdc2e04)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-tools/hadoop-streaming/src/site/markdown/HadoopStreaming.md.vm
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2075 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2075/ ) MAPREDUCE-579 . Streaming slowmatch documentation. (harsh: rev b6dea9776b92c46d2ca593f7ada0a3b5dfdc2e04) hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-streaming/src/site/markdown/HadoopStreaming.md.vm
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #877 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/877/)
        MAPREDUCE-579. Streaming slowmatch documentation. (harsh: rev b6dea9776b92c46d2ca593f7ada0a3b5dfdc2e04)

        • hadoop-tools/hadoop-streaming/src/site/markdown/HadoopStreaming.md.vm
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #877 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/877/ ) MAPREDUCE-579 . Streaming slowmatch documentation. (harsh: rev b6dea9776b92c46d2ca593f7ada0a3b5dfdc2e04) hadoop-tools/hadoop-streaming/src/site/markdown/HadoopStreaming.md.vm hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #143 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/143/)
        MAPREDUCE-579. Streaming slowmatch documentation. (harsh: rev b6dea9776b92c46d2ca593f7ada0a3b5dfdc2e04)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-tools/hadoop-streaming/src/site/markdown/HadoopStreaming.md.vm
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #143 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/143/ ) MAPREDUCE-579 . Streaming slowmatch documentation. (harsh: rev b6dea9776b92c46d2ca593f7ada0a3b5dfdc2e04) hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-streaming/src/site/markdown/HadoopStreaming.md.vm
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7429 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7429/)
        MAPREDUCE-579. Streaming slowmatch documentation. (harsh: rev b6dea9776b92c46d2ca593f7ada0a3b5dfdc2e04)

        • hadoop-tools/hadoop-streaming/src/site/markdown/HadoopStreaming.md.vm
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7429 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7429/ ) MAPREDUCE-579 . Streaming slowmatch documentation. (harsh: rev b6dea9776b92c46d2ca593f7ada0a3b5dfdc2e04) hadoop-tools/hadoop-streaming/src/site/markdown/HadoopStreaming.md.vm hadoop-mapreduce-project/CHANGES.txt
        Hide
        qwertymaniac Harsh J added a comment -

        Thanks Tsuyoshi Ozawa for the review! Committed to branch-2 and trunk.

        Show
        qwertymaniac Harsh J added a comment - Thanks Tsuyoshi Ozawa for the review! Committed to branch-2 and trunk.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        +1. Harsh J, please commit this!

        Show
        ozawa Tsuyoshi Ozawa added a comment - +1. Harsh J , please commit this!
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12705537/MAPREDUCE-579.patch
        against trunk revision 93d0f4a.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-tools/hadoop-streaming.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5311//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5311//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12705537/MAPREDUCE-579.patch against trunk revision 93d0f4a. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-tools/hadoop-streaming. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5311//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5311//console This message is automatically generated.
        Hide
        qwertymaniac Harsh J added a comment -

        This seemed simple enough to extract from code comments and long overdue. Attached a doc change that comes up well rendered via 'mvn site'.

        Show
        qwertymaniac Harsh J added a comment - This seemed simple enough to extract from code comments and long overdue. Attached a doc change that comes up well rendered via 'mvn site'.

          People

          • Assignee:
            qwertymaniac Harsh J
            Reporter:
            thumper Bo Adler
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development