[MAPREDUCE-5708] Duplicate String.format in YarnOutputFiles.getSpillFileForWrite

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Konstantin Weitz
• Reporter: Konstantin Weitz
• Created: 04/Jan/14 17:38
• Updated: 30/Aug/16 01:20
• Resolved: 14/May/15 16:46

Description

The code responsible for formatting the spill file name (namely getSpillFileForWrite) unnecessarily calls String.format twice. This does not only affect performance, but leads to the weird requirement that task attempt ids cannot contain % characters (because these would be interpreted as format specifiers in the outside String.format call).

I assume this was done by mistake, as it could only be useful if task attempt ids contained %n.