Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-5708

Duplicate String.format in YarnOutputFiles.getSpillFileForWrite

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The code responsible for formatting the spill file name (namely getSpillFileForWrite) unnecessarily calls String.format twice. This does not only affect performance, but leads to the weird requirement that task attempt ids cannot contain % characters (because these would be interpreted as format specifiers in the outside String.format call).

      I assume this was done by mistake, as it could only be useful if task attempt ids contained %n.

        Attachments

          Activity

            People

            • Assignee:
              konnew88 Konstantin Weitz
              Reporter:
              konnew88 Konstantin Weitz
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 10m
                10m
                Remaining:
                Remaining Estimate - 10m
                10m
                Logged:
                Time Spent - Not Specified
                Not Specified