Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-5432

JobHistoryParser does not fetch clockSplits, cpuUsages, vMemKbytes, physMemKbytes from history file

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 2.0.4-alpha
    • Fix Version/s: None
    • Component/s: jobhistoryserver, mrv2
    • Labels:
      None

      Description

      JobHistoryParser's handleMapAttemptFinishedEvent() function does not look at MapAttemptFinishedEvent's
      int[] clockSplits;
      int[] cpuUsages;
      int[] vMemKbytes;
      int[] physMemKbytes;

      JobHistoryParser's inner class TaskAttemptInfo also needs to be enhanced to have these as members so that handleMapAttemptFinishedEvent() can get them and store them.

      1. MAPREDUCE-5432.1.patch
        4 kB
        Tsuyoshi Ozawa
      2. MAPREDUCE-5432.2.patch
        4 kB
        Tsuyoshi Ozawa

        Activity

        Hide
        Tsuyoshi Ozawa added a comment -

        Updated JobHistoryServer to fetch these attributes from events.

        Show
        Tsuyoshi Ozawa added a comment - Updated JobHistoryServer to fetch these attributes from events.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12596342/MAPREDUCE-5432.1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3933//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3933//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12596342/MAPREDUCE-5432.1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3933//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3933//console This message is automatically generated.
        Hide
        Vrushali C added a comment -

        A few minor comments:

        + printAttributes("CLOCK_SPLIT", clockSplits);
        + printAttributes("CPU_USAGE", cpuUsages);
        Maybe print it as "CLOCK_SPLITS" AND "CPU_USAGES" so that it is consistent with the naming of the attribute?

        for the following function:
        + void printAttributes(String tag, int[] attributes) {
        + for (int i=0;i<attributes.length;i++)

        { + System.out.println(tag + "[" + i + "]:" + attributes[i]); + }

        + }

        I believe it would print it as:
        CLOCK_SPLIT[0]: 8691
        CLOCK_SPLIT[1]: 129
        CLOCK_SPLIT[2]: 128
        CLOCK_SPLIT[3]: 129
        CLOCK_SPLIT[4]: 128
        ... etc

        Would it be slightly better to print it as:
        "clockSplits":[8691,129,128,129,128,129,128,129,128,129,128,129]
        "cpuUsages":[28,28,29,28,28,29,28,28,29,28,28,29]

        Show
        Vrushali C added a comment - A few minor comments: + printAttributes("CLOCK_SPLIT", clockSplits); + printAttributes("CPU_USAGE", cpuUsages); Maybe print it as "CLOCK_SPLITS" AND "CPU_USAGES" so that it is consistent with the naming of the attribute? for the following function: + void printAttributes(String tag, int[] attributes) { + for (int i=0;i<attributes.length;i++) { + System.out.println(tag + "[" + i + "]:" + attributes[i]); + } + } I believe it would print it as: CLOCK_SPLIT [0] : 8691 CLOCK_SPLIT [1] : 129 CLOCK_SPLIT [2] : 128 CLOCK_SPLIT [3] : 129 CLOCK_SPLIT [4] : 128 ... etc Would it be slightly better to print it as: "clockSplits": [8691,129,128,129,128,129,128,129,128,129,128,129] "cpuUsages": [28,28,29,28,28,29,28,28,29,28,28,29]
        Hide
        Tsuyoshi Ozawa added a comment -

        Vrushali C:Thanks for your reviewing. I updated patch based on your comments. Additionally, I added null check before call printAttributes because it's also done before printing counters' values.

        Show
        Tsuyoshi Ozawa added a comment - Vrushali C :Thanks for your reviewing. I updated patch based on your comments. Additionally, I added null check before call printAttributes because it's also done before printing counters' values.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12596548/MAPREDUCE-5432.2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3935//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3935//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12596548/MAPREDUCE-5432.2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3935//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3935//console This message is automatically generated.
        Hide
        Vrushali C added a comment -

        Thanks, looks good to me.

        Show
        Vrushali C added a comment - Thanks, looks good to me.
        Hide
        Arun C Murthy added a comment -

        Tsuyoshi Ozawa Patch looks good. Can you pls modify existing tests to check for the new values? Tx.

        Show
        Arun C Murthy added a comment - Tsuyoshi Ozawa Patch looks good. Can you pls modify existing tests to check for the new values? Tx.

          People

          • Assignee:
            Tsuyoshi Ozawa
            Reporter:
            Vrushali C
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:

              Development