[MAPREDUCE-5316] job -list-attempt-ids command does not handle illegal task-state

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.4-alpha, 0.23.8, 3.0.0-alpha1
• Fix Version/s: 0.23.9, 2.3.0
• Component/s: client
• Target Version/s: 2.1.0-beta, 0.23.9
• Hadoop Flags: Reviewed
• Assignee: Ashwin Shankar
• Reporter: Ashwin Shankar
• Created: 10/Jun/13 22:27
• Updated: 12/May/16 18:22
• Resolved: 18/Jun/13 20:40

Description

Courtesy : mikanboy

job -list-attempt-ids command should handle illegal argument for <task-state>
the same way as <task-type>. Right now only illegal <task-type> is handle by
an exception being thrown. Illegal <task-state> on the other hand does not
throw exception. For example is a user mistype 'completed' as 'complete', they
may wrongly think there are no completed tasks, instead of being notified of
the illegal <task-state> that was used.

1) illegal <task-type> handled.

[philips@gwbl2003:4095 ~/svn/HadoopQEAutomation/branch-23]$
/home/gs/gridre/yroot.theoden/share/hadoop/bin/mapred job -list-attempt-ids
job_1345673924741_0086 map completed
12/08/24 15:16:31 WARN conf.Configuration: mapred.used.genericoptionsparser is
deprecated. Instead, use mapreduce.client.genericoptionsparser.used
Exception in thread "main" java.lang.IllegalArgumentException: No enum const
class org.apache.hadoop.mapreduce.TaskType.map
at java.lang.Enum.valueOf(Enum.java:196)
at org.apache.hadoop.mapreduce.TaskType.valueOf(TaskType.java:27)
at org.apache.hadoop.mapreduce.tools.CLI.displayTasks(CLI.java:553)
at org.apache.hadoop.mapreduce.tools.CLI.run(CLI.java:309)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:69)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:83)
at org.apache.hadoop.mapred.JobClient.main(JobClient.java:1242)

1) illegal <task-state> not handled.

/home/gs/gridre/yroot.theoden/share/hadoop/bin/mapred job -list-attempt-ids
job_1345673924741_0086 MAP complete
12/08/24 15:15:47 WARN conf.Configuration: mapred.used.genericoptionsparser is
deprecated. Instead, use mapreduce.client.genericoptionsparser.used

Also,we could make input task-state to be case-insensitive to be consistent with
task-type behavior(MAPREDUCE-4019).