Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-5190

Unnecessary condition test in RandomSampler

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 2.6.0
    • 2.8.0, 3.0.0-alpha1
    • mrv2
    • None
    • Reviewed

    Description

      In getSampe method, there is a condition test after "int ind = r.nextInt(numSamples);". The test is "(ind != numSamples)".
      This test is unneeded since nextInt(numSamples) will not return numSamples.

      Attachments

        1. MAPREDUCE-5190.patch
          1 kB
          Jingguo Yao

        Activity

          People

            yaojingguo Jingguo Yao
            yaojingguo Jingguo Yao
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 20m
                20m
                Remaining:
                Remaining Estimate - 20m
                20m
                Logged:
                Time Spent - Not Specified
                Not Specified