Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: mrv2
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In getSampe method, there is a condition test after "int ind = r.nextInt(numSamples);". The test is "(ind != numSamples)".
      This test is unneeded since nextInt(numSamples) will not return numSamples.

        Activity

        Hide
        yaojingguo Jingguo Yao added a comment -

        Patch available.

        Show
        yaojingguo Jingguo Yao added a comment - Patch available.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12580837/MAPREDUCE-5190.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3552//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3552//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12580837/MAPREDUCE-5190.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3552//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3552//console This message is automatically generated.
        Hide
        qwertymaniac Harsh J added a comment -

        +1, change looks good to me (http://docs.oracle.com/javase/7/docs/api/java/util/Random.html#nextInt(int))

        Committing shortly. Thanks Jingguo!

        Show
        qwertymaniac Harsh J added a comment - +1, change looks good to me ( http://docs.oracle.com/javase/7/docs/api/java/util/Random.html#nextInt(int )) Committing shortly. Thanks Jingguo!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7397 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7397/)
        MAPREDUCE-5190. Unnecessary condition test in RandomSampler. Contributed by Jingguo Yao. (harsh: rev 1d5c796d654c8959972d15cc6742731a99380bfc)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/partition/InputSampler.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7397 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7397/ ) MAPREDUCE-5190 . Unnecessary condition test in RandomSampler. Contributed by Jingguo Yao. (harsh: rev 1d5c796d654c8959972d15cc6742731a99380bfc) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/partition/InputSampler.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #140 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/140/)
        MAPREDUCE-5190. Unnecessary condition test in RandomSampler. Contributed by Jingguo Yao. (harsh: rev 1d5c796d654c8959972d15cc6742731a99380bfc)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/partition/InputSampler.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #140 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/140/ ) MAPREDUCE-5190 . Unnecessary condition test in RandomSampler. Contributed by Jingguo Yao. (harsh: rev 1d5c796d654c8959972d15cc6742731a99380bfc) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/partition/InputSampler.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #874 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/874/)
        MAPREDUCE-5190. Unnecessary condition test in RandomSampler. Contributed by Jingguo Yao. (harsh: rev 1d5c796d654c8959972d15cc6742731a99380bfc)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/partition/InputSampler.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #874 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/874/ ) MAPREDUCE-5190 . Unnecessary condition test in RandomSampler. Contributed by Jingguo Yao. (harsh: rev 1d5c796d654c8959972d15cc6742731a99380bfc) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/partition/InputSampler.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2072 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2072/)
        MAPREDUCE-5190. Unnecessary condition test in RandomSampler. Contributed by Jingguo Yao. (harsh: rev 1d5c796d654c8959972d15cc6742731a99380bfc)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/partition/InputSampler.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2072 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2072/ ) MAPREDUCE-5190 . Unnecessary condition test in RandomSampler. Contributed by Jingguo Yao. (harsh: rev 1d5c796d654c8959972d15cc6742731a99380bfc) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/partition/InputSampler.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #131 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/131/)
        MAPREDUCE-5190. Unnecessary condition test in RandomSampler. Contributed by Jingguo Yao. (harsh: rev 1d5c796d654c8959972d15cc6742731a99380bfc)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/partition/InputSampler.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #131 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/131/ ) MAPREDUCE-5190 . Unnecessary condition test in RandomSampler. Contributed by Jingguo Yao. (harsh: rev 1d5c796d654c8959972d15cc6742731a99380bfc) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/partition/InputSampler.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #140 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/140/)
        MAPREDUCE-5190. Unnecessary condition test in RandomSampler. Contributed by Jingguo Yao. (harsh: rev 1d5c796d654c8959972d15cc6742731a99380bfc)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/partition/InputSampler.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #140 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/140/ ) MAPREDUCE-5190 . Unnecessary condition test in RandomSampler. Contributed by Jingguo Yao. (harsh: rev 1d5c796d654c8959972d15cc6742731a99380bfc) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/partition/InputSampler.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2090 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2090/)
        MAPREDUCE-5190. Unnecessary condition test in RandomSampler. Contributed by Jingguo Yao. (harsh: rev 1d5c796d654c8959972d15cc6742731a99380bfc)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/partition/InputSampler.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2090 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2090/ ) MAPREDUCE-5190 . Unnecessary condition test in RandomSampler. Contributed by Jingguo Yao. (harsh: rev 1d5c796d654c8959972d15cc6742731a99380bfc) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/partition/InputSampler.java hadoop-mapreduce-project/CHANGES.txt

          People

          • Assignee:
            yaojingguo Jingguo Yao
            Reporter:
            yaojingguo Jingguo Yao
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 20m
              20m
              Remaining:
              Remaining Estimate - 20m
              20m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development