[MAPREDUCE-5098] Fix findbugs warnings in gridmix - ASF JIRA

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.0.3-alpha
Fix Version/s: 2.1.0-beta
Component/s: contrib/gridmix
Labels:
- findbugs

Target Version/s:

2.1.0-beta
Hadoop Flags:

Reviewed

Description

Work on ~~MAPREDUCE-5077~~ has exposed a bunch of findbugs warnings in gridmix code.

https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3459//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-gridmix.html

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending

Attachments

mr-5098.patch

23/Mar/13 02:40

6 kB

Karthik Kambatla
mr-5098.patch

26/Mar/13 20:24

6 kB

Karthik Kambatla
mr-5098.patch

28/Mar/13 19:54

7 kB

Karthik Kambatla

Issue Links

is blocked by

MAPREDUCE-5077 Cleanup: mapreduce.util.ResourceCalculatorPlugin and related code should be removed

Closed

is duplicated by

MAPREDUCE-4239 gridmix has 11 findbugs warnings

Resolved

relates to

MAPREDUCE-5077 Cleanup: mapreduce.util.ResourceCalculatorPlugin and related code should be removed

Closed

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Karthik Kambatla (Inactive) added a comment - 23/Mar/13 02:40

Uploading a straight-forward patch to fix the findbugs warnings.

Show

Karthik Kambatla (Inactive) added a comment - 23/Mar/13 02:40 Uploading a straight-forward patch to fix the findbugs warnings.

Hide

Permalink

Karthik Kambatla (Inactive) added a comment - 23/Mar/13 02:49

The patch is generated on top of ~~MAPREDUCE-5077~~ patch and hence should wait until that goes in.

Show

Karthik Kambatla (Inactive) added a comment - 23/Mar/13 02:49 The patch is generated on top of MAPREDUCE-5077 patch and hence should wait until that goes in.

Hide

Permalink

Karthik Kambatla (Inactive) added a comment - 26/Mar/13 20:24

Rebased on trunk after ~~MAPREDUCE-5077~~ is committed.

Show

Karthik Kambatla (Inactive) added a comment - 26/Mar/13 20:24 Rebased on trunk after MAPREDUCE-5077 is committed.

Hide

Permalink

Thomas Graves added a comment - 26/Mar/13 20:30

we can probably dup ~~MAPREDUCE-4239~~ to this

Show

Thomas Graves added a comment - 26/Mar/13 20:30 we can probably dup MAPREDUCE-4239 to this

Hide

Permalink

Karthik Kambatla (Inactive) added a comment - 26/Mar/13 20:43

Thanks Thomas, the findbugs warnings look the same to me. Should have looked for existing JIRAs before creating this. For now, resolved ~~MAPREDUCE-4239~~ as duplicate. In the future, will try to remember to search for existing open JIRAs.

Show

Karthik Kambatla (Inactive) added a comment - 26/Mar/13 20:43 Thanks Thomas, the findbugs warnings look the same to me. Should have looked for existing JIRAs before creating this. For now, resolved MAPREDUCE-4239 as duplicate. In the future, will try to remember to search for existing open JIRAs.

Hide

Permalink

Hadoop QA added a comment - 27/Mar/13 03:18

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12575573/mr-5098.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

-1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed unit tests in hadoop-tools/hadoop-gridmix.

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3472//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3472//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-gridmix.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3472//console

This message is automatically generated.

Show

Hadoop QA added a comment - 27/Mar/13 03:18 -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12575573/mr-5098.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-tools/hadoop-gridmix. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3472//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3472//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-gridmix.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3472//console This message is automatically generated.

Hide

Permalink

Karthik Kambatla (Inactive) added a comment - 28/Mar/13 19:54

Addressing the remaining findbugs.

Show

Karthik Kambatla (Inactive) added a comment - 28/Mar/13 19:54 Addressing the remaining findbugs.

Hide

Permalink

Hadoop QA added a comment - 29/Mar/13 00:03

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12575942/mr-5098.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed unit tests in hadoop-tools/hadoop-gridmix.

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3477//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3477//console

This message is automatically generated.

Show

Hadoop QA added a comment - 29/Mar/13 00:03 -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12575942/mr-5098.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-tools/hadoop-gridmix. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3477//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3477//console This message is automatically generated.

Hide

Permalink

Karthik Kambatla (Inactive) added a comment - 29/Mar/13 00:24

The patch is strictly meant to fix findbugs warnings and doesn't add any additional code - hence the lack of tests.

Show

Karthik Kambatla (Inactive) added a comment - 29/Mar/13 00:24 The patch is strictly meant to fix findbugs warnings and doesn't add any additional code - hence the lack of tests.

Hide

Permalink

Alejandro Abdelnur added a comment - 03/Apr/13 21:21

Show

Alejandro Abdelnur added a comment - 03/Apr/13 21:21 +1

Hide

Permalink

Alejandro Abdelnur added a comment - 03/Apr/13 21:22

Thanks Karthik. Committed to trunk, waiting to commit on branch-2 till CHANGES.txt gets fixed.

Show

Alejandro Abdelnur added a comment - 03/Apr/13 21:22 Thanks Karthik. Committed to trunk, waiting to commit on branch-2 till CHANGES.txt gets fixed.

Hide

Permalink

Hudson added a comment - 03/Apr/13 21:35

Integrated in Hadoop-trunk-Commit #3557 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3557/)
~~MAPREDUCE-5098~~. Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209)

Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209
Files :

/hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java

Show

Hudson added a comment - 03/Apr/13 21:35 Integrated in Hadoop-trunk-Commit #3557 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3557/ ) MAPREDUCE-5098 . Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java

Hide

Permalink

Hudson added a comment - 04/Apr/13 10:48

Integrated in Hadoop-Yarn-trunk #174 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/174/)
~~MAPREDUCE-5098~~. Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209)

Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209
Files :

/hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java

Show

Hudson added a comment - 04/Apr/13 10:48 Integrated in Hadoop-Yarn-trunk #174 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/174/ ) MAPREDUCE-5098 . Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java

Hide

Permalink

Hudson added a comment - 04/Apr/13 13:09

Integrated in Hadoop-Hdfs-trunk #1363 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1363/)
~~MAPREDUCE-5098~~. Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209)

Result = FAILURE
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209
Files :

/hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java

Show

Hudson added a comment - 04/Apr/13 13:09 Integrated in Hadoop-Hdfs-trunk #1363 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1363/ ) MAPREDUCE-5098 . Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java

Hide

Permalink

Hudson added a comment - 04/Apr/13 14:05

Integrated in Hadoop-Mapreduce-trunk #1390 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1390/)
~~MAPREDUCE-5098~~. Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209)

Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209
Files :

/hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java
/hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java

Show

Hudson added a comment - 04/Apr/13 14:05 Integrated in Hadoop-Mapreduce-trunk #1390 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1390/ ) MAPREDUCE-5098 . Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java

Hide

Permalink

Alejandro Abdelnur added a comment - 11/Apr/13 13:09

Committed to branch-2 (thanks Sid for fixing CHANGES.txt)

Show

Alejandro Abdelnur added a comment - 11/Apr/13 13:09 Committed to branch-2 (thanks Sid for fixing CHANGES.txt)

People

Assignee:

Karthik Kambatla

Reporter:

Karthik Kambatla

Votes:

0 Vote for this issue

Watchers:

8 Start watching this issue

Dates

Created:

23/Mar/13 01:17

Updated:

03/Nov/14 18:33

Resolved:

11/Apr/13 13:09

Development

Agile

View on Board