Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-5098

Fix findbugs warnings in gridmix

        Details

        • Hadoop Flags:
          Reviewed
        • Target Version/s:
        1. Text File
          mr-5098.patch
          7 kB
          Karthik Kambatla
        2. Text File
          mr-5098.patch
          6 kB
          Karthik Kambatla
        3. Text File
          mr-5098.patch
          6 kB
          Karthik Kambatla

          Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. MAPREDUCE-5077 Cleanup: mapreduce.util.ResourceCalculatorPlugin and related code should be removed

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. MAPREDUCE-4239 gridmix has 11 findbugs warnings

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MAPREDUCE-5077 Cleanup: mapreduce.util.ResourceCalculatorPlugin and related code should be removed

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

            Activity

            Descending order - Click to sort in ascending order
            Arun C Murthy made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            Alejandro Abdelnur made changes -
            Status Patch Available [ 10002 ] Resolved [ 5 ]
            Hadoop Flags Reviewed [ 10343 ]
            Fix Version/s 2.0.5-beta [ 12324032 ]
            Resolution Fixed [ 1 ]
            Hide
            Permalink
            Alejandro Abdelnur added a comment -

            Committed to branch-2 (thanks Sid for fixing CHANGES.txt)

            Show
            Alejandro Abdelnur added a comment - Committed to branch-2 (thanks Sid for fixing CHANGES.txt)
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Mapreduce-trunk #1390 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1390/)
            MAPREDUCE-5098. Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209)

            Result = SUCCESS
            tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209
            Files :

            • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java
            Show
            Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1390 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1390/ ) MAPREDUCE-5098 . Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Hdfs-trunk #1363 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1363/)
            MAPREDUCE-5098. Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209)

            Result = FAILURE
            tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209
            Files :

            • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java
            Show
            Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1363 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1363/ ) MAPREDUCE-5098 . Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Yarn-trunk #174 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/174/)
            MAPREDUCE-5098. Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209)

            Result = SUCCESS
            tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209
            Files :

            • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java
            Show
            Hudson added a comment - Integrated in Hadoop-Yarn-trunk #174 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/174/ ) MAPREDUCE-5098 . Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-trunk-Commit #3557 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3557/)
            MAPREDUCE-5098. Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209)

            Result = SUCCESS
            tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209
            Files :

            • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java
            • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java
            Show
            Hudson added a comment - Integrated in Hadoop-trunk-Commit #3557 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3557/ ) MAPREDUCE-5098 . Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java
            Hide
            Permalink
            Alejandro Abdelnur added a comment -

            Thanks Karthik. Committed to trunk, waiting to commit on branch-2 till CHANGES.txt gets fixed.

            Show
            Alejandro Abdelnur added a comment - Thanks Karthik. Committed to trunk, waiting to commit on branch-2 till CHANGES.txt gets fixed.
            Hide
            Permalink
            Alejandro Abdelnur added a comment -

            +1

            Show
            Alejandro Abdelnur added a comment - +1
            Hide
            Permalink
            Karthik Kambatla added a comment -

            The patch is strictly meant to fix findbugs warnings and doesn't add any additional code - hence the lack of tests.

            Show
            Karthik Kambatla added a comment - The patch is strictly meant to fix findbugs warnings and doesn't add any additional code - hence the lack of tests.
            Hide
            Permalink
            Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12575942/mr-5098.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 eclipse:eclipse. The patch built with eclipse:eclipse.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed unit tests in hadoop-tools/hadoop-gridmix.

            +1 contrib tests. The patch passed contrib unit tests.

            Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3477//testReport/
            Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3477//console

            This message is automatically generated.

            Show
            Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12575942/mr-5098.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-tools/hadoop-gridmix. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3477//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3477//console This message is automatically generated.
            Karthik Kambatla made changes -
            Status Open [ 1 ] Patch Available [ 10002 ]
            Karthik Kambatla made changes -
            Attachment mr-5098.patch [ 12575942 ]
            Hide
            Permalink
            Karthik Kambatla added a comment -

            Addressing the remaining findbugs.

            Show
            Karthik Kambatla added a comment - Addressing the remaining findbugs.
            Karthik Kambatla made changes -
            Status Patch Available [ 10002 ] Open [ 1 ]
            Hide
            Permalink
            Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12575573/mr-5098.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 eclipse:eclipse. The patch built with eclipse:eclipse.

            -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed unit tests in hadoop-tools/hadoop-gridmix.

            +1 contrib tests. The patch passed contrib unit tests.

            Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3472//testReport/
            Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3472//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-gridmix.html
            Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3472//console

            This message is automatically generated.

            Show
            Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12575573/mr-5098.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-tools/hadoop-gridmix. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3472//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3472//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-gridmix.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3472//console This message is automatically generated.
            Hide
            Permalink
            Karthik Kambatla added a comment -

            Thanks Thomas, the findbugs warnings look the same to me. Should have looked for existing JIRAs before creating this. For now, resolved MAPREDUCE-4239 as duplicate. In the future, will try to remember to search for existing open JIRAs.

            Show
            Karthik Kambatla added a comment - Thanks Thomas, the findbugs warnings look the same to me. Should have looked for existing JIRAs before creating this. For now, resolved MAPREDUCE-4239 as duplicate. In the future, will try to remember to search for existing open JIRAs.
            Karthik Kambatla made changes -
            Link This issue is duplicated by MAPREDUCE-4239 [ MAPREDUCE-4239 ]
            Hide
            Permalink
            Thomas Graves added a comment -

            we can probably dup MAPREDUCE-4239 to this

            Show
            Thomas Graves added a comment - we can probably dup MAPREDUCE-4239 to this
            Karthik Kambatla made changes -
            Status Open [ 1 ] Patch Available [ 10002 ]
            Karthik Kambatla made changes -
            Attachment mr-5098.patch [ 12575573 ]
            Hide
            Permalink
            Karthik Kambatla added a comment -

            Rebased on trunk after MAPREDUCE-5077 is committed.

            Show
            Karthik Kambatla added a comment - Rebased on trunk after MAPREDUCE-5077 is committed.
            Hide
            Permalink
            Karthik Kambatla added a comment -

            The patch is generated on top of MAPREDUCE-5077 patch and hence should wait until that goes in.

            Show
            Karthik Kambatla added a comment - The patch is generated on top of MAPREDUCE-5077 patch and hence should wait until that goes in.
            Karthik Kambatla made changes -
            Attachment mr-5098.patch [ 12575147 ]
            Hide
            Permalink
            Karthik Kambatla added a comment -

            Uploading a straight-forward patch to fix the findbugs warnings.

            Show
            Karthik Kambatla added a comment - Uploading a straight-forward patch to fix the findbugs warnings.
            Karthik Kambatla made changes -
            Link This issue is blocked by MAPREDUCE-5077 [ MAPREDUCE-5077 ]
            Karthik Kambatla made changes -
            Field Original Value New Value
            Link This issue relates to MAPREDUCE-5077 [ MAPREDUCE-5077 ]
            Karthik Kambatla created issue -

              People

              • Assignee:
                Karthik Kambatla
                Reporter:
                Karthik Kambatla
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development