Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    1. mr-5098.patch
      6 kB
      Karthik Kambatla
    2. mr-5098.patch
      6 kB
      Karthik Kambatla
    3. mr-5098.patch
      7 kB
      Karthik Kambatla

      Issue Links

        Activity

        Hide
        kkambatl Karthik Kambatla (Inactive) added a comment -

        Uploading a straight-forward patch to fix the findbugs warnings.

        Show
        kkambatl Karthik Kambatla (Inactive) added a comment - Uploading a straight-forward patch to fix the findbugs warnings.
        Hide
        kkambatl Karthik Kambatla (Inactive) added a comment -

        The patch is generated on top of MAPREDUCE-5077 patch and hence should wait until that goes in.

        Show
        kkambatl Karthik Kambatla (Inactive) added a comment - The patch is generated on top of MAPREDUCE-5077 patch and hence should wait until that goes in.
        Hide
        kkambatl Karthik Kambatla (Inactive) added a comment -

        Rebased on trunk after MAPREDUCE-5077 is committed.

        Show
        kkambatl Karthik Kambatla (Inactive) added a comment - Rebased on trunk after MAPREDUCE-5077 is committed.
        Hide
        tgraves Thomas Graves added a comment -

        we can probably dup MAPREDUCE-4239 to this

        Show
        tgraves Thomas Graves added a comment - we can probably dup MAPREDUCE-4239 to this
        Hide
        kkambatl Karthik Kambatla (Inactive) added a comment -

        Thanks Thomas, the findbugs warnings look the same to me. Should have looked for existing JIRAs before creating this. For now, resolved MAPREDUCE-4239 as duplicate. In the future, will try to remember to search for existing open JIRAs.

        Show
        kkambatl Karthik Kambatla (Inactive) added a comment - Thanks Thomas, the findbugs warnings look the same to me. Should have looked for existing JIRAs before creating this. For now, resolved MAPREDUCE-4239 as duplicate. In the future, will try to remember to search for existing open JIRAs.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12575573/mr-5098.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-tools/hadoop-gridmix.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3472//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3472//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-gridmix.html
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3472//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12575573/mr-5098.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-tools/hadoop-gridmix. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3472//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3472//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-gridmix.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3472//console This message is automatically generated.
        Hide
        kkambatl Karthik Kambatla (Inactive) added a comment -

        Addressing the remaining findbugs.

        Show
        kkambatl Karthik Kambatla (Inactive) added a comment - Addressing the remaining findbugs.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12575942/mr-5098.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-tools/hadoop-gridmix.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3477//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3477//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12575942/mr-5098.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-tools/hadoop-gridmix. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3477//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3477//console This message is automatically generated.
        Hide
        kkambatl Karthik Kambatla (Inactive) added a comment -

        The patch is strictly meant to fix findbugs warnings and doesn't add any additional code - hence the lack of tests.

        Show
        kkambatl Karthik Kambatla (Inactive) added a comment - The patch is strictly meant to fix findbugs warnings and doesn't add any additional code - hence the lack of tests.
        Hide
        tucu00 Alejandro Abdelnur added a comment -

        +1

        Show
        tucu00 Alejandro Abdelnur added a comment - +1
        Hide
        tucu00 Alejandro Abdelnur added a comment -

        Thanks Karthik. Committed to trunk, waiting to commit on branch-2 till CHANGES.txt gets fixed.

        Show
        tucu00 Alejandro Abdelnur added a comment - Thanks Karthik. Committed to trunk, waiting to commit on branch-2 till CHANGES.txt gets fixed.
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3557 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3557/)
        MAPREDUCE-5098. Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-trunk-Commit #3557 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3557/ ) MAPREDUCE-5098 . Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #174 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/174/)
        MAPREDUCE-5098. Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Yarn-trunk #174 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/174/ ) MAPREDUCE-5098 . Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1363 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1363/)
        MAPREDUCE-5098. Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1363 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1363/ ) MAPREDUCE-5098 . Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1390 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1390/)
        MAPREDUCE-5098. Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1390 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1390/ ) MAPREDUCE-5098 . Fix findbugs warnings in gridmix. (kkambatl via tucu) (Revision 1464209) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464209 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/dev-support/findbugs-exclude.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/JobMonitor.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/SleepJob.java /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/emulators/resourceusage/TotalHeapUsageEmulatorPlugin.java
        Hide
        tucu00 Alejandro Abdelnur added a comment -

        Committed to branch-2 (thanks Sid for fixing CHANGES.txt)

        Show
        tucu00 Alejandro Abdelnur added a comment - Committed to branch-2 (thanks Sid for fixing CHANGES.txt)

          People

          • Assignee:
            kasha Karthik Kambatla
            Reporter:
            kasha Karthik Kambatla
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development