Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      My IDE flags a lot of trouble in the JobTracker code, but I dont want to mix those changes with any lifecycle changes. After doing that, then I'd like to clean up the code in JobTracker

      -move to generic types and foreach loops over Vector and iterators.
      -give all threads the correct type
      -stop using package scoped static variables to pass instance-data around specifically
      TASKTRACKER_EXPIRY_INTERVAL
      RETIRE_JOB_CHECK_INTERVAL
      RETIRE_JOB_INTERVAL
      -fix up all the javadoc warnings
      -remove the needless this. references on lots of local variables
      -replace the log + stringifyException with log(text,exception).

      Its only an hour or so of work, and would improve the code maintainability, but it would make merging existing code harder.

        Activity

        steve_l created issue -
        Hide
        Vivek Ratan added a comment -

        I'd suggest that you should go ahead and provide a patch. HADOOP-3412, which changed JobTracker.java a fair bit, is committed. Most of the scheduler work will affect other classes, not JobTracker.

        Show
        Vivek Ratan added a comment - I'd suggest that you should go ahead and provide a patch. HADOOP-3412 , which changed JobTracker.java a fair bit, is committed. Most of the scheduler work will affect other classes, not JobTracker.
        Owen O'Malley made changes -
        Field Original Value New Value
        Project Hadoop Common [ 12310240 ] Hadoop Map/Reduce [ 12310941 ]
        Key HADOOP-3888 MAPREDUCE-500
        Affects Version/s 0.19.0 [ 12313211 ]
        Component/s mapred [ 12310690 ]
        Gavin made changes -
        Reporter Steve Loughran [ steve_l ] Steve Loughran [ stevel@apache.org ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Steve Loughran
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development