Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4990

Construct debug strings conditionally in ShuffleHandler.Shuffle#sendMapOutput()

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.3-alpha, 0.23.5
    • Fix Version/s: 0.23.7, 2.1.0-beta
    • Component/s: None
    • Labels:
      None

      Description

      In #sendMapOutput(), the debug statements are not wrapped in the customary #isDebugEnabled() condition. Given this piece of code is critical for performance, it would be nice to fix it.

      1. mr-4990.patch
        2 kB
        Karthik Kambatla

        Activity

        Gavin made changes -
        Reporter Karthik Kambatla [ kkambatl ] Karthik Kambatla [ kasha ]
        Gavin made changes -
        Assignee Karthik Kambatla [ kkambatl ] Karthik Kambatla [ kasha ]
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Thomas Graves made changes -
        Fix Version/s 0.23.7 [ 12323954 ]
        Alejandro Abdelnur made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 2.0.5-beta [ 12324032 ]
        Resolution Fixed [ 1 ]
        Karthik Kambatla (Inactive) made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Karthik Kambatla (Inactive) made changes -
        Attachment mr-4990.patch [ 12573231 ]
        Karthik Kambatla (Inactive) made changes -
        Field Original Value New Value
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Karthik Kambatla (Inactive) created issue -

          People

          • Assignee:
            Karthik Kambatla
            Reporter:
            Karthik Kambatla
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development