Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4990

Construct debug strings conditionally in ShuffleHandler.Shuffle#sendMapOutput()

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.3-alpha, 0.23.5
    • Fix Version/s: 0.23.7, 2.1.0-beta
    • Component/s: None
    • Labels:
      None

      Description

      In #sendMapOutput(), the debug statements are not wrapped in the customary #isDebugEnabled() condition. Given this piece of code is critical for performance, it would be nice to fix it.

      1. mr-4990.patch
        2 kB
        Karthik Kambatla

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #559 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/559/)
        MAPREDUCE-4990. Construct debug strings conditionally in ShuffleHandler.Shuffle#sendMapOutput(). (kkambatl via tgraves) (Revision 1458376)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1458376
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #559 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/559/ ) MAPREDUCE-4990 . Construct debug strings conditionally in ShuffleHandler.Shuffle#sendMapOutput(). (kkambatl via tgraves) (Revision 1458376) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1458376 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
        Hide
        Thomas Graves added a comment -

        I merged this into branch-0.23

        Show
        Thomas Graves added a comment - I merged this into branch-0.23
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1377 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1377/)
        MAPREDUCE-4990. Construct debug strings conditionally in ShuffleHandler.Shuffle#sendMapOutput(). (kkambatl via tucu) (Revision 1457914)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1457914
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1377 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1377/ ) MAPREDUCE-4990 . Construct debug strings conditionally in ShuffleHandler.Shuffle#sendMapOutput(). (kkambatl via tucu) (Revision 1457914) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1457914 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1349 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1349/)
        MAPREDUCE-4990. Construct debug strings conditionally in ShuffleHandler.Shuffle#sendMapOutput(). (kkambatl via tucu) (Revision 1457914)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1457914
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1349 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1349/ ) MAPREDUCE-4990 . Construct debug strings conditionally in ShuffleHandler.Shuffle#sendMapOutput(). (kkambatl via tucu) (Revision 1457914) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1457914 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #160 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/160/)
        MAPREDUCE-4990. Construct debug strings conditionally in ShuffleHandler.Shuffle#sendMapOutput(). (kkambatl via tucu) (Revision 1457914)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1457914
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
        Show
        Hudson added a comment - Integrated in Hadoop-Yarn-trunk #160 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/160/ ) MAPREDUCE-4990 . Construct debug strings conditionally in ShuffleHandler.Shuffle#sendMapOutput(). (kkambatl via tucu) (Revision 1457914) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1457914 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3486 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3486/)
        MAPREDUCE-4990. Construct debug strings conditionally in ShuffleHandler.Shuffle#sendMapOutput(). (kkambatl via tucu) (Revision 1457914)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1457914
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
        Show
        Hudson added a comment - Integrated in Hadoop-trunk-Commit #3486 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3486/ ) MAPREDUCE-4990 . Construct debug strings conditionally in ShuffleHandler.Shuffle#sendMapOutput(). (kkambatl via tucu) (Revision 1457914) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1457914 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
        Hide
        Alejandro Abdelnur added a comment -

        Thanks Karthik. Committed to trunk and branch-2.

        Show
        Alejandro Abdelnur added a comment - Thanks Karthik. Committed to trunk and branch-2.
        Hide
        Alejandro Abdelnur added a comment -

        +1

        Show
        Alejandro Abdelnur added a comment - +1
        Hide
        Karthik Kambatla (Inactive) added a comment -

        I mean trivial and concern only log messages.

        Show
        Karthik Kambatla (Inactive) added a comment - I mean trivial and concern only log messages.
        Hide
        Karthik Kambatla (Inactive) added a comment -

        Didn't include a test because the changes are pretty trivial.

        Show
        Karthik Kambatla (Inactive) added a comment - Didn't include a test because the changes are pretty trivial.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12573231/mr-4990.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3402//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3402//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12573231/mr-4990.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3402//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3402//console This message is automatically generated.
        Hide
        Karthik Kambatla (Inactive) added a comment -

        Trivial patch that checks if the log is debug enabled before logging.

        Show
        Karthik Kambatla (Inactive) added a comment - Trivial patch that checks if the log is debug enabled before logging.

          People

          • Assignee:
            Karthik Kambatla
            Reporter:
            Karthik Kambatla
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development