-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12563672/MAPREDUCE-4923.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3207//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3207//console

This message is automatically generated.

This looks good; shall we also mark TaggedInputSplit public for those who wish to determine logic based on Context.getInputSplit()?

Almost all other input splits are public I think, including FileSplit.

That makes sense to me. Should it have InterfaceAudience.Stable?

Yes I suppose we could throw that in; there has not been drastic changes to it over the years. Besides, it implements the public interface of InputSplit anyway.

A test case, specifically for the use of a TIS#getFile method, would be good to catch any future i/face stability regressions.

TaggedInputSplit has no getFile method as far as I can tell?

+1. Please open another jira for the annotation changes, thx

Thanks Sandy. Committed to trunk, branch-1 and branch-2.

Integrated in Hadoop-trunk-Commit #3258 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3258/)
MAPREDUCE-4923. Add toString method to TaggedInputSplit. (sandyr via tucu) (Revision 1434993)

Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1434993
Files :

• /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
• /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/lib/TaggedInputSplit.java
• /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/TaggedInputSplit.java

Integrated in Hadoop-Yarn-trunk #100 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/100/)
MAPREDUCE-4923. Add toString method to TaggedInputSplit. (sandyr via tucu) (Revision 1434993)

Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1434993
Files :

• /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
• /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/lib/TaggedInputSplit.java
• /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/TaggedInputSplit.java

Integrated in Hadoop-Hdfs-trunk #1289 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1289/)
MAPREDUCE-4923. Add toString method to TaggedInputSplit. (sandyr via tucu) (Revision 1434993)

Result = FAILURE
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1434993
Files :

• /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
• /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/lib/TaggedInputSplit.java
• /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/TaggedInputSplit.java

Integrated in Hadoop-Mapreduce-trunk #1317 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1317/)
MAPREDUCE-4923. Add toString method to TaggedInputSplit. (sandyr via tucu) (Revision 1434993)

Result = FAILURE
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1434993
Files :

• /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
• /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/lib/TaggedInputSplit.java
• /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/TaggedInputSplit.java