Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Duplicate
    • Affects Version/s: 0.20.1, 0.21.0
    • Fix Version/s: 0.20.1, 0.21.0
    • Component/s: None
    • Labels:
      None

      Description

      DBInputFormat doesnt support interfacing with Oracle.

      1. HADOOP-5616.patch
        21 kB
        Amandeep Khurana

        Issue Links

          Activity

          Hide
          Amandeep Khurana added a comment -

          The query being generated inside DBInputFormat wasnt compatible with Oracle. It supported only MySQL, PostgreSQL etc.. Just added a check for the DB being connected to and the correct query for that.

          Show
          Amandeep Khurana added a comment - The query being generated inside DBInputFormat wasnt compatible with Oracle. It supported only MySQL, PostgreSQL etc.. Just added a check for the DB being connected to and the correct query for that.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12404480/HADOOP-5616.patch
          against trunk revision 761407.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no tests are needed for this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/102/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12404480/HADOOP-5616.patch against trunk revision 761407. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/102/console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12404480/HADOOP-5616.patch
          against trunk revision 761407.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no tests are needed for this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/103/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12404480/HADOOP-5616.patch against trunk revision 761407. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/103/console This message is automatically generated.
          Hide
          Amandeep Khurana added a comment -

          Updated patch

          Show
          Amandeep Khurana added a comment - Updated patch
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12404504/HADOOP-5616.patch
          against trunk revision 761482.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no tests are needed for this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/107/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/107/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/107/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/107/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12404504/HADOOP-5616.patch against trunk revision 761482. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/107/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/107/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/107/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/107/console This message is automatically generated.
          Hide
          Edward J. Yoon added a comment -

          Hey, I think that you need try to fix your coding style. There is a lot of unnecessary changes. for example,

          • private Statement statement;
            + private Statement statement;

          Also, I would recommend that use my code formatter – http://incubator.apache.org/hama/hama-eclipse-formatter.xml

          Rests are good.

          Show
          Edward J. Yoon added a comment - Hey, I think that you need try to fix your coding style. There is a lot of unnecessary changes. for example, private Statement statement; + private Statement statement; Also, I would recommend that use my code formatter – http://incubator.apache.org/hama/hama-eclipse-formatter.xml Rests are good.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12404504/HADOOP-5616.patch
          against trunk revision 761530.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no tests are needed for this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/108/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/108/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/108/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/108/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12404504/HADOOP-5616.patch against trunk revision 761530. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/108/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/108/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/108/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/108/console This message is automatically generated.
          Hide
          Edward J. Yoon added a comment -

          Please check my comment!

          Show
          Edward J. Yoon added a comment - Please check my comment!
          Hide
          Amandeep Khurana added a comment -

          Edward,

          I cant seem to figure out why the tests are failing.

          And using your formatting wouldnt help those changes. I tried it and ended up with similar number of changes.

          Amandeep

          Show
          Amandeep Khurana added a comment - Edward, I cant seem to figure out why the tests are failing. And using your formatting wouldnt help those changes. I tried it and ended up with similar number of changes. Amandeep
          Hide
          Edward J. Yoon added a comment -

          The test failures are not related with this patch.
          I was mean that patch is not readable since there are trivial changes by Tab spacing.

          See http://wiki.apache.org/hadoop/CodeReviewChecklist

          Show
          Edward J. Yoon added a comment - The test failures are not related with this patch. I was mean that patch is not readable since there are trivial changes by Tab spacing. See http://wiki.apache.org/hadoop/CodeReviewChecklist
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12404504/HADOOP-5616.patch
          against trunk revision 764287.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no tests are needed for this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/189/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/189/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/189/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/189/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12404504/HADOOP-5616.patch against trunk revision 764287. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/189/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/189/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/189/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/189/console This message is automatically generated.
          Hide
          Johan Oskarsson added a comment -

          Moving to 0.21.0 since it's an improvement

          Show
          Johan Oskarsson added a comment - Moving to 0.21.0 since it's an improvement
          Hide
          Amareshwari Sriramadasu added a comment -

          Please incorporate Edward comments. Patch is not readable.
          Also, submit the changes for new api also.

          Show
          Amareshwari Sriramadasu added a comment - Please incorporate Edward comments. Patch is not readable. Also, submit the changes for new api also.
          Hide
          Aaron Kimball added a comment -

          Another patch for this same issue (Oracle/DBIF integration) was available at HADOOP-5482. I have cleaned up that patch and attached the newest version there to that issue. It's considerably less code than this one.

          Show
          Aaron Kimball added a comment - Another patch for this same issue (Oracle/DBIF integration) was available at HADOOP-5482 . I have cleaned up that patch and attached the newest version there to that issue. It's considerably less code than this one.
          Hide
          Aaron Kimball added a comment -

          Related to the above comment, I moved HADOOP-5482 to MAPREDUCE-716.

          Show
          Aaron Kimball added a comment - Related to the above comment, I moved HADOOP-5482 to MAPREDUCE-716 .
          Hide
          Enis Soztutar added a comment -

          Resolving as a duplicate of MAPREDUCE-716.

          Show
          Enis Soztutar added a comment - Resolving as a duplicate of MAPREDUCE-716 .

            People

            • Assignee:
              Unassigned
              Reporter:
              Amandeep Khurana
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 2h
                2h
                Remaining:
                Remaining Estimate - 2h
                2h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development