Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.1
    • Fix Version/s: 1.1.2
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      TestWebUIAuthorization fails on branch-1

      1. MAPREDUCE-4858.patch
        3 kB
        Arun C Murthy
      2. MAPREDUCE-4858.patch
        3 kB
        Arun C Murthy

        Activity

        Hide
        Arun C Murthy added a comment -

        A combination of MAPREDUCE-4328 and more importantly, HADOOP-8343 broke this.

        Btw, not sure how/why HADOOP-8343 went in, looks like an incompatible change.

        Show
        Arun C Murthy added a comment - A combination of MAPREDUCE-4328 and more importantly, HADOOP-8343 broke this. Btw, not sure how/why HADOOP-8343 went in, looks like an incompatible change.
        Hide
        Mahadev konar added a comment -

        +1 the patch looks good to me.

        Show
        Mahadev konar added a comment - +1 the patch looks good to me.
        Hide
        Vinod Kumar Vavilapalli added a comment -

        Looks good.

        HADOOP-8988 is the issue. That and HADOOP-8343 should be reverted/fixed - a quick look tells me it can be done in a compatible way.

        Show
        Vinod Kumar Vavilapalli added a comment - Looks good. HADOOP-8988 is the issue. That and HADOOP-8343 should be reverted/fixed - a quick look tells me it can be done in a compatible way.
        Hide
        Arun C Murthy added a comment -

        Minor update to apply to branch-1.

        Show
        Arun C Murthy added a comment - Minor update to apply to branch-1.
        Hide
        Arun C Murthy added a comment -

        Thanks Mahadev & Vinod. I committed this for Matt to pick up for 1.1.2.

        Show
        Arun C Murthy added a comment - Thanks Mahadev & Vinod. I committed this for Matt to pick up for 1.1.2.
        Hide
        Arun C Murthy added a comment -

        FYI - I had to add a minor addendum to fix the merge since HADOOP-8988 isn't in branch-1.1. My bad.

        Index: src/test/org/apache/hadoop/mapred/TestWebUIAuthorization.java
        ===================================================================
        --- src/test/org/apache/hadoop/mapred/TestWebUIAuthorization.java	(revision 1418203)
        +++ src/test/org/apache/hadoop/mapred/TestWebUIAuthorization.java	(working copy)
        @@ -782,9 +782,6 @@
                 "true");
             props.setProperty(PolicyProvider.POLICY_PROVIDER_CONFIG, 
                 HadoopPolicyProvider.class.getName());
        -    props.setProperty(
        -        CommonConfigurationKeys.HADOOP_SECURITY_INSTRUMENTATION_REQUIRES_ADMIN, 
        -        "true");
             props.setProperty(JobConf.MR_ADMINS, mrAdminUser + " " + mrAdminGroup);
         
             startCluster(true, props);
        
        Show
        Arun C Murthy added a comment - FYI - I had to add a minor addendum to fix the merge since HADOOP-8988 isn't in branch-1.1. My bad. Index: src/test/org/apache/hadoop/mapred/TestWebUIAuthorization.java =================================================================== --- src/test/org/apache/hadoop/mapred/TestWebUIAuthorization.java (revision 1418203) +++ src/test/org/apache/hadoop/mapred/TestWebUIAuthorization.java (working copy) @@ -782,9 +782,6 @@ "true"); props.setProperty(PolicyProvider.POLICY_PROVIDER_CONFIG, HadoopPolicyProvider.class.getName()); - props.setProperty( - CommonConfigurationKeys.HADOOP_SECURITY_INSTRUMENTATION_REQUIRES_ADMIN, - "true"); props.setProperty(JobConf.MR_ADMINS, mrAdminUser + " " + mrAdminGroup); startCluster(true, props);
        Hide
        Matt Foley added a comment -

        Closed upon successful release of 1.1.2.

        Show
        Matt Foley added a comment - Closed upon successful release of 1.1.2.

          People

          • Assignee:
            Arun C Murthy
            Reporter:
            Arun C Murthy
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development