Details

    • Type: Test Test
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.2-alpha
    • Fix Version/s: 2.0.3-alpha
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      I am not sure whether it was intentional, but I found two identical copies of TestIndexCache.java one in hadoop-mapreduce-client-core and the other in hadoop-mapreduce-client-jobclient.

      If someone confirms me it was not intentional, I can submit a small patch on this.

      1. mapreduce-4803.patch
        12 kB
        Mariappan Asokan
      2. mapreduce-4803.patch
        12 kB
        Mariappan Asokan

        Activity

        Hide
        Mariappan Asokan added a comment -

        Deleted the one in mapreduce-client-core.

        Show
        Mariappan Asokan added a comment - Deleted the one in mapreduce-client-core.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12554089/mapreduce-4803.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3039//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3039//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12554089/mapreduce-4803.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3039//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3039//console This message is automatically generated.
        Hide
        Arun C Murthy added a comment -

        I think we are better off removing the one in hadoop-mapreduce-client-jobclient, no?

        Show
        Arun C Murthy added a comment - I think we are better off removing the one in hadoop-mapreduce-client-jobclient, no?
        Hide
        Mariappan Asokan added a comment -

        Hi Arun,
        I noticed that most of the tests are under mapreduce-client-jobclient. I was not sure about where the test belongs. I went with the majority If you think it belongs in mapreduce-client-core, I am uploading a new patch that deletes the one mapreduce-client-jobclient. Can you please commit it?

        Thanks.
        – Asokan

        Show
        Mariappan Asokan added a comment - Hi Arun, I noticed that most of the tests are under mapreduce-client-jobclient. I was not sure about where the test belongs. I went with the majority If you think it belongs in mapreduce-client-core, I am uploading a new patch that deletes the one mapreduce-client-jobclient. Can you please commit it? Thanks. – Asokan
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12554181/mapreduce-4803.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

        org.apache.hadoop.mapreduce.v2.TestMRJobsWithHistoryService

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3040//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3040//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12554181/mapreduce-4803.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.mapreduce.v2.TestMRJobsWithHistoryService +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3040//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3040//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12566655/mapreduce-4803.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3282//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3282//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12566655/mapreduce-4803.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3282//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3282//console This message is automatically generated.
        Hide
        Siddharth Seth added a comment -

        +1. Committing this. Thanks Asokan! IndexCache and the test can likely move over to the shuffle module - but that's independent of this.

        Show
        Siddharth Seth added a comment - +1. Committing this. Thanks Asokan! IndexCache and the test can likely move over to the shuffle module - but that's independent of this.
        Hide
        Siddharth Seth added a comment -

        Committed to trunk and branch-2 (removed the extra copy, no historic information lost by removing the copy on hadoop-mapreduce-client-jobclient).

        Show
        Siddharth Seth added a comment - Committed to trunk and branch-2 (removed the extra copy, no historic information lost by removing the copy on hadoop-mapreduce-client-jobclient).
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3288 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3288/)
        MAPREDUCE-4803. Remove duplicate copy of TestIndexCache. Contributed by Mariappan Asokan (Revision 1439590)

        Result = SUCCESS
        sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1439590
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestIndexCache.java
        Show
        Hudson added a comment - Integrated in Hadoop-trunk-Commit #3288 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3288/ ) MAPREDUCE-4803 . Remove duplicate copy of TestIndexCache. Contributed by Mariappan Asokan (Revision 1439590) Result = SUCCESS sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1439590 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestIndexCache.java
        Hide
        Mariappan Asokan added a comment -

        Thanks Siddharth for committing this.

        – Asokan

        Show
        Mariappan Asokan added a comment - Thanks Siddharth for committing this. – Asokan
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #111 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/111/)
        MAPREDUCE-4803. Remove duplicate copy of TestIndexCache. Contributed by Mariappan Asokan (Revision 1439590)

        Result = SUCCESS
        sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1439590
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestIndexCache.java
        Show
        Hudson added a comment - Integrated in Hadoop-Yarn-trunk #111 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/111/ ) MAPREDUCE-4803 . Remove duplicate copy of TestIndexCache. Contributed by Mariappan Asokan (Revision 1439590) Result = SUCCESS sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1439590 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestIndexCache.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1300 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1300/)
        MAPREDUCE-4803. Remove duplicate copy of TestIndexCache. Contributed by Mariappan Asokan (Revision 1439590)

        Result = SUCCESS
        sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1439590
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestIndexCache.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1300 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1300/ ) MAPREDUCE-4803 . Remove duplicate copy of TestIndexCache. Contributed by Mariappan Asokan (Revision 1439590) Result = SUCCESS sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1439590 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestIndexCache.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1328 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1328/)
        MAPREDUCE-4803. Remove duplicate copy of TestIndexCache. Contributed by Mariappan Asokan (Revision 1439590)

        Result = SUCCESS
        sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1439590
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestIndexCache.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1328 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1328/ ) MAPREDUCE-4803 . Remove duplicate copy of TestIndexCache. Contributed by Mariappan Asokan (Revision 1439590) Result = SUCCESS sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1439590 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestIndexCache.java

          People

          • Assignee:
            Mariappan Asokan
            Reporter:
            Mariappan Asokan
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development