Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4707

Add a comment to explain why FairScheduler#dump()'s body is synchronized on eventLog

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Trivial
    • Resolution: Won't Fix
    • 1.0.3
    • None
    • contrib/fair-share
    • None

    Description

      FairScheduler#dump() is a synchronized method. In addition to that, the entire method body is in a synchronized block on eventLog. However, there is no other portion of the code that tries to acquire a lock on eventLog. So, it seems like the second synchronized block is redundant, and can be removed.

      Attachments

        1. MR-4707.patch
          0.8 kB
          Karthik Kambatla
        2. MR-4707.patch
          4 kB
          Karthik Kambatla

        Activity

          People

            kasha Karthik Kambatla
            kasha Karthik Kambatla
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: