Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4697

TestMapredHeartbeat fails assertion on HeartbeatInterval

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.1
    • Fix Version/s: 1.1.2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TestMapredHeartbeat fails test on heart beat interval

          FAILED
      expected:<300> but was:<500>
      junit.framework.AssertionFailedError: expected:<300> but was:<500>
          at org.apache.hadoop.mapred.TestMapredHeartbeat.testJobDirCleanup(TestMapredHeartbeat.java:68)
      

      Replicate math for getNextHeartbeatInterval() in the test-case to ensure MRConstants changes do not break test-case.

        Activity

        Hide
        Gopal V added a comment -
        Show
        Gopal V added a comment - Possible test-case update needed to match https://github.com/apache/hadoop-common/commit/51fc4611f99ac3a1f797ec7403d3bb78ee94972e
        Hide
        Gopal V added a comment -

        patch to test case

        Show
        Gopal V added a comment - patch to test case
        Hide
        Gopal V added a comment -

        Replace constant in the test case with a calculated value so that the test-case will no longer go out of date when MRConstants.HEARTBEAT_INTERVAL_MIN is changed.

        Show
        Gopal V added a comment - Replace constant in the test case with a calculated value so that the test-case will no longer go out of date when MRConstants.HEARTBEAT_INTERVAL_MIN is changed.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12547839/mapreduce-4697.patch
        against trunk revision .

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2907//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12547839/mapreduce-4697.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2907//console This message is automatically generated.
        Hide
        Siddharth Seth added a comment -

        +1. Will commit shortly.

        Show
        Siddharth Seth added a comment - +1. Will commit shortly.
        Hide
        Siddharth Seth added a comment -

        Committed. Thanks Gopal!

        Show
        Siddharth Seth added a comment - Committed. Thanks Gopal!
        Hide
        Matt Foley added a comment -

        Closed upon successful release of 1.1.2.

        Show
        Matt Foley added a comment - Closed upon successful release of 1.1.2.

          People

          • Assignee:
            Gopal V
            Reporter:
            Gopal V
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development