Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4675

TestKillSubProcesses fails as the process is still alive after the job is done

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0, 1.2.0
    • Fix Version/s: 1.1.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Fixed a race condition caused in TestKillSubProcesses caused due to a recent commit.

      Description

      I ran this test in branch 1 and branch 1.1 and they both failed with the following

      Testcase: testJobKillFailAndSucceed took 82.219 sec
              FAILED
      null
      junit.framework.AssertionFailedError: null
              at org.apache.hadoop.mapred.TestKillSubProcesses.validateKillingSubprocesses(TestKillSubProcesses.java:245)
              at org.apache.hadoop.mapred.TestKillSubProcesses.runKillingJobAndValidate(TestKillSubProcesses.java:97)
              at org.apache.hadoop.mapred.TestKillSubProcesses.runTests(TestKillSubProcesses.java:336)
              at org.apache.hadoop.mapred.TestKillSubProcesses.testJobKillFailAndSucceed(TestKillSubProcesses.java:320)
      

        Activity

        Hide
        bikassaha Bikas Saha added a comment -

        A recent commit changed the heartbeat interval for small clusters that looks like it made this test race and fail. The MR parameter that was changed is final and so the test cannot override it. Working around by changing a different parameter that will change the heartbeat.

        Show
        bikassaha Bikas Saha added a comment - A recent commit changed the heartbeat interval for small clusters that looks like it made this test race and fail. The MR parameter that was changed is final and so the test cannot override it. Working around by changing a different parameter that will change the heartbeat.
        Hide
        acmurthy Arun C Murthy added a comment -

        +1, thanks for the fix Bikas!

        Show
        acmurthy Arun C Murthy added a comment - +1, thanks for the fix Bikas!
        Hide
        arpitgupta Arpit Gupta added a comment -

        Ran the test a few times with the patch attached and tests pass.

        Show
        arpitgupta Arpit Gupta added a comment - Ran the test a few times with the patch attached and tests pass.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Tx for the update, Arpit!

        This looks good. +1. Committing.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Tx for the update, Arpit! This looks good. +1. Committing.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Just committed this to branch-1 and branch-1.1. Thanks Bikas! And Arpit for reporting and verifying the fix!

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Just committed this to branch-1 and branch-1.1. Thanks Bikas! And Arpit for reporting and verifying the fix!
        Hide
        mattf Matt Foley added a comment -

        Closed upon release of Hadoop-1.1.0.

        Show
        mattf Matt Foley added a comment - Closed upon release of Hadoop-1.1.0.

          People

          • Assignee:
            bikassaha Bikas Saha
            Reporter:
            arpitgupta Arpit Gupta
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development