[MAPREDUCE-4653] TestRandomAlgorithm has an unused "import" statement - ASF JIRA

Details

Type: Improvement
Status: Resolved
Priority: Trivial
Resolution: Fixed
Affects Version/s: 1.0.3
Fix Version/s: 2.8.0, 3.0.0-alpha1
Component/s: contrib/gridmix
Labels:
None
Environment:

hadoop 1.0.3 on any platform

Hadoop Flags:

Reviewed

Description

need to remove the import statement usinf below patch. will attach a patch shortly .

Index: TestRandomAlgorithm.java
===================================================================
— TestRandomAlgorithm.java (revision 1380737)
+++ TestRandomAlgorithm.java (working copy)
@@ -30,8 +30,6 @@

import org.junit.Test;

-import com.sun.tools.javac.code.Attribute.Array;
-
public class TestRandomAlgorithm {
private static final int[][] parameters = new int[][] {

{5, 1, 1}

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending

Attachments

MAPREDUCE-4653.patch

13/Sep/12 21:01

0.6 kB

Amir Sanjar

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Aaron T. Myers added a comment - 13/Sep/12 18:14

Hi Amir, when posting a patch you should create the diff from the root directory of the repository. Mind posting an updated patch?

Show

Aaron T. Myers added a comment - 13/Sep/12 18:14 Hi Amir, when posting a patch you should create the diff from the root directory of the repository. Mind posting an updated patch?

Hide

Permalink

Amir Sanjar added a comment - 13/Sep/12 19:37

sure will do..

Show

Amir Sanjar added a comment - 13/Sep/12 19:37 sure will do..

Hide

Permalink

Amir Sanjar added a comment - 13/Sep/12 20:00

pathc from TRUNK

Show

Amir Sanjar added a comment - 13/Sep/12 20:00 pathc from TRUNK

Hide

Permalink

Amir Sanjar added a comment - 13/Sep/12 20:01

done, thx

Show

Amir Sanjar added a comment - 13/Sep/12 20:01 done, thx

Hide

Permalink

Aaron T. Myers added a comment - 13/Sep/12 20:04

Hi Amir, it looks like you've now posted a patch for the trunk branch, which is good, but you should still be creating a patch based in the root of the repository directory structure, i.e. the diff you make should include the full path to TestRandomAlgorithm.java, not just the file name.

Show

Aaron T. Myers added a comment - 13/Sep/12 20:04 Hi Amir, it looks like you've now posted a patch for the trunk branch, which is good, but you should still be creating a patch based in the root of the repository directory structure, i.e. the diff you make should include the full path to TestRandomAlgorithm.java, not just the file name.

Hide

Permalink

Amir Sanjar added a comment - 13/Sep/12 21:02

sorry, I hope this one is okay

Show

Amir Sanjar added a comment - 13/Sep/12 21:02 sorry, I hope this one is okay

Hide

Permalink

Aaron T. Myers added a comment - 13/Sep/12 21:14

That looks better. Marking this patch available so that test-patch runs.

Show

Aaron T. Myers added a comment - 13/Sep/12 21:14 That looks better. Marking this patch available so that test-patch runs.

Hide

Permalink

Hadoop QA added a comment - 13/Sep/12 21:33

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12545053/MAPREDUCE-4653.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 1 new or modified test files.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

-1 findbugs. The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed unit tests in hadoop-tools/hadoop-gridmix.

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2851//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2851//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-gridmix.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2851//console

This message is automatically generated.

Show

Hadoop QA added a comment - 13/Sep/12 21:33 -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12545053/MAPREDUCE-4653.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-tools/hadoop-gridmix. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2851//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2851//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-gridmix.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2851//console This message is automatically generated.

Hide

Permalink

Hadoop QA added a comment - 17/Mar/15 06:49

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12545053/MAPREDUCE-4653.patch
against trunk revision bb243ce.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 1 new or modified test files.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. There were no new javadoc warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed unit tests in hadoop-tools/hadoop-gridmix.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5299//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5299//console

This message is automatically generated.

Show

Hadoop QA added a comment - 17/Mar/15 06:49 +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12545053/MAPREDUCE-4653.patch against trunk revision bb243ce. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-tools/hadoop-gridmix. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5299//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5299//console This message is automatically generated.

Hide

Permalink

Harsh J added a comment - 17/Mar/15 08:44

+1, old but still applies, as other import-unused removals don't appear to have covered this. Committing shortly.

Show

Harsh J added a comment - 17/Mar/15 08:44 +1, old but still applies, as other import-unused removals don't appear to have covered this. Committing shortly.

Hide

Permalink

Harsh J added a comment - 17/Mar/15 08:45

Thanks Amir!

Show

Harsh J added a comment - 17/Mar/15 08:45 Thanks Amir!

Hide

Permalink

Hudson added a comment - 17/Mar/15 08:53

FAILURE: Integrated in Hadoop-trunk-Commit #7345 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7345/)
~~MAPREDUCE-4653~~. TestRandomAlgorithm has an unused import statement. Contributed by Amir Sanjar. (harsh: rev e5370477c2d00745e695507ecfdf86de59c5f5b9)

hadoop-mapreduce-project/CHANGES.txt
hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestRandomAlgorithm.java

Show

Hudson added a comment - 17/Mar/15 08:53 FAILURE: Integrated in Hadoop-trunk-Commit #7345 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7345/ ) MAPREDUCE-4653 . TestRandomAlgorithm has an unused import statement. Contributed by Amir Sanjar. (harsh: rev e5370477c2d00745e695507ecfdf86de59c5f5b9) hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestRandomAlgorithm.java

Hide

Permalink

Hudson added a comment - 17/Mar/15 10:44

FAILURE: Integrated in Hadoop-Yarn-trunk #869 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/869/)
~~MAPREDUCE-4653~~. TestRandomAlgorithm has an unused import statement. Contributed by Amir Sanjar. (harsh: rev e5370477c2d00745e695507ecfdf86de59c5f5b9)

hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestRandomAlgorithm.java
hadoop-mapreduce-project/CHANGES.txt

Show

Hudson added a comment - 17/Mar/15 10:44 FAILURE: Integrated in Hadoop-Yarn-trunk #869 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/869/ ) MAPREDUCE-4653 . TestRandomAlgorithm has an unused import statement. Contributed by Amir Sanjar. (harsh: rev e5370477c2d00745e695507ecfdf86de59c5f5b9) hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestRandomAlgorithm.java hadoop-mapreduce-project/CHANGES.txt

Hide

Permalink

Hudson added a comment - 17/Mar/15 11:32

FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #135 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/135/)
~~MAPREDUCE-4653~~. TestRandomAlgorithm has an unused import statement. Contributed by Amir Sanjar. (harsh: rev e5370477c2d00745e695507ecfdf86de59c5f5b9)

hadoop-mapreduce-project/CHANGES.txt
hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestRandomAlgorithm.java

Show

Hudson added a comment - 17/Mar/15 11:32 FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #135 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/135/ ) MAPREDUCE-4653 . TestRandomAlgorithm has an unused import statement. Contributed by Amir Sanjar. (harsh: rev e5370477c2d00745e695507ecfdf86de59c5f5b9) hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestRandomAlgorithm.java

Hide

Permalink

Hudson added a comment - 17/Mar/15 14:32

FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #126 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/126/)
~~MAPREDUCE-4653~~. TestRandomAlgorithm has an unused import statement. Contributed by Amir Sanjar. (harsh: rev e5370477c2d00745e695507ecfdf86de59c5f5b9)

hadoop-mapreduce-project/CHANGES.txt
hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestRandomAlgorithm.java

Show

Hudson added a comment - 17/Mar/15 14:32 FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #126 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/126/ ) MAPREDUCE-4653 . TestRandomAlgorithm has an unused import statement. Contributed by Amir Sanjar. (harsh: rev e5370477c2d00745e695507ecfdf86de59c5f5b9) hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestRandomAlgorithm.java

Hide

Permalink

Hudson added a comment - 17/Mar/15 14:44

FAILURE: Integrated in Hadoop-Hdfs-trunk #2067 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2067/)
~~MAPREDUCE-4653~~. TestRandomAlgorithm has an unused import statement. Contributed by Amir Sanjar. (harsh: rev e5370477c2d00745e695507ecfdf86de59c5f5b9)

hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestRandomAlgorithm.java
hadoop-mapreduce-project/CHANGES.txt

Show

Hudson added a comment - 17/Mar/15 14:44 FAILURE: Integrated in Hadoop-Hdfs-trunk #2067 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2067/ ) MAPREDUCE-4653 . TestRandomAlgorithm has an unused import statement. Contributed by Amir Sanjar. (harsh: rev e5370477c2d00745e695507ecfdf86de59c5f5b9) hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestRandomAlgorithm.java hadoop-mapreduce-project/CHANGES.txt

Hide

Permalink

Hudson added a comment - 17/Mar/15 15:11

FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/135/)
~~MAPREDUCE-4653~~. TestRandomAlgorithm has an unused import statement. Contributed by Amir Sanjar. (harsh: rev e5370477c2d00745e695507ecfdf86de59c5f5b9)

hadoop-mapreduce-project/CHANGES.txt
hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestRandomAlgorithm.java

Show

Hudson added a comment - 17/Mar/15 15:11 FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/135/ ) MAPREDUCE-4653 . TestRandomAlgorithm has an unused import statement. Contributed by Amir Sanjar. (harsh: rev e5370477c2d00745e695507ecfdf86de59c5f5b9) hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestRandomAlgorithm.java

Hide

Permalink

Hudson added a comment - 17/Mar/15 15:34

FAILURE: Integrated in Hadoop-Mapreduce-trunk #2085 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2085/)
~~MAPREDUCE-4653~~. TestRandomAlgorithm has an unused import statement. Contributed by Amir Sanjar. (harsh: rev e5370477c2d00745e695507ecfdf86de59c5f5b9)

hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestRandomAlgorithm.java
hadoop-mapreduce-project/CHANGES.txt

Show

Hudson added a comment - 17/Mar/15 15:34 FAILURE: Integrated in Hadoop-Mapreduce-trunk #2085 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2085/ ) MAPREDUCE-4653 . TestRandomAlgorithm has an unused import statement. Contributed by Amir Sanjar. (harsh: rev e5370477c2d00745e695507ecfdf86de59c5f5b9) hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestRandomAlgorithm.java hadoop-mapreduce-project/CHANGES.txt

People

Assignee:

Amir Sanjar

Reporter:

Amir Sanjar

Votes:

0 Vote for this issue

Watchers:

5 Start watching this issue

Dates

Created:

13/Sep/12 13:30

Updated:

30/Aug/16 01:20

Resolved:

17/Mar/15 08:45

Time Tracking

Estimated:

24h

Remaining:

24h

Logged:

Not Specified

Development

Agile

View on Board