Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4594

Add init/shutdown methods to mapreduce Partitioner

    Details

    • Type: Improvement Improvement
    • Status: Patch Available
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: trunk
    • Fix Version/s: None
    • Component/s: client
    • Labels:
      None

      Description

      The Partitioner supports only the Configurable API, which can be used for basic init in setConf(). Problem is that there is no shutdown function.

      I propose to use standard setup() cleanup() functions like in mapper / reducer.

      Use case is that I need to start and stop spring context and datagrid client.

      1. partitioner1.txt
        2 kB
        Radim Kolar
      2. partitioner2.txt
        12 kB
        Radim Kolar
      3. partitioner2.txt
        4 kB
        Radim Kolar
      4. partitioner3.txt
        13 kB
        Radim Kolar
      5. partitioner4.txt
        13 kB
        Radim Kolar
      6. partitioner5.txt
        12 kB
        Radim Kolar
      7. partitioner6.txt
        12 kB
        Radim Kolar
      8. partitioner6.txt
        12 kB
        Radim Kolar
      9. partitioner7.txt
        12 kB
        Radim Kolar
      10. partitioner8.txt
        13 kB
        Radim Kolar
      11. partitioner9.txt
        13 kB
        Radim Kolar

        Activity

        Hide
        Radim Kolar added a comment -

        Add same thing to RawComparator. It needs init/shutdown cycle too.

        Show
        Radim Kolar added a comment - Add same thing to RawComparator. It needs init/shutdown cycle too.
        Hide
        Harsh J added a comment -

        Marking this as an incompatible change for now, 'cause we have a set interface today in the stable API, and adding any methods to that is bound to cause an incompatibility.

        Show
        Harsh J added a comment - Marking this as an incompatible change for now, 'cause we have a set interface today in the stable API, and adding any methods to that is bound to cause an incompatibility.
        Hide
        Radim Kolar added a comment -

        It can be backward compatible. You can still call setConf().

        Show
        Radim Kolar added a comment - It can be backward compatible. You can still call setConf().
        Hide
        Harsh J added a comment -

        Changing public interface of Partitioner to add new method calls will not be backward compatible, as users who have implemented the interface will begin facing compilation errors if they have not also defined their init/shutdown new methods. This is what I meant.

        For the new API, this is easier to do, since the Partitioner is an abstract class. So I suppose we can add it to the new API alone, but I'm still not sold on why we need this. I've always been satisfied with the task's own cleanup function.

        I'm not a spring guy, can you explain with a little more detail on why a simple class such as the comparator or the partitioner need an exit method? They aren't really supposed to be holding any states.

        Show
        Harsh J added a comment - Changing public interface of Partitioner to add new method calls will not be backward compatible, as users who have implemented the interface will begin facing compilation errors if they have not also defined their init/shutdown new methods. This is what I meant. For the new API, this is easier to do, since the Partitioner is an abstract class. So I suppose we can add it to the new API alone, but I'm still not sold on why we need this. I've always been satisfied with the task's own cleanup function. I'm not a spring guy, can you explain with a little more detail on why a simple class such as the comparator or the partitioner need an exit method? They aren't really supposed to be holding any states.
        Hide
        Radim Kolar added a comment -

        If you have component based application where partitioner is one of application components it needs to have support for its own lifecycle if it does anything which allocate resources in init (setConf()) method.

        Show
        Radim Kolar added a comment - If you have component based application where partitioner is one of application components it needs to have support for its own lifecycle if it does anything which allocate resources in init (setConf()) method.
        Hide
        Radim Kolar added a comment -

        I am fine with adding it to new API Partitioner. Its simple to do and it does not have any negative side effects.

        Show
        Radim Kolar added a comment - I am fine with adding it to new API Partitioner. Its simple to do and it does not have any negative side effects.
        Hide
        Radim Kolar added a comment -

        What about to convert RawComparator from interface to class?

        Show
        Radim Kolar added a comment - What about to convert RawComparator from interface to class?
        Hide
        Radim Kolar added a comment -

        ticket edited, to be for partiotioner only since it is class and not interface, easy to change.

        Show
        Radim Kolar added a comment - ticket edited, to be for partiotioner only since it is class and not interface, easy to change.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12556006/partitioner1.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3098//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3098//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12556006/partitioner1.txt against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3098//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3098//console This message is automatically generated.
        Hide
        Harsh J added a comment -

        I notice no objects (such as an attempt context object) being passed into the setup and cleanup methods you wish to introduce here. Without that how is this helpful?

        In my mind I was viewing your proposal as a step over writing "extends Configurable" for new API partitioner implementations, when one needs at least the Configuration object instance to pull values out from.

        Plus, the ordering of these calls matter, so tests are absolutely necessary if we do not want to regress by accident in future.

        Show
        Harsh J added a comment - I notice no objects (such as an attempt context object) being passed into the setup and cleanup methods you wish to introduce here. Without that how is this helpful? In my mind I was viewing your proposal as a step over writing "extends Configurable" for new API partitioner implementations, when one needs at least the Configuration object instance to pull values out from. Plus, the ordering of these calls matter, so tests are absolutely necessary if we do not want to regress by accident in future.
        Hide
        Radim Kolar added a comment -

        i do not need that objects like attempt context, but i can add them as parameters.

        I do not understand meaning of 2nd paragraph. extends Configurable is handled by reflectionUtils

        Show
        Radim Kolar added a comment - i do not need that objects like attempt context, but i can add them as parameters. I do not understand meaning of 2nd paragraph. extends Configurable is handled by reflectionUtils
        Hide
        Radim Kolar added a comment -

        now with TaskAttemptContext support

        Show
        Radim Kolar added a comment - now with TaskAttemptContext support
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12556382/partitioner2.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3102//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3102//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12556382/partitioner2.txt against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3102//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3102//console This message is automatically generated.
        Hide
        Radim Kolar added a comment -

        now with unit tests

        Show
        Radim Kolar added a comment - now with unit tests
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12560007/partitioner2.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        -1 javac. The patch appears to cause the build to fail.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3113//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12560007/partitioner2.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3113//console This message is automatically generated.
        Hide
        Radim Kolar added a comment -

        hmm, it fails to compile with javac. In eclipse it works. Its problem with generic.

        i can not cast class Partitioner.class to Class<? extends Partitioner<?, ?>> because of type erasure.

        Show
        Radim Kolar added a comment - hmm, it fails to compile with javac. In eclipse it works. Its problem with generic. i can not cast class Partitioner.class to Class<? extends Partitioner<?, ?>> because of type erasure.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12560018/partitioner3.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core:

        org.apache.hadoop.mapred.TestMapTask

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3114//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3114//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12560018/partitioner3.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: org.apache.hadoop.mapred.TestMapTask +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3114//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3114//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12560312/partitioner4.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3115//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3115//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12560312/partitioner4.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3115//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3115//console This message is automatically generated.
        Hide
        Luke Lu added a comment -
        1. Fix test name and comments. It's neither TestMapTask nor TestCounters. Suggestion: TestPartitionerSetupCleanup
        2. Make TestingPartitioner as a static inner class of the test.
        3. Indentation should be two spaces. No tabs.
        Show
        Luke Lu added a comment - Fix test name and comments. It's neither TestMapTask nor TestCounters. Suggestion: TestPartitionerSetupCleanup Make TestingPartitioner as a static inner class of the test. Indentation should be two spaces. No tabs.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12561534/partitioner5.txt
        against trunk revision .

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3132//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12561534/partitioner5.txt against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3132//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12561538/partitioner6.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        -1 javac. The patch appears to cause the build to fail.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3133//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12561538/partitioner6.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3133//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12561548/partitioner6.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        -1 javac. The patch appears to cause the build to fail.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3135//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12561548/partitioner6.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3135//console This message is automatically generated.
        Hide
        Radim Kolar added a comment -

        patch reuploaded

        Show
        Radim Kolar added a comment - patch reuploaded
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12561557/partitioner7.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core:

        org.apache.hadoop.mapred.TestPartitionerLifeCycle

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3136//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3136//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12561557/partitioner7.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: org.apache.hadoop.mapred.TestPartitionerLifeCycle +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3136//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3136//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12561610/partitioner8.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3138//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3138//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12561610/partitioner8.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3138//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3138//console This message is automatically generated.
        Hide
        Radim Kolar added a comment -

        rebased against trunk.

        Show
        Radim Kolar added a comment - rebased against trunk.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12580618/partitioner9.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3548//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3548//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12580618/partitioner9.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3548//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3548//console This message is automatically generated.

          People

          • Assignee:
            Radim Kolar
            Reporter:
            Radim Kolar
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:

              Development