Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4465

Update description of yarn.nodemanager.address property

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.2-alpha
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The description for the property 'yarn.nodemanager.address' says 'address of node manager IPC.', which is not clear enough. It should be changed to something as 'The address of the container manager in the NM'.

        Activity

        Bo Wang created issue -
        Bo Wang made changes -
        Field Original Value New Value
        Summary CDH-6433 Update description of yarn.nodemanager.address property Update description of yarn.nodemanager.address property
        Hide
        Bo Wang added a comment -

        Changed the description "address of node manager IPC" to "The address of the container manager in the NM".

        This parameter is used as YarnConfiguration.NM_ADDRESS in ContainerManagerImpl.start() to get RPC Server for ContainerManager.

        Show
        Bo Wang added a comment - Changed the description "address of node manager IPC" to "The address of the container manager in the NM". This parameter is used as YarnConfiguration.NM_ADDRESS in ContainerManagerImpl.start() to get RPC Server for ContainerManager.
        Bo Wang made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 2.0.0-alpha [ 12320354 ]
        Bo Wang made changes -
        Attachment MAPREDUCE-4465.patch [ 12537282 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12537282/MAPREDUCE-4465.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2630//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2630//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12537282/MAPREDUCE-4465.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2630//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2630//console This message is automatically generated.
        Hide
        Alejandro Abdelnur added a comment -

        +1. Not very convinced about the description but I seen it used like that for other services address properties.

        Show
        Alejandro Abdelnur added a comment - +1. Not very convinced about the description but I seen it used like that for other services address properties.
        Hide
        Alejandro Abdelnur added a comment -

        Thanks Bo. Committed to trunk and branch-2.

        Show
        Alejandro Abdelnur added a comment - Thanks Bo. Committed to trunk and branch-2.
        Alejandro Abdelnur made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 2.2.0-alpha [ 12322471 ]
        Resolution Fixed [ 1 ]
        Hide
        Bo Wang added a comment -

        Thanks Alejandro.

        Show
        Bo Wang added a comment - Thanks Alejandro.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2583 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2583/)
        MAPREDUCE-4465. Update description of yarn.nodemanager.address property. (bowang via tucu) (Revision 1365322)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365322
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2583 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2583/ ) MAPREDUCE-4465 . Update description of yarn.nodemanager.address property. (bowang via tucu) (Revision 1365322) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365322 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2518 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2518/)
        MAPREDUCE-4465. Update description of yarn.nodemanager.address property. (bowang via tucu) (Revision 1365322)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365322
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2518 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2518/ ) MAPREDUCE-4465 . Update description of yarn.nodemanager.address property. (bowang via tucu) (Revision 1365322) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365322 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2539 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2539/)
        MAPREDUCE-4465. Update description of yarn.nodemanager.address property. (bowang via tucu) (Revision 1365322)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365322
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2539 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2539/ ) MAPREDUCE-4465 . Update description of yarn.nodemanager.address property. (bowang via tucu) (Revision 1365322) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365322 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1115 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1115/)
        MAPREDUCE-4465. Update description of yarn.nodemanager.address property. (bowang via tucu) (Revision 1365322)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365322
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1115 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1115/ ) MAPREDUCE-4465 . Update description of yarn.nodemanager.address property. (bowang via tucu) (Revision 1365322) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365322 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1147 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1147/)
        MAPREDUCE-4465. Update description of yarn.nodemanager.address property. (bowang via tucu) (Revision 1365322)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365322
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1147 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1147/ ) MAPREDUCE-4465 . Update description of yarn.nodemanager.address property. (bowang via tucu) (Revision 1365322) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365322 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        5m 13s 1 Bo Wang 20/Jul/12 01:25
        Patch Available Patch Available Resolved Resolved
        4d 20h 43m 1 Alejandro Abdelnur 24/Jul/12 22:09
        Resolved Resolved Closed Closed
        78d 19h 38m 1 Arun C Murthy 11/Oct/12 17:48

          People

          • Assignee:
            Bo Wang
            Reporter:
            Bo Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development