Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.2-alpha, 0.23.8
    • Component/s: pipes
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Since MAPREDUCE-4267 I've seen "mvn -Pnative compile" failing with:

      [exec] /usr/bin/c++ -g -Wall -O2 -D_REENTRANT -D_FILE_OFFSET_BITS=64 -I/home/adi/w/apache-hadoop-trunk/hadoop-tools/hadoop-pipes/src/main/native/utils/api -I/home/adi/w/apache-hadoop-trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/api -I/home/adi/w/apache-hadoop-trunk/hadoop-tools/hadoop-pipes/src -o CMakeFiles/hadooppipes.dir/main/native/pipes/impl/HadoopPipes.cc.o -c /home/adi/w/apache-hadoop-trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
      [exec] /home/adi/w/apache-hadoop-trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc: In member function ‘std::string HadoopPipes::BinaryProtocol::createDigest(std::string&, std::string&)’:
      [exec] /home/adi/w/apache-hadoop-trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc:439:21: warning: value computed is not used [-Wunused-value]
      [exec] /home/adi/w/apache-hadoop-trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc: In function ‘void* HadoopPipes::ping(void*)’:
      [exec] /home/adi/w/apache-hadoop-trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc:1049:16: error: ‘sleep’ was not declared in this scope
      [exec] /home/adi/w/apache-hadoop-trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc:1067:30: error: ‘close’ was not declared in this scope
      [exec] /home/adi/w/apache-hadoop-trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc: In function ‘bool HadoopPipes::runTask(const HadoopPipes::Factory&)’:
      [exec] /home/adi/w/apache-hadoop-trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc:1162:28: error: ‘close’ was not declared in this scope
      [exec] make[2]: *** [CMakeFiles/hadooppipes.dir/main/native/pipes/impl/HadoopPipes.cc.o] Error 1

      I believe the failure is new simply because I wasn't compiling pipes before.

      The fix is pretty simple, just include unistd.h in HadoopPipes.cc.

      My environment is debian unstable, amd64, g++ 4.7.0-6, openjdk-6-jdk 6b24-1.11.1-6.

      1. mapreduce-4383.txt
        0.7 kB
        Andy Isaacson

        Issue Links

          Activity

          Hide
          Andy Isaacson added a comment -

          Attaching one-line patch that fixes my build.

          Show
          Andy Isaacson added a comment - Attaching one-line patch that fixes my build.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12533878/mapreduce-4383.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2528//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2528//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12533878/mapreduce-4383.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2528//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2528//console This message is automatically generated.
          Hide
          Andy Isaacson added a comment -

          This patch doesn't include any tests because it's a compile fix.

          Show
          Andy Isaacson added a comment - This patch doesn't include any tests because it's a compile fix.
          Hide
          Eli Collins added a comment -

          +1

          Show
          Eli Collins added a comment - +1
          Hide
          Eli Collins added a comment -

          I've committed this and merged to branch-2. Thanks Andy!

          Show
          Eli Collins added a comment - I've committed this and merged to branch-2. Thanks Andy!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2479 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2479/)
          MAPREDUCE-4383. HadoopPipes.cc needs to include unistd.h. Contributed by Andy Isaacson (Revision 1355555)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355555
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2479 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2479/ ) MAPREDUCE-4383 . HadoopPipes.cc needs to include unistd.h. Contributed by Andy Isaacson (Revision 1355555) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355555 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2411 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2411/)
          MAPREDUCE-4383. HadoopPipes.cc needs to include unistd.h. Contributed by Andy Isaacson (Revision 1355555)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355555
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2411 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2411/ ) MAPREDUCE-4383 . HadoopPipes.cc needs to include unistd.h. Contributed by Andy Isaacson (Revision 1355555) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355555 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2428 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2428/)
          MAPREDUCE-4383. HadoopPipes.cc needs to include unistd.h. Contributed by Andy Isaacson (Revision 1355555)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355555
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2428 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2428/ ) MAPREDUCE-4383 . HadoopPipes.cc needs to include unistd.h. Contributed by Andy Isaacson (Revision 1355555) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355555 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1092 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1092/)
          MAPREDUCE-4383. HadoopPipes.cc needs to include unistd.h. Contributed by Andy Isaacson (Revision 1355555)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355555
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1092 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1092/ ) MAPREDUCE-4383 . HadoopPipes.cc needs to include unistd.h. Contributed by Andy Isaacson (Revision 1355555) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355555 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1125 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1125/)
          MAPREDUCE-4383. HadoopPipes.cc needs to include unistd.h. Contributed by Andy Isaacson (Revision 1355555)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355555
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1125 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1125/ ) MAPREDUCE-4383 . HadoopPipes.cc needs to include unistd.h. Contributed by Andy Isaacson (Revision 1355555) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355555 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
          Hide
          Ravi Prakash added a comment -

          Hi,

          Could this please be committed to 0.23 too?

          Show
          Ravi Prakash added a comment - Hi, Could this please be committed to 0.23 too?
          Hide
          Thomas Graves added a comment -

          I merged into branch-0.23

          Show
          Thomas Graves added a comment - I merged into branch-0.23
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #586 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/586/)
          MAPREDUCE-4383. HadoopPipes.cc needs to include unistd.h. (Andy Isaacson via tgraves) (Revision 1469340)

          Result = UNSTABLE
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1469340
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #586 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/586/ ) MAPREDUCE-4383 . HadoopPipes.cc needs to include unistd.h. (Andy Isaacson via tgraves) (Revision 1469340) Result = UNSTABLE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1469340 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc

            People

            • Assignee:
              Andy Isaacson
              Reporter:
              Andy Isaacson
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development