Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4287

jobClient.getQueues () API is giving empty by default

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 2.0.0-alpha, 3.0.0
    • Fix Version/s: None
    • Component/s: mrv2
    • Labels:
      None

      Description

      getQueues () API is returning empty instead of giving default queue info.
      By default "default" queue will be there so the API should return default queue info.

      1. MAPREDUCE-4287-1.patch
        5 kB
        Devaraj K
      2. MAPREDUCE-4287.patch
        4 kB
        Devaraj K

        Activity

        Nishan Shetty created issue -
        Devaraj K made changes -
        Field Original Value New Value
        Assignee Devaraj K [ devaraj.k ]
        Devaraj K made changes -
        Attachment MAPREDUCE-4287.patch [ 12530009 ]
        Hide
        Devaraj K added a comment -

        I have attached patch to fix this issue.

        Show
        Devaraj K added a comment - I have attached patch to fix this issue.
        Devaraj K made changes -
        Affects Version/s 2.0.1-alpha [ 12321442 ]
        Affects Version/s 3.0.0 [ 12320355 ]
        Status Open [ 1 ] Patch Available [ 10002 ]
        Devaraj K made changes -
        Summary jobClient.getQueues () API is giving zero by default jobClient.getQueues () API is giving empty by default
        Description getQueues () API is returning zero instead of one
        By default "default" queue will be there so the API should return one
        getQueues () API is returning empty instead of giving default queue info.
        By default "default" queue will be there so the API should return default queue info.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12530009/MAPREDUCE-4287.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

        org.apache.hadoop.mapreduce.v2.TestYARNRunner

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2419//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2419//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12530009/MAPREDUCE-4287.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.mapreduce.v2.TestYARNRunner +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2419//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2419//console This message is automatically generated.
        Devaraj K made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Devaraj K made changes -
        Attachment MAPREDUCE-4287-1.patch [ 12530033 ]
        Hide
        Devaraj K added a comment -

        I have attached patch with the test fix.

        Show
        Devaraj K added a comment - I have attached patch with the test fix.
        Devaraj K made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12530033/MAPREDUCE-4287-1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2420//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2420//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12530033/MAPREDUCE-4287-1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2420//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2420//console This message is automatically generated.
        Hide
        Vinod Kumar Vavilapalli added a comment -

        Even the command line "queue -list" returns empty, we should fix "getRootQueues()" too.

        Regarding the solution, it seems wrong that we are adding root queue also to the list. For better or worse, CapacityScheduler introduced the concept of a root queue which is hidden from users. With the patch, we are now exposing the root queue to the users. Instead if we change FifoScheduler to also have root->default queue hierarchy, this will be automatically solved, what do you think? Granted, we will need to fix some tests..

        Show
        Vinod Kumar Vavilapalli added a comment - Even the command line "queue -list" returns empty, we should fix "getRootQueues()" too. Regarding the solution, it seems wrong that we are adding root queue also to the list. For better or worse, CapacityScheduler introduced the concept of a root queue which is hidden from users. With the patch, we are now exposing the root queue to the users. Instead if we change FifoScheduler to also have root->default queue hierarchy, this will be automatically solved, what do you think? Granted, we will need to fix some tests..
        Vinod Kumar Vavilapalli made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Arun C Murthy made changes -
        Affects Version/s 2.1.0-alpha [ 12321442 ]

          People

          • Assignee:
            Devaraj K
            Reporter:
            Nishan Shetty
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:

              Development