Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4211

Error conditions (missing appid, appid not found) are masked in the RM app page

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.3, 2.0.0-alpha
    • Fix Version/s: 0.23.3, 2.0.2-alpha
    • Component/s: mrv2
    • Labels:
      None
    1. MAPREDUCE-4211.patch
      9 kB
      Jonathan Eagles
    2. MAPREDUCE-4211.patch
      9 kB
      Jonathan Eagles

      Activity

      Hide
      Jonathan Eagles added a comment -

      Kicking the build

      Show
      Jonathan Eagles added a comment - Kicking the build
      Hide
      Jonathan Eagles added a comment -

      My approach was to stop masking errors and to refactor the code so that the controller class delegates the content to the rendering page.

      Show
      Jonathan Eagles added a comment - My approach was to stop masking errors and to refactor the code so that the controller class delegates the content to the rendering page.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12525173/MAPREDUCE-4211.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      -1 javadoc. The javadoc tool appears to have generated 16 warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2341//testReport/
      Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2341//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525173/MAPREDUCE-4211.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 16 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2341//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2341//console This message is automatically generated.
      Hide
      Robert Joseph Evans added a comment -

      The change looks good to me. The javadoc warnings are leftover from some of the testpatch changes that happened recently. I assume that you tested this manually, so +1.

      Show
      Robert Joseph Evans added a comment - The change looks good to me. The javadoc warnings are leftover from some of the testpatch changes that happened recently. I assume that you tested this manually, so +1.
      Hide
      Robert Joseph Evans added a comment -

      Thanks Jon,

      I put this into trunk, branch-2, and branch-0.23

      Show
      Robert Joseph Evans added a comment - Thanks Jon, I put this into trunk, branch-2, and branch-0.23
      Hide
      Jonathan Eagles added a comment -

      Cool. Thanks, Bobby.

      Show
      Jonathan Eagles added a comment - Cool. Thanks, Bobby.
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk-Commit #2238 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2238/)
      MAPREDUCE-4211. Error conditions (missing appid, appid not found) are masked in the RM app page (Jonathan Eagles via bobby) (Revision 1332701)

      Result = SUCCESS
      bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332701
      Files :

      • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
      • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
      • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RmController.java
      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2238 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2238/ ) MAPREDUCE-4211 . Error conditions (missing appid, appid not found) are masked in the RM app page (Jonathan Eagles via bobby) (Revision 1332701) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332701 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RmController.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Common-trunk-Commit #2164 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2164/)
      MAPREDUCE-4211. Error conditions (missing appid, appid not found) are masked in the RM app page (Jonathan Eagles via bobby) (Revision 1332701)

      Result = SUCCESS
      bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332701
      Files :

      • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
      • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
      • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RmController.java
      Show
      Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2164 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2164/ ) MAPREDUCE-4211 . Error conditions (missing appid, appid not found) are masked in the RM app page (Jonathan Eagles via bobby) (Revision 1332701) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332701 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RmController.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk-Commit #2181 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2181/)
      MAPREDUCE-4211. Error conditions (missing appid, appid not found) are masked in the RM app page (Jonathan Eagles via bobby) (Revision 1332701)

      Result = ABORTED
      bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332701
      Files :

      • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
      • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
      • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RmController.java
      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2181 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2181/ ) MAPREDUCE-4211 . Error conditions (missing appid, appid not found) are masked in the RM app page (Jonathan Eagles via bobby) (Revision 1332701) Result = ABORTED bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332701 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RmController.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-0.23-Build #245 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/245/)
      svn merge -c 1332701 FIXES: MAPREDUCE-4211. Error conditions (missing appid, appid not found) are masked in the RM app page (Jonathan Eagles via bobby) (Revision 1332704)

      Result = SUCCESS
      bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332704
      Files :

      • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
      • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
      • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RmController.java
      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #245 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/245/ ) svn merge -c 1332701 FIXES: MAPREDUCE-4211 . Error conditions (missing appid, appid not found) are masked in the RM app page (Jonathan Eagles via bobby) (Revision 1332704) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332704 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RmController.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk #1032 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1032/)
      MAPREDUCE-4211. Error conditions (missing appid, appid not found) are masked in the RM app page (Jonathan Eagles via bobby) (Revision 1332701)

      Result = FAILURE
      bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332701
      Files :

      • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
      • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
      • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RmController.java
      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1032 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1032/ ) MAPREDUCE-4211 . Error conditions (missing appid, appid not found) are masked in the RM app page (Jonathan Eagles via bobby) (Revision 1332701) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332701 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RmController.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk #1067 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1067/)
      MAPREDUCE-4211. Error conditions (missing appid, appid not found) are masked in the RM app page (Jonathan Eagles via bobby) (Revision 1332701)

      Result = FAILURE
      bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332701
      Files :

      • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
      • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
      • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RmController.java
      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1067 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1067/ ) MAPREDUCE-4211 . Error conditions (missing appid, appid not found) are masked in the RM app page (Jonathan Eagles via bobby) (Revision 1332701) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332701 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RmController.java

        People

        • Assignee:
          Jonathan Eagles
          Reporter:
          Jonathan Eagles
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development