Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: test
    • Labels:
      None

      Description

      The test fails because a cluster is unexpectedly created with an empty conf.

      1. MAPREDUCE-4202-1.patch
        3 kB
        Daryn Sharp
      2. MAPREDUCE-4202.patch
        0.9 kB
        Daryn Sharp

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1067 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1067/)
          MAPREDUCE-4202. Updating changes to just be branch-2 (Revision 1332731)
          MAPREDUCE-4202. TestYarnClientProtocolProvider is broken (Daryn Sharp via bobby) (Revision 1332716)

          Result = FAILURE
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332731
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332716
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapred/LocalClientProtocolProvider.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/TestYarnClientProtocolProvider.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1067 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1067/ ) MAPREDUCE-4202 . Updating changes to just be branch-2 (Revision 1332731) MAPREDUCE-4202 . TestYarnClientProtocolProvider is broken (Daryn Sharp via bobby) (Revision 1332716) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332731 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332716 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapred/LocalClientProtocolProvider.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/TestYarnClientProtocolProvider.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1032 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1032/)
          MAPREDUCE-4202. Updating changes to just be branch-2 (Revision 1332731)
          MAPREDUCE-4202. TestYarnClientProtocolProvider is broken (Daryn Sharp via bobby) (Revision 1332716)

          Result = FAILURE
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332731
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332716
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapred/LocalClientProtocolProvider.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/TestYarnClientProtocolProvider.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1032 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1032/ ) MAPREDUCE-4202 . Updating changes to just be branch-2 (Revision 1332731) MAPREDUCE-4202 . TestYarnClientProtocolProvider is broken (Daryn Sharp via bobby) (Revision 1332716) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332731 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332716 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapred/LocalClientProtocolProvider.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/TestYarnClientProtocolProvider.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2182 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2182/)
          MAPREDUCE-4202. Updating changes to just be branch-2 (Revision 1332731)
          MAPREDUCE-4202. TestYarnClientProtocolProvider is broken (Daryn Sharp via bobby) (Revision 1332716)

          Result = ABORTED
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332731
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt

          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332716
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapred/LocalClientProtocolProvider.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/TestYarnClientProtocolProvider.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2182 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2182/ ) MAPREDUCE-4202 . Updating changes to just be branch-2 (Revision 1332731) MAPREDUCE-4202 . TestYarnClientProtocolProvider is broken (Daryn Sharp via bobby) (Revision 1332716) Result = ABORTED bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332731 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332716 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapred/LocalClientProtocolProvider.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/TestYarnClientProtocolProvider.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2166 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2166/)
          MAPREDUCE-4202. Updating changes to just be branch-2 (Revision 1332731)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332731
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2166 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2166/ ) MAPREDUCE-4202 . Updating changes to just be branch-2 (Revision 1332731) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332731 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2240 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2240/)
          MAPREDUCE-4202. Updating changes to just be branch-2 (Revision 1332731)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332731
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2240 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2240/ ) MAPREDUCE-4202 . Updating changes to just be branch-2 (Revision 1332731) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332731 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          Hide
          Robert Joseph Evans added a comment -

          Thanks Daryn,

          I put this into trunk, and branch-2

          Show
          Robert Joseph Evans added a comment - Thanks Daryn, I put this into trunk, and branch-2
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2165 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2165/)
          MAPREDUCE-4202. TestYarnClientProtocolProvider is broken (Daryn Sharp via bobby) (Revision 1332716)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332716
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapred/LocalClientProtocolProvider.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/TestYarnClientProtocolProvider.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2165 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2165/ ) MAPREDUCE-4202 . TestYarnClientProtocolProvider is broken (Daryn Sharp via bobby) (Revision 1332716) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332716 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapred/LocalClientProtocolProvider.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/TestYarnClientProtocolProvider.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2239 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2239/)
          MAPREDUCE-4202. TestYarnClientProtocolProvider is broken (Daryn Sharp via bobby) (Revision 1332716)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332716
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapred/LocalClientProtocolProvider.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/TestYarnClientProtocolProvider.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2239 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2239/ ) MAPREDUCE-4202 . TestYarnClientProtocolProvider is broken (Daryn Sharp via bobby) (Revision 1332716) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332716 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapred/LocalClientProtocolProvider.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/TestYarnClientProtocolProvider.java
          Hide
          Daryn Sharp added a comment -

          Tests appear to have failed due to errant java processes still running which resulted in bind errors. I've manually run the set of tests that failed and all passed.

          Show
          Daryn Sharp added a comment - Tests appear to have failed due to errant java processes still running which resulted in bind errors. I've manually run the set of tests that failed and all passed.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12524872/MAPREDUCE-4202-1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.yarn.server.resourcemanager.security.TestApplicationTokens
          org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService
          org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry
          org.apache.hadoop.yarn.server.resourcemanager.TestAMAuthorization
          org.apache.hadoop.yarn.server.resourcemanager.TestApplicationACLs
          org.apache.hadoop.mapred.TestClientRedirect
          org.apache.hadoop.mapreduce.security.TestJHSSecurity

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2321//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2321//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12524872/MAPREDUCE-4202-1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.yarn.server.resourcemanager.security.TestApplicationTokens org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry org.apache.hadoop.yarn.server.resourcemanager.TestAMAuthorization org.apache.hadoop.yarn.server.resourcemanager.TestApplicationACLs org.apache.hadoop.mapred.TestClientRedirect org.apache.hadoop.mapreduce.security.TestJHSSecurity +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2321//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2321//console This message is automatically generated.
          Hide
          Robert Joseph Evans added a comment -

          The change looks good to me +1, assuming that Jenkins comes back with success.

          Show
          Robert Joseph Evans added a comment - The change looks good to me +1, assuming that Jenkins comes back with success.
          Hide
          Robert Joseph Evans added a comment -

          Kicking Jenkins

          Show
          Robert Joseph Evans added a comment - Kicking Jenkins
          Hide
          Daryn Sharp added a comment -

          Essentially revert service provider behavior, and update test since a cluster with no config key isn't supposed to fail, but rather instantiate a local job runner.

          The test was assuming that any failure meant the cluster failed to init due to the missing framework key. Yet the service provider assumes an undefined framework key means a local runner. The test was really failing due to fs.file.impl not being defined. The jira mentioned by Bobby introduced a service provider for filesystems, so now the instantiation of the local fs does not fail. That causes the test to erroneously fail.

          Show
          Daryn Sharp added a comment - Essentially revert service provider behavior, and update test since a cluster with no config key isn't supposed to fail, but rather instantiate a local job runner. The test was assuming that any failure meant the cluster failed to init due to the missing framework key. Yet the service provider assumes an undefined framework key means a local runner. The test was really failing due to fs.file.impl not being defined. The jira mentioned by Bobby introduced a service provider for filesystems, so now the instantiation of the local fs does not fail. That causes the test to erroneously fail.
          Hide
          Robert Joseph Evans added a comment -

          Linking this to the JIRA that caused it so that if HADOOP-7549 gets merged anywhere else this can go with it.

          Show
          Robert Joseph Evans added a comment - Linking this to the JIRA that caused it so that if HADOOP-7549 gets merged anywhere else this can go with it.
          Hide
          Robert Joseph Evans added a comment -

          I was debugging this too and the reason that the test passed previously was because it was trying to instantiate a DefaultFileSystem, which with not config was file:// which there was no fs.file.impl.class for.

          java.io.IOException: No FileSystem for scheme: file
          	at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2085)
          	at org.apache.hadoop.fs.FileSystem.access$0(FileSystem.java:2081)
          	at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2122)
          	at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2104)
          	at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:284)
          	at org.apache.hadoop.fs.FileSystem.getLocal(FileSystem.java:255)
          	at org.apache.hadoop.mapred.LocalJobRunner.<init>(LocalJobRunner.java:605)
          	at org.apache.hadoop.mapred.LocalJobRunner.<init>(LocalJobRunner.java:600)
          	at org.apache.hadoop.mapred.LocalClientProtocolProvider.create(LocalClientProtocolProvider.java:43)
          	at org.apache.hadoop.mapreduce.Cluster.initialize(Cluster.java:98)
          	at org.apache.hadoop.mapreduce.Cluster.<init>(Cluster.java:85)
          	at org.apache.hadoop.mapreduce.Cluster.<init>(Cluster.java:78)
          	at org.apache.hadoop.mapreduce.TestYarnClientProtocolProvider.testClusterWithYarnClientProtocolProvider(TestYarnClientProtocolProvider.java:56)
          

          Also org.apache.hadoop.conf.TestNoDefaultsJobConf is more or less trying to test the exact opposite of TestYarnClientProtocolProvider. For backwards compatibility I would prefer to see TestYarnClientProtocolProvider not explode if no configs are set, but just validate that it got a LocalClientProvider.

          Show
          Robert Joseph Evans added a comment - I was debugging this too and the reason that the test passed previously was because it was trying to instantiate a DefaultFileSystem, which with not config was file:// which there was no fs.file.impl.class for. java.io.IOException: No FileSystem for scheme: file at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2085) at org.apache.hadoop.fs.FileSystem.access$0(FileSystem.java:2081) at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2122) at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2104) at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:284) at org.apache.hadoop.fs.FileSystem.getLocal(FileSystem.java:255) at org.apache.hadoop.mapred.LocalJobRunner.<init>(LocalJobRunner.java:605) at org.apache.hadoop.mapred.LocalJobRunner.<init>(LocalJobRunner.java:600) at org.apache.hadoop.mapred.LocalClientProtocolProvider.create(LocalClientProtocolProvider.java:43) at org.apache.hadoop.mapreduce.Cluster.initialize(Cluster.java:98) at org.apache.hadoop.mapreduce.Cluster.<init>(Cluster.java:85) at org.apache.hadoop.mapreduce.Cluster.<init>(Cluster.java:78) at org.apache.hadoop.mapreduce.TestYarnClientProtocolProvider.testClusterWithYarnClientProtocolProvider(TestYarnClientProtocolProvider.java:56) Also org.apache.hadoop.conf.TestNoDefaultsJobConf is more or less trying to test the exact opposite of TestYarnClientProtocolProvider. For backwards compatibility I would prefer to see TestYarnClientProtocolProvider not explode if no configs are set, but just validate that it got a LocalClientProvider.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12524770/MAPREDUCE-4202.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.conf.TestNoDefaultsJobConf

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2316//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2316//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12524770/MAPREDUCE-4202.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.conf.TestNoDefaultsJobConf +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2316//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2316//console This message is automatically generated.
          Hide
          Daryn Sharp added a comment -

          Use same type of conditional as yarn's protocol provider. The test and related files haven't been touched in a long time, so I have no idea how this test ever passed unless the CLASSPATH changed such that the service provider started finding the local provider class.

          Show
          Daryn Sharp added a comment - Use same type of conditional as yarn's protocol provider. The test and related files haven't been touched in a long time, so I have no idea how this test ever passed unless the CLASSPATH changed such that the service provider started finding the local provider class.

            People

            • Assignee:
              Daryn Sharp
              Reporter:
              Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development