Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4197

Include the hsqldb jar in the hadoop-mapreduce tar file

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.1
    • Fix Version/s: 0.23.3, 2.0.2-alpha
    • Component/s: None
    • Labels:
      None

      Description

      Courtesy Brahma

      In the previuos hadoop releases(20.XX) hsqldb was provided.
      But in hadoop-2.0.0 it is not present.Is it intentionally deleted or missing?

        Activity

        Hide
        Ravi Prakash added a comment -

        This patch adds hsqldb to the dependencies of hadoop-mapreduce. This list of dependencies is then used to assemble the tar file in hadoop-assemblies->hadoop-mapreduce-dist.xml

        Can someone please review and commit this small change?

        Show
        Ravi Prakash added a comment - This patch adds hsqldb to the dependencies of hadoop-mapreduce. This list of dependencies is then used to assemble the tar file in hadoop-assemblies->hadoop-mapreduce-dist.xml Can someone please review and commit this small change?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12524367/MAPREDUCE-4197.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.yarn.server.TestContainerManagerSecurity
        org.apache.hadoop.mapreduce.TestYarnClientProtocolProvider

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2311//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2311//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12524367/MAPREDUCE-4197.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.yarn.server.TestContainerManagerSecurity org.apache.hadoop.mapreduce.TestYarnClientProtocolProvider +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2311//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2311//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        Given that it's only used by the MR client we only need to update hadoop-mapreduce-project/hadoop-mapreduce-client/pom.xml right?

        Show
        Eli Collins added a comment - Given that it's only used by the MR client we only need to update hadoop-mapreduce-project/hadoop-mapreduce-client/pom.xml right?
        Hide
        Ravi Prakash added a comment -

        Hi Eli! Its actually the mapreduce-examples which need the hsqldb Server class. However, hadoop-mapreduce-dist.xml (in hadoop-assemblies) seems to package only the dependencies in hadoop-mapreduce/pom.xml . (hadoop-mapreduce-examples/pom.xml already has hsqldb listed as a dependency, but its still not getting packaged in the tarball)

        The test results from Hadoop QA are spurious. I ran both of them on my local machine and they passed. I suspect they failed because .m2 cache needs to be refreshed after MAPREDUCE-3942 went in. No tests were included because this is a change only in the pom.xml file.

        Show
        Ravi Prakash added a comment - Hi Eli! Its actually the mapreduce-examples which need the hsqldb Server class. However, hadoop-mapreduce-dist.xml (in hadoop-assemblies) seems to package only the dependencies in hadoop-mapreduce/pom.xml . (hadoop-mapreduce-examples/pom.xml already has hsqldb listed as a dependency, but its still not getting packaged in the tarball) The test results from Hadoop QA are spurious. I ran both of them on my local machine and they passed. I suspect they failed because .m2 cache needs to be refreshed after MAPREDUCE-3942 went in. No tests were included because this is a change only in the pom.xml file.
        Hide
        Thomas Graves added a comment -

        +1 looks good and pulls in the dependency. As Eli mentioned, seems like there should be a way to set it up by subproject but since its not setup that way right now I think this is good. Any maven experts out there know how to easily do that please let me know.

        Show
        Thomas Graves added a comment - +1 looks good and pulls in the dependency. As Eli mentioned, seems like there should be a way to set it up by subproject but since its not setup that way right now I think this is good. Any maven experts out there know how to easily do that please let me know.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2339 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2339/)
        MAPREDUCE-4197. Include the hsqldb jar in the hadoop-mapreduce tar file (Ravi Prakash via tgraves) (Revision 1339957)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339957
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2339 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2339/ ) MAPREDUCE-4197 . Include the hsqldb jar in the hadoop-mapreduce tar file (Ravi Prakash via tgraves) (Revision 1339957) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339957 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2266 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2266/)
        MAPREDUCE-4197. Include the hsqldb jar in the hadoop-mapreduce tar file (Ravi Prakash via tgraves) (Revision 1339957)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339957
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2266 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2266/ ) MAPREDUCE-4197 . Include the hsqldb jar in the hadoop-mapreduce tar file (Ravi Prakash via tgraves) (Revision 1339957) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339957 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/pom.xml
        Hide
        Thomas Graves added a comment -

        Thanks Ravi!. I committed this to trunk, branch-2, and branch-0.23

        Show
        Thomas Graves added a comment - Thanks Ravi!. I committed this to trunk, branch-2, and branch-0.23
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2284 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2284/)
        MAPREDUCE-4197. Include the hsqldb jar in the hadoop-mapreduce tar file (Ravi Prakash via tgraves) (Revision 1339957)

        Result = FAILURE
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339957
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2284 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2284/ ) MAPREDUCE-4197 . Include the hsqldb jar in the hadoop-mapreduce tar file (Ravi Prakash via tgraves) (Revision 1339957) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339957 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1049 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1049/)
        MAPREDUCE-4197. Include the hsqldb jar in the hadoop-mapreduce tar file (Ravi Prakash via tgraves) (Revision 1339957)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339957
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1049 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1049/ ) MAPREDUCE-4197 . Include the hsqldb jar in the hadoop-mapreduce tar file (Ravi Prakash via tgraves) (Revision 1339957) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339957 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #260 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/260/)
        merge -r 1339957:1339958 from branch-2. FIXES: MAPREDUCE-4197 (Revision 1339959)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339959
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #260 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/260/ ) merge -r 1339957:1339958 from branch-2. FIXES: MAPREDUCE-4197 (Revision 1339959) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339959 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1083 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1083/)
        MAPREDUCE-4197. Include the hsqldb jar in the hadoop-mapreduce tar file (Ravi Prakash via tgraves) (Revision 1339957)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339957
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1083 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1083/ ) MAPREDUCE-4197 . Include the hsqldb jar in the hadoop-mapreduce tar file (Ravi Prakash via tgraves) (Revision 1339957) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339957 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/pom.xml

          People

          • Assignee:
            Ravi Prakash
            Reporter:
            Ravi Prakash
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development