Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: trunk
    • Fix Version/s: None
    • Component/s: build
    • Labels:
      None
    • Target Version/s:

      Description

      Clean up a bunch of existing javac warnings in hadoop-yarn-applications-distributedshell module.

        Activity

        Harsh J made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Won't Fix [ 2 ]
        Hide
        Harsh J added a comment -

        Setting proper resolution.

        Show
        Harsh J added a comment - Setting proper resolution.
        Harsh J made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Harsh J made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Harsh J added a comment -

        Patches were too broad and have gone stale. Will address these forms of issue over separate, smaller and more divided JIRAs in future.

        Closing out parent JIRA MAPREDUCE-4172, and hence closing out this.

        Show
        Harsh J added a comment - Patches were too broad and have gone stale. Will address these forms of issue over separate, smaller and more divided JIRAs in future. Closing out parent JIRA MAPREDUCE-4172 , and hence closing out this.
        Harsh J made changes -
        Summary Clean up yarn-applications-distributedshell Remove an used import from TestDistributedShell
        Hide
        Harsh J added a comment -

        Fixing summary based on Nicholas' comments.

        Thanks for reviewing Tom and Nicholas!

        Show
        Harsh J added a comment - Fixing summary based on Nicholas' comments. Thanks for reviewing Tom and Nicholas!
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Typo: "used" should be "unused".

        Show
        Tsz Wo Nicholas Sze added a comment - Typo: "used" should be "unused".
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Since only an used import is removed, I think the summary and the description should be revised to something like "Remove an used import from TestDistributedShell".

        Show
        Tsz Wo Nicholas Sze added a comment - Since only an used import is removed, I think the summary and the description should be revised to something like "Remove an used import from TestDistributedShell".
        Hide
        Tom White added a comment -

        +1

        Show
        Tom White added a comment - +1
        Hide
        Harsh J added a comment -

        Failing test org.apache.hadoop.yarn.server.TestContainerManagerSecurity is unrelated to this change. See MAPREDUCE-4189 for more information on that failure.

        Show
        Harsh J added a comment - Failing test org.apache.hadoop.yarn.server.TestContainerManagerSecurity is unrelated to this change. See MAPREDUCE-4189 for more information on that failure.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12523748/0010-YARN-Applications-DistributedShell-Example-Cleanup.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.yarn.server.TestContainerManagerSecurity

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2292//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2292//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523748/0010-YARN-Applications-DistributedShell-Example-Cleanup.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.yarn.server.TestContainerManagerSecurity +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2292//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2292//console This message is automatically generated.
        Harsh J made changes -
        Hide
        Harsh J added a comment -

        Re-uploading patch as previous didn't trigger a QA build for some reason.

        Patch is ditto as previous.

        Show
        Harsh J added a comment - Re-uploading patch as previous didn't trigger a QA build for some reason. Patch is ditto as previous.
        Harsh J made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Harsh J made changes -
        Field Original Value New Value
        Attachment 0010-YARN-Applications-DistributedShell-Example-Cleanup.patch [ 12523703 ]
        Hide
        Harsh J added a comment -

        Minor patch that removes some of the warnings left in DistributedShell app example.

        Show
        Harsh J added a comment - Minor patch that removes some of the warnings left in DistributedShell app example.
        Harsh J created issue -

          People

          • Assignee:
            Harsh J
            Reporter:
            Harsh J
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development